From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 47ED8402C3 for ; Fri, 21 Jan 2022 01:44:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D625968B240; Fri, 21 Jan 2022 03:44:09 +0200 (EET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2088.outbound.protection.outlook.com [40.92.19.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8E08568B181 for ; Fri, 21 Jan 2022 03:44:03 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mt4ODxl/KHGu0CJnwDLSO7wWnq4DNiez7tyE0ICDtOXJ7y6H3ShHZaHzb3LIhDiVPaTFsEQx1Bqvkepn/jtTN+KDKA/7KoFkGU81CUl6moMTTowWUvs/5mz9NDhek/VBc6OeL12FP4+GXGIej6F4DGX62K6d6hk5BRRR8JuyZKrbQj45l9SlY7dvKcasPTJl5bcs2TPVL11tFNqA8LawxRGl6GJSvnaCWwPfo48la2wzOxHHjDW4Z3AB9bQ8xQo4iPGC1FwrYCntPRxXL0UA6Xn7W7XRdRJI+sjtbqRLN7xg3sOA6AlrQ/yWVPD3O2e+5ujbePiZBT8WOHTiPBexzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgBUsEUUiiZUh0Elta2CA1Gw7fCUZsaKUq6uBChVXc4=; b=lq06nWAJUXy2h80WriveX3Es3mnqWIvTyX1vPgP1/T0fJVfhPJeXvGXsHDMEZEulpzkF5ZLaanWUsMaVbUhYsL3ZU5SIpWW5VIpXBzTCOj5fmrARr7SSXnoj5JORbfuuvvY4wc0lj+0DiHBSVxaF2GKr4Rvie2zOXJCg7l/gQ+OjdO+ZrnEr+Dygnml2a55VVpjfUkxUGrdboBY7ddjxmfBDYvmDpmK6mzmGNhsCb4PItv4LfNEkbPnZ/6I0AvjSOx/mEHaEe69HBXQ6YCRoMfY+PMJamJSCisyDhcaJgr8unvhBBSbxn/bAtmdQ/9qqP+/OvN0lKjoowjCJ7bGtwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgBUsEUUiiZUh0Elta2CA1Gw7fCUZsaKUq6uBChVXc4=; b=e9TJiOlYJmwt3eS/Sp/9dIfUwwnmNydDaPBfVjS1u5suBZq139tf1FcdZYpGblvUQSbj+buzShbC1IFiUF2/Bvefd7Rj9D2uYyjeJ+/uqonjB+jckFTIQoaWxLkC4hPxdNlsdV5FablE0POTw6uA3EaDz9WosWmuDQTUcN7bQRjA9WMd+JUjn2ymsTEJj5z3KJpKzI74isD3qgjqS/1cGo1WqxAtn8Pb94mkJ02iBTMskXHS2Ak+sX2g5Q4zHh4leUeAZIPuukKo6bMwTpXoIMtmbMdb/zD2/987T2FNrSpxIt6VFKod3TUcNISusxCub/lZWzCOZ9ZAULE+vHvMnw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0133.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:144::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Fri, 21 Jan 2022 01:44:00 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%7]) with mapi id 15.20.4909.010; Fri, 21 Jan 2022 01:44:00 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Patchwork FATE Errors Thread-Index: AdgOQNFmFBJsNZyGRJ6OuUpdsVW+VwAAvO0AAAFcPsAAAUbugAAAsjEwAAVfjgAAABZmYA== Date: Fri, 21 Jan 2022 01:44:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [rcBFZL9tOBjWa8TFmUQjkB883yicGc0B] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7bb8b7c8-6bd7-487f-1ef4-08d9dc7f7f5d x-ms-traffictypediagnostic: BN0P223MB0133:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pLeCjq2MghKFNtSspy2xZpAkHFvuZhaccm2UJDbDr1orpo0Y43gi330GwOAWtMzAOEpyTaEKLxvhFTlQ2bJGDcyB73YHCEUjoLqnO2tRHIwIS6FSIeUwzz1tdTMh4f8MyAhRQckzmgbpISJrT2z3X1GUCubdVyNFP0JQrWaU8V/52deO0z2KuhSL7FcknzlF5CZF3kObup+U71tg5b+WcjBnI7T7ruk3Sx/LaSvRr3XzQeFdzTGN8UtZCT02R3SmffzlKNw6VOvdNrznxrMabt1EJdaUM+6kBpl5NR9gFCPnh2H88r70ASX2oGIIlw/CY19bEuZqeY4WuaG7wYntSXrRTLtN8bnxh7D+Ic6FBhylUGSGfzv1DHpvwWR9/kTLBkZSsFxUbTtSK0iiBOA6bX9P9r2RJ8rbNxZNwypSjStuJBJRvkoGzT3Z0P5STMlp+BDtzyhWttAambWzJG73bEEK2r+6H1VsssUmOB5ILIQI3gnnRKM54oAGZv8joC7pRfXTjbLic1KXQYUnpimrzN3tk6hLXepWGkjlZUDLlWFYBIqZmzREuMjhCfu78jsVrMurkEIm9bea1MwHn+ZPGQhYr2hJPkVPOFrtS6hXLY4qKc56TsySb/NoTSXxXG6W x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N1MvVlBBdy85akwxTzVnY1hQYmtScUNQMkRMeE9NMDMvMHVoRFd5MUJSdldM?= =?utf-8?B?T2ZrRTFCVUNHRklYODVVUE1QWHMvZUJ0Um9iQ2FzWlpyWFRIZ2ErMytoMmx0?= =?utf-8?B?THpXNzVHTjh3MWtXVTlXazduREJZL3JMZ2Nic1NaZGUrMCs4eHRsL3VycGN4?= =?utf-8?B?SVBiVDBjMnFIVjdsYWlreEFWY3IrSjFvTEFaTndyTCtOLzV2MFVIUVF5aEJq?= =?utf-8?B?Z3VDSDVLMWJnSk1TVHMrWXd2bGJNNmZTRVBJaHo3MWRvbE4wbmZRUHhyRFJi?= =?utf-8?B?eHAwclo2QnViS0RZU1RwaTBCb2I4aWxZcDhIRWgxaXdxSVZvRkdKUjZ4K3Za?= =?utf-8?B?ZEpKeEJsaUlhRFlzK0RyUGpoSGtGSHNhS2xid1hQdkN2ZzhJeHVkdzBKcDc3?= =?utf-8?B?aGN1NGw4Z0s3WGFlTVA4S2tiVHpXaUhBSU9CV0ZRWHBVVFdaUkRRNStRWjA4?= =?utf-8?B?TEVPRURjZ1A1dEl3SFBWSmcrR1hNUzBxdFRyOVVzZ3lVaG1iVTBjVlZ3NGpV?= =?utf-8?B?bk1QY20xNFFLQ1BDQkxBM0lDbjMxdC9IZ01xbXZaNW1wcnorQmxXR3Y2Z1NZ?= =?utf-8?B?TGZjcmwxSGxMY09FOEpNZjJqb01wR25mNHJtdmxjcnZUMnN5N3lmUzEwYUhu?= =?utf-8?B?TXlyT3pReC9tWlZ6SFFNQUsrcENFdDhYS2hhZU1EMEV0M1BWeU51bDBNY2Zh?= =?utf-8?B?S2JZZDZsOHRZRUc2MlcxOXcvdWpQb1lkMG9jemI1OHhWSlpkRTRsNTQvS2Q3?= =?utf-8?B?Z0wxY0hPVHk1blI3Sm5ObnZJQy83YlY4QjkrYkViSFNKcnorM1Z4b1VlbHFh?= =?utf-8?B?U095YTVYTnV5WXBLa2N5YzNqazJYdnlHZkZMZElvcHVsTFY4VHZkTFZ1UmJp?= =?utf-8?B?YWtFTVpRV2ZwZldIWUd4ZDE3cm1tYlNvalFHL25tL2xac25PdzZ3MjBOUnE0?= =?utf-8?B?TGJSRm9GQ1dxRkd0YmhoUEFkVEpZcVpQeU1jQWM3enNxWE85QWJhNC9EclZq?= =?utf-8?B?dURzOFpYWWcwNjgxV3F1SS9RNXI4Rmg1SmVOMHNaTWZlREMrWnlZSmRJQzJT?= =?utf-8?B?cEtsS0VhcEhkOHRTNk9hd0FLUDNLOGZrOHZBUGhZRG9YMGNBUGZLUXRiT0w1?= =?utf-8?B?QTk4c1ZoOEgyd1M1R2dnOFBLWW9rWWRnQm82YXFwUDNXcVdTVHd1SHM5YnRv?= =?utf-8?B?S2d5QWhVanFBQmZsMFFsdFRBWUZzK1M1dEloRDRXQ3IxQXRzemJyZitCUGsx?= =?utf-8?B?emQrQ2RlaklmczlocktGL0xHNStEWndlQUxBS3lGVDkzak40UT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb8b7c8-6bd7-487f-1ef4-08d9dc7f7f5d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 01:44:00.4777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0133 Subject: Re: [FFmpeg-devel] Patchwork FATE Errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Friday, January 21, 2022 2:31 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > Soft Works: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Andreas > >> Rheinhardt > >> Sent: Thursday, January 20, 2022 11:38 PM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > >> > >> Soft Works: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf Of > Andreas > >>>> Rheinhardt > >>>> Sent: Thursday, January 20, 2022 10:22 PM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > >>>> > >>>> Soft Works: > >>>>> > >>>>> andriy/make_fate_ppc > >>>>> > >>>>> => Does it possibly need 'make fate-rsync'? > >>>>> > >>>> > >>>> No. The test does not rely on need samples; > >>> > >>> It was just a very quick guess, because yesterday I rebased and > >>> saw the test matroska-dovi-write-config7 failing which was fixed > >>> after fate-rsync - that's why I though it might be the same reason > >>> (with make -jX, it's probably not deterministic, which test will > >>> fail first). > >>> > >>> > >>>> and the other test that uses > >>>> this sample works fine. Some time ago, someone else wrote FATE tests for > >>>> AVDOVIDecoderConfigurationRecord in Matroska > >>>> > (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220101165153.440729- > >> 6- > >>>> tcChlisop0@gmail.com/). > >>>> These were faulty and one of them relied on a sample that has apparently > >>>> never been uploaded (but this test is actually redundant with the other > >>>> test), so I investigated and saw that the test (presumably > >>>> unintentially) reencoded audio, so I switched it to a pure copy test and > >>>> applied it, believing that codec-copy tests could not possibly for some > >>>> arches. That was a mistake and I am deeply sorry for this mess. > >>> > >>> Nevermind - things happen.. > >>> > >>> > >>> BTW, I was thinking about submitting a patch for libavutil/tests/md5.c > >>> > >>> something like: > >>> > >>> #ifdef __GNUC__ > >>> #pragma GCC diagnostic ignored "-Wdiscarded-qualifiers" > >>> #endif > >>> > >>> #ifdef __clang__ > >>> #pragma clang diagnostic ignored "-Wdiscarded-qualifiers" > >>> #endif > >>> > >>> Would that make sense? > >>> Those warnings are appearing in every single fate error output on > >> patchwork, > >>> possibly covering up more relevant things. > >>> > >> > >> Instead of pragmas one should limit the volatile to those compilers > >> which miscompile the code without them. > >> (IMO one does not need to find the exact set of compilers that > >> miscompile this; all that matters is that recent versions don't give > >> warnings and old versions don't miscompile. If some compilers of medium > >> age still show this warning afterwards without needing the volatile, so > >> be it.) > > > > You mean like this? > > > > #if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > > volatile uint8_t in[1000]; // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > #else > > uint8_t in[1000]; > > #endif > > > > I would not use an else branch, but only put the volatile and the > comment in the #if branch. > > > > > It was fixed in 3.5.1, so "medium age" would be 3.5.1 to 4.0.0 > > > > Fine by me if tested. I do not have a Clang setup locally, I'd assume at least one of the Patchwork VMs uses Clang? softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".