From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 108F942826 for ; Fri, 7 Jan 2022 20:02:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8330068AB5B; Fri, 7 Jan 2022 22:02:08 +0200 (EET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2060.outbound.protection.outlook.com [40.92.23.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA73F680923 for ; Fri, 7 Jan 2022 22:02:01 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enKbDySKAL1WiQtDdj1o/6C/fXDbLe8DQtaN2bxnykmRCm1G6YOQrYkkP5rnwqorahaVDqzW2xfS7Saz0tyMY5Q2IzayWSYTWh1uY81ZtAaiWHqt+AhCzfPwE8BkkjYNF9/DT29/im0QjJR0sDdkWtdUKXzz+A0ABBFC74G/wMdnG5J3mbSmIMbJV5csl/3lhzWwjAkPE31qa1lv8KHusdbS8gqvR1RWF3N9d+1y2jLZRZQlg59EpaJcjtg7gZLTpBcXsuMtyZTN9tOpp6zsVmvkqQGKowYSwPCvoudrJHpMyP3VUviMziwnFp8RemNjNuQ9w/QDn4zRp49uoWp9qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hI6CZTBRodvUc1hkR0TSuHT+phmmO0U35BxwyG2A4ds=; b=H8hjR+1BenjhFCIxMfWYae+XstrMvDDeUGkDCCsgRE7yM1HoKTuWhR5kVX79uEhIkDK2Gpr491sk8pVOAaFzeABmumT2aBAomnk3rSWa233brGmHWoO7iq+suWm5oh/sdX5bz+qlIww8Kxd6+jZr49rTPgThwJQj/xPXnGzPt3IMH9eY91crRSvVz2it9BjxhyfkzJQ5PTJs5PUxwMElRQQRdI0Nl6fbNAwqLPV2HrLVwHA8+dFH/IVp9Qr5Tgb+1v1+SZSyZttQeACT7ZgHpSDuiC+wwFPEEgb8c9Hxtwn3PyhUBsDxX8K9r8YufD/1Yb7KlJPoNBzJTmjER1zm+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hI6CZTBRodvUc1hkR0TSuHT+phmmO0U35BxwyG2A4ds=; b=RMiaCqcOmNc7a5TryZU6yiLYtO+U7DjWEEskEAIzSVDotrKm3LMS4Z7fJl78NXNr/yWLDgzjLxAQ+oYPZobEWjH0KmYLYr/ycZrD4HBixZ60UnQaqq7G+a+xlE2H4XKd8MgAdhiYodhAZYeusxaGCfL7EdUksev4EAbgh0GmAvJ6OIDt3YZACpCTAkFFfBrrYfl/wF7UysXb3q3k4UeA0TcT9MT/ilwA2rWLBTC+7jFpaqCboaEoALw7iyb20ZtWG4cS7fejTdTFBAeIwoZps65qltoadQhyvjcQIVLU41o90y2t1EFXd6pc3Tow2IYwNR526RBolyWynirJxbG0xg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0288.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Fri, 7 Jan 2022 20:01:57 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%8]) with mapi id 15.20.4867.011; Fri, 7 Jan 2022 20:01:57 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define Thread-Index: AQHYBADKYpheftzI80ShXywzU5s5VaxX+mxA Date: Fri, 7 Jan 2022 20:01:57 +0000 Message-ID: References: <64b6a71c-ff36-1218-448a-186a729be62@passwd.hu> In-Reply-To: <64b6a71c-ff36-1218-448a-186a729be62@passwd.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [DA9cVYdoOuwPSIIt0JCtKTzueWtJCu0K] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26410f57-f258-4828-326e-08d9d2188f5f x-ms-traffictypediagnostic: DM8P223MB0288:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hJpQgUmJiYn8rePsn5lSBlBjsPlPDHsU5jc/0tIo8T1UvKvAoo4ij/PYq+kIPyg6TewPAc8u7VndsJkkLFXzateBD/1OSOcL8Zh26z3Dhg8WWkygKrYDfR9yXKPuIClZTtqlO6lGcNRAec6GbjH4Iix4S5lMlQg+9gaaGwsUqPV6sQPdCKSZvb3DreVz9UVludTJDJaNWoYEml6emE0ul+bRx2d4ZZ8UIvPZ8rletU1M+XyWlvudwMa3gEL3Z7l80q1gxaEpqtTAROcnlyigg04QhHqyroUs2C8phzQTnv19jkt2ieD/ALdtzK7dcuHbvgms6Cv5IpVFyEror5AIWlAGbnGCweI3GIpA/QhL/A9KgKvsPB5kk/QBNP8JZNgNLy5HlV2kGsDXxiSafkbcBOZ/dbsYUvnll3EBE5f4p08XQnNqotvJTxKdpPg8oo0pp0RTHDcrSoNbK7tvQTPmV7UzYgF/DPEBLUXoQMlYMO1fErEGki71lvrc4ThtU0Z4D0NXR++gTdRdybFDlX1Hs4L1ZvH+QpwDwAQPoVv/+wSowQviA4g3rkJEu7yjPcxyk1O+rc+05xvGx1qtMy4/+di+ANubfhzDV7KstXc46PLZ96fT+gfGPr66iI1/gWH6 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUp3TGdYSlNEVWRPbWdRQVVOQi9PWmxMVlk3Slh3WEljSXBUY1dDbjBDRWlu?= =?utf-8?B?WlZCOUVteFh5S3grcXdMb0U0K3FvWHEvMlovZDFacFVxUER2cjdFYzZYcnVM?= =?utf-8?B?NVMzU1FITkwyZm04TzRiaVQxY0lqUEEyTUZlNVVZMmZNbnA0MSt5M2tHU0pM?= =?utf-8?B?ODRrM1dwT2ZtNXRVRWdFYVIrbEdHRHhYaXJ2ZldxMURNRTZiQ001V0dsVENB?= =?utf-8?B?UnRDRkJ2RHY4TEZ3Y1R6cXpIK3N2UVpPQnhMN2tGdFZWUmI0SU1Ha1ZwOUdY?= =?utf-8?B?MmNFTlpuRW1ENm0zTmk5cUlCOGw4L0g2TkltQnJ5NnB0UEJhbzBaUndyODZt?= =?utf-8?B?eTh0UmE5eGtMbC9BQ2pmbnpvMlpRT2VVSHYzY3JaU0JaaDRrS0RxR1FNekND?= =?utf-8?B?b1lDRk1GOXRlc2NZeVl3U0pTTEduMjBTbk03amZETlNiR0c3bStNMHl2b2U1?= =?utf-8?B?d2hsdlJ3dHl3SHJEVHkrSWhqS1BpbEZaM0EyTGN6NXRxM3FxU2VjTmZBU2ov?= =?utf-8?B?RzUwd3BEamljM2szbVJyN2UyVlArOEFNdlZsWUhIeCs0VlB3RUV0RTdyWEFk?= =?utf-8?B?Sk9rZUZ5b2xEQWE0eVN6Nkk0WE9zYjFPMnlIbFYvMVVEUkYvNjRWYTc1dEpw?= =?utf-8?B?ZXFDZnhmMVB0WW5Kb3g2eE5rdFIvcmRXUWZtamFDMGc1S08rSldZaFZ5MjNR?= =?utf-8?B?aGl3V0crSXAzeEI0SElCUVByRW00QXZHWTEwMmM0RVR4WTczdTRPd3l0c1Nx?= =?utf-8?B?TitUalgyclpPYkxEV3l0S1dhL093Nlk4Tmw2WGZlbXhzUVJ5RUZsaWpPSzdk?= =?utf-8?B?RHNHSHZKcTAvUTArcUtlS2FUOU9jSHZtb0UwODlYSWtiMW5uSkQ3VEJzeVpP?= =?utf-8?B?L05lU21vVURTWXJIdFNDNnZoRVBnRlJnWHVYQldQQ2hGRXYvbU4wdFVGR2o2?= =?utf-8?B?SDVDaFRqMjdYZDBpWVNxT1RYUHRENU15UVhQS1Vid1Y4NEtPaXFFZVVRRXBa?= =?utf-8?B?alVrSDZxSnhqOU04UDdZVjRWc1owSmRwR0pBaW43UzFEY3BIYUNEV1NDdE9t?= =?utf-8?B?YjJ6U2ZHSU5Dc3Q1dnkrbjIxK0UwdlRoR1kyN0FHYmM3c29McTJNN3ZZcHVn?= =?utf-8?B?MzJpZTUyRVVVTXZpWkJQejdZZjFWVGNzdDhJc0ZleFkzcUxQNy91SHV1dXRR?= =?utf-8?B?MjlhTXduL2MwenFad1YwNEc0YXBvNC9HTC9kOTE0dzliRW41bkovVCtYUVBm?= =?utf-8?B?UGJQUjhMUEhIVkc5YzFYSzZkR3Q3d0tVcThoMHZiRExJRDNCQT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 26410f57-f258-4828-326e-08d9d2188f5f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2022 20:01:57.5283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0288 Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Marton > Balint > Sent: Friday, January 7, 2022 8:57 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't > dump images to disk based on DEBUG define > > > > On Fri, 7 Jan 2022, ffmpegagent wrote: > > > It's annoying and unexpected, but still useful at times (as I've realized > > just recently). > > > > This is a follow-up to the earlier submission here: > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > There has been a comment from Anton, questioning whether the dump-feature > is > > useful. Meanwhile I came to the conclusion that it can be useful in-fact. > It > > just shouldn't happen automatically when DEBUG is defined. That's what > these > > patches do. > > Well, I kind of agree with Anton, this a debug feature and it should not > be added as an option, but simply should be removed from the codebase. It's not added as a regular option. It's an option that is only available when you compile with DEBUG defined. Isn't this an acceptable compromise? softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".