From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DF6B438AF for ; Sat, 2 Jul 2022 19:11:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE7A868B8E1; Sat, 2 Jul 2022 22:11:48 +0300 (EEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2075.outbound.protection.outlook.com [40.92.47.75]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 09987689F54 for ; Sat, 2 Jul 2022 22:11:42 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oIeu0GSGxlkHA0TqCQGVDc7SSdMHQWYLcs5hzH4Fgx2ulS/XBOOj8ya/BPbgaCXGdqipCSXWledDtWMBcBgLSAtjcwTFrVeM4a1MSEPp7Hf56OOL85yubozc8YRvzVG1VXKDJ+uaykYIFrlnaKuRQHDWKdCJsk1TgViijoBjtI2+s9pWN6Zbp2qNmREzDti93xep8QsBvyuPq5UGwRCP+I/I8Y9SLG3mr04ReLYgNvyIBNtOvHFly4m9SAaj5cA+DRCEBTBmw8whoV1CTNljDu35aVJlArgj+wNiuvg5/W1qVv24iTR2JV6YzKUm33S9N56C767KZG0oqx/Vf13wlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Wr4kg/dpIcrkrJvk18PzycDkWs2VpNfKGfMTwUX64c=; b=KeDEoVWpROy2ul9czxS5p3v6A790ceuc4gmcvGCEKCoBetaxqUenzrSa5288VRTeTYMTLNaOjrQTRwviHEhIAccwatV7hYWH8SDn73W27sq8OKAQ6a85OLdkQNILLoRRijvS2GvqMD5+g+CXbmEIYJreOKru6nCe8uo9Nj8WznibcB5jg6oiGmROoSl+VxYrTdhQM0LT5l19o7LDZ6UIvSFHSSCgZOX6rZTyeszqC5FPOALlaAbtRXIaYAZ6WZPHj0/UMxirDTRlWvxBjtBH1JiYeAp0tIII5kZcVLNN8G3m1k4pzmJi5LqqnU8hNRls0H8TSxC8lU3owuCBTaYGRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Wr4kg/dpIcrkrJvk18PzycDkWs2VpNfKGfMTwUX64c=; b=gR5JzqWGY2bWrdQfB1eyzCWRZ1r/RWVyS6iufXTc2vP1S40XNSCuvq4b1dRySeiJLapD7o8SJjjM57bYdzDPm1LPsCYg7nODhJlEmDoRF46V2JrK9p/nSIIty8VMcmI+ZSdgfG3eRkiwNVgLJ+n4RvPryqr17XQIQ4Mfx4M+BtDiC3T0iA9aS/My15hhZ+5X+MB4ZqNKe54XDlG6y9UhyQ1ZmEOR7MRkqt4nccqlIBLdEQ7BXj0/wkvhVkhXCxFP4dCgr/LeG7r3TqhKAKfnSRjpEA3wSyxHr4mnGMwmlRcoME79aNwNjXooapr2sZxR5efJahKRBjL7S3u1P9aqGw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DS7P223MB0527.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Sat, 2 Jul 2022 19:11:39 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231%2]) with mapi id 15.20.5395.018; Sat, 2 Jul 2022 19:11:39 +0000 From: Soft Works To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 Thread-Index: AQHYiHoQ/s8zpruhyEis6n+SHo1FCK1rU4+AgAAK6wCAABxXoA== Date: Sat, 2 Jul 2022 19:11:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [rXLxc3Ma5kHM2hbf63lR/kNcmbePEMl4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd3ed37d-828b-434b-919e-08da5c5eb144 x-ms-exchange-slblob-mailprops: +LiGfBxqLEtZ2Se9LXW8/h2t+qO8Gfnc45fIYJfsDMkNFAxKCvBZ8BfVMiKLBuq3uGZMEMcvH6PdkyzHtPwn6mnsztXGN2qZvKW3DnJD4hw+134jR7uIZifcVJZeN55PoqFIGOlDkigiaTzUHdEQESpZ1suuEaWTS1LAJE8Z6JbAyPvX5pATdbjHDbCoMj6iLv8fCcvUN376ok+9tql7E7aR8MisYnEwtcsv34jpi6pPCMnaxtUQZQY2kEjHx7GyE7Xj8Nz5o+ObDcl0F7u9w/RLPu8zHeWj6GRTg1ZCTwsYj2yQzGGPdKfvAew/D1ICnrDNs08t1F74JtW7Iyx+3dys87eGC0Q0JVioHoXgUYCZ1bYkFiZpUL08ZpV/eqK1DPHzdfsDn3hcrVvBUm9+1oUgUe5mW/chKAF7giwY2bE6yC3SXRs9WS0unkzYbaxBmpDZfHzAs16NYySdzgVvxtwD/NIUw0523ZxDqu/zRyK4bfi5L+GoXXJrsSI6BmTh21Ucl/gReVWONMyGnPcRuJox8TeJ2/w19FR5SWWeocqCHbLI6Q+nPNiqrYw9uupZLyTJ/wNTmk6z/PHhWO6/pgA+qIxr6BY/U6h9CbqxfIxo1QpQi2kxrwoeUXYh8vQQXt9HIfNN+SqnfiGCrOn0MbSVyMdERGlL+gfj+t1T5lu6/7pxQZYmIAcpjZC0FCxBlEy0wF0va0lUC9XST86TWAXWCaKFXrMGBybMc/pilraSACG/BckDMMn9MeauZjUogNKnPcIq8IrwMxJTxQW62q80R5UWFNj7 x-ms-traffictypediagnostic: DS7P223MB0527:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sYXl0mvE1tQWqy4UuYvZ8BgeLCMaGLXVQgHNxsUNaevkaGylF57qWSxsZs/fxlIWRBAa6qcYtrLfz6eoV7yxEWAkrKHlitDlclLVb8XsGZWncwOBAc7kQxGBEr1x7gIuRXKY89N2eBRGHOEIaHd4vSotGbx/bJ40I/3cjPKJlMjF9295JmOmFT/iyyg6cexy7T3kpfhilShSu4m/bwKjMRVwP1t+ZIFYfrEwfBa72IEAX6IniDXzaB4LrplDcbyPm7Wb3k0lpYfFseOdf6egx+vD49NJgVKPhPyO0onufy1NjqI8aFBQb6W48ove0Pr0d4I/YlpCs4QAWNn3UaVtOEcq2V8dBiH9w8inb3H+opZkK+UEaaJwvwse0SS9CPvz0w7iZ+DNVbdK1otu3a5r53rWTadUD+LbvjB8kZp21Tw0RqIl4YjQLSl8TME47XrBrlIL7n1cAG9lUZJ7K4bN4UFRDmxzPHJpzKl0NKjFqahc+YnICnQpdANnZw4YiPrYm54Yc6Ws2UKpit8DCDq/4jz+k/xZhZr4r4W1a10EVPbx9P1oMlPXVtGAJz619vMhv2Rfc0K16s4xp5ghEIODR9xtVHxdMwmg2U5b6Fv9B7Si5btUVsDj1nHRMS+TQRQ8+8dHni0jV2gHw6lvkqv3tA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WmNhSTVhaEZRU05ZbFlJYmR4Nk83bGlhWW5wUkFNOWlBVm1qRHdLblROZW1K?= =?utf-8?B?K2JpOHc5Smx2aTh3cnoyck1RWE9vNDZ5NTJIL3VLNlYyTzNLa2wxd0x0Rlp6?= =?utf-8?B?bnFhaDNya09mUld4aytGVVljS1kzOWFxZDc3WWY1bmVaRnBtKy9NMUNYZmlG?= =?utf-8?B?ZEt5NlVvNzJUT3I4NnVVL3dNaTBNOGJxdHVYNUFUMFR1U2E3dnpRcHdGR1pD?= =?utf-8?B?eFhtM0pIbEJwODRpbnZmdzk1V1VoQ090ZW91OHgwWnlUTHJicTk3eVNuM01y?= =?utf-8?B?ZUZWSUZQbnFGTEVacnd4aDVZRlFvL3NMcC9Qb1Awc1dVMzN4bFpsd1F1UWM4?= =?utf-8?B?TjR5Wmg1ZGw5alMrQlZaWVViRTU0cEVFQU01K2VVR25mU2Nwd0ZUVHdwZklU?= =?utf-8?B?MnB6QXdBTnFvcGFIOVpqTWVZbldjTnRva0E4R1M3djhzNXh6aWJDN0NRaS95?= =?utf-8?B?bW1aNHMrZzljbDZMS0ZOM1p1VmVNcE56NnJ5QS9HQUYrQnoybjRlc3NPbllU?= =?utf-8?B?UUw4TkNXOHVNdTI5R2h1VjdXdmtzd3g1ZEFnbU92bWVEMEFqYzBkVUFoSmQ0?= =?utf-8?B?YWhiMU1jQXdEVFBZampCU1NRQ0U4dGdNU2JYODJSbjNKRHdORWl2ZTFJVEV3?= =?utf-8?B?V3ZmdTh6ZmV4VWdmODVTVG9BbHBxYndhejFRQ0IvbUlqUCtlOFdPTm5HVWpH?= =?utf-8?B?dE50U1JJSVlRSXlQY0xDc3kycWJPK3owVy92NC91NUJPcjBWeGFqSDh4VVds?= =?utf-8?B?SHZ0dk1maEwveWtaMFdqT1FiRmx2S0M0MGZmRnZPdjRSMmE2YjFTWEZhN3or?= =?utf-8?B?Ullya2xWclZrZkRQK0R3U3I4MC9wMENVZGdPOHJpVnByVTJmQUdNL2tLSUhU?= =?utf-8?B?MDNIdDd5bXBGck9xb2laQVJia2ovSWhtTXFzSFhCV0FnemFyaW9aS3NlOEJB?= =?utf-8?B?RTVZc3R1dFM3Zk5BZGgxdTFvVUExSzlyeGN2S2JBOHJxTyt3NHJucGp1dlEr?= =?utf-8?B?LzVQZGxuYmxYbmlJbjF1V2pJR2JxL2psR1V5c0wrd0NaeG4wdnNtU3Y5V1dx?= =?utf-8?B?SWcvc0Y4MVE0SlJ4akJBUGJnVmdyblZuK25Xamo2Nk1XYWhoSVJZTy95dmll?= =?utf-8?B?Tm9LR1NPbVpnNm1Jdk9uRWxadVZLazg4WVFaNmNOWG1GbGtUQlVGdllRNUpC?= =?utf-8?B?cUNSdHFuZ1NOaUZkME5LaDJtckxZZy9YSmhYZnI5TWJpd1NwZ3RDRTE5RU9Q?= =?utf-8?B?ZWQ1NjJUTWcyclN2U29CN1F6SnUzU1U1WVJsVlNHcmIwQVVqNG1DV2ZxYzlG?= =?utf-8?B?Z0J3TXdNc2NlcVQrV0x2UDlCTmJjYUhSbGEzblNWQjRGdWxndnBmelBEaEk3?= =?utf-8?B?ZGdML3NZb01jWnZEVDVUMVVQRTFLSnB1KzVkWCtuc2ZKN25rTzVSaHJ5b2Zw?= =?utf-8?B?enBTa1VZcDFSMzFoNnhYeThFS1BaVXJCSHIvZ1ppQy9nOTZaNU9FeTVub0dK?= =?utf-8?B?QWVydEQyK3Y1SlRLODhPYjZhSjFhbHhKc0U5WUhvcjltV0dFaDZ6YkI3VXc1?= =?utf-8?B?d0k3dTVHVWpOMEN2M3Fza0NUaFRVaDVLQzJYbmt6SWgrTmJZNHp2QU9HSSt5?= =?utf-8?B?SXZsdXc5K05WaHNTeVQwWGhpdWsza2l1NzdSbXUzV2ZjS2hFV1E4cnlwREJ0?= =?utf-8?Q?/iih9adhuGpRhYirOy5u?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fd3ed37d-828b-434b-919e-08da5c5eb144 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2022 19:11:39.6579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7P223MB0527 Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer , Andriy Gelman , Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Nicolas George > Sent: Saturday, July 2, 2022 7:18 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Cc: Michael Niedermayer ; softworkz > ; Andriy Gelman ; > Andreas Rheinhardt > Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 > > Paul B Mahol (12022-07-02): > > Can this be properly finally be fully reviewed and accepted? > > As long as the patch does not have a solution to have all the utility > filters (setpts, trim, concat, etc.) working with subtitles too > without > more code duplication, the review is just "NAK". The latest versions has added support for trim (strim). I strongly disagree on the "code duplication" argument. AFAIU, this is about having similar filters duplicated for each media type, e.g. trim, atrim and strim. The duplication has always existed already between audio and video filters. You could have unified and eliminated that duplication for years, but you didn't. Now that a third media type is being added, it is totally arbitrary to ask for unification and de-duplication of the code. You didn't do it for 2 media types, so why should 3 be the magic number where this is suddenly a requirement? This is an unjustified request. Even when I would follow that demand, it wouldn't be reasonable, because in that case, the patchset would dramatically widen its scope and start affecting audio and video as well - which is much too huge to get it tackled in a single patchset. It has always been possible to de-duplicate between audio and video, and in the future, it will always be possible to de-duplicate between audio, video and subtitles. It might make sense to do so at some point in time, but it is out of the scope of this patchset. And when this is the only objection, then I think that the patchset is actually in really good shape for getting merged. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".