From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9B5F04BF2E for <ffmpegdev@gitmailbox.com>; Thu, 6 Mar 2025 17:02:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 01F0668F22C; Thu, 6 Mar 2025 19:02:12 +0200 (EET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2037.outbound.protection.outlook.com [40.92.21.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B58FB68F205 for <ffmpeg-devel@ffmpeg.org>; Thu, 6 Mar 2025 19:02:05 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RhdF4XBbiQ++BWQ2umDURX3IjyewVDJf1rQZE9MrB9PP5xPOjCq5OejtH/vJ41D0NhhJtyEdbTPvKBhsU1iXe2BUK+Y6hDLgEc16YYf6dtXm8nYI18eAMRXe0HxauA3Vk650/UZddDuZY1SUaS3BqpXj5RfNKVf9uoQyRZvAE2WSvd4S0Ddk+Vr67hvljT68BLtkyNzNVSViGOV09Jy6qKV0sjMIISkhgRp6xjMtnlh22DdGfBGF7sgym9XBlK4n3UhbT6ZaY1h8Cu7aSQK0aT3oqt2bATZ8M+a2rRrtDD2JymR+139AsuWH3mTUc/M/4gr1MTh2a9P+6R5ngdOGsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R7kx51GpV/thxlkmVVyZvYieNytvwCIAVjUw7YghiaU=; b=c8/KfXVdNYahd7rv7FmgWRLghh923Nc9WDQrX7y44hH5MoqfEBqS/iaIzuk8FOlHW35tzK7RsrR34hxS+u5OIVQe8YidAMLP3hr/Up8QbT/RyoWd+4zHTDA0WRweQ+aCqSRYPr/HSydF6kTQK6eooT2vmzjOpkH/SYdZcVlNieyujtp83RQWCChSIesIB7z2vuN5Jx3MJZ+s3ZVoEaVI/BYLOpJtUK24twy2Q3nEK4d0kPB1/M9V3QZQzofNwN7MbzomaxqHHAZ88wOsgwnaTbsF+qZlRjp/rfCnFjR+6q+vurIyvZvdaAHiNOTKbovHh070nG2yKas1RkinM5vPNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7kx51GpV/thxlkmVVyZvYieNytvwCIAVjUw7YghiaU=; b=Dk6vUw0v9HNDnonvj4Pg+we80Q2Wu/CirbUgtk5wAKYziejLQJlYS7q03id2r2zm4PQSKDZukV8cvQcWBv1cqK75L0/3W+U+5/hh8UzZNx28RBl/noMdHn4SWgzMkps2/zWQQVxaPu4myIe9MDo3axB8gm03bfWb1cIksL/Hf4Jp1x4ov4zQxQr2EElQsV3pLIFKORSenCR6vL/taIKMXuQ2urLDLyVty+aef7LGXspoeaGkoZ6KB5EhbAoUxv3RlMB7ftIQ03cMboVCyObk9cRsXvG6vaos0jHD3D0DiADZ+N6kuWcVXoWwg7W5iScrIr1gt4qLx0D4iqXQvl5u6Q== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ0P223MB0637.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:44f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.18; Thu, 6 Mar 2025 17:02:02 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8511.017; Thu, 6 Mar 2025 17:02:02 +0000 From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids Thread-Index: AQHbjeSnJYtY2XIGVE+nxmGIv6NZhbNkre2AgAACIJCAATOWgIAAbOVg Date: Thu, 6 Mar 2025 17:02:01 +0000 Message-ID: <DM8P223MB0365D1DCA266FBD80AE5BF66BACA2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.59.ffstaging.FFmpeg.1741189106311.ffmpegagent@gmail.com> <Z8hwUZUibUe5Ff4g@phare.normalesup.org> <DM8P223MB0365975894E9FE6F7424880DBACB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <Z8l0H8xQNhwcB5sR@phare.normalesup.org> In-Reply-To: <Z8l0H8xQNhwcB5sR@phare.normalesup.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0637:EE_ x-ms-office365-filtering-correlation-id: d59fb4d1-f177-4a2e-9a26-08dd5cd09d6c x-ms-exchange-slblob-mailprops: pR6bHsz2grYoOjbNJSDqfm2a6/N/0bK1Xhs56u+CUkjtmuXMCfnjQVq0rCM6p7YhRts4GS3t7ISruEAiKAMG513IOpaXpxO323uc9DE20zgNP3ubqcSBFK9+XoO3HxzRQWx3mHydi/8IRzdDG3GyGqOuNsTo0KRU3v4UG2myI+DbgaQKsMxhnVaM27pl5Vefcu9I3rGBhdd45FmzdPTkFqzyuwopNWJ02SjqdbVisJfX5CRbYeeTyMDNqerjRA4nDefP8ozS76lpA+pzgkVRbmpaq9fctyNGLxa4m+vnXFG8Y2R18zWos9GPz2hdR7q/AVtc9+pbWkvI9RznV9UhKYZVRxFelNDx/KHyRcZZEDd7Xb278zA6s6D2aVcRM+icQxRoBidOZ0mjQ2Ej8PINs/sJySzC5Gws9JSF7HGNtNEHL4HzUEj0qJKH4/kDEIx8VOB7q/41uN506rx+lSuUwrBQSoJ1fRdrdX0f4Cw5yixVw2+TSbtOhaSoYLrMrM3nc3DIRvXNGfFaX35Awh4X0Fe04BkOC2fMR/IT9aRwd5vqi1+58LTmBl7W3OO9FDGc x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|19110799003|8062599003|8060799006|461199028|7092599003|3412199025|440099028|13041999003|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?FpV98asO4dc9X5La9of/j70G9oF7IsKHYKq/9lQviZ4x8KRDMaLCw5mo6A?= =?iso-8859-1?Q?FovcVbmZe4ChHT8Ji+Niatj46ejg27w/bqzDRRP/uEsaSjvSny50cilqI0?= =?iso-8859-1?Q?iRmLbyANSO/N0o74Hy5841sySupHuN1fBg8tXNB6jpxcpSffMg9iJbwVDG?= =?iso-8859-1?Q?sngJpgD7SGjTUDQ6zGV0jatrkcW3fVoshRxvW47m8BwGmTiHTjXgFQ93r2?= =?iso-8859-1?Q?CLqatn7+lNx7/iX9eatu+BGpnGN/l24EdDBC8hcrsi0NpsCg/0nV9JDt3n?= =?iso-8859-1?Q?JoW+KzpefXdeMrE84KaG+Gf6GqxiwFnoMKbEQCwVG9iBHNT6Zuuue3iMpw?= =?iso-8859-1?Q?wNN6NdkkCJrV8TKoyEBAKuyY5wUvi3tTnjNBAzVZSU5nZ2k8rY18ZBUFeB?= =?iso-8859-1?Q?uPLhilEKerzM0ea5Iy6I2Pqqwi3OPlYuLYk0MQ7HCwYNXq8Q7eFPV+vjmP?= =?iso-8859-1?Q?zdG39QQH8iI4fCWh6Og/urAtVOhEg1d48sSsqqK9OltaND0dKNKcSk135w?= =?iso-8859-1?Q?y3AfOeOYQGdHgtc/+0BKesgPb6/Nfec9U2kPykUF5EYJ1ckbkEaaZgoLjU?= =?iso-8859-1?Q?+angcG5qMsLwsODsBSZc2dSoHhi9hV3ofbtTEP9HwvSV1FL3D5dLeDyxUa?= =?iso-8859-1?Q?rJrOBEorPJgq5gVCNsEV1Y+tkgvKFRP2+JSVful9dOrFy5aSpAXhVpf+vx?= =?iso-8859-1?Q?iOnPSENJaIHfcXDdi1DbcHRzMNmM2tCfOq0rXD8qY/5kRRNCzbJcsO4A6X?= =?iso-8859-1?Q?PObyZqp3GocmyYBm3/WnNRoojGN3LXXhGHMTFW/vy3Bti0qh0iP/dZNr+8?= =?iso-8859-1?Q?+781IPUxgfJfKvwpr7cAUnjAxzH6A8qlpGzg4sGCrogJeCnJpzPhOdAont?= =?iso-8859-1?Q?7wpM7jqAcUCItIv4+/6djbEhTY4fPBERaQxaPMbEj57reRUkKSL/ymGD4X?= =?iso-8859-1?Q?pc2kdiLF92IUUXeggfsZ1+AxYNoIuY7RNShEGEQZ2iKemkXXgg2ttj2eiw?= =?iso-8859-1?Q?KHvRkY1DHAMzxV9ION7HAdzmI5quK3Mjatz2Cxo6gyQh4IE51/lHkJs74Z?= =?iso-8859-1?Q?pAjBrCeLFoSd0jCkWQmgr2fF0noNDRj5OC331UuwA31hlyMtkWK/LD9qiD?= =?iso-8859-1?Q?mZs4Rn2mnTXLNMj74R12CYMQgutVc=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?03Wujk0HH7MV6eeFCjAomJWJIMMhphs/7jPaY049KSIb8YRdeRzPKqDZO9?= =?iso-8859-1?Q?thRTNWhQ7ASVYG4zgeD+y4SEnwl/zw25UCff12zJWMQptCFgZ3EJgn0Ebo?= =?iso-8859-1?Q?LbzXZCO/HcPqwrF9pBYeI7o4IXCr2J2LzFDKRfjKZBv04Mqixp7aEiM9Cq?= =?iso-8859-1?Q?lSyUeC2p46aXPEUyyuBODcydUKMHsSE77FhdyoBPcf6Ud9kxuiR6TgrYk8?= =?iso-8859-1?Q?wQ8AGTCcFAX1MLHdyL/cnMaIEnylAW5LO/yxRDvMopQoujcORmF2KSbrHj?= =?iso-8859-1?Q?7ys26iqXGIuSDvWA5RWrWxkEUGkb+qYmmDv6BqyQoLvspZJTMoRBWtf0Vy?= =?iso-8859-1?Q?NOUNG1BAx6dv/Im+L4Ditiapzn18ygIdVni4ghRWHx01xrE9mQMUZmLjT6?= =?iso-8859-1?Q?2U4IKwAFJP15eB+tzKapbnRcJWgjvUuQIazJu0NI6jodNWER5unp0SYxEO?= =?iso-8859-1?Q?myvczXiSvqSe/zE4jvO0gQ0AtFhdU+SKa9N8OpaIfcuj+1sVjcFChlR/d3?= =?iso-8859-1?Q?KB927QAXbgJpk/cGb4F6TQTfFeFhXWanvM+qZA3pmxDoktIe1kU04jaK5y?= =?iso-8859-1?Q?Z/qtu2HUpi+6OJLk4BMyEr0zjhXejC9z2V+0oW3w8Bpg7ttPR4ShrpGEW+?= =?iso-8859-1?Q?cfVzK1ptw0fH+c0WpxKV2aX1VlariIP8RkjlHq3ysV0qVhiT2WzvCI8cS2?= =?iso-8859-1?Q?lGGHlEvffOGOU+0e74ftpS0RSsKWsFdWJGPoi0e4tRmqZYKE38n97gtH2d?= =?iso-8859-1?Q?Y6ex+NFGru79Ut4R4P1ToaGBxEBu5LID+kAV5Q4K+WrP9rhITuZ/7hFEnx?= =?iso-8859-1?Q?xs8rP3jwA/2/Kzl8FSg1+2dmvIh8V+wJZY+cHaBLbm5E2x+fGCnngSzDAj?= =?iso-8859-1?Q?YRuwJrJjg9Z1uw2nGA9fsYV3zhtNnWIRhExooKIeZIDlGqQwEv5q87LVOG?= =?iso-8859-1?Q?Ayb1nNiAzBjs58ValFGJpcyVkR2mxFFO89jpzBUgW05zpDELNEkgwODelI?= =?iso-8859-1?Q?k9dIl1U6HlftDj2FwVwJKtme60lj6+ixJJkI14XFql4Had8pYrDAXRQBew?= =?iso-8859-1?Q?pOLuTjSkG5A/b/faBD6/B4Lz1vN3jZZnhSzJ1dvzwQFvrs8+RRlJKxzs78?= =?iso-8859-1?Q?F3mcArB7K+xaWoh0y1+Wq+pi6r1NgCkJ1UOz2hyM433P1rvx6XR0xOcnoT?= =?iso-8859-1?Q?8YLsVAQZIIp3emF+n6JUVOd233y40JO2exqk7q4KdDWA5mbtAp5yThKGhP?= =?iso-8859-1?Q?1MDn+1oVUbmUNq0tUBWqlUqFEfOMouDGFC6u1cj8g=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d59fb4d1-f177-4a2e-9a26-08dd5cd09d6c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2025 17:02:02.0236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0637 Subject: Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365D1DCA266FBD80AE5BF66BACA2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Nicolas George > Sent: Donnerstag, 6. M=E4rz 2025 11:09 > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log > output with simple ids > = > Soft Works (HE12025-03-05): > > Sorry. So - seriously: what would be your recipe then? > = > I see not just a little of non-trivial code for a very minor feature, Whether trivial or non-trivial, it's definitely just very little code. > that might be a hint that it would be best to let it go. This is not a helpful comment. I'm trying hard to be friendly and productiv= e and I think it's not asked too much to at least try doing as well. = > Also, if somebody is debugging a program using the libraries, the > pointers are relevant for that program. For that reason, I think the > change is a bad idea in the library. It's a valid point, I have acknowledged that already and added a log flag i= n V2 which allows to control it. As a further compromise, we could also enable it by default in case when DE= BUG is defined, how about that? Generally, debugging is important without doubt, but it doesn't mean that M= illions of users need to see something in the output which is only ever rel= evant to developers - that's the premise of this patchset. = And even as a developer, those addresses are interesting only in a very nar= row range of cases. = These addresses have been a major pain point for myself and many others ove= r years when comparing logfiles. Even the best diffing algorithms are getti= ng confused by these addresses and I think this patchset provides a huge be= nefit for both, users and developers in the future, making their work a lot= easier. > On the other hand, you could do that change in the fftools. The point > about pointers being relevant does not apply for them, and they can have > as much global state as they want. You know that it's not easily possible to do it from within fftools because= all libs are logging directly to avutil, so it's not quite clear to me wha= t you are up to. = Do you mean something like a int(* av_log_format_prefix)(...) callback that= fftools could register to? Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".