From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A2C0407A4 for ; Sun, 1 May 2022 03:10:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 101A768B2C6; Sun, 1 May 2022 06:10:27 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2085.outbound.protection.outlook.com [40.92.22.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 602AC68AE71 for ; Sun, 1 May 2022 06:10:20 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3/yrW/ZawAf75uTtksbz77lqrbc9ktLqr1arLztHMuba4y/ys+VXqC+X6bJUmmMcsZmbQPAqTNOpicJR6vjDbc1L8neQKgWzEfF0sZt4nbacS6pk2P7jUDTfq3WatoeIeohsZkNz9y5ZQmxsqgxP31HrBNFiXHTZBeica/jzubR3yoUOH6Z9HiwmXJ7JsFZUZEXzKa4hF8WbMgKwbwi1fpvoUJnmg+e+t7fxvDCRqcRddw7RIB70V38R0bywn/Q+X8fiNEIktOMFUC+DNr8jcU/mK726jhau2xql17LP76I2g/UQxvTL//0lyMkqpbFmBtM7W8RrxSN9pMeBLDbYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x3wQgbhONSCw8KOTZfRQWsOh3+LcJj313IoATHvqB3g=; b=IGgAapCu6ohylsqAHtw2xI4iHeyAjdStU3EJQpytQBSeG39EJxTL8z74rU2yV6pWTMNg2bgkcyxkIPlj8IMJrcoFTa1M9928NQTg6PaXBfVK0rHe4DUzNeFtg4k+Y+Vftto9mjYunI4zKCui7PR61ZupJOe2n+OY8+EOY1fG99yLUtacwQBIts/SFHPIQcJ9m5pNbGduJovdR5TZ+eXk+N5Xr66B5MrO6zqcIRePwoAlCZ7tsGNxRM5AV/7lK82Te6Whsm1zTZFxxzKlY0nbe0NXh6R4YzjPty+P+pjXclcQuhWKl71iOBVgELriZ8llIgt4xbMPJi6xf3Y1cY4Q+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x3wQgbhONSCw8KOTZfRQWsOh3+LcJj313IoATHvqB3g=; b=rIiGuH0rFnB2a2SwNSSAhJcMB2BFuE59n8nGcH/uADflUptb8oNrreF7+tBuQ/Q9ngCPR7WmovwZZzyhdgmW/X7uOwRIygqPHQm9o9sCktEnsvhfbYEwVsUyI955cjQHvtxXvvmmnUwkBXtEuVnjA9/oIn1z27XuC0bgIcwtW0LNqGWsKhYanFsYpNARiYuXsZerzBrNu0X/JrXDTkNWQ/LnyXyhKbtQCHeE6PzgNHNTQr4qz9vrqeO+mFsLSem4C6+x5nyYtw57IKXbVuOM6HtiNsj/RcY9Uxr9yq7XFrJ3DSFcnE1ozfT0H5dPp1pabs0vGq5qN9HopNb715TWjQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0160.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Sun, 1 May 2022 03:10:17 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5206.013; Sun, 1 May 2022 03:10:17 +0000 From: Soft Works To: FFmpeg development discussions and patches , "anton@khirnov.net" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSCOoldZr8XAI0qbTqYdIv60xqzhXE0AgAEI6YCAJpQPsIAAn14AgAADMfA= Date: Sun, 1 May 2022 03:10:17 +0000 Message-ID: References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> In-Reply-To: <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [ux9+N+EFL5tBtqcS2fM7FYtJ9wvhdLWT] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b17f600-41ab-4be4-c101-08da2b201e53 x-ms-traffictypediagnostic: DM8P223MB0160:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cPbkxTnEM/f3dtARTLUKnht2VT9JTyXrsFYuEYUB0zoIKh0GnnDo+Y+gVRyvHz0s4nAl+0GOGe2SV93+fDBCqP2G5Fzd/DL5rEBV4Nu1i9HcU02dcbFPmAABwTHbt7WYDD4/LqcwgwKmpJKqK9bOx8KhiosmKTsNbwz6cqJb1i4DTHwQ0FdkDDEGbVWBqexmvY2AJDo3RXDIJGPrKomMcCacnOcpPka8iVXbB1t/eJFHFSN2na/ht8vyi72twuKPtNxsaE/HSzVLLSW22FBjqH9GmkBQ0lj93t2/UB0rbJCIabhc0BcFkocinDnDkUZWl2eOofVbvSxccBmRUQJPuMP6nzk6q3CMEHZW5PZHuzK1c/UEitph8iXYg+ThhYmTkCdXU2JGNJWxc1/HzwTxZO1gmwLgykXMkRd+X/ejKdYhdQihwxOtHTiCP5gfeOJhSCnbRWViDCyocZ8V29rVKzWwSlYsvclG0I/aJBU6t/UNQ4+6NvwUeljhB3mQ2/0nHYO5UlQJmpfWfloPGkNJDNUVhJhttlaT6lOpS2uhHmYaepM0QA+zPw7SQE7vSYU1aW6XzsFpi1o5vIwNpuH9S6P8KBZOzA+kxL9A6XICgJfSBwhA8YYB4x7mWQT0WuJ1 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TDExd3VoaVRoOSt5TlkyRWViOTM5czRFRzQxZmlHYzhxZVhyNmwrMkxlYno3?= =?utf-8?B?dzRHdHdOWGJVTWlUKzZpOGFodS9UOHRVemZkV2hYcUtFS3RaWVZMbHdUS29O?= =?utf-8?B?ZlhVaFpYbkZ6ZlZwaVVQNjBzZ2c2WmFUQXJmU0poWjNxaHd0T2xTMmhJemZx?= =?utf-8?B?aC9qQk13UDJMeTFKMTFwbEpMQUhFR1FUbEc4N2ZXVENueDg2YVNCQjZRY0x1?= =?utf-8?B?bFEyQU5tYUllc3dzakpiVG9MK1hmanpkRW9jR3RxSzFaWUV6a3A1Ni9UekJv?= =?utf-8?B?MHFycmk2UFlGaU8zZW5kSkQ0ZHJYSU5qb0xQb0Y2MGF0YkMrZ2dDeUlXMUc5?= =?utf-8?B?anVma3UwQlF1TGpoRkhYdSt0b1NlZVFqcGJDVVpLYkJ4aHpJejdqVThLVEJG?= =?utf-8?B?b1MwdC96ZmNwb3Z3NjNaVDg5Z0ZQWmJXdUJVQkZoeDlMRWd2bDUvQ1p6ekt5?= =?utf-8?B?T0gzZy9FcWRhcU10Z0RyRmJ4anNpMUQ2U2x5UUtHZVRHVnZIMFVPOGF1TGg3?= =?utf-8?B?YXpLUTRhR2ZNY2cwWnNRV2h4Mno0MHY2ZVRyazFlMXhBWXdSb2liZ29NU1M0?= =?utf-8?B?NVNMRzViaXZKeEJVcHVVTk4xUHpiQWRIVm51MWFwbWoyNnAvQjU4M1IxODAy?= =?utf-8?B?OG42dTVJYktnU3c2RmlrVG1scFB6UmM1WVU2UnNqcEhDVFhrcjlkb0M5allV?= =?utf-8?B?L1RMbHdHL2owR1QyaXRwMW9xOEZlcktGQ3dGODhsVUY4eVNmT2RBazZ0SjFp?= =?utf-8?B?S3c3M005eU5FNG1YNU9NR0M4M2hQWWJNWksyRzZ0b0hZbCtJRnZNZTVmRS9h?= =?utf-8?B?WVJvTGdGOXdBM2FuMWdDRTRMd1lvSFA5RlNyZndWV04weERud20vYmJNUDVB?= =?utf-8?B?SXh6YTh2ZERqeVVjajRXWE1pU2d1dGVMSFpuNnhBQkR6dGtBV3g4SG1mNTQ5?= =?utf-8?B?b2l3Q1pxdy9aY1FwT2VScThIMFVSSlE4ZngyQ2VDZ2tpQVBJblJnTVRMTWxS?= =?utf-8?B?dmV2a1AwZ3hCRHZJQmFoeGZtanN6RzBUZm1iOEFySmVRbENHK3lzZTYzdGVw?= =?utf-8?B?S1lnUUpGaUdobFlwSGtITlFMYVZOVFZwWWhOclA2QWptMm1CUEhuaFVNdXJn?= =?utf-8?B?dkNnN3c0cFJwalgxa1JHTDR0czhLbXFNWEFoQlN1aWEvRk5EK0JBQ0lvUlRu?= =?utf-8?B?a3NQeWVOTHJGOFFGVHZ1a1ZWRnNxSGxFcE5CV0ZGZys1NEFRUzl3aDl4Y0ww?= =?utf-8?B?L29NNTBZYVUyeGxhRXdEY3RnaUdDbmJVRFJLVGJWSmZXM1FnbUlNalZ0U1Fw?= =?utf-8?B?ZTgrNUFKdHBXUkcvK3dYcnB1Nno2MUw4bjRYVXZIb3lXNWdSdVFMNFpzb3B0?= =?utf-8?B?Q01sSnN1SjVRLzBoN3JITXhTVHBRaURibVBISG42WkNvNHR5T1dheG9BeTBK?= =?utf-8?B?cFE2RE9mcnp5b0tDaG0zcUV3SEVmM0lPVEZRRTFjKzJHUUIyMXdQVE8vL09i?= =?utf-8?B?UWtnMjJ5aEp0UHNkSS9TTXFoUFFtRkNvSG1WeTM0SHpVbUk3cWFXeDRuWFJv?= =?utf-8?B?QU1lay9aV3g0MkRZeXA1bTNiNmU5NEIyTFBsOElPTk9ja1dvNXo2TlluOHl6?= =?utf-8?B?aFhSUnMySVM1OUI4d000TndhNkkxQTBYNllaQjJ4UzVBVVk3a0hEMWpFUFUx?= =?utf-8?B?NkhHd2JWY0ZWbHhMdmk5eWpMM2svd201WFFTZHo0RHNDQVVDS01JMGEveXNW?= =?utf-8?B?czgya0JKcGhNZ0xkL1E5b0lLLzNFMFB0TWhWaUlJbEJlYk95QlhnNS9PSDhx?= =?utf-8?B?TTIwcmdlSzZDU3dpNWJibHdHM1YyWnliU2hEcnd0WXZ3Sjk4SXlsSGQ5Vk5r?= =?utf-8?B?by9HdkgwU1B2NFdhYk9aNlZPeU1xamozUzJxL2ZTYktkc3R4WlFCL1pkdDFh?= =?utf-8?Q?X1oRegGnZYw=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3b17f600-41ab-4be4-c101-08da2b201e53 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 03:10:17.3474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0160 Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Sunday, May 1, 2022 4:16 AM > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > code when MFX_VERSION < 2.0 > > On Sat, 2022-04-30 at 16:51 +0000, Soft Works wrote: > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Xiang, Haihao > > > Sent: Wednesday, April 6, 2022 5:38 AM > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > related > > > code when MFX_VERSION < 2.0 > > > > > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > > > From: Haihao Xiang > > > > > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in > > > > > preparation for oneVPL support > > > > > > > > > > [1]: > > > > > > > > > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > > > l_media_sdk.html#msdk-full-name-feature-removals > > > > > [2]: https://github.com/oneapi-src/oneVPL > > > > > --- > > > > > libavcodec/qsv.c | 5 +++++ > > > > > libavfilter/qsvvpp.c | 6 ++++++ > > > > > libavfilter/qsvvpp.h | 2 ++ > > > > > 3 files changed, 13 insertions(+) > > > > > > > > Why not just remove this completely? > > > > None of our QSV code does anything with audio. > > > > > > It was removed in an older version, however someone objected the > > > removal of > > > this. See > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > > 4-2-haihao.xiang@intel.com/ > > > > I think this was a misunderstanding. I see not objection. One was > > just asking "why" and the other one had missed the point that audio > > has never been functional. > > Please find the comment below in the original thread > > "This seems like a generic translation from the library errors to FF > error > codes. So even if we'll never touch the audio functionality of it, I'd > prefer > to have that struct complete already" > > So my understanding was that the reviewer preferred to keep the audio > stuff > unchanged for libmfx. Hm, I hadn't see that here: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.443304-2-haihao.xiang@intel.com/ Considering the text again: > "This seems like a generic translation from the library errors to FF > error > codes. So even if we'll never touch the audio functionality of it, I'd > prefer > to have that struct complete already" I understand the idea. Normally those lines wouldn't hurt. But now, that we're facing some kind of "#ifdef hell" anyway, I think it would be much better to minimize this as much as possible, and there's really no point in translating audio error codes. Also, the struct has never been really complete. Instead of retaining unused audio error codes, we should better add those that are missing (like -21, -22 and others) and relevant. @Thilo - can we get you warm with that? As an alternative, we could simply replace the two audio definitions with plain integer values (MFX_ERR_INVALID_AUDIO_PARAM >> -19) This is a small bit only, but before adding the oneVPL stuff, I think we should consolidate the conditional stuff as much as possible. As discussed before, we also need to settle for a minimum libmfx SDK version (compile-time, not runtime!). This will allow to drop quite an amount of conditional code, and this cleanup should be done before getting to oneVPL. Another thing that is a bit unfortunate is that we are duplicating this error mapping struct in qsv.c and qsvvpp.c. I don't mean that it should be linked as an external between avfilter and avcodec, but it should come (be included) from a single file. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".