Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: add a disable_2bpp option to work around some decoders.
Date: Sat, 1 Mar 2025 15:00:46 +0000
Message-ID: <DM8P223MB0365CB80A73A31C295E314F6BACF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <5B5E99C1-EE70-47B7-B3BF-DEE19C41DBC7@waider.ie>



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronan
> Waide
> Sent: Samstag, 1. März 2025 15:30
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: add a
> disable_2bpp option to work around some decoders.
> 
> > On 1 Mar 2025, at 14:10, Ronan Waide <waider@waider.ie> wrote:
> >
> > (changes from previous attempt: fixed an error in the docfile and made
> sure I'm diffing against origin/master)
> >
> > As noted in the code in several places, some DVB subtitle decoders
> > don't handle 2bpp color. This patch adds a disable_2bpp option which
> > disables the 2bpp format; subtitles which would use 2bpp will be
> bumped
> > up to 4bpp.
> >
> > Signed-off-by: Ronan Waide <waider@waider.ie>
> > ---
> > doc/encoders.texi      | 27 ++++++++++++++
> > libavcodec/dvbsubenc.c | 85 +++++++++++++++++++++++++++++++++---------
> > 2 files changed, 95 insertions(+), 17 deletions(-)
> >


> 
> This failed again, and I see the problem - I'm diffing against
> https://github.com/FFmpeg/FFmpeg.git rather than
> https://git.ffmpeg.org/ffmpeg.git. Apologies for the confusion on my
> part. Fixed fix of a fix incoming...

Both repos are in sync. Git says your patch is corrupted at line 11, but no matter from where I start counting, it doesn't lead to anything that looks suspicious.

You can also make a PR to this GitHub repo: https://github.com/ffstaging/FFmpeg and let it send the patch to the ML automatically.

sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-01 15:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01 11:43 [FFmpeg-devel] [PATCH] dvbsubenc: " Waider
2025-03-01 11:48 ` Ronan Waide
2025-03-01 12:44   ` Ronan Waide
2025-03-01 12:55 ` Soft Works
2025-03-01 13:52   ` Ronan Waide
2025-03-01 14:10     ` [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: " Ronan Waide
2025-03-01 14:29       ` Ronan Waide
2025-03-01 15:00         ` Soft Works [this message]
2025-03-01 15:07           ` Ronan Waide
2025-03-01 15:32             ` [FFmpeg-devel] [PATCH v4] " Ronan Waide
2025-03-02 13:13               ` Andreas Rheinhardt
2025-03-02 15:00               ` Soft Works
2025-03-02 17:23                 ` [FFmpeg-devel] [PATCH v5] " Ronan Waide
2025-03-02 20:38                   ` Soft Works
2025-03-02 17:26                 ` [FFmpeg-devel] [PATCH v4] " Ronan Waide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8P223MB0365CB80A73A31C295E314F6BACF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
    --to=softworkz-at-hotmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git