From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C4A634BC1E for ; Mon, 2 Jun 2025 02:46:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3C51468D566; Mon, 2 Jun 2025 05:46:14 +0300 (EEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2106.outbound.protection.outlook.com [40.92.45.106]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CEB8368D4BF for ; Mon, 2 Jun 2025 05:46:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JdPA7mBnI4uSYs1OX2byoc344jK7lPaeZ5Lx8yec6CkPBisfee0r2bZNY6szqKhLMHpKqodHck4NQu8HdJW086/eQYXdphe2mbNEnKZaf/mgZ7xO+qXXjYVRZ+b0/uhFSlzwwxVjinb7+BuVNBcSuFIED2ZrOIGDfNOlv5QqzJSWAyO9e+mKYx/dvcNNO8Qtd3Bt27BjtNU1ZLj0vOgWtgyJsqBSebUtb75t2ztOP2lzfvDjv2gGvIU4/KK198NupK//YpMgNKaqZfYp/zeXSGl2MLrsMRgaUbRBWroQMqFBiye39B9z1+pMOJfqKQuMhaeF2a+ZgbPTY47cHZ9rdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bk1YJav2HqzySiRvXgwf4ge1LsQtlHrLPGlyNNlA1xU=; b=A8YEBFU94XeKsrym67k5rQIgR6eTK/Arsk/TXHcPh+n54k2Mdx6iRhLu/hwtjD9SPCzvcSkuYOr/Ovy6hMAG11mwbxX5rO5kkRGYagb9mFPiW9aBtq4pnx/hDrkmkqBy8wYwLYjN9GfVkh7+kLlEVPi391A2UsrLaX/p72e8CTBELqXuC0xn8X5pLNxNF276dc7SbkQD4oXopbK/zCTjm3KR/ddQ0iMoArBGb6+D5Y7NHOmE36U6mCMpNboEqR89gMo8gxLioZyXurpZktq6K6rSAV7PDofvmU67gwhbaPNLL7UfD1bnzgFYhMZN3E/YoMO2Ee3pUhAISCMCDY3+dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bk1YJav2HqzySiRvXgwf4ge1LsQtlHrLPGlyNNlA1xU=; b=SjqTENOQxSq0ih+8e9PwhrNbs30UJFXckDcyiWEg/rmbQUJokkvu259RO5KuXiKFn/JKbsgrVjt3ms4bjYg0r7+MmBJcNzNB3kpHa4WHandBrqE1Or7QHtfablwtWRb3BsM/pH11/OTCvx3kh6JmSFLe8fPXxuDpOYEJiKzzYdPdtq/0sPPtt7uCqULr1Lsc5Gdc9Wi0eJlODijcaq/ISacyHgptD5zti8bv0HUCg5r7+HlYQU02L6yxd/1q4mKcC7tgXWwkHAf64q3+ZFjIkiEnDscEgwfaduvzM29akK3L/597eumEoWDGDW+ys6RC73k4014Mk1bHHm3/517gbA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DS4PPF6396563DB.NAMP223.PROD.OUTLOOK.COM (2603:10b6:f:fc00::a4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.27; Mon, 2 Jun 2025 02:46:03 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8769.031; Mon, 2 Jun 2025 02:46:03 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again Thread-Index: AQHb0EbOKCk3Wt12nkKvgiNogA3SgrPr21AggANFnRCAAA36AIAAAIUw Date: Mon, 2 Jun 2025 02:46:01 +0000 Message-ID: References: <20250529030643.70454-1-jamrial@gmail.com> <20250529030643.70454-2-jamrial@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DS4PPF6396563DB:EE_ x-ms-office365-filtering-correlation-id: 00c414a0-5cc6-46be-a477-08dda17f9c7b x-ms-exchange-slblob-mailprops: 9IecXKUgicB0Vgu95vFSoXNdCFmhIzagu0/WjyR+FiobRWjHNq1HEFwuOaKg3MeQ3DDXgI6P01fDtr5kwXgAaZ4aAHf4FlZ2qTRGriCFkvaf1zF1qzcPUokdBZe9WVmLpo+/IglDXOyboaMMjttBqPxoOZV/cLNlITxMRg41TwsxHPJUBNlpq46LVzz2t66Q1M86pgdxHALy9DvW812C1Hn6e24OJmZDFwPT4uhUT1FEJA5fdFFhzLpVWzVVm1bn6KeVlnVt70+pcqDPagDgpoOIzCmVY3sAgXZWX+OWib7x2PfgjnvRVLI9gDZa8mklgtMTMwow85XI/t8urGkMxxCFsHnHLRwnBBuH9+w/U2heERg0lESyAWcpDERysdXkBfqhElvZehNqZEkqBYJRDXuhaS78Z5rFsBruD3rlx2bqOdtv3LanAhINbntiOk1Bb3m7yqKF9ZHsTAp2Ub8B1o5Tt+DE007eAo9JyJJyx6d75/5/jJpG1jnZYJDc3J8sJCO71M3SvLrkETYjQpti18HhcDizbhY7gJ0mGcTeaJCU1kw/szhQpzpCNguFZ2b6yObKunG3Rux4CA1NlJemOXJkrPaeKO1m+6ahdu8kGOIQlADsaz3mSvAIx2CZrLPe+sGFXfdm/NP2nKDlNlpWK2dbHxu1L8X7ql9F9j+0isd6ZrU5+5aPgiJBlTYegQULjcXec8Xk2ZnnM6nD9Oy/pu+P1RAxIIAxEpIbSXjluai7LElq4V028g== x-microsoft-antispam: BCL:0; ARA:14566002|8060799009|461199028|8062599006|7092599006|15080799009|19110799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?B?SmFDUWw4T0hxZm82SmVaMWhMSTA4cnRZTkluTDRURkR5ZzNhaGI0WGVGTjRP?= =?utf-8?B?dDZsVjVSYm9YNHBWQ3BjTlIvYnpoakRnendiOENhZENOWmVodTJnSkVWZHBh?= =?utf-8?B?K3JUWWgwQTFxZGdvTExxUU1idVpVUTZYRGJSSmdWc2hPaXZtZjlYL2d3czhq?= =?utf-8?B?WmpuZHlEdnpPY0J5YmZGNUJXVVNDbk04c1Rpcy9VeGJQbHdZNi9zbVJXVGUx?= =?utf-8?B?ZG12MzF3aWNGWTQ5cUVYSGlIRVZmRGJnTlFZSm42amlBZTdEUmpucGcxVmNo?= =?utf-8?B?VW1hdmNzSWVTMEFmK2FmQ1pWa3lQazNabkd5ajRXdStlb2k1b3hleWpvYWlD?= =?utf-8?B?VUo0S1V5cTJEUlBjb1prd0c5MUZjVHVNSlR6SVZIMzM0NWh1YnRrekpIM1hZ?= =?utf-8?B?c29PdEZpWnBraGdaVnF6d3JsL25DTHQ0WlVraXhRVmNWSkJmbVJCMmNNYURo?= =?utf-8?B?ckhlVW8zdVc2WS9jeW1qUkFXTWc4WDE1Z0NxQm1rRUJhK2ZxcGdBNmZ1eXVT?= =?utf-8?B?R1BDRWZ5aTRxOHpYdktQdUE5NktqSW1YaUNCSjlWNUNkUUwxSGw3Y2RVOERF?= =?utf-8?B?bHJMaFR3SnhYekdmd1NsSWlTZTBxTTdTRzhxQStUNmUwcVBwZUh5dURVdERY?= =?utf-8?B?ZEZkd0RRN1lmdUxNMVVQWkJrc1h0NWUrdjc4QjF4eEY2NGRyek13M2FFbjVJ?= =?utf-8?B?NzFXOXEzTXdJSEZUV2l5ZVRyV2ZiaVcwcC9jQml1SzdUd2U4TGlBYTBucEFU?= =?utf-8?B?THpta29xU1BoU1RkNEFiUDQ5Wkg1NFJibWZDbVJvU1I0QlRkbFRMTEVPMEk0?= =?utf-8?B?ZFJNM216UWhCeGJIZW11WHAwRFdiWjRWbW82TWZ6bzVVRVZlbGYycjI1Vm5Z?= =?utf-8?B?NFhKZ0ZjOEplUitqYkl0ME1yS1lCMFB0VVFseE5rUENITVJyWjJodk93MVpU?= =?utf-8?B?UzIvaWs3aG1GU2xMM2pSWEJBSktLMUpaekJXQ1lsTEVWZWFic3ZpM20xVWRO?= =?utf-8?B?R09mb1BNVC9XM3VNN09lejVoRXBWQ0lpeSs4WmZqRzJLbERTdGwvRU9meTJ5?= =?utf-8?B?TEwyQU91NWx0Q3pwWVlnSTBrNHdTeUJKMEhxWHpPcWFHa3l2aDBwbnBGcEhF?= =?utf-8?B?eWRnZjJUd0R2M2xobkVhT1h6R1AwbElmb2hSTDBVWU8xbnVlNjU2RjhQOEtI?= =?utf-8?B?RmVJUWVnSUNJWXBWbkMxNTVBTE1Ybmc5V2J1bERyTVExeG43dWI2cnphN0c5?= =?utf-8?B?eGpnNjN6WFJyNUFPaDdXSFBSUkxtSTd1RTZNc1lnR2s3MFJBMC80RnpHUjl3?= =?utf-8?B?Z1dMV0ZNekxQWnIxQncrUXJSTFdwRnN6ZWE4TW5YUm9abUdhTnRISWZsaWNn?= =?utf-8?B?RVdLR2JIODUzcWtMZU9LQzkzMzltVVl2alVvUUgybXo5aGNhK0pxbktTWDZL?= =?utf-8?B?ZXRXT05FQm0yTUpPNEtKV3h5bWkvQVQ5VnEzYjNlbjhmSzNVMjNQODNGNm1O?= =?utf-8?Q?nbzJ2Q=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZmtqQktpSjdxNW8zMkVGMTlRaWZrUnFjZXRYamR2ZHBLRWhlM2F3N3BnWkFK?= =?utf-8?B?UFpZWEdqSVQwMGFCZnhnSlZ3TWl0eWxYQnhyN1Z6OXJwa2RoYnJLZVZJNXlW?= =?utf-8?B?ZVBHcGJyaHdHSDB4NDlxc2J3elllNiszRmlDaTdUd3FlcHFDTmlzVFp2T3RY?= =?utf-8?B?Sy9LeURKVlBvZ3pKTXN4WEpzcmhKZXloWkpDZ2VIUS9RZFZJbjY2SW83NGlM?= =?utf-8?B?cVBDdk8zRmtvRHhkMVd6c1pJOUl3WFhrWkJaTUNGNlV6OGF6OEpFQlM2SHlL?= =?utf-8?B?aUY5Zk1lMzA2QzRKRysrTTBJeW9QdS83ZGVqREYzRStpY2VKUTBNWkpjS3Bv?= =?utf-8?B?TG92Qkh5WU5SWXJUM0ZDQnhkZklvdXpCcFRvZkdUOUFBR29pWXl2ZHZzU3Fo?= =?utf-8?B?MXUyL3JybEFuZlBnUHBHRXZROFVIcCtKclBJMkNKcUp2aE1vOXVuVzE2bXFU?= =?utf-8?B?dUowdE9Da1p5YWZkZ1NRYlo2Ym9CSDdkeWtLT3JmYjIwMlZHK25PUlM0RnFi?= =?utf-8?B?Z0FvS0djV3lJeENLU2llcXVldGxuUHcyem9LVDcvZGFjRHpUQ1I3L2pSUnlx?= =?utf-8?B?KzdRZEd4NE13TStxWHZmU2gzNkZHYTJSNlZzS05NTTAyZUNSd1VkRVlPOVpJ?= =?utf-8?B?aU1xQWRSaXBGSTVWd1B1ZzA2NVFCbXdldHJNaFdxdndGY1Q2T043R3BGb2d5?= =?utf-8?B?VFpodERJbGV5eW1rRU1MTGJwbmR1SE00TWdTQ29NVngyTTB1TWt4VzhSM0R1?= =?utf-8?B?akxGUWFyam14M2JmWGhSRmViTHJoY2paNkZUczRuMGNQQXpWS1pYc08xc2hX?= =?utf-8?B?R056cFo1WVVNQVpZMVJFcFVhamZ5Uyt3Z2h1T1luNERCWlQ5SGY0TkhHaExC?= =?utf-8?B?YXVRSVhKaUxmYk9KandObXc3T2FaVWhKTmVTTGt5UTh1Z1JCMHhVYnJWSnlm?= =?utf-8?B?SlU2T0tYY3JlMUFOTDQrSExUWFFqeFV6dGtoVlcvQlNHNXhJbndxOFZCU0p2?= =?utf-8?B?bzRpZ2JZaWJlSTZuMlR0bUVRWURBMUtLWXZUVlFTYncxbEVVNGpiVVhHZnJE?= =?utf-8?B?WTVsOXpIN2plU2FYb2poU1hmbmJ2TmtHNHVSSDZ5a2sydjNRaXQ1S0lOSlpL?= =?utf-8?B?M29JVzhkMmtFUUZYblpSRXIrc2hxMW1UY2JPUmdmM004UUZsazF2TndOamcz?= =?utf-8?B?aFVLQzcrdmFvT3dGU0Y0SDBlajhkNDIwR1djc09JY1l5WWF0aWlGNVg2WWpJ?= =?utf-8?B?UXU0UVVPSmdLVTJIUzBkYVA0QWxrcnR4ZFNzazY4dkFKa2xIbzRHKzRPUFFV?= =?utf-8?B?eVlRR1hOZGhKbXRGY1FpelExcyt2L0NtaEhLazRhaC9EbjdBYWtUNjRhRXFO?= =?utf-8?B?dWxDKzgzWjJHeXpZdVZ2b1NodEZRbVRzUGxpKzQrR2ZNVlZmS2lKTjRvWlg4?= =?utf-8?B?THFLTjRNbjBQTGJtT09lR2tpRVB1bDg1clplQ3dnY1VxckZDSkpmeGo4aFFB?= =?utf-8?B?TVhBYW5UeGJvZUxCblpUckgrdzRGd2dGRVJpWEV2NnZic3N4RnFWUGd5b3Ey?= =?utf-8?B?R0k5bnhWb25pQmMzeVMyMlpkVm9kVlk4bSsxb1o4aU56OWRTcVlZTnF6blVB?= =?utf-8?Q?j3+6hFlaGCCOcz8xH50WZ9+WmeeiLX+GhVGVyDlQ/x1w=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 00c414a0-5cc6-46be-a477-08dda17f9c7b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2025 02:46:01.4706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF6396563DB Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Montag, 2. Juni 2025 04:41 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make > InputFilterPriv and OutputFilterPriv private again > > On 6/1/2025 11:07 PM, softworkz . wrote: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of softworkz > . > >> Sent: Samstag, 31. Mai 2025 03:44 > >> To: FFmpeg development discussions and patches > >> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make > >> InputFilterPriv and OutputFilterPriv private again > > > > [..] > > > >> 7 lines further down, there's another change needed: > >> > >> > >> if (ofilter->output_name && ofilter->filter) > >> av_dict_set(&output_map, ofilter->filter->name, ofilter- > >>> output_name, 0); > >> > >> > >> This is what broke the graph connections on the output side. > >> > >> Thanks > >> sw > >> > >> _______________________________________________ > > > > > > Hello James, > > > > I have seen you already pushed this. > > > > What I would like to note is that you could have just asked me > > and I would have done it myself. This goes without saying. > > I pushed the set because i authored it. No point asking someone else to > do it. I did however forget to send a reply acknowledging your review > and LGTM before pushing it. Oh, sorry for the misunderstanding. I wasn't talking about pushing. I was talking about doing the work you did in this patchset. When my changes did something that should have been done differently, then it's my responsibility to get it right. (unless somebody really wants to do it). In this regard I'm always open to talk about, because the least thing I want is to cause additional work for others. Best, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".