Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer
> Sent: Montag, 2. Juni 2025 04:41
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make
> InputFilterPriv and OutputFilterPriv private again
> 
> On 6/1/2025 11:07 PM, softworkz . wrote:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of softworkz
> .
> >> Sent: Samstag, 31. Mai 2025 03:44
> >> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> >> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make
> >> InputFilterPriv and OutputFilterPriv private again
> >
> > [..]
> >
> >> 7 lines further down, there's another change needed:
> >>
> >>
> >>          if (ofilter->output_name && ofilter->filter)
> >>              av_dict_set(&output_map, ofilter->filter->name, ofilter-
> >>> output_name, 0);
> >>
> >>
> >> This is what broke the graph connections on the output side.
> >>
> >> Thanks
> >> sw
> >>
> >> _______________________________________________
> >
> >
> > Hello James,
> >
> > I have seen you already pushed this.
> >
> > What I would like to note is that you could have just asked me
> > and I would have done it myself. This goes without saying.
> 
> I pushed the set because i authored it. No point asking someone else to
> do it. I did however forget to send a reply acknowledging your review
> and LGTM before pushing it.

Oh, sorry for the misunderstanding.

I wasn't talking about pushing. I was talking about doing the 
work you did in this patchset.

When my changes did something that should have been done 
differently, then it's my responsibility to get it right.
(unless somebody really wants to do it).

In this regard I'm always open to talk about, because the least
thing I want is to cause additional work for others.

Best,
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".