From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 064B249E38 for ; Fri, 28 Feb 2025 01:31:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C563968DCF7; Fri, 28 Feb 2025 03:31:01 +0200 (EET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2066.outbound.protection.outlook.com [40.92.23.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3029468D8E2 for ; Fri, 28 Feb 2025 03:30:55 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NtZR8HRq1hrH194Z50Z7q4C/CPCC4cfnlIou8UpSoizGNvvr/NlhIaeUkT+Hzt7zb1O8IlK1Bqt2LQklSYG3SRRkJcMx0k0+Dp09BmP59e7nQFySjB/l2EczEQkKncsCjkMvIEaANIbmyoRBekGZp+GWuoXw6vU5OnT4ra2AUj/vaRjMmiqtWqSvW9Oqh9QFjxv9F/zYJMKQUDorRD5yB+u6keJbd9bnn+ujn8U8a9+Kz+zccyOAz8d1rNJhkdD+F6ZFV+Cq3DtXDCoBoHEBMKpCWmTEC9z16ZIIM36auyBuWGIFTeom0lSju5a0FHroTO8lK7bothRxMnRG/td64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CRDBT5V14NTa3RpgTr7dXykFjfEmcezn648uFM0cAXs=; b=F0lRMh0I8ZbuB2gxKKoOTFdBWHNZUb9n3ZTpwckZAE1Nni4zi2E5v5t+OGRcFfGGwkjGKLnNyzUZfpyLxSmRTwf+BLSdJbgTiGZaWxyVEgI0JCIWf4z3wtXI+lNMQ2QjmVBT5V35UE9ljgc0qxOxRPrV+ysfGPeCYLoTvm/M8lk6ISpx3Elak1BJhjEfjvS7BWY4CEjoGmdyWEY6SoIglqOMyeQ1sTPJbumDL0a4wltf5K4SP4A3X8ZjUkGBBlFN36y81TeI9mKyByFyiSBVGxOypRZvFgvnLMNRnPDYUtW2omOfTi6eCzw9E+a88ZL37DZGt3M2ooS10A7+25grPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CRDBT5V14NTa3RpgTr7dXykFjfEmcezn648uFM0cAXs=; b=l0xrAxAptZObdNCgQHjN55VBHeRfUEGSrSirDa4e+Y+pdOQvZW1kEju8YL35r1TLTuOnrsIDAq8gSP831dbiO4HIgxuBxfseSIXEOh3Y4IJu8mO7JNkDcqS7jaHBZvwr+HXVKxe+T++xiN1zigDj3IixRtXxIwMbfIHjuIVN7Fs7224WmXv2b1DUUaq9vZ6zWoMFeHU8c8fpQjNswKMHFtUs67AXDkNqPtdx6JxdCEyUjqxx6Z6M/zgxVXbdpiR0tboPvwRfEpZ9c2K15W5QLrAJk4X63fTeDwdd0YK+sZa9OYgnI88eKIaRbb5FM4a8Tv0YRTuOnKfBPpTrR2CC0w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CY5P223MB0418.NAMP223.PROD.OUTLOOK.COM (2603:10b6:930:2e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.22; Fri, 28 Feb 2025 01:30:51 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8489.021; Fri, 28 Feb 2025 01:30:51 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and move writer functions and options Thread-Index: AQHbiSAsTL1DYjnhHEKR31MvWbpZXrNb7HSAgAABH5A= Date: Fri, 28 Feb 2025 01:30:49 +0000 Message-ID: References: <89d538cab47c517b35ecaccb563e14334c9f9927.1740664900.git.ffmpegagent@gmail.com> <20250228012321.GP4991@pb2> In-Reply-To: <20250228012321.GP4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CY5P223MB0418:EE_ x-ms-office365-filtering-correlation-id: 0ba3b61e-01a5-49ed-5329-08dd5797887d x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|19110799003|8060799006|7092599003|15080799006|461199028|3412199025|440099028|41001999003|12091999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?qHfTtURkAERmcTvj9dJQEQ91C30MXzuWAj+Ul95c1Vqygr/Sgydb84cAGBTh?= =?us-ascii?Q?TVRccI0oU8AtUtj+9uUmTYN3RZhuxTsw/Q05aP3lAv3x/qux9zFyXsC8d6Di?= =?us-ascii?Q?z8PndKP3hQM5RbH8pClNjgqdLudZbJ52zb7A9UXYLT3lOP5KfMHoGQL5HEuJ?= =?us-ascii?Q?OvjBCFfkW0CzvzC15oPgaEdh1xBFN9WPgm4owDBIGWDz14kLv7FovMJfi02+?= =?us-ascii?Q?c4KydT6KmAPTJ4JnmjoJb9SG8odYY+7n8iOG/PXBQqO6Xw+ULKFfBM1dUl8g?= =?us-ascii?Q?VienmpQdwC65MyETclHRphcn58are/4yoGxg5/twPaW3gu1h76lXNU0PDNZr?= =?us-ascii?Q?TaLJe84BLjf59sxCjALMd3pGjsJkRDBouLFxmzgwZuGAnh8r7hvXwgzmjsq+?= =?us-ascii?Q?mro8/7y8//0fh1W5VLHQAUcAXPBZO5Q5/H5LGYY/Ws0zfYa+o5PoogiE0bSV?= =?us-ascii?Q?DLTzxLMijFsyTIrrpizROY2dPNBwl8fWHFSvKjCRLEkGYFVpcjhinOGmQ5ze?= =?us-ascii?Q?9dlf0zv9nduRkA3NsVlJBd3nTDypjjXJtzr6hAa3UrVMVfsrNa53MoFaz2ui?= =?us-ascii?Q?ult7/0yKopZ2hplucTvHcXr93wQeEC/mIxVR9+yycWWl8W2VFWvFzqN9DwrJ?= =?us-ascii?Q?H034hXvuzfvvyKPoLcsA+LVgpaqk+0wWVtPb8JzJsKdi7R38he1BP2wRp0Lh?= =?us-ascii?Q?Y3Rh3qkYaB70A5dzdYMhTYmDSuPuNflC14zxICBFxSTA/y1PlZOx/V5VsPmF?= =?us-ascii?Q?mZak2WiEDbVWvZqdAqbsUcCfN0WEwfWFSRAJqR7K3sPeT8VlEUg0efyHuir/?= =?us-ascii?Q?8j696Pkd+iJ9H5Mi/pdVUtiu7uDWj+J+gADMBq6wh0mhzfi+xBUPCL0TvDJt?= =?us-ascii?Q?2a/JTNr3x7O4YVEqm0vfpyFhRbrR+ztBZbEkoYGY1wu6VuXTFvKJdmMSwS/W?= =?us-ascii?Q?1qkyJaZl9YP8ckq8cAe4tzsKH4fMy49KG/zdoWcRc49USFRXHY/uaX61UU2r?= =?us-ascii?Q?2i1GIdT/d3p0OoG83i0wDYnfN61gAS3TcmNVsdUyrpx9Fdj7Cbki07Zf26ns?= =?us-ascii?Q?HAN0ZaPbc3EnCP8sFywWNOZEhIuZiBndnN9pWllGNsy2QcOApi6C9eZiTEwX?= =?us-ascii?Q?E3EKNZWcKHBOJa55ql2oSzrqgLjapYqAdQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M24F78jdquYB32ohlllB/YMw2QnFw7EkHt4LQYADpuDUZ3gt5dds6v7wBWXA?= =?us-ascii?Q?XN2L02s/5bFvzpA+Xd8g+RxfoT4M6dJip+iZV/1smbgz1H3d2qfazO/b0Gqs?= =?us-ascii?Q?JEPcDfM6j7WPxUrD69gIgXU28yIGlCt6JuBb5xB/z2jIWFe5JqV4RJvgOak0?= =?us-ascii?Q?Bm50wtWjjPdq4KfrFL75YjdJ8hxlI4DXLDOxkgaf2QQW59c8RQ8nOwfYOrtN?= =?us-ascii?Q?GxzRfgIIuom9EJLZCRKX3sHW5SNj+z/XWqt+FMlBSuvtZyYBdjqWM5fuc/ro?= =?us-ascii?Q?HE7rd5d8pRvBF9W+XQwdiGehGMdqvb8hlFzgzc7EqA7gs6H7lPpWhHMo99Bk?= =?us-ascii?Q?hCPsnewqKvMIeQKR5vSYniIdJ4K/IVf4fwQ0gLVoJkw+x7l8D68MLLQFtoP7?= =?us-ascii?Q?sZxRrQpQZJU+Dm335WSZcnhyYpaC+3RyOlF9FBzEzTSZcSiEIqevAZPfMoR/?= =?us-ascii?Q?0SyShwo51XhfFLQ3aaAcYPWmk7xMoyw4jtEVMByEQHEQxZ1ARROb/uEyS8xN?= =?us-ascii?Q?A28IY7lmlJxLOOvwd8Hw7DV+9An1OKuH41y0KGMKZRXTnArPzOPYJiSXjJmQ?= =?us-ascii?Q?VXUlS7Bm1qUVGXN/AQN1/c5DkSHam314vbRE3y4OPeWC6vGt6Ztw38jg+jTh?= =?us-ascii?Q?IAzLdHAfBIhcOQmKeYZ9mQYkRWPfls5eQ9zIlkt7yMkQjwV7Jsq27PMBjZqW?= =?us-ascii?Q?v8K+hZRt854zQ1h2BAdduOfLoCeSwSZ8nkV+JSKqcUsUcrZSX6uk5uPZpZBx?= =?us-ascii?Q?sReqjYIsnAHK15b8TpIABl4RwiYCo6YWSO7LE1PrF9YVFug9mOzcW2JgzeOZ?= =?us-ascii?Q?jS4bwjryncNmyyJNIrwVmrwtuCg2cm+ot018V3WWn+R79U2McL+eDookq5xv?= =?us-ascii?Q?F1eoBVG9bV8T0nyhRzcv3QDxa/L+y6HagKcHS2rHWn3qMlHg37z4/PwYRU6K?= =?us-ascii?Q?9Tagygd2Yteb/iVRx/CNnuBfLKe6AYMqiJgcqmF+S/JPC3RakCOrHse/WBzJ?= =?us-ascii?Q?Mls3KCU3MgatVUKYo0owMqVaKA8x/EcrXk+0DicEb3hJrtzVB8HBvAiy4351?= =?us-ascii?Q?EL+yQYYbeMrWOWVLZMhpKxm7xa53rbQdXPPkjn64Sy67ncDxDHHkM/vfyA9+?= =?us-ascii?Q?/IwgeeECXQd6LhuOBal1RC3Fl+mIAMd27QNIzUsWf80YLG1eiz8Jqve+SJbr?= =?us-ascii?Q?V8qhFqk/PvbWOOqCt1kvdmL2lL+OgTMbjnmf67mSE45feDV5BxCHeyUsDEg?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0ba3b61e-01a5-49ed-5329-08dd5797887d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2025 01:30:49.7669 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5P223MB0418 Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and move writer functions and options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Freitag, 28. Februar 2025 02:23 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and > move writer functions and options > > On Thu, Feb 27, 2025 at 02:01:34PM +0000, softworkz wrote: > > From: softworkz > > > > Signed-off-by: softworkz > > --- > > fftools/ffprobe.c | 910 ++++++--------------------- > - > > libavutil/Makefile | 1 + > > libavutil/avtextformat.h | 50 ++ > > libavutil/textformat/avtextformat.c | 620 +++++++++++++++++++ > > 4 files changed, 848 insertions(+), 733 deletions(-) > > create mode 100644 libavutil/textformat/avtextformat.c > > this and patch 1 crash > > ==1574970== Invalid read of size 1 > ==1574970== at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==1574970== by 0x7683D14: __vfprintf_internal (vfprintf- > internal.c:1688) > ==1574970== by 0x7696F99: __vsnprintf_internal (vsnprintf.c:114) > ==1574970== by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > ==1574970== by 0x1256473: av_log_default_callback (in > ffmpeg/ffprobe_g) > ==1574970== by 0x1256162: av_log (in ffmpeg/ffprobe_g) > ==1574970== by 0x125CB4B: av_opt_set_defaults2 (in ffmpeg/ffprobe_g) > ==1574970== by 0x127611C: avtext_context_open (in ffmpeg/ffprobe_g) > ==1574970== by 0x2F9672: main (in ffmpeg/ffprobe_g) > ==1574970== Address 0xffffffff is not stack'd, malloc'd or (recently) > free'd > ==1574970== > ==1574970== > ==1574970== Process terminating with default action of signal 11 > (SIGSEGV) > ==1574970== Access not within mapped region at address 0xFFFFFFFF > ==1574970== at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==1574970== by 0x7683D14: __vfprintf_internal (vfprintf- > internal.c:1688) > ==1574970== by 0x7696F99: __vsnprintf_internal (vsnprintf.c:114) > ==1574970== by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > ==1574970== by 0x1256473: av_log_default_callback (in > ffmpeg/ffprobe_g) > ==1574970== by 0x1256162: av_log (in ffmpeg/ffprobe_g) > ==1574970== by 0x125CB4B: av_opt_set_defaults2 (in ffmpeg/ffprobe_g) > ==1574970== by 0x127611C: avtext_context_open (in ffmpeg/ffprobe_g) > ==1574970== by 0x2F9672: main (in ffmpeg/ffprobe_g) > ==1574970== If you believe this happened as a result of a stack > ==1574970== overflow in your program's main thread (unlikely but > ==1574970== possible), you can try to increase the size of the > ==1574970== main thread stack using the --main-stacksize= flag. > ==1574970== The main thread stack size used in this run was 8388608. > > testcase: ./ffprobe_g -v 99 ~/tickets/3679/wgetmjpegdump > > tell me if this file is not in the ticket and ill send it to you Hi Michael, only patch 8/8 is expected to work. Since this is a RFC for the moment, I spared the time for making sure that every single commit builds. (please see cover letter notes in 0/8) Once the direction is clear, I'll prepare a patchset with all commits working of course. Thanks _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".