From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id A4FE74E83F
for <ffmpegdev@gitmailbox.com>; Thu, 8 May 2025 00:25:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48E9868C07A;
Thu, 8 May 2025 03:25:38 +0300 (EEST)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12olkn2066.outbound.protection.outlook.com [40.92.22.66])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A919268BCB0
for <ffmpeg-devel@ffmpeg.org>; Thu, 8 May 2025 03:25:31 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=EJ0WVnkub7y6rKwdRhDEiTBgO2j6+JrE3aCpb614oP5xG7r/bl81yCwOgUvo5gBrBLA1zYAs9A8A5uox5D8OTvPK+ZUgeOfdzds1mYd3c2YYscjDINHCIOQr9oTIPdZxRkrv/A4t28WCLtxRoVPxeOVsmnZwjjTaRc4KmlJy872V0oGnBJaJeX7xviYwqp6CszgELHyl9Ror3/w/RczEXrndrL9hSDkcxCn0vgr5GOBOVeS9HOC5PtonifA6MuzzlDD0aJi44/QAB23HlJHeGBsigUbTAjdq4Mifyt+3H8/QJLTwi3JMND+gmxt981fpxwYD3j2cydek1/StGUmFLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=xlM1yBTBvd1TZZt0hevEeu/020uuHQSYGLSMJOKhp5c=;
b=CZloLefXm/4o1mcZQDzciEW0G68nlZp/20gD7VnEbCkhuB6lzGXXl12BBmtVqWbcI6hoFhPjxwkroLVYhENfMxFK/tB1oPC/6IGBVtTVJ9DoKRSmwqLumMaWifCB7g+YI6KBNx4QrOe0qO9kGZ/mh2HhePV9pse0sS6MUnLLyYajivetPiyzjrCi9SinbEcXlrZ5JzDuOMWQiN62hKopULu2N0L+dcD3nh4ZU++mNCXeMUHkbkfOlpxg7D0RDVM7aHLe0y+uK7gm5ZdsCtK4Q1Dx2ifPXvICLFGhYpfMWGaf6Tlud8OqprAX/cut8VrDhcYyt1YRN+J8gCKpe3EDXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=xlM1yBTBvd1TZZt0hevEeu/020uuHQSYGLSMJOKhp5c=;
b=Q1t21nHCABAor5sOwxw+fTalsCFHEi2Z4y30Zfk+3yMeQV+cF/rZbYoJHBD3+t2/DinvT/CO6vaKrVtwbsiQ+DgsJzZbDDzWz87tlPk/HFLW6tbAWkcYs1pKan6YD0IyDWIVFHuwlH86wk3JMUl/eeZtai3nfxBxGd5Fy9px/1KUnDzecXEeZfcBvKy14byfZNyQx/3rcuBGYjJ9L6BdIKAlEmY4scOJ9dYPAyc1Hdb+BVba+rE0kToYWHuiDnP8anu3Qlan8F0TQ7wka3j1NhwAPscO5stOPJCWfRQTsZMpRUXJgAzbWhV0hLYX7aC89DdzB8Dco6MZ419OXcXLSw==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
DM4P223MB0493.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:ae::16) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8699.24; Thu, 8 May 2025 00:25:29 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8699.019; Thu, 8 May 2025
00:25:29 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: Stefano Sabatini <stefasab@gmail.com>, FFmpeg development discussions and
patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce
AVTextFormatOptions for avtext_context_open()
Thread-Index: AQHbvKBcnhhzxZap10eWd4vtA4PxOrPH4KCAgAAD0fA=
Date: Thu, 8 May 2025 00:25:28 +0000
Message-ID: <DM8P223MB0365C851CD4090830CB64D7FBA8BA@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.v9.ffstaging.FFmpeg.1746260565.ffmpegagent@gmail.com>
<pull.66.v10.ffstaging.FFmpeg.1746327446.ffmpegagent@gmail.com>
<3aa16bc39f30554808c946673dd3862380314788.1746327446.git.ffmpegagent@gmail.com>
<aBv1V3pmE0iRt7Lq@mariano>
In-Reply-To: <aBv1V3pmE0iRt7Lq@mariano>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DM4P223MB0493:EE_
x-ms-office365-filtering-correlation-id: bb9e57be-49db-4480-a865-08dd8dc6d5f2
x-ms-exchange-slblob-mailprops: 9IecXKUgicB0Vgu95vFSoXNdCFmhIzagUrh7PCgm/Tb9XwGcnKLAn9bloCf72+cQxV/3Qrtp3VeCQJ1lAXHVZQuhuzcJA6OA1Bxtp7uG1pQd2Clxqkum71nj6Wr67hLllLv5TdxdPM7mlAhznLFQTTYdQA1ywr+FuwK5VHpNhP8xPAa7ef3ayC4Ejhi1vQgTW35zaWAKxysEDy3GX7U+c5w/QLU/urrQyRo6yarVTMb3bWpAd59T/ulIma9FiS+WCyB8bD5TuPMm8ViR2nw6ghiD/BY+1g6CGBvWZpH35dSU05mka8ybVquPXD7F7ElkKTSkUKicT3dX6oJGs5OHtBHYINXAMyWRgYHTbXBdrbOut5zg/AekyTuwhLNt8sPWoCCNncH8IA7+F7/m0hwwTvXf71eUpto737mnnZ9upDhG/fG+syNyGGRC8fHD68hTeIrMLiAFpEg7CrzckcA94IFcgWFyn85CQaF8O9p/HZJjAGTTBShNBJQF6xR+xySpFpI1oxspNeOaIRyrDpY/SZAUwoIE0C8fmsIHRKimlJxwMC+BYwuIwgUZwTLVIgQX6RLlU6qtpK9z/9YLFlJ9SbKODyTPtsimboZW/CCUlA90Zqz3UOb0vQ4QhwAdeb6WOLgA6pcc6PelKbtn2ITlMMH67M0llsLFp6NPCNzW5rRvj0mjPzoPTAC3+3FPzaUKgVZhiHfWWgSIX+SE6RYyDdJOePlr/BR7VhYUiqJ5k3ephG7ObkG56w==
x-microsoft-antispam: BCL:0;
ARA:14566002|461199028|19110799006|7092599006|8060799009|8062599006|15080799009|440099028|3412199025|12091999003|102099032;
x-microsoft-antispam-message-info: =?us-ascii?Q?1klwOS8A9dVVH1EC2uy0je39KgXplfhWNL6H37SUx6lcXROjAsnahwHhOss9?=
=?us-ascii?Q?8rklsijERxXOHkJNFIlSnUY8Y042hge3hf1ZTRt2jDDlPptyGBkyV4Rs52Rm?=
=?us-ascii?Q?EEChy2NHI7dNJcp3gfNbRtQ246qPnAUKRh1Xp9H10c1w/23HQTEHEXIkSI7+?=
=?us-ascii?Q?j8XuVe9sqtutPSqGIflNPc5P+hipMpcmdkd+EGn1H6eK9NR4not3tm5jueU0?=
=?us-ascii?Q?8KP29xExmiGamPzEh+KrvWMXjAnpCuGAPlOPH/TiMizr6V0WS4/gqxXJKMwT?=
=?us-ascii?Q?OGJe5ltJV/3XvqZteGgtw3apFhj63Nfjnes3/kzu9bg4nBIXqV7oXwpBUs0G?=
=?us-ascii?Q?UC2J7K3hUeuP1IDOWmFiC2ZBrcaZu1WO4aI/usiVq33WOn4gTmZcfJnVXQgn?=
=?us-ascii?Q?iTEvxTdIA8N8zCE6k53EVgRRpXuDKqJl8dIs1g32UOG1DBML0PCBbK3OrO0m?=
=?us-ascii?Q?hxb2NKxzNjmmJRlFqX5N9uuYdIHBEsU4n1l/S5HvOsMEjuafp60BkIkSa/vl?=
=?us-ascii?Q?CVNYkU6PLyP1GdTSnROKvvcwSZwFIgHcYuWLhgEB3e/L/hq9bgd1LeH+/ooD?=
=?us-ascii?Q?tj4mb4F2A0gEAU9qcsm2P88tBcc7fNCUHuAO5KtZrM37A6DvEKjJ+u5P03Y3?=
=?us-ascii?Q?TYb81T3cm8JklhVZ7uKwrII913bRyAX98FxPrq1OFJHI00vqHlRAf+/tb504?=
=?us-ascii?Q?OztIpnkRUrEOk1DDtJ54GVj95aK3YdSJ4aPzFzOj/N6sT6E9pV4C1p030/Wy?=
=?us-ascii?Q?PqI2Uq1fGVbQuk5Hygr1nFBepsGwu17vZHe+JeDsxST3dLM2TcrNgZCNUABx?=
=?us-ascii?Q?x7mkt3MUOU8SAW/3youAJvwgbwER9Yj8GBhrWPgzC2C88OdvlhalVwSLbFBm?=
=?us-ascii?Q?d+p3yYm6gUcPpyQtx7dkr139PJ5CeQEfGNm6ZOQNFOtNSH9vMm88HkA9MNeU?=
=?us-ascii?Q?lV3c4u94tWFUYRd71xexP6ayCCef/cg2TQXCFhVbzsNUa6adn8P4e9n2JquE?=
=?us-ascii?Q?6q14F8L/5dGI16AmUkYDXlBsGlBOQMDA777nnOArnRLfyEcDBY3F+PnGYPsK?=
=?us-ascii?Q?sx14zpTaMJ2ydS8Sg5ENCl+I55lkqpWmpLTMstXpElCOeFjMd9zuKdjgRcwF?=
=?us-ascii?Q?bAblyR84PL2Vl3YOrjWqtWXUWhhoOdb9RA=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Llutw5eATxsmMx4/ZNcGunCqVO916Y5+bCBmFqG4RwCHFTaz1JBPqsz/Yu3J?=
=?us-ascii?Q?eH2FUb97hIFsc4Xtm61DS8rs3P5t/WGMbxcV1sT8H44P8W3XHRwhfvHuPFME?=
=?us-ascii?Q?Sydxs4rL83ig4AqirTahKSLVInTxSdrh29CUOuVbmFd8daNCAC/RspLFK/rE?=
=?us-ascii?Q?tiOV64uZxu96htn59wbfVZ0CElbvOzCnb1obSmAVy6YlD0uIcIehiI/A45kx?=
=?us-ascii?Q?Uz9z6+7vgP+jCuDKgk6aP1T7lku4AosmvPjpmB7siKVMEmtp+K2zXLxLhHt2?=
=?us-ascii?Q?viejTP4Cfuagk7Es2oRv1jpX4QnIdMrrj24gwP4rdF9GqhwMkrCQbCr6iIng?=
=?us-ascii?Q?uhYH/JTNoEUjHgBZTVdYwgk47tenlO28X+OLlV13nx/ri20CaiUsJ3f5t6yB?=
=?us-ascii?Q?0h01EgQglDti2whCyTWIh3nPWgDu82+tEXcwSO+TRdPO1U5svA7KGXOUHS6L?=
=?us-ascii?Q?o/intigngJHh/0k+0gsqRYPZqmPiw912ZbBG8DJeRP08uQSSLE7vSkzBJ+sO?=
=?us-ascii?Q?yCYn/Zrr3P6xMqW6VqrXlKbfyst9Wl8AA4w62IlGnY+zTELwrbvcrTHal4/b?=
=?us-ascii?Q?6MUxohhGWnGnkwQ8Un94NmeyX/gKgzPvQJw0/xBqLdpLceILzo9UUg2S0R5t?=
=?us-ascii?Q?V68m7qi5z8bqKZK98tRdrC4Zmhql2wlafOWQvaEYC/nilAXJZ3oGVgFF+yet?=
=?us-ascii?Q?0iNlOjgXmD1+K7f6rW90VWTB7UAnnUgezAlD7c0SugmUAwjUK2MZYRzbPXDf?=
=?us-ascii?Q?piF9aYPloyZIYiqVp/YrGsOFudoSAp2kVHZUpPIu/KjffZ3xGacBKEH5huIc?=
=?us-ascii?Q?Y3R3UF4IoVwdTkGNkrxq8Wo2gaiJBC2qavgZNd52T1Zltic2XV0PmTwmyNLe?=
=?us-ascii?Q?MnedHH8wZ3rhOLVM2BgfS+9fxmsY8lOYyg2VCqP0aKxEO+CAGXHzwKeW/nx4?=
=?us-ascii?Q?0mYKMM6i5r2rB45w61c9PVLpwlUZQmOV1I+OXFt9CsjxcVRxONat5OXix3Zj?=
=?us-ascii?Q?jNwKbfxMMYRORMzHCI3VXar5xAmvWAmqudQLIGT7nLPJso3TxwQxXMEbtkIg?=
=?us-ascii?Q?Dm+V1G1GGXAcZZ3N6NIsd1x6rhO6881iiiZeISA6tVPd+dGOrmD0xwWDj2ip?=
=?us-ascii?Q?cVClMv9iaqsk3prGmFai5xuF12ATUxcX3hYXmo2l9EnbiZASOu/SWRyAOvMF?=
=?us-ascii?Q?KGfmH+z7EX2I16Ck31RVRDwfAZTUcu5hvACBomki2nsOLFqK/acDDOYOZTU?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: bb9e57be-49db-4480-a865-08dd8dc6d5f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2025 00:25:28.8661 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0493
Subject: Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce
AVTextFormatOptions for avtext_context_open()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365C851CD4090830CB64D7FBA8BA@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: Stefano Sabatini <stefasab@gmail.com>
> Sent: Donnerstag, 8. Mai 2025 02:06
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: softworkz <softworkz@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce
> AVTextFormatOptions for avtext_context_open()
>
> On date Sunday 2025-05-04 02:57:17 +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > This allows future addition of options without
> > changes to the signature of avtext_context_open().
> >
> > Reviewed-by: Stefano Sabatini <stefasab@gmail.com>
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > fftools/ffprobe.c | 13 +++++++++----
> > fftools/textformat/avtextformat.c | 21 ++++++++-------------
> > fftools/textformat/avtextformat.h | 16 +++++++++-------
> > 3 files changed, 26 insertions(+), 24 deletions(-)
> >
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index f5c83925b9..1277b1e4f9 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -3168,10 +3168,15 @@ int main(int argc, char **argv)
> > if (ret < 0)
> > goto end;
> >
> > - if ((ret = avtext_context_open(&tctx, f, wctx, f_args,
> > - sections, FF_ARRAY_ELEMS(sections),
> show_value_unit,
> > - use_value_prefix, use_byte_value_binary_prefix,
> use_value_sexagesimal_format,
> > - show_optional_fields, show_data_hash)) >= 0) {
>
> > + AVTextFormatOptions tf_options = {
> > + .show_optional_fields = show_optional_fields,
> > + .show_value_unit = show_value_unit,
> > + .use_value_prefix = use_value_prefix,
> > + .use_byte_value_binary_prefix = use_byte_value_binary_prefix,
> > + .use_value_sexagesimal_format = use_value_sexagesimal_format,
> > + };
> > +
> > + if ((ret = avtext_context_open(&tctx, f, wctx, f_args, sections,
> FF_ARRAY_ELEMS(sections), tf_options, show_data_hash)) >= 0) {
> > if (f == &avtextformatter_xml)
> > tctx->string_validation_utf8_flags |=
> AV_UTF8_FLAG_EXCLUDE_XML_INVALID_CONTROL_CODES;
> >
> > diff --git a/fftools/textformat/avtextformat.c
> b/fftools/textformat/avtextformat.c
> > index b2c3aa3fc7..91469ef576 100644
> > --- a/fftools/textformat/avtextformat.c
> > +++ b/fftools/textformat/avtextformat.c
> > @@ -125,13 +125,7 @@ void avtext_context_close(AVTextFormatContext **ptctx)
> >
> >
> > int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter
> *formatter, AVTextWriterContext *writer_context, const char *args,
> > - const AVTextFormatSection *sections, int
> nb_sections,
> > - int show_value_unit,
> > - int use_value_prefix,
> > - int use_byte_value_binary_prefix,
> > - int use_value_sexagesimal_format,
> > - int show_optional_fields,
> > - char *show_data_hash)
> > + const AVTextFormatSection *sections, int
> nb_sections, AVTextFormatOptions options, char *show_data_hash)
> > {
> > AVTextFormatContext *tctx;
> > int i, ret = 0;
> > @@ -154,11 +148,11 @@ int avtext_context_open(AVTextFormatContext **ptctx,
> const AVTextFormatter *form
> > goto fail;
> > }
> >
> > - tctx->show_value_unit = show_value_unit;
> > - tctx->use_value_prefix = use_value_prefix;
> > - tctx->use_byte_value_binary_prefix = use_byte_value_binary_prefix;
> > - tctx->use_value_sexagesimal_format = use_value_sexagesimal_format;
> > - tctx->show_optional_fields = show_optional_fields;
> > + tctx->show_value_unit = options.show_value_unit;
> > + tctx->use_value_prefix = options.use_value_prefix;
> > + tctx->use_byte_value_binary_prefix =
> options.use_byte_value_binary_prefix;
> > + tctx->use_value_sexagesimal_format =
> options.use_value_sexagesimal_format;
> > + tctx->show_optional_fields = options.show_optional_fields;
> >
> > if (nb_sections > SECTION_MAX_NB_SECTIONS) {
> > av_log(tctx, AV_LOG_ERROR, "The number of section definitions (%d)
> is larger than the maximum allowed (%d)\n", nb_sections,
> SECTION_MAX_NB_SECTIONS);
> > @@ -201,7 +195,7 @@ int avtext_context_open(AVTextFormatContext **ptctx,
> const AVTextFormatter *form
> > av_dict_free(&opts);
> > }
> >
> > - if (show_data_hash)
> > + if (show_data_hash) {
> > if ((ret = av_hash_alloc(&tctx->hash, show_data_hash)) < 0) {
> > if (ret == AVERROR(EINVAL)) {
> > const char *n;
> > @@ -212,6 +206,7 @@ int avtext_context_open(AVTextFormatContext **ptctx,
> const AVTextFormatter *form
> > }
> > goto fail;
> > }
> > + }
> >
> > /* validate replace string */
> > {
> > diff --git a/fftools/textformat/avtextformat.h
> b/fftools/textformat/avtextformat.h
> > index 8ff503401a..87f57d8c24 100644
> > --- a/fftools/textformat/avtextformat.h
> > +++ b/fftools/textformat/avtextformat.h
> > @@ -117,17 +117,19 @@ struct AVTextFormatContext {
> > unsigned int string_validation_utf8_flags;
> > };
> >
> > +typedef struct AVTextFormatOptions {
> > + int show_optional_fields;
> > + int show_value_unit;
> > + int use_value_prefix;
> > + int use_byte_value_binary_prefix;
> > + int use_value_sexagesimal_format;
> > +} AVTextFormatOptions;
>
> I'm not yet convinced this is needed - why not to use a flags field as
> in most other places?
Believe it or not, I actually had flags initially, but then I figured
how ugly this code:
> > + AVTextFormatOptions tf_options = {
> > + .show_optional_fields = show_optional_fields,
> > + .show_value_unit = show_value_unit,
> > + .use_value_prefix = use_value_prefix,
> > + .use_byte_value_binary_prefix = use_byte_value_binary_prefix,
> > + .use_value_sexagesimal_format = use_value_sexagesimal_format,
> > + };
> > +
..would look like when assembling flags from the settings values and then
I changed to this way, which looks much cleaner and nicer.
This also allows adding non-bool options in the future without changing the
signature of avtextformat_open().
> Also if we go with this we should use bool since it's used already in
> other places.
Is this allowed in FFmpeg? I thought I had it some years ago in a patch
and it was rejected (just vague memory, though).
Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".