From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 904104F1ED for ; Sat, 17 May 2025 20:04:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2BD9E68D8B4; Sat, 17 May 2025 23:04:33 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2107.outbound.protection.outlook.com [40.92.21.107]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id F2A7D68D730 for ; Sat, 17 May 2025 23:04:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JjbsKI88favwcBdYwevrtocv4lPGUckXFjFlgvGel8jJ85f1jDwhMEVOb5ldUOBT48vbd6eHXlYXPHRQaCkbTjDZBO3377lxfHCxEXjBZV86EvvMyhXnYHTcoZXTC7iBCYpMnIlLvKZ4e1p+PuOOUO8mv1BBPkevmgP0j7d4V4HdFzVn7rKx7RPU9TKUg+1L71WJTnBkrt8sLw5Unw8Ytx8on93/A3exYolFhHeKLtt/j2xGucFurPDG5OLQlaHaI3TWKMQljlykxLlqiYuxkeWHsbMU+MecEh97QFZW6F5ULyl0ec4FBapMGNkkTmXSBEXYTt7RgWIV3KnIZOFG6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyFNI4zYL5Q0L8tkga3M5iPYX4TGRpKcTt7XSFVcfUs=; b=p5f7yQR0XoN13UwnvFRyTkqR2IH+8ZR6Y7PD+t096dj01jZ0jeD41jDTv0SVnu8tBvKHzc34t0yj4vjE8Mqge7Up5NDBAojWGEZUBbbtOa5LemH7KbwxXfkSq0BHl1LV2zTha9HAA76Zh6XvfN+Y3MLIEUwrIulQhSNTad4yAUWDd0MqE/0obHPigM/Vl7pkN3w+Oasvtsw9mjYyzEv5bgAkTqJzIirlPca1ZSWDaCh3WIneos1scboIJNnOdbL5AhHwAsPe+1//z/o+dQRV5zdkLzZxjvHyTkUk3Rq8Ix06qO9MSzQljK5xWRlu16pncJt0pzyzhsHexGvXXjOGjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gyFNI4zYL5Q0L8tkga3M5iPYX4TGRpKcTt7XSFVcfUs=; b=UtiXXe/Qoj/EHXom2EfBN0/D9Xxnq/KdFUZ9TyMA8lrsaGklOnkvZUnn5i2JsBsdvEsGPnBUpn5AgOSWO4aLPa6Da6cQl9IIsZ85drUlCC84uipCaO+duPMZXrYIUs49kUB304LftsRG4KOi4PSpHG2ZvP68Mz1gV4yLuPkC533Ilh6ARMygoI17ORCDD0sJtWMi88IfvoXdGyuzPn5IUCUi4jDob1PtKxUjBuGtdgQ1+Eio6lMaRCJ6MWfUx4bHur6GYLiA1C32wd6G81lw7h3uq1smNL0ag71J46V93NfTjproReJq1AnPwDNMgKmc2z1R9lO6GyyAOh1U9A10yg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0549.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Sat, 17 May 2025 20:04:23 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8722.031; Sat, 17 May 2025 20:04:23 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet Thread-Index: AQHbx2awZ/QCy+fUiEGTYz1VDOaYE7PXPsFg Date: Sat, 17 May 2025 20:04:22 +0000 Message-ID: References: <20250517200227.3454348-1-sw@jkqxz.net> In-Reply-To: <20250517200227.3454348-1-sw@jkqxz.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0549:EE_ x-ms-office365-filtering-correlation-id: 7bd995b3-5dde-4b30-00b9-08dd957e046f x-microsoft-antispam: BCL:0; ARA:14566002|15080799009|8062599006|7092599006|8060799009|461199028|19110799006|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?UAFIkDd/36ZnJpJtPQTOPT1pbl34pAtrFc4rA5AODjux4ssFa1wnnGyo7IcW?= =?us-ascii?Q?Wh5dJR5xOa0WDVJL7sR6gt3kwc716d2MAqdiWlSjGS5soSfNL7HOouHn/ZMH?= =?us-ascii?Q?/UcScuiDRiZxmbHlQKFPE3J0pP7C90C2q6U56IQE+Tao5KrPS7QgyiAtvFSM?= =?us-ascii?Q?Vl64u3Q1aE6OLUkUtOkW0M7gjWTWME322iBVuUKKstg2vAjmIApwWy/BI9T1?= =?us-ascii?Q?maLyrQ2mYo40XBVC8Y97CZnvE4a2t4XCbP96eCif9jLBV+RHIetLqcatY3TV?= =?us-ascii?Q?vG38eW0h3IFoq55UkV1UMWdvwITnUEvPkD1HL51rjYkOuNdGnSCt1udDX6/9?= =?us-ascii?Q?QIYWIdwmW2AYCYnOTiYOwjIZepNfNWkJRywHG+4AYRBtmTzoIx0Oai8z8qoA?= =?us-ascii?Q?9If7ZBcrULlppNyKuojbTxXKdtgyWBtX+4WPyWr0xQH4+ycu8dgBeM8+GFvL?= =?us-ascii?Q?awkWNAbtd5thn1Y19DwgFFVPJ4tRmXbEOXQyETrJmg34/7ff16cDF6DGx/IL?= =?us-ascii?Q?AEXROC5B72CtX6lvkpi7IZEBpl20ZHyCWAS8IYZQyfsbuyA51/I0Hxqw9Jnt?= =?us-ascii?Q?W5OpaIpJBDh+D4iHyXwvm9fFeSJMbwE0lomF1nVERwa9qxlFNsaOk4jZ7vZB?= =?us-ascii?Q?bBUNJkQ0upyJMmIuGbVVfIO160cHT2P+ioq6ngn3wa1yONxuWVU7/9S9nhpn?= =?us-ascii?Q?Y6P69+GL7KQhtM77u6dVMeApbCkuv4RZfay6TCN9eMEk4GHwhSK1Hg51aShn?= =?us-ascii?Q?uXkhcMS4bWXtE9Pl8L/xh+a6/NVXhBGyDp83B3hhE0EA3ycYpWS5yqwW7MkX?= =?us-ascii?Q?c6IZgXZmmtj4cNx2b5kb/z/KOJAP/5b0PagjrmyYJCtrsOs0g9yZbnV6mb/M?= =?us-ascii?Q?k1O6HC6fbly+HuQmncUEvXwD7suytEjJR3pft7/YQD1zJfxz+7K49Dp+Akoe?= =?us-ascii?Q?u/pESCdMq2SN074zGtJzVjOE89PO89/osqVOO8UoudxAq3AURO2Gu4KXiCja?= =?us-ascii?Q?nF10SaxnekH0w6S2P7qpX0O9kuuu3H8n8l7Xyv3r940nla8rN+wv920q9Drc?= =?us-ascii?Q?l1hrcvBDRABRlsy6Eejvaz25tw34rRLctDe89KKEF/sWwRwD7t4=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ppwyOYeb/6OKOgwvYpiAHGjzKIsWWIXf45yIkLFYGCQ0F/JM4tj+Faq4wzm7?= =?us-ascii?Q?IrNGh2CexGCJ3UmoDWx+yARKn+tBqzleY/9oMbPPefLW82AyRlXJ8Q+ro87Q?= =?us-ascii?Q?fqxRliO/toStIU0iShq60jJXkp0erWRpi5gSXOZHmlfB19q4Dax9jgUMZuak?= =?us-ascii?Q?BfSubefO6sqfXDeQsKwh1c8+o/6tB934bZllmZx4+8AxQ7K6Feg0ombKY9Ul?= =?us-ascii?Q?wi6qDdneSPrKm15W2vQ42NfXWZrLPNdwk7CLmw8SLE960q+5yNbWtVcWgJFb?= =?us-ascii?Q?gieOqgqCwNUZXHKmX457hFxa1MWzTn04OjKErl+gDLoNKT0fQHHC/pZXwctZ?= =?us-ascii?Q?fNgsP837+x0W6fYnVapTCSPw7lSVDXTc+9YGDBaqzDS3FduknD7ws9bDyrPH?= =?us-ascii?Q?x6dZ2R5/2fWUUHpc7CncZGvrRISzfH79KXJA84Tm3PW42dzqDpS6bZFvjMfr?= =?us-ascii?Q?tSOPbwejbs6NwtVSXvwyVjayF9Yg4iTevnB2MWGJeUETdCEqwrfDUpkKztvM?= =?us-ascii?Q?YVFn+EZyYuZDdrjmnhRbmqrelHr+guqEMIJj/pAKhGvWM1ihRbpjIG/iXMs3?= =?us-ascii?Q?KXb8YMgatkq4K0/xM1tW+N9GzYPxUtTTmgWI1NHzIu2b5ll4oAMfzDcUZrl6?= =?us-ascii?Q?nEXuyKwrxu4T6QHhx1E6soNUz1YDoyYZMbur3ZxvWfFl2Z90Vxdyi/aWKXA+?= =?us-ascii?Q?fsc8yJX9lpOF1IzB39jAUJkdiLftx4J9tmPjBts0Ol951UBCtjBw0ZpKQaBX?= =?us-ascii?Q?7VtKeIU4UhZrRYPC0xV7pjT/hAQ+HyJaXxFTiEgRzeGrxpJ3Tw3SBh7kD6ty?= =?us-ascii?Q?aFIczAzsmZO6KQ461uTZc/kqZ1CT2nnWAUHLaVIg2FrdiInCzsPPGcruNzz1?= =?us-ascii?Q?29qBULbFcN5y0THzhBU3WCAYrOmWPJdx8+XuhdzH4/YcWRGLoOEaWIIUwbBY?= =?us-ascii?Q?NE8VUmLLPbCN9rkuq58vCuM6mdonYGTGXg9wb0jX/YwZ7wcrvcv1chHyMXiR?= =?us-ascii?Q?HE9FXVwEOy1YGav35l0s2yQdXl3OaJFNSLeYpVO8nWXMAuUqsXNtEIOzUd0d?= =?us-ascii?Q?WP/YPiqMR0wciG/NPjUNS5Bizex7wv4Q3lYdpLl9pij7PPRZguW3lWqY9KDx?= =?us-ascii?Q?NyVCrht+llWxv0otBlG1HCRCoi0TUMJK1vv0D9r/Taxc6FqUNjdIrqHclXGn?= =?us-ascii?Q?lqjVOPupqJ27YcF/zzBqdaqrGEsQD+hdNIOF//H8XVsWJ1ph4bsKiisz6gs?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7bd995b3-5dde-4b30-00b9-08dd957e046f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2025 20:04:22.9262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0549 Subject: Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 22:02 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no > outputs yet > > Avoids writing an empty json blob in setup error cases. > --- > On 17/05/2025 20:08, softworkz . wrote: > > If you could resubmit without the nb_filtergraphs check that would be fine! > > Sure, here. > > Thanks, > > - Mark > > fftools/ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 964770df23..bd6f22e421 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -309,7 +309,7 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL > }; > > static void ffmpeg_cleanup(int ret) > { > - if (print_graphs || print_graphs_file) > + if ((print_graphs || print_graphs_file) && nb_output_files > 0) > print_filtergraphs(filtergraphs, nb_filtergraphs, input_files, > nb_input_files, output_files, nb_output_files); > > if (do_benchmark) { > -- Excellent, thanks a lot for reviewing the feature! LGTM sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".