Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Stefano Sabatini <stefasab@gmail.com>
Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
Date: Sat, 3 May 2025 08:55:42 +0000
Message-ID: <DM8P223MB0365C64B0C3BEB1C659F4DFABA8C2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DM8P223MB036544510099A04264475BE1BA812@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of softworkz .
> Sent: Dienstag, 29. April 2025 01:24
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Stefano
> > Sabatini
> > Sent: Dienstag, 29. April 2025 00:27
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
> >
> > On date Sunday 2025-04-27 17:54:21 +0000, softworkz . wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > > > Stefano Sabatini
> > > > Sent: Sonntag, 27. April 2025 12:42
> > > > To: FFmpeg development discussions and patches <ffmpeg-
> > > > devel@ffmpeg.org>
> > > > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
> > > >
> 
> [..]

Hello Stefano,

I have five new commits for this:

fftools/textformat: Rename variables wctx to tctx
fftools/textformat: Cleanup unneeded includes
fftools/textformat: Add validation for TextFormat API
fftools/textformat: Add validation for AVTextWriter implementations
fftools/textformat: Add validation for AVTextFormatter implementations

Yet I don't believe it makes sense to squash them once again back into 
commits that you have reviewed already, they are much easier to review
separately.

So, if you would agree, I'd merge the current patchset first (once 
Michael confirms the zlib issue being resolved) and send the new commits
as a new patchset then?

Thanks,
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".