From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 37CB04D2D8 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 14:26:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A73F368813B; Wed, 16 Apr 2025 17:26:12 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2070.outbound.protection.outlook.com [40.92.22.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8498B687B1C for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 17:26:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pM3HsI9wXmqATZG/5uaZwA53HmFy0YHICbOoLKj6NyjPjvqE4gH3H+cSjyhHgb22nyQOYCm0SV047/bQREDdTBKhdL3hjnA1KsBcDgD0cjgcrP3CkV1Io8FII3Hr1VDbPd7c8MHyqso2Bp/bez6ztAt5v9XZd6+DHSE3vwLc6hxqhmIqvMy1xjNMC6R/Ak9pumL3XaAlHabePgK3hTux+ISaqbvWwP6nknntx2+z9OLYzRgDwtxog1Pi+qB1wz0cYOiXiwmyyz1z118K2RO0z8GoJduDeG1ftL0jb8fg0zZzZQBcLmNTTAp/2n4wkfSRNv86DrfUT7OzWHFpKQMXcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hlv2GQIrxm4Z/M3T4MFTdjWyHoLl751Uhqb6j8yDiHU=; b=o3jcjHgyOYfgr60Q6sT4wgncytZHnZxyZbIKCEWwJRw4Dt4EHollj+Z1S8+BCNTTnxLQBS1oFclRNuFlIAB/abpArSPWjG4TdszgHe6vdCLu+HEtRzSE8Lj+9KfdJ6QXSAmwAFXg49Nyqq7+N320A6WGBqLUTg57mPkDvSLH4Tcj7ldBXkOGTzV7lMNtRd4J6gAkt3p7R3vZejQChGvGCTVC6yLM0ycO75BWz6v+Ml0HtAdbKD3BnHxDB45v4EqGhw2OdZFdqs4d0V7XL4RnlSkysdtMU8eWzInpRIHRoLb7ddzefL0/qWcBFcxTesPSQ+oSt4PGmz/eksXy7JMwyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hlv2GQIrxm4Z/M3T4MFTdjWyHoLl751Uhqb6j8yDiHU=; b=N7MDJPuLZVcKMrW0Qe8/aWLvBXt9Wix6j8sY4T6J6nzZC5U2XZzBm7u6lWX27LDCCgCdMUCbS3uCSiodCOkjlq9GgM6JsfQfI+4hfbkGXjfcFE8l7R1L2v3WJ6u6bLWMaViFoWFR0z3fc1c5844OBCVp8Sf2UWshQpiKqkAku9EKLaiL41e5eNzGhCbZnZKxy3+P/z/MCzTyy3Pr+lcYhBVzgrQTXccEQx+3GHxUvqU8KVKIgaWWgxta+kvUdZIFl76L67JX1msktXKPV2/F31vuUzahaHYyheijYhB8/Dz6CXsJ5uhZMUhul3Pyn1+xcMvgTCSb+criDMUZw4b3Jw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH3PPF89AA14D35.NAMP223.PROD.OUTLOOK.COM (2603:10b6:518:1::52c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.36; Wed, 16 Apr 2025 14:26:02 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.022; Wed, 16 Apr 2025 14:26:02 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH v10 2/3] fftools: add mem log flag and disable printing addresses by default Thread-Index: AQHbqbD+K+X+cMg82Ui9nP+6irCnebOcdnkAgAnhKgCAAAc0wA== Date: Wed, 16 Apr 2025 14:26:02 +0000 Message-ID: <DM8P223MB0365C362FE47B250CC452B13BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.59.v9.ffstaging.FFmpeg.1744222745.ffmpegagent@gmail.com> <pull.59.v10.ffstaging.FFmpeg.1744245539.ffmpegagent@gmail.com> <207dedbff61f0676c78c06ea759e6c7038dcbe86.1744245539.git.ffmpegagent@gmail.com> <Z_dqWF5iN6IiAfGv@phare.normalesup.org> <20250416134318.GK4991@pb2> In-Reply-To: <20250416134318.GK4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH3PPF89AA14D35:EE_ x-ms-office365-filtering-correlation-id: a1038f55-95b6-4629-603b-08dd7cf29daa x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|461199028|8060799006|19110799003|7092599003|15080799006|440099028|3412199025|13041999003|41001999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?Tix299SlZhsfyQ3GKsMJU3gbBKcHkY9m4GV7OuaSjh4yjX637lE5wZ1krdDa?= =?us-ascii?Q?5fCzQDV4vntAMD+SCew64p//RrFtl+0cBQcKcbTCR84/yAXxgheZksSXmR6/?= =?us-ascii?Q?WFGynq5WC6Na4gnGd71gwGet1gTrY8MqTZexL07aNcV9SFTX6gH7bYkLNt/3?= =?us-ascii?Q?+xTD226JvDKpIQQglaCP0BRlPwjU+S8fNawGtVKfBLFG7IMQkp325ADO3O9W?= =?us-ascii?Q?wjKiXbrArrjjvX8EefU63t6QuQB+0eNoTZab4n3CLfmJuV20GcvXlxpmx5Xg?= =?us-ascii?Q?aFyKSwSgULaDowtZHSWMAyusvnWBGiYwj5rKtX/EorM5CFM1dv17TsxxGcBp?= =?us-ascii?Q?x9PjgVYvKGqufBEUtjc6zRO/+9fneHD04B68PVukSOy386Ck1JaSYZS9UYkz?= =?us-ascii?Q?dLx/aHugplKQLcGPB0PPdcl8dHiwPti7OXD5lpbtTbYLHDsIPZkz2T200KWR?= =?us-ascii?Q?PD9U3p8ER1BxICWtOcjkG/H3PzMyQUlUGcGqu2oHPxFerAn+pjl8yFEsm7e/?= =?us-ascii?Q?qobdqqiTzi1yazlxbHy0DM40fXqOxo3zYZZqQbXiabrINsFlFQeYk1l4+MP7?= =?us-ascii?Q?MMUhccL75Osj/TTHYhcNFZerHZ/43HExF46nXLdHMYVuRRFMI5/azv3jJjry?= =?us-ascii?Q?elJjFjt5zwy85UbPd67aL37OWa/bBwIA/PNlxK+aOhIEUn96rMP/l5QFxIeL?= =?us-ascii?Q?kFKhieHh0pDd3wEIo7hvimRWWu+ulrvJe/3YlZq1hS+CLxEEDzwRL71yXw3d?= =?us-ascii?Q?dQrJ0lMMFlanu/GkEJzcv5U4zYmNE8cUHoOrGfoWUo5V8hShSo/H1Gn14oEh?= =?us-ascii?Q?C/9cEwZABhMDfUfod+i8u1QO7MsE4l3wFtL/9orKZIgzaI9QWBuzDNwMuBzH?= =?us-ascii?Q?FoJfaOcWsilQae4YbFWgLtt18kUssM5qTHG7mc4Xa4f3aRskgXmYU3BUlCcy?= =?us-ascii?Q?XIVRgEn5EmSe61eW0g3hbAezdrcEqCi5bAbvuch1931yKAvh9RBqtUfMFxay?= =?us-ascii?Q?UjJBhLRBGhZ+JbiOvWxQkgByCLsYGN+9yHoL/S+60+PXnINrcQHDJrmCH5Wb?= =?us-ascii?Q?E/TAB4IuEiBNbwXBoIUueP7e2oXBlTiiusrUWupcMfBUDyhQQLFZ3xz47yRa?= =?us-ascii?Q?kl4erFdWHe/gwF5ebWcLJ7DS1ZyLK9cQTvlBAMREv+utDUMGwvtWAuA=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lecVsCesSgG7kV3REGLc5fCDi8lhdhD+R7YjY8sYeQ7L/odobKHFRIoz43Ea?= =?us-ascii?Q?VaF/+jklIaubXyL17je8xWgO4t7z4VReDlqXugkx+aQhG1DMJPV69xKgKO6p?= =?us-ascii?Q?d5RQyjImNN8rCkIs5Tn/kSGMz9UHCbQ8qhOLUzAUrUrzZdyR56rv7hPKeSp4?= =?us-ascii?Q?8s4j9cpLmBgWDuVTRYvIPv+z3NB/luFHlfsTYiu4s3dwx9XgGMogqF3hDOlF?= =?us-ascii?Q?zyg24cG9UDd2XfYqHuQVmgj23Vd4ZG5pWYEUjN24GlE+ukV2fKpJwNsqTWWA?= =?us-ascii?Q?JVOzcJQVTLyShUTsC63W1q8Mw5mPQ0U8yv8XxL/9g1807Km5OGEDRiN3bao/?= =?us-ascii?Q?XjRiFMjAnMV0ReShM1PWBQMNnLhqCmRpVex5sYhkeTFK6bc7I1qR3/U8rZYQ?= =?us-ascii?Q?Dx7AxWeOTpF89kGvKM6FvJ0o9SPcvBP6+NeZGe94F8PYR8a1KBu1i9s6ln+M?= =?us-ascii?Q?GHwguVsenCDe+PkaVWOtwCidrNWBuqDJdDKMYjSxSBfgEoAjhil3vJbxDaVC?= =?us-ascii?Q?wLgyVj/vW6k2Xx7T0toOTtnqIgLEl/xQ1pS4Iebl6WKyT/CAIICqUjNm3Bce?= =?us-ascii?Q?OmE6Cv6riocNic21an48ymsvR/Fuh4/1Ns70J8O0bnnPezsceT46d7C/CPUo?= =?us-ascii?Q?zW8rClGJvebAn7ysCzAuFLV5lI1IFkwCgrEnZZ0ZsCw8MH4gnp44Wqbh0bYf?= =?us-ascii?Q?d50S0lw9r8IRXUSjhbcPa3wQsfOLtjBT9PMaJF0aGu+UrGIfqZqbF6RTe7uR?= =?us-ascii?Q?qrLyrEC/qnask6+Phz0XiBZK46BEiTir+mkxaOe+vrXCo/ssmoi1l921gb9E?= =?us-ascii?Q?i58OTaMcKdn7+Kbfk7CWdLkEJnOfayD6F0VnUjx9dtKZxKGTUdyiA0It/IS3?= =?us-ascii?Q?eDH5R5VD9P1ts4sLJYb+PR02DBkJHwO4euScE1DZhwuE56rcBZ4KPIBHcRl5?= =?us-ascii?Q?8f6kung9PeOMv8NDv2zp8NtWnMLEx6NwP9v2X2tZFkTl/Ceyy9ijUGHxv1ug?= =?us-ascii?Q?YhPkYDMrNPNC9H/WvLeWL5NFKEByiuFSQUgRaNCp/6lXOlk1rgAh+xhYcGHt?= =?us-ascii?Q?DyhfZDQ8DJh4DUbwny1W66BsjcdUTfw1wXjLNXy1x5ZarXNot0CUhYoFRBup?= =?us-ascii?Q?OtI1RJi9P1nnl0MfaNHJPA6f5FkB7O5Sa0TWXSy4ASnRxEi0kajGA0kx2ZUF?= =?us-ascii?Q?VbE0KxQvv6OrAve409upvlVXWZCaR6VK6lu540rBBWRLX5+6aJvg6Q6exqc?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a1038f55-95b6-4629-603b-08dd7cf29daa X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 14:26:02.5086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF89AA14D35 Subject: Re: [FFmpeg-devel] [PATCH v10 2/3] fftools: add mem log flag and disable printing addresses by default X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365C362FE47B250CC452B13BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 15:43 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v10 2/3] fftools: add mem log flag > and disable printing addresses by default > > Hi > > On Thu, Apr 10, 2025 at 08:51:04AM +0200, Nicolas George wrote: > > softworkz (HE12025-04-10): > > > From: softworkz <softworkz@hotmail.com> > > > > > > This commit adds the mem log flag. > > > When specifying this flag at the command line, context prefixes > will > > > be printed with memory addresses like in earlier ffmpeg versions. > > > > > > Example with mem flag: > > > > > > [hevc @ 0000018e72a89cc0] ..... > > > > As explained recently, strong opposition to this being the default. > > just some random comments: > > I think some way to distingish two different "hevc" instances > with high probability should remain. > > About the addresses. Iam curious how frequently do people use them ? > and for what exactly ? > > I do think *item_name() should be used more often. The "hevc" is a > quite bland identifcation of the instance. > > in absence of a item_name(), that is *av_default_item_name() > which prints just the class name. I think printing the address by > default > is reasonable otherwsie instances would be always indistingishable > > beyond that, i dont remember using the addresses and would not > mind if it gets replaced by something more usefull more repeatable > with maybe some mem flag that could force them to be printed in all > cases > > but i dont know, really depends on what the community prefers Thanks Michael, I'm gonna keep myself out of arguing, I believe that this is a decision that should be based on what the community (majority) will prefer. I just want to summarize the different implementations that are available already while the patchset has walked its way through the various comments that were made. ----------------------------------------- 1. Implementation in avutil with replacement Ids The replacement Ids are a direct projection of the mem addresses, which means that they are equally evident - yet subject to the same limitations as the mem-addresses. But other than the mem-addresses, this creates the identical log output when repeating the same command. Reviews: - It has been criticized that this introduces global state which is undesired in case of library use - It has been suggested to implement this in fftools only, in a way that fftools has its own and independent logging implementation, no longer using the one in avutil. It was also based on the idea that this would allow to do other things in the future which cannot reasonably be implemented in avutil This has led to the second variant: ----------------------------------------- 2. Implementation in fftools with replacement Ids Replacement Id behavior is the same as in (1). Obviously, there's no point in writing this from scratch, so the starting point was the logging code from avutil Reviews: - This has raised criticism due to the copied logging code - It was suggested to drop the replacement Ids and then it could be implemented in avutil only This has led to the third version: ----------------------------------------- 3. Implementation back in avutil without Ids Means you switch the mem addresses on or off, when off, no Ids are printed ----------------------------------------- Best regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".