From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2BA54280B for ; Sun, 1 May 2022 05:13:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFD0168B185; Sun, 1 May 2022 08:13:53 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2096.outbound.protection.outlook.com [40.92.21.96]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 470F768B0BE for ; Sun, 1 May 2022 08:13:48 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VtI0kGjXgPSlsGfaIQ34c4Cs4m3ZwkJC4FREh52mPIQ/eZT8reax082Eg2c389MLD71zz404UkCHBt6hPdWQTfWPDPIysVDHviiYxkG3t531ww26N0lvopDvH4AiLsKNLICUD+gbCVBqxede6GT203OEtcykKnfA7Bc3/z3Oo8qZFLelXUdomjkLynYvFUzlyhdQnlJsp8LQEeGLTzd/7TFX4vN0hdsK33b2T9wC9loIBvbi2Kxib7SCUrpUUUnG8YFFebavRaJFSWZ2GoVp8e+gJyq1uTXjJuHe4gA3S3KICTOIFyp3KmfihrEuUFd8YIERGK4a+EALXWSGAeoG8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aj/v+lY69aL9x0Qn7cnyCvOHA3xyeDn+eVBVai4VXbU=; b=Ja5xJ5p4T06X0JEJiX2IzEz73aeDz2GfGUgjRwAQYvbHnUvX/STNwfuKzZ9MGmFFzAdjzpuGQSDxOV3VFTPsX7v+2YDlofrvjD73BI0+8XPytTcOKUcRV75IkB+GGXlr51FG1gDvpdtoRAU8IyXKsYOK7gb8PyMCVf4/79zkWSWt0CqG0Gw9Tlnu2RD+OuxX93tVRteLw3esJ7l30+5FaHS8ancFE0JP81ThyJnWI4rQW6RvThzPt3vIzOFSyBx2ZYDL4Xj0CkcIRe2Eds/53zgUGtHIbzo2rqvxYmILSkBJcmN1aM2+cjg8Fwo/3K/wDbWHh0g//+AlYL9MKrZ2dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj/v+lY69aL9x0Qn7cnyCvOHA3xyeDn+eVBVai4VXbU=; b=OB6CaxNLAswoNuJboiUAKLOrioFrIumIKUX8J5ml+crXhBGMpr1nzDUAVjgDjzE0kWv2Zt0zrp3kitOIXiWtEqIM7HlzUVbxQjzpt6n8HCpb3UI1pVumOayK6TBvLsOM3rv9RJKTt1iQrEbjo4eIRbQ2YhGKIU+w9AkIsdvhwy2Gwy21KIpH7Gh2T9s0rnSJcpPKAwI5QEZ/c1DsA++MaXXh9zevxQ9Cep2FQr/BCR1NJ9ZZfGLQh7+yeIrV3Hu1itHeVvL3DcAHRHWS90ua8KTx/my2h1zsSwhy8pwKN1LUFjjW8mTz37aO7civsxPMEoWY6NrzX9WyIBrCp5u5lQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0108.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sun, 1 May 2022 05:13:45 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5206.013; Sun, 1 May 2022 05:13:45 +0000 From: Soft Works To: FFmpeg development discussions and patches , "anton@khirnov.net" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSCOoldZr8XAI0qbTqYdIv60xqzhXE0AgAEI6YCAJpQPsIAAn14AgAADMfCAACg4AIAABSqg Date: Sun, 1 May 2022 05:13:45 +0000 Message-ID: References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> <99d97f51de78fdbe99a309272be81cce2efafd16.camel@intel.com> In-Reply-To: <99d97f51de78fdbe99a309272be81cce2efafd16.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Yi+q18v0PhhLVijaykc4AHOKmVglbwTa] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20a42e0b-3870-4a6d-4491-08da2b315de9 x-ms-traffictypediagnostic: CH0P223MB0108:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hkKdDr8mOqB7NAsUL1y/N2e6rQ/IOuE2cha7Nw/fBcYAd08QFffmcZG8NbEJsFal/x/NhwxntCmae4EBQ0iDGREoVE26ZfIQTqskuNqli9YP0s62jqjlMOPfTsOc651s/GYAUNTgzFMSK2lN3AKE7Ov3HBQ/Lk8qVrBbzRQEYRpeNdZtyFHL2dzaN1E8I8K2zQy42QDihH7wDKripeWdftXyjd85XUPGK9eIwljpr/UVQ/0o7G3oS8iatGWAI8QVJN3RAamN/GRcHGGlhQTSeOpewe6SE6zhUdaQPcAzYFm/MAUbQYmGZfY948GimcvaM6Y7QtGJH0QpgBLulunOct8yZbWT237i5hn+G79mET1lQpz6nW6AlqbpT9dwnQ6OcLHxJV7+SOdmQTIITzq7Vu0RYDYKzT4qZT4BP8DNZZ01WnIsCzvpu5u44jrSEPgn4rIYMgxK4utPsH9LtlykDLGNtFfkd95+lZnrAUFEIs6bW8xZ+qB4CUD3DnL99P5LBCIqb3N3+vtstyph7UqZj2A/rsaZdvx5BKvzxTIluVs0OsH3WE4BjshrELgFSqD2SFoQNuz1KFBYASsGXuE0ry4XmlgmAGw1QfcAx3o4/oZmTbvwIBoF1ySm15WgW70d x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bFh3bzZRM1dqemhYU0tpMXkvc0NIeEx2djl3c3YwSVB2R1FrYm9ZVTM0RzNm?= =?utf-8?B?V29mMU5XRStZQ3ZSa0NpNWxYZ0RlMnk3cjNnUUplQjdqaDZPN3JqQXNWRXlP?= =?utf-8?B?V25nMy9XdDFRQzdlOFNtS3dKTGhieEd2dUkvZ1ZIQ1VFRXgvaFBWZWpnY2Jl?= =?utf-8?B?RmJ6MldTK0FtcEhKWWYrSW53OVk4aVpVejJOSTRFWmhuVFFCQ0x4RVh6KzVz?= =?utf-8?B?SlV4Tk1nLzRCakxmYkxvbmlWOXp5MkV0QW5CRDRtSzhLSzBURUZjMzhkRjlt?= =?utf-8?B?bHJxR2ZvaXN1ZUZNM05JZnVOanRZRHpIRFFmVTI0cmJhaE1GTVZqWnRPSGRO?= =?utf-8?B?ZUxRVDBZV2I1aXNnZzl1ZmJzZ1ZqUVhIZlY0elFHUEt6b1pIdnJDd2pRc0Rk?= =?utf-8?B?bWk2UXExbFByUWl6NmlxbHVGL3Fwd3lhS0xmNTBtTU5qNlRRZ1pWc0dzZ2lJ?= =?utf-8?B?VjF2NjFOMU9vTlVmMGtCeU1WUzhvRVk4R2JFajBqTGpEWDNhbEJCeHNZam04?= =?utf-8?B?Y1p3RWU4U1RWOWUzN0xvN3I5b2NmN01JREp5V3JNNkJGTXdlY3BlUmViR3pB?= =?utf-8?B?MFQ2bUo1OWxoeDN1S2hzOUpZT3crNmF1WkhsOW5Cbi9tTG9QMURFeTA1eTZa?= =?utf-8?B?eXIrdmVyZFA5emI0ZVZ4OHl2dDNGZFBsbUY0dkJOeGhGOElGZEFQTHIrQ2pi?= =?utf-8?B?UnBzUnpPSlZ2eEdWbDNiKzkzNVh1ZkIzQklkaE9SSkE5WUVHbEVnNys3VCtU?= =?utf-8?B?bjVYZ3ZSZS9HMkhkcHhKWXdQVnNXSnl2SWtoMEFIS2FXNDIzck5Bd3NFekRD?= =?utf-8?B?YkdHRTlDcGl5a0UxQjVXNEQ5Vk9oelZZckhsQ3pEZUoxUFl6SlR2dHQvT3hE?= =?utf-8?B?RkJSMEIzS2I1dUk3MWtKWkhsMjlHbDJoancxUjZHalFsbm9aTm1Sa0wrVGhs?= =?utf-8?B?WURwOGNRM05uTGM0K3RhRDlzdTAvTm9jRTFuRFREaUc0N1NiWE8zQ1BzdzEx?= =?utf-8?B?Q0sxSE4vVDJ3MEVOQnFJTHdEUTEvVy9CWnpiUm1Sd3N0K1d6SWNRYmtFSnJ2?= =?utf-8?B?ZTYrMXM2dnUyNTRTOHJnQ0RzZXdxUTk4b0VudU1xWHhWcy9FRnVwcm1rOWoy?= =?utf-8?B?TFVnWkFvakJWVllKTFFRcEtWaEhvOC81WVJqS25lNFp5WE1ISnhHUThMVlVO?= =?utf-8?B?bkhIY3dZNlZnbkIyank2c2dJWXdhQ0RISFkxcjdGTTB3Q0lkbkhMM2Rrd1Iz?= =?utf-8?B?QWRtdTVYaExBRGpXYVFMUWhWU01IL0tjbklsWS84Y0x3VFZ0dStNTXdVcVha?= =?utf-8?B?UzRlbHdxT3V3UUlnZjR0bGJBc0pJL1BHRG95Y1V4U0xVUXF3MXRzK3hYcm1p?= =?utf-8?B?QitCMXdsTkRtNmt4MjFmN2RhdVRNVFRSR2NnZDJmQW83cDdPdXQ1d1dTbkdS?= =?utf-8?B?dWo3NUpHWkliTE4rdHYrWjVJMW94T0xLUm4ybHJCQXh1NmhxS3hTbW44MXhW?= =?utf-8?B?Nlg1UVlEMGdtRXlSSGNWMDFCejc2ZnRDdkRyb0ZyVzc5aE5ZcXdZN2FDQ09G?= =?utf-8?B?bGdmb0F1YTlYT1pxOFZoMDVnUlJVZG5YQkR4cDVKV29LcjdLNE4wUHZDTmNo?= =?utf-8?B?Sm1jSncyVGlyVHhSenN4Y1VVU2VHeXhKRkFQTmlFbU44cnMrdzBUQ0NMVkI5?= =?utf-8?B?QkVEVjF0ZVRYdWx0ZkdQY3dvemtxSW1KM0JJZGNNRnJVN2tFNkxXMjR5aG9a?= =?utf-8?B?NnZoTS9OMlh4UmtmdjExOWhiajBMSlVqdmlIazVYYUV1Wkh3MlIwWDllM3Aw?= =?utf-8?B?RXViNzBiWDEzdG9Ka2d0MXVCeFUzaFNOYkZ6UWtveVpTc3BSdm54b3UvcnZl?= =?utf-8?B?MDhqODZuM001UlIyWEtDT0YvM2ZCUkR2RC9IVGpuczFYd3VLU2Q1aEJDdXdV?= =?utf-8?Q?ZB2H5pZ4xv0=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 20a42e0b-3870-4a6d-4491-08da2b315de9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 05:13:45.4682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0108 Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Sunday, May 1, 2022 6:52 AM > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > code when MFX_VERSION < 2.0 > > On Sun, 2022-05-01 at 03:10 +0000, Soft Works wrote: > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Xiang, Haihao > > > Sent: Sunday, May 1, 2022 4:16 AM > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > related > > > code when MFX_VERSION < 2.0 > > > > > > On Sat, 2022-04-30 at 16:51 +0000, Soft Works wrote: > > > > > -----Original Message----- > > > > > From: ffmpeg-devel On Behalf > Of > > > > > Xiang, Haihao > > > > > Sent: Wednesday, April 6, 2022 5:38 AM > > > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > > > > > > related > > > > > code when MFX_VERSION < 2.0 > > > > > > > > > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > > > > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > > > > > From: Haihao Xiang > > > > > > > > > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This > is in > > > > > > > preparation for oneVPL support > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > > > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > > > > > l_media_sdk.html#msdk-full-name-feature-removals > > > > > > > [2]: https://github.com/oneapi-src/oneVPL > > > > > > > --- > > > > > > > libavcodec/qsv.c | 5 +++++ > > > > > > > libavfilter/qsvvpp.c | 6 ++++++ > > > > > > > libavfilter/qsvvpp.h | 2 ++ > > > > > > > 3 files changed, 13 insertions(+) > > > > > > > > > > > > Why not just remove this completely? > > > > > > None of our QSV code does anything with audio. > > > > > > > > > > It was removed in an older version, however someone objected > the > > > > > removal of > > > > > this. See > > > > > > > > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > > > > 4-2-haihao.xiang@intel.com/ > > > > > > > > I think this was a misunderstanding. I see not objection. One > was > > > > just asking "why" and the other one had missed the point that > audio > > > > has never been functional. > > > > > > Please find the comment below in the original thread > > > > > > "This seems like a generic translation from the library errors to > FF > > > error > > > codes. So even if we'll never touch the audio functionality of it, > I'd > > > prefer > > > to have that struct complete already" > > > > > > So my understanding was that the reviewer preferred to keep the > audio > > > stuff > > > unchanged for libmfx. > > > > Hm, I hadn't see that here: > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > 4-2-haihao.xiang@intel.com/ > > > > Considering the text again: > > > > > "This seems like a generic translation from the library errors to > FF > > > error > > > codes. So even if we'll never touch the audio functionality of it, > I'd > > > prefer > > > to have that struct complete already" > > > > I understand the idea. Normally those lines wouldn't hurt. But now, > that > > we're facing some kind of "#ifdef hell" anyway, I think it would be > much > > better to minimize this as much as possible, and there's really no > point > > in translating audio error codes. > > Also, the struct has never been really complete. Instead of > retaining > > unused audio error codes, we should better add those that are > missing > > (like -21, -22 and others) and relevant. > > > > @Thilo - can we get you warm with that? > > > > As an alternative, we could simply replace the two audio definitions > with > > plain integer values (MFX_ERR_INVALID_AUDIO_PARAM >> -19) > > > > > > This is a small bit only, but before adding the oneVPL stuff, I > think > > we should consolidate the conditional stuff as much as possible. > > > > As discussed before, we also need to settle for a minimum libmfx SDK > > version (compile-time, not runtime!). This will allow to drop quite > > an amount of conditional code, and this cleanup should be done > before > > getting to oneVPL. > > Sure, I'll submit a patch for it. > > > > > Another thing that is a bit unfortunate is that we are duplicating > this > > error mapping struct in qsv.c and qsvvpp.c. > > I don't mean that it should be linked as an external between > avfilter > > and avcodec, but it should come (be included) from a single file. > > We moved the static error table to a .h in the past however it > resulted in link > error when building FFmpeg with static libraries. That's why I said that it doesn't need to be exported - just a single file that can be included/inlined in both cases where it is used (lavcodec, lavfilter). Best, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".