From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33D9E44CB6 for ; Mon, 14 Nov 2022 17:29:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5770E68BE99; Mon, 14 Nov 2022 19:29:51 +0200 (EET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02olkn2012.outbound.protection.outlook.com [40.92.43.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B9C3368BDBA for ; Mon, 14 Nov 2022 19:29:44 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYZsa2Dmov6EP/K0RjiL3lvOSmMTMzHsA3KRMaW3s53wI2/lov0jOnf0enAz0W/3NbWB25VWweX1U5m58+gVPcQye5LQGSZPIu9lmxC6Q0Kp50lBXthW37KpatcuWOZ2My3n1KFcWqzgg07/0bcN1PciaBYMUKtDc3vn6BI5TueI+mP+yu4v8kf3sGBCEm7SQKhz+d40kObDAUpWjT0gVFnGLDpABR8tAxwWl0JENTaW/uvW0O9TmsIzUrTz4aYHzyTZWhCepkPDpGIlpMAaJcopRe/KNZp5DhrfT83Y18wYJqJzvG4sdLlvog09yhaT5CYTP3PB023ru00bofrKAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmyJw1td0OTAuvC2DoTXDoBqc8H5Jb/L333h4p5DuOE=; b=jUwDJNbO4JQzKGlpq9lxgvEpoU2VqYy6ds4WWldSxJev+PmeTs8nc/j3GBd9htGUnsNPex5Ye9Dixl49YeaqGfL3VvdTpIKddTQ4Bw7/bUxLhthyJqPLXBexETzEB5TsM9edxBXottS5QE9TDr/6GY90/v4TEByHNLB4HjWb/j7rULPqmOaWATjKP+8kd9FjkDqxPWtmubz7LhBnyJJtMKZnPCqoUiAWaBdMXO/nIrjdPtXiDHCURHaF1GgGeDjWVZh6Zbexyd4dOxWxZmYhc7D/SKMCGAAFAbI7RhfJsOWAEE0E4TT4KiPRwX1l91zXIAeAzKcIlJrvBXgaV0EwiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TmyJw1td0OTAuvC2DoTXDoBqc8H5Jb/L333h4p5DuOE=; b=P8RuC8Z4Eqq7QgK5wmjtJKOuliiV5EQzqbzg2mxqq/uZ1AhmB/jxcx4XiZbqYqrryXMmXtZq5+mxmTpRXmqYu/0JWt5PTsuQr1UpbT6MxIgG4WLLRrLb3oQTcUet8dQ0MfQamHq9hTVtAdXqTC1vnitqK4v5tDEbUNzpIo7MRybQdQ2xBHe0GinkojFPU1odQjP2Wf5f49VIw4OQDA+qwU8eeYeobwn2bXqxFYgB+MUb9vn1Ibk1GR8YyQwkItFHz7IGa1+0eCxDgPf9uWVYIXFlcdQaTaCejwSDCM4i66E6Z3ZfaXEFG4Fuf12fIbz5HxTyhgjXEmJ0cEet2qPKsA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SA1P223MB0629.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:259::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 17:29:41 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0%9]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 17:29:41 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: simplify ost_iter() Thread-Index: AQHY+DvLPF3Yi6jU9EipGAd2PyewmK4+rKpA Date: Mon, 14 Nov 2022 17:29:41 +0000 Message-ID: References: <20221114151350.5134-1-anton@khirnov.net> In-Reply-To: <20221114151350.5134-1-anton@khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [YECPXRXD1E7KymQ/STdgyrJTOMG/H41/] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SA1P223MB0629:EE_ x-ms-office365-filtering-correlation-id: b0e56ab0-add6-4c08-437e-08dac665d03e x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: asbAlz/6vtkpn/SlR11VmwBUgHlebqw902adjc0GMFeBQU6L5nrm0GgP8KOFdzibDQnCWOjhA7934ky2X/9d43UAmCjsRbY2LTB5v5shA6f71K2wlA+z8lAI24SIrOJaYNMlm7X2tdDRJAmC+aSFGA8AJHl6OttpMsun3F4drT3wzO/ORkvclVt8hqw3b37tKrRXBeA7c03hMDfHPOT69BweFrRYUa8p3R4sxuhsJNczG7PFOHMZjJfDbgiFUekVeFDMgXSiA4dyFQPeqOaIy9U42VJxolcdNslD7DAXQXTQnr4QG68r3ArHHWI5WRcYfv/v/Z6MU+7OV2UZ4HcOU6NzN4JjMCBvMJHzHTpUdS3RaMSlcl5lzaedO1Pt/6C4Dvx49OGzUhbLF60S3eFsyu8icWIpJwwbZ97Z+8xtC02lzUbMBOJnKkWDBzTW/Liy487i2WZxUS6UsruV+uWLZHJrYb12u/77Zw2KXPaY4tHNw8Y/gCTz5OQaMaYT7t4/lpNUNIJMQv94DC9jBMV2bkrvI7yLB1sDgyTo/4E2DPiBSbo9u79iurcEq/29r760OfIKR6PpMJSmNJ9hSjucvGApAEW+871UW7AWmtFSEMPC5aj1XGaAYnh4vrHokALvUNrxYbt43XVkSwkX1ux4laTm5M7UvuBtMPI2XOGTVLUxJT+B2hojDY67NoiB6Y54 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c0FHYTRuUk9ZS25KaWVNWU5pT2FyMjVsMi9CSTlDUDRTK1VxdG5GNFVuanFy?= =?utf-8?B?Y2ttMTlNeEk3WnEydjJZV2RTTlNLcG4yQkl5UEw4c0pITWh2RWI0d0dBK1Fa?= =?utf-8?B?M2xxQXltUFNqUGpTcmNNTk82bUtPOFJpcXlzc3RxblpQMGdaRW1wcnJoZmxV?= =?utf-8?B?ekFMbHhRL1dRL1VseGxrTjQwVEU2Zm1nenUvOXh0MkxUdklxWlJZNzB0U3FB?= =?utf-8?B?ak1keUVtazJzdTcyeHBFdDN3RjhLVDBLdWRpZkhTNlI4emZ1RlBxcDhvU3ZO?= =?utf-8?B?Z3hKRXlTV3h3TTQ2Sll0REZndjAyYTJWbEFCN09SMGxFU01QTFkzNWJQV3dp?= =?utf-8?B?NmJ3NjFKRGxYMERNMG5CNzYyOFMrZzNwdFRTOEYwT2pDYWs3T2NrdE5nRGhZ?= =?utf-8?B?MnVhMVJOUDQ3VlFMQ1hiekNvQi85YUp3MjZYWk9Da0VnZHFVYnJ4SnJXdjlO?= =?utf-8?B?TGM3dnplWko4aWZJU3ZFU3ZFV2l6eW1iM25BZDJZcVM0WVNQY3k4dkxzQzBq?= =?utf-8?B?ODdxencrR1lhbGZ2S0JEQWFyK3E1czZIRUQ4OEdsRGVtNkFBQ21Rbm9KTmN5?= =?utf-8?B?dEMwaENkWHFia2xFWjhTU1ZyZ1lkbVVqYTZ4ak5vRmNUY01rRUlSS0N3Wkll?= =?utf-8?B?cm5sSi9UaXAwK0c5d1h5ZW4yai9oYXhBajFqYzJ6OTB1UHVySktkRG9jR29T?= =?utf-8?B?TTBEMHlSUnQwWG91VEM3QXVXUEhOMGpQSjV2TXdKOVNWYmdZMERvN2p5U2to?= =?utf-8?B?bTdpMmEwdlBhNHA5bW5aWnVoeC9jUDFTcnQ3TVM2QU9EenBsbWlnRUVaVXpv?= =?utf-8?B?QjJjWk1mVDRhVHZsekZWdWVpeHVyYXJlSEJTSmI1TTB6dkYyVnNDWVpaYU5m?= =?utf-8?B?ZmlsSVlCU2U2cWIyYmhhUDNEVE4vL1V6Q1ZCd2U3WW9JUjhvUWE2VGFucGZS?= =?utf-8?B?UlpoR2U5aVE2c0pma0Z1OHlkYjVZZnhzVUZVSnFVTWhzcCthWFViNjNSOXFx?= =?utf-8?B?S2ZnemtROTdpSHc1djhndEhYTUpoVk5zeFNIMURuazFsR3BMa0lScmNaeUlq?= =?utf-8?B?NHJXQ25NMktUZkkwb2dScHRnUDlpWWVzc2UyV3ptUnhTYnJEVzkyMUthOXBN?= =?utf-8?B?VmlzWWc3bFRnbVlmRTlrdzZ0L2NvNWQzc2tnSFRtUEZlRmNaQVJYNzdkaHpw?= =?utf-8?B?UDR1WkRjRHZzVytHTkVURElXdytBN2hvemNoZkNNMHlhQ1hSejlweG9JM1BC?= =?utf-8?B?T3ZQZXY0WDVPV0J1bzViN2dvMWtWVGVOdnBGS2Y2aDN2cHhIQmdvQnoyd2Yz?= =?utf-8?B?Ymo4dVZlcGUxY1RXQ0RISytnMXZFQTNmMnhxQVNjbis0N0FBTlJOMGs3MWRp?= =?utf-8?B?ME9CbDNDOU9Za05iY1lTelRFR242L0pJQzRoa0lBYkV2UHFmdG4reXpvU1hy?= =?utf-8?B?UWtReWdoRzBYS1VGQWxoejR4N3hVSnRPRzYveFlMK3ZzcnNUM0Q3TmlkVzF0?= =?utf-8?B?L3NxNUNOTld4dGd0eFBsVFoyYjNVaGRsd1dsTEFyNVZ5RjNsQUdLYXdBMFJv?= =?utf-8?B?azFJMUdPTTkwZHVtRmtaaFJmZVlsdGhQbmJCaS9lcEcvTE1UUTZoU0RVS2lR?= =?utf-8?B?ZXJneitUc0h6a0pMOEhzaWhMU3pIYytEQlpGM2g0blVIN3hqdG1QMFJ5STMx?= =?utf-8?B?WEI3UHM5Y1lCN1BnUE5rQm1oVU1ZTzhQSjltdHpnQU5ycFZzV2FoUmlRPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b0e56ab0-add6-4c08-437e-08dac665d03e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 17:29:41.3615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1P223MB0629 Subject: Re: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: simplify ost_iter() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, November 14, 2022 4:14 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: simplify > ost_iter() > > The inner loop never goes through more than 1 iteration, and so can > be > replaced by an if(). > > Found-by: Andreas Rheinhardt > --- > fftools/ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index e6f6773f6a..0fa2fe8c52 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -612,7 +612,7 @@ static OutputStream *ost_iter(OutputStream *prev) > > for (; of_idx < nb_output_files; of_idx++) { > OutputFile *of = output_files[of_idx]; > - for (; ost_idx < of->nb_streams; ost_idx++) > + if (ost_idx < of->nb_streams) > return of->streams[ost_idx]; > > ost_idx = 0; > -- > 2.35.1 I'm objecting the whole patchset. I think it's not fundamental enough. softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".