From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 76A9A42979 for ; Mon, 10 Jan 2022 13:44:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B07D68ADDC; Mon, 10 Jan 2022 15:44:33 +0200 (EET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2025.outbound.protection.outlook.com [40.92.22.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31E5068A8EE for ; Mon, 10 Jan 2022 15:44:27 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnnwDMaS2YfdKo8GwAt2ef5m0lV7RaX53uw6le9nF58FF0ePO+ltfG75fZ9i6zFig28pqkkSMXj9qMKT50j9XSCEUnpMurl+R/7akPagC/MhRyrnr19BuN5BlS+ry8j0q67H/n3mBdtXkVVYTJQcH/IZA5N2BN9xB9ao444L/E38FCuK3DeTDA1jsRjCX+gXY0v3ck4znIxfFmGwOARdN6hom4AVZJzkxrWP9evVhYjtKcg91cbF1A8o7oqP5ABbtZxnd+DVxg3fCdXuUbolRUER66gZiMT1IhGvMhY+x7Ga2ZSGpmKJvzeaky3AYMWIwRoXBJKiTeZxIL3e2NJhDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CXJtDCtYaKzfZbS3xnMSUYPIuSC79oII0GdSO+Nl/QY=; b=fh7qY4qBAYf7JVLjKC1NSp69j/BrUbxgcPNTHEw2tSAwrchjwD62QFHIfQjjw/larwCABcqqe8nyjjWZyM6SmEUrM5XwsJHXGnZqIFIV8HgXo2QmOfq2DyTj0Ph8qbJFwJ/0VJ5Tg3iIO24py7VB5NFxkUdfz4VXWZ29PZavZtXADg67DWgm4uriHj88nXgOH0pIzucq7SlI0e+VcNiLu+v65Jo1dqNsH+Z+7UxPnwMGuTIHeDEebvH4D7Qmg8WO17IkACJcZYRBZVLmBpQe/PuGXKeNRjTswLUr88bThMcAPNbkqPwqPMj3FcHMxHPFqmLScUChHgp8bfEFFjvfVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CXJtDCtYaKzfZbS3xnMSUYPIuSC79oII0GdSO+Nl/QY=; b=s8TsZCZuz7Sd5GiD6vhcYn6x98CweO34GTmF4wnKKQvJhb34FEW4KgA83fbWbAIYlCjXLAJszLs9JUUjgUpStkzo7EF0V+TXRpi5jkImAevquzTqoRlBt+BRTLfTIpkC8TKWNv1S2MLxyh22PwQ2S/gnAte5lM1fy6favEa9Qfo9mLNVpdjMnkOVEfQIbKBMEk8BLtcgotlfY1QIiQR8NCyOsO+wHoKLoHaBPsCIvhAxfxLf+rqULhESq6bbG7oPkNKzKbqdKzGYPedCOhFDy9Uo8f0YkGOH6FFoQceLqu5OLz+LaKO8HsXhUcj6v/pr0EzCn7i+DqM534BUmNkjYA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0240.NAMP223.PROD.OUTLOOK.COM (2603:10b6:5:316::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Mon, 10 Jan 2022 13:44:24 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%8]) with mapi id 15.20.4867.012; Mon, 10 Jan 2022 13:44:24 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define Thread-Index: AQHYA7A8l94DiL6ARkGLmmcz+4mIX6xXXCIAgABe1wCABFf/AIAANeiw Date: Mon, 10 Jan 2022 13:44:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [x0/jTgXBYOv0Y8XNnv6YB+moTu5AvgTC] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4b6cbb0-749e-4950-b49e-08d9d43f5063 x-ms-traffictypediagnostic: DM8P223MB0240:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JqPVrzUc5usNeNMqD7/Qfr3nqF1/Z2ewfSYlDYhxxpjbxcf3HwC6OzJyMrdtKGr4CZry00lzEcr3OewgiGHxUe4vZZd1KWD1nkmUUBsgS12fgxEZNJCa2qd/0NWUq1PYoU4IvlCYzS4LLEkp3e0UF15fcYrSnLEtum9w4TKip7J3sKnqEJix6m8Bji8RZSRnwrPx/IPV7JjrvCVSIazywH21OIDg55rSudwguIK3ThhYMTHCJuL0abgdPHUFBLDt8S2StzylKysmIa9bEjplq7tfjNIdHmS/qvdn7pZJWFqyRyuyXR/aX6w2TsnhS5BRrcoTp4dkZsU6lmEBiSX68gsbdwgk1qu3prLTZe7CkbSW3skAi7ZnICUaACdU6bZBVwXRuOD2pa+/5tZSLcW35ecJAvw8QCUlVpNig8ZxG8qK5s+1r87SLkYtZPi1AuLQnWsstfEpeX2CwTdAtIxQEMUcSgnYxxb3ohRxwBs9tLnWUfqMbMhUEGzr7gcOXEnMD0su+t/R8Dlk9C9YSwsSxG3Wk3ll1fc69vQpO49PZT9EhaIdIMXXRxVCkjlg98vzexR+DZ2JhmRNYKrjtwTkUzyn4MmHHE0NA4wn/9GXdKaWkAVXIfZ2whDwhMYCsl+B x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ejhqODJOSlZoUkxPN29kbU5CanJROVNQTVR4MzdhREZ2Y2VVMFkxYmc5cXYw?= =?utf-8?B?bUNPNFQ2aUNMRnVvTXRwR3pWMWtmdUxrOWxTK1FNS1Q4VUE0MXd6ZDhUbUU4?= =?utf-8?B?L1BpTU9jNkFVOERWZm4vWGc3VlV0bWlwclNNUGQyelFzU3RiZUVUckRZeFl5?= =?utf-8?B?ZzROQTZiOEwyaSt5S3BrbWFkQnRCcXhmcGx4dmFvRWFmd1NHSkd1K1NtZk41?= =?utf-8?B?RDF4NURjNDV6enJENWZNSTVMZTgwQ1Y4TVhoUW56QzlpeU1aL3BHck5YNEpl?= =?utf-8?B?QlUzMTJRWEdjclBISGRKZWVpZVF3TzNDODgwRUEyWE9iUlhrRXdZdnl1WGkr?= =?utf-8?B?Vml4WVNHTGc0MFIrWkgveGtmaitMejUxQVhOZkdlWW9hcGo1WUlTMWtNdkY2?= =?utf-8?B?aTk1enNuYXlZV1RMZ2FaQkR6cUFIMGxDbXZsOTJFWWRCa2UxaU9qT1p0SzhH?= =?utf-8?B?U3ozenJYbG1ibEUxTktYaCtaRDhoQUgvSGFTUDg1dFdmTGxGY1pHdythNUdM?= =?utf-8?B?S0tzdVY3c24yeTVwVVJPdzgxWkl5MGduMGdveUNEQlcrZ3JEdElGZHZveXRD?= =?utf-8?B?UzlZUWRaZUFZRUFONjRMTnNyZnFhOUFlUWFGalg5bitoQzJWMkU2bWQxdzJF?= =?utf-8?B?Q1Z3TkRFNENGZzk3VjVEV0tRdFI2b3JiNjAwaFdRM2xwU3lzVDVLVGdVQ0dl?= =?utf-8?B?VWM5QUNMWnRtNVdVS0pqYmVJRld4NTlWa2dtUHhBelNVcWtra081SnROWTMy?= =?utf-8?B?V05Dek95R0k2ZVE1K2JiaFNiTTM0QWtqbjZUMW9hNHA0R1hDK0FqVXp5eCtt?= =?utf-8?B?QVdHaE5keWpFSWRBbENZbitXZDNlSS9XVzY2cUdEczlIVW9GVzlIcTByaFdm?= =?utf-8?B?OE4vMU1LZ0lab1N4MHhhbGxBRXhZY1hOVmVidVhaUlA3eFJQNlptRmpUaW40?= =?utf-8?B?c0NjZTJ4YmxFMUdNcHhQRnNBUXdDZXBEU3VDTjJ2RXNuaUlITTlwSlRXTmdQ?= =?utf-8?B?R2w3OGdIdU5JTmlhWmx3UDF4L0JYNW9NN0g1RFZhdm45SUNzR0t6RUpOUUZU?= =?utf-8?B?SjBPNEdjTmF1ZEptcEJDaEZSNlFmeE1oMGErTFR0RENHRGVxZFBrYmk5V2p3?= =?utf-8?B?UEMrMkxhQTJRL2dpcEpOb3BPRlI2Q2JXSGhUbC9oUkdndnRPRmYzL3pYSnJO?= =?utf-8?B?cDUvK1RQZTlweUgzQ0JKVkNhL2VaQjlSckl6ZjJPcWUwNnM5ZWhGQU53eXlG?= =?utf-8?B?am5qQ2UyTkx4KyswY3Z2c00yZWM2TXMyVTFYbE56TUpsRS91QT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b4b6cbb0-749e-4950-b49e-08d9d43f5063 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 13:44:24.5907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0240 Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Hendrik > Leppkes > Sent: Monday, January 10, 2022 11:31 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't > dump images to disk based on DEBUG define > > On Fri, Jan 7, 2022 at 5:14 PM Soft Works wrote: > > > > > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of Hendrik > > > Leppkes > > > Sent: Friday, January 7, 2022 11:32 AM > > > To: FFmpeg development discussions and patches > > > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: > don't > > > dump images to disk based on DEBUG define > > > > > > On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes > wrote: > > > > > > > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent > wrote: > > > > > > > > > > It's annoying and unexpected, but still useful at times (as I've > realized > > > > > just recently). > > > > > > > > > > This is a follow-up to the earlier submission here: > > > > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > > > > > > > There has been a comment from Anton, questioning whether the dump- > feature > > > is > > > > > useful. Meanwhile I came to the conclusion that it can be useful in- > fact. > > > It > > > > > just shouldn't happen automatically when DEBUG is defined. That's > what > > > these > > > > > patches do. > > > > > > > > > > I also added fixes for the fopen() call. > > > > > > > > > > softworkz (4): > > > > > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > > > > > avcodec/dvbsubdec: fix writing ppm > > > > > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > > > > > avcodec/dvdsubdec: fix writing ppm > > > > > > > > > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > > > > > libavcodec/dvdsubdec.c | 11 ++++++++--- > > > > > 2 files changed, 21 insertions(+), 10 deletions(-) > > > > > > > > > > > > > > > > > > These patches need some squasing. It should've been obvious from them > > > > being duplicated. > > > > > > > > > > Actually I fell into the dvb dvd trap, but regardless the patches are > > > basically identical, so I would still squash them, personally. > > > > No problem, but in which way? > > > > 1. All 4 commits into a single one > > 2. 4 >> 2 horizontally (a single one for the debug commits and a single > > one for the fopen commits) > > 3. 4 >> 2 vertically (a single commit for dvb and a single one for dvd) > > > > I figured combining the patches that do the exact same thing for the > two different decoders. OK, will do. Thank you, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".