From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9371E43446 for ; Sun, 12 Jun 2022 08:17:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C89568B3DB; Sun, 12 Jun 2022 11:17:37 +0300 (EEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2080.outbound.protection.outlook.com [40.92.18.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C207468B2C1 for ; Sun, 12 Jun 2022 11:17:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QnVt3aup4Ob+LBwz3T5zjyo6wZd9kmpPAKc+WDrAJk32ES78tHVgMtmf8Iza2f2OTvu5yGSbPbo2zJG6ICRmq7d4sKvl0vIEKD+8XGsKQbY222+RTsp7edoeY8P8c8yNhyhdLi9NwrurOaIsapzGlNtF8LsvGH42mJABUR9HyZwTCaEwnnVvswwT3aSv6kaSmDkUseEP/aJDRPWMqY7KGzqbOkNqZ9bAd+cldAwgUxFYY5Wd98/FiJraugomDY1dawaoGJlhneVxTo9HUusfGRd0BSBtmU2NY9WRXlZXQ2Xn54H+7uC30XqtTCNmCu9TunwpVAbpGlXmSRWk/P0VhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ys9eb5zzIMP4XCrVS2j/MG7FfGDJqvzgA4R72Jg5bus=; b=A8QSJ3n6uVrjz+G4PeSubU7xYRY9nWxJdHc5h+aogqTyV1aNX9oon3+cVShahZaPhYiTtIs/9o3pbLcyE86rA4wgIirkrY39gRfMe2PCa1wuFCW5y/AdNMJmvns844WKO38NYwYyE9lWqW9Gm+ZQ579Qm3ovD+qmM0Xu6FglBLs6otntSLJ45AH06qPG0Q5dSd4uYXMV2mvEXACzeZFdWE7HXbJuCmWw3eymd88hiksBK/cGT7hdS8jEoPVqoYCYyDzuXen9a+1KxMWctEJtT6oOjq7zati3Uz9W5Cvpi5MHaQBve3Dr9/luP9Pt2KwmifjC8W705wE0EVjl/KalgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ys9eb5zzIMP4XCrVS2j/MG7FfGDJqvzgA4R72Jg5bus=; b=J6+l4s+UN7rNx7qMr6XvAOZBxgRSUvS17g0zrhM8JjQe/ZGXMAQvpuTeK8ETF4IaXwytZiVyFZT7f3vLUpIbKaJH7xZvkYZlBciui1sENRpSF94IvtPskzlM4Y32ZT7YQtGf4VjjaKEKKYmeLGz2dhTQBM8ODOBsCDtGF2Fl1DGe9V7507m8KLGLCCfo6VgiRiHFrAZr+AphNzK1Sf0GZg9vj5Zfe6LpadAL/1uZZ/gcOPla7w+9bMwuH8rwjU+pQNKjiOcaDJQz9WxnGa2zfp0qtqjLryZ2iXRfpuMATd9BbJzM2iyP/8fWR+ZbptyPaVZiIeSEvsUnaYIaD/WhnA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (20.182.50.244) by BN0P223MB0055.NAMP223.PROD.OUTLOOK.COM (13.101.143.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15; Sun, 12 Jun 2022 08:17:27 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%9]) with mapi id 15.20.5332.019; Sun, 12 Jun 2022 08:17:27 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO Thread-Index: AQHYfh08eAL8kjh5N0u0MEs2y/Jx661LVsYw Date: Sun, 12 Jun 2022 08:17:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [0H9a8XqxwTpTGEMndvcaQAnjaPaJ2tVJ] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6692585-441f-42a8-2f58-08da4c4bfc7b x-ms-exchange-slblob-mailprops: sTyj/kSftoskdsLClZJ/tJMPh2jXxsYRNGtQnjRJBsx6gECnhiuds3eSmQJzpoUNQqigBh6JHsY2bCd/uGI6/6WLIkggX7ZAVGEzOGcHQOsu2zXWwlD2rb94ScBxhgGBXLPAZOQ3lHYCIMQGlzDd5UW4cDG7asi0/HCXcz3Ho46OoTIdbDTPKEqrBDh9PhKAD5Wn+ptbx/c/vP0vLZgGvd5/DRTUnOnLXl87U8u6E3OIYTwmNavOoeUn9OWWx9bJNkN4tqWOnM3H8UP3RJvuAVV38BwqhNT7x0ceOUoqYwQoOhbBqDeVoHho5JKblKotSxhUkS+TFZ4Ac0m8WvsVyexVQegwWU8daVgfXC52H5NVTrRzoGoN9UB5E+0260O9XRHzcwPcGe3o82uN4+/aNDDVA2eHIqkrGounnkOKkJK7q5lhzkGzqr06XifvnhCBwfGHWX5REKJMJtR0EcLERbILr4RZJ8r4jfKzhbSGNZIAWayjB46+hEV0/yBqO40igiZiNU3Lrzqk7unu00DLMJ/V6ZT1qVPeQXWop0Oq+s6byCX8wlFI62Qd7sR13bhTL11yFemMcqlZUPgZv4LfFIj7aQZ4WS5Vq+az15IMGsm/5GNRQEM1YVR0oEMojLzf82kDrBKUK19Of5WHDxGk2vkVnoHbE7XEbNYyphvXO33oLYnk5NdD2mD21687nwjkAywK9RKbEEoP5WL51FWdMYXxjmOnD9xdUwKvyQsVwHFfkhNrckAAr83sj0qSqG2VMYEY8G7eoLhCoJapixCDf5toN/3D3P+zQtDGjVT59h2fI+GYWAE4TBFtR0ZAmtoIfB8SOQrTdRlmfSAJCnC2DA== x-ms-traffictypediagnostic: BN0P223MB0055:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f5upzsrgU47hWxYOqyD0D405uS5nvacW2gywBRl/j1YVEOqH+swNeX5oAcEfKjLKwateMxvmtCowCr/1B0y64/tqa4+KwMRdIHCRZUVCWyh5Gs7f4ipJuxgKs/bglqapXxkw6KATKx9WYs8qXB7A1WYG9sIUAzxjHfXtU/y/BJJkQlBpE4hj8tXNwGhiDDPCLKNlXF8uekTXTeb+13U9M8+B8dqHyQN/8ahV4l7Gm3Y4yoTnm9Kc/Ul6oinE0m0ND3rsopC9pib0D9GgWOmfMU9wzfGfk+ils7EMTd6I+knkvuKDuMG5+2NHzsDhnVHECtjQv6Fi041tET0ujNYYSrCzeN1dZxBLgJ68V57s8FGEigzNUoaHo9jVaLxti4rPqY71ms7C9y7OSqHqwalLPhpjs5GJotI8o4fMK2TsOURr8Ds0z4UtQ19FBP2hlh9om2/vC0ZY1BMTxBAJ6bzZQasmy3fOtz82BbKTlUh5LW0aYdrEfCzSVMy+UJx5Od/FWu6/j5kEA7ax0Hl/owbnrNcMGdXHEL8pKmwCtqpFNU3OjaTyciMeNTA//MkGAWS6mFPS4SLIE22QQmXz1dDMonsKKTutHvIzwIKdI2m81snRslIDTSinvRaQF980UDacNHgXY3HrQYhta9GHzIaJSBwlCdAuxUr3wu4GyJuG5+4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Vno4cVBSQjBMRzRMNW5FV0x1ajNVZnNYQks0aTByOXA5TnI1SUlTMFpIQUY3?= =?utf-8?B?SmRmYmV4UlVQOEs3WnBXT0V6UG5CRUgxZ29IUWZmYUE3cTgrNy91aHgvNTRp?= =?utf-8?B?ZmdFMklvU1BvYTdnTzY1WjhkVURNYTdsM3JTL1h0SDNFV3pOWmNQUnZnTllP?= =?utf-8?B?R0Fta3djdy9tTGpyQ2RIcXI1SjhMNHJSVWYyR3ViT0MxclBZYlU5Yk9VNnA0?= =?utf-8?B?bmVoTGZ2YVdVWHNkS0ptbHJVaWFhajNkaURtNVpyQ3g4UFFsZjV0T3R0VEo2?= =?utf-8?B?d2ZBR1c0clppendZcEFCNmJmR0w0K3dOVkdZbThlejliTEVUVmNBLzF2STlZ?= =?utf-8?B?K0kzQ2dZUWl6WVB6a3M2c084UDFPWDhVWVlmcGhoL00wQjQzRVNWSzRmcmd1?= =?utf-8?B?YnJCZ2NvaXJ6VjM5TWdBT2V0RXRVSTJQRUVEbzdhSlpOdmRCRWFPUWdPeDBq?= =?utf-8?B?WGRwS1FMNjlXdnQ4NFhlS1FRd0JIQllCMXY1end0SklIdTBSUnl3eVJmYUV6?= =?utf-8?B?ZTJ6M1M5QnlvaGdhRzh2RDlscUpldnAwRW5rZDZMMk5hOHd2d3h1cGZnV0Na?= =?utf-8?B?eWNrSTl6dkxaL3hIU0R5VlhKRVVHdDJCTkRyeGtmL1hLQW1FK3Vablk3NHhD?= =?utf-8?B?TXZxcCtoRHhjTHR2T2s3d1pFMHJHOGN5QThXOXUrWksvZ0FQL2xiQU5MYm5r?= =?utf-8?B?aVBpcE9xODh3Znlnb01OakhiL1JhL1ZTUE4weWo0eStCSE1WRVpqZ2MwODRF?= =?utf-8?B?TzRLMy83VXpDYTRVL2R6ZjlVMjVPN2tOVnVxTC9TMXRvb1NCcjdpTjFTeE5n?= =?utf-8?B?dmxHdml6NEJDYUJIUENZanM5T3lkNjF0Ti90dDBXRjJXRlBmVFdOVU43ak5l?= =?utf-8?B?WVd5ai84RStGdlBaTkpUYzFHS2luSTlQOEM5ZHFabk92czVYdzVSb2R2Q0RQ?= =?utf-8?B?WmFtRXZtUHJzdUxrVUkrd1c1RVMxcEVoazF2bGoyWE9zMTF4YU9PNFlKMXhU?= =?utf-8?B?dmNZZUZ2QXJ3SzQ1RGtKLzQ2VDdHWm16cnBCRHVmY3Yxd1VzTXE0aElralZW?= =?utf-8?B?UUU4bEdIdDNVV2RnaFQ3b3hWYStpSGdDcXg2eUI2Y09JMmJwd0txeU1NdFd0?= =?utf-8?B?V09GdlFmRno3cFFwQ0xGeDZqU00xd3daS3JEdGpDLzN2ZWh4V2I0R01aUUNK?= =?utf-8?B?amM5Z0NZcVk5ekxIUXJzYy9QNElrMitrZzNGdk1UOTRHSjgzSUVjVmN2Qm85?= =?utf-8?B?OG9LWEp0U1ljZktMYTY4SzVrRHd1aDJWSHVPZGNRWXNRbzFkV05icDdLZkZE?= =?utf-8?B?c09aMDBhN21NSXVHVHU2NkJidmV2MTNQYVVPZ2duNkhJQUUxcW5IVzRYR3cy?= =?utf-8?B?a3NJYXdweVMwNWdnbFZETnNNdmxTYzhJMHlwa2UxSGZML2pvTERjc1c1Rm0v?= =?utf-8?B?UlVPQ2ZoUVZPSll6aGh3UHg1T3hjZ1IvS3RiYVVwN1JNS24yS3VJbW5PNVpY?= =?utf-8?B?ZUVDbzVrRUwzMUhETGFoN2M3MFZOSm5UaHBzUEFkOTI0NGt2L1RndzdGeVFW?= =?utf-8?B?ZjlaV0l3NktENDQ4S3Y5WVVzOVhXSDdRYnlsUGdiaWFYVVRuOFBLeXZpeE82?= =?utf-8?B?R2JZRWNmN0YrRENKcEV5cHpOclh1SXdEcDAvYm1WZlJ1d3JOTmVaZjd2WEY3?= =?utf-8?B?Zmg2VVBFbktXY0R0eVZadjhibUp4RjQvalhZUnkvRWIwWFIvYmNqM3RyTnFX?= =?utf-8?B?bHdEc0ZOUkl0WnhBY0lFR1hGOERhdFg4emZoTFRDK3NVSXpPbC9jMm4zUVdm?= =?utf-8?B?WEI2dEFWRnF0VmxLUU41c1lVTmhrU0lzMlJyMER0TnowS3c3RjZ4KzExdWFl?= =?utf-8?B?SlcxM0pJRU9ESDFLZ3RaU09SUnBCN3REcC93YzJFdmlCN0dYRm9Gb01jUjZQ?= =?utf-8?Q?pUPaxMoZ4PE=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b6692585-441f-42a8-2f58-08da4c4bfc7b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2022 08:17:26.8380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0055 Subject: Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, June 12, 2022 7:28 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by > #if ARCH_FOO > > This is more spec-compliant because it does not rely > on dead-code elimination by the compiler. Especially > MSVC has problems with this, as can be seen in > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296373.html > or > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/297022.html > > This commit does not eliminate every instance where we rely > on the dead code elimination: It only tackles branching to > the initialization of arch-specific dsp code, not e.g. all > uses of CONFIG_ and HAVE_ checks. But maybe it is already > enough to compile FFmpeg with MSVC with whole-programm-optimizations > enabled (if one does not disable too many components). > > Signed-off-by: Andreas Rheinhardt > --- LGTM. It's not really a story as simple as "poor MSVC is unable to perform dead-code-elimination". It is actually capable to do that, but the ffmpeg code was not only requiring the compiler to eliminate dead code, it actually required a compiler to ignore dead code blocks even when those would contain invalid code that cannot be compiled at all. Besides that, DCE is not always useful. Especially during development you might want to see the full impact of code changes, even on those parts which are "dead" according to your working configuration. This will also provide advantages for the use of linting or other kinds of code analysis and assistance tools, to get better and more accurate analysis results. Eventually, it will make it easier to switch between different branches or HEAD commits without needing to re-generate a new project setup on every small change. Thanks for working on this patch, much appreciated! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".