From: Soft Works <softworkz@hotmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8
Date: Mon, 23 May 2022 11:06:09 +0000
Message-ID: <DM8P223MB0365BEA0C40B729C2B787864BAD49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <b95b398b-94d0-98af-45d2-7cc057158296@martin.st>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Martin
> Storsjö
> Sent: Monday, May 23, 2022 12:58 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8
>
> On Mon, 23 May 2022, Soft Works wrote:
>
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Martin
> >> Storsjö
> >> Sent: Monday, May 23, 2022 12:53 PM
> >> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> >> Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools: Stop using
> av_fopen_utf8
> >>
> >> On Sat, 21 May 2022, Soft Works wrote:
> >>
> >>> LGTM. (all three)
> >>>
> >>> Tested with VS project build (full static linkage, though).
> >>
> >> I discussed this with Anton on irc, and he was ok with the patchset
> too,
> >> so I pushed it now.
> >>
> >> // Martin
> >
> > Great, thanks.
> >
> > Shall I update mine now to cover the remaining fopen() calls?
>
> Yep, that sounds good to me. It should be easier to move forward with the
> uncontroversial parts of the patchsets now.
>
> // Martin
Sure, will do.
I think I have addressed all concerns from the side of nil-admirari;
the last point was the mapping of the stat() function, which -
even though it works - could use a few more eyes taking a look at.
Any other specific concerns from your side?
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-23 11:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 21:12 Martin Storsjö
2022-05-20 21:12 ` [FFmpeg-devel] [PATCH 2/3] libavutil: Deprecate av_fopen_utf8, provide an avpriv version Martin Storsjö
2022-05-20 21:12 ` [FFmpeg-devel] [PATCH 3/3] Switch uses of av_fopen_utf8 to avpriv_fopen_utf8 Martin Storsjö
2022-05-21 5:07 ` [FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8 Soft Works
2022-05-23 10:53 ` Martin Storsjö
2022-05-23 10:55 ` Soft Works
2022-05-23 10:58 ` Martin Storsjö
2022-05-23 11:06 ` Soft Works [this message]
2022-05-23 11:11 ` Martin Storsjö
2022-05-23 11:44 ` Soft Works
2022-05-24 9:29 ` Martin Storsjö
2022-05-24 19:45 ` Soft Works
2022-05-24 20:21 ` Martin Storsjö
2022-05-24 20:50 ` Soft Works
2022-05-24 20:55 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB0365BEA0C40B729C2B787864BAD49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz@hotmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git