From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B30524E9AA for ; Thu, 12 Jun 2025 16:10:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3ECB368C203; Thu, 12 Jun 2025 19:10:28 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2032.outbound.protection.outlook.com [40.92.19.32]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7D1E8687DA9 for ; Thu, 12 Jun 2025 19:10:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b+OsQL/Ljwtc+ZiacRQ27+qrAt/fjyY2qXx/Lh123YzNLX2yc8D0TuFhNCnl0nONXQlwF7k53/zGs+yXWSlN1fujAAUY98OqfDBj/YTmFUT0BBlkWFV55xJCvuKQ9x1kc+eTrkYa3oueRoUlbIwg1jrNoWnDTKf56uXLsmZj2Nf5JBif4AUv5CeHYLc6oH4nXK8TJxPJuXEYUd/rrKCIdORoGOQutZHxR5os1re40IJq0ImA0HZDloJb6sGBoYF4VFOav5I1ksS+btZUgJ9vbS1kkUf22ywqhevfWbMuwI7OMD7XMvlCn2blP5kjo61hY5W2lUZWTI5oGxePF4T7FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pY5CDQP7O1+UrE6aBHAo8B7AFGfNGQ2HRyxEV1d2jpg=; b=jqHOcRHagWcyh3ZJTwbHbzO//XN2i3u2QhW2rx3QeM/5yKM3RIX0g6wZWFUyVcqxcpa2/1TJ7uNYICPRq3/DGfm3hCIAETzT32KFlCsocPiseVGtbPSUcZIzdpvxknLHt+se61WB1ozSnID5zEI/2fY0T9IrlPYXWoAUs/JAWNIQCWkTrSOOjlO4FjOwiRe1V6qKtHsggl5R8jqS/ZJeVZiVD1h2jdkOSmOSr13/rVFyPwRHItlVo3rxn/IDSb1cOAkCKmnk32dejZyHIJmwN45liGHUpo9MIq6ep5mS2+hKZX8tLpKSZFZCCTPcZfM1Q+BO4za5NaOyM1A6VmoxTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pY5CDQP7O1+UrE6aBHAo8B7AFGfNGQ2HRyxEV1d2jpg=; b=oA5HRfuU2csJSRd8mSRBCRsgcCefMzaewfDvhRSJ/Z9sVQMeF6CUZR9R0RhVyNlL2U+fKJKP/NWxV1Pela2GdI7q96w1PWCecDnb/rA8mW5Opc7Egfj8axwoaJ7m0RXbzhKWMm5S3u5kZj26CcEUAAmtKf8i1mNH6q3sSwEgdr4C3WF5Byp9qDIAjM5W8JMwD8nat3E+I+KudIGZkx6Y9Werqj465ebDhOspsxjCqgvVuUg45dbq++QftycrxdPUJVqnawbwxAL2kS00KNCIEcYFB/faERLe8CFer5y+YI7Wz5lFK2NCeUQrrA5/RI6AYNFaiF6Gmqk5PKW/hnrB0w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ1P223MB0410.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:48b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.24; Thu, 12 Jun 2025 16:10:18 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.023; Thu, 12 Jun 2025 16:10:17 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes Thread-Index: AQHb2xFtsobu0ETyC0KHJhY1nBY0ULP+zBuAgACXBgCAAE9RYA== Date: Thu, 12 Jun 2025 16:10:17 +0000 Message-ID: References: <20250611204213.97295-1-epirat07@gmail.com> <395F8F80-4C17-48A4-AD34-442029EF7D11@gmail.com> In-Reply-To: <395F8F80-4C17-48A4-AD34-442029EF7D11@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ1P223MB0410:EE_ x-ms-office365-filtering-correlation-id: 561bc921-3339-4d53-dd01-08dda9cb9fa7 x-ms-exchange-slblob-mailprops: Cq7lScuPrnrJkrZRMGqfbBl750LAC0JuJHGYhequIZtFxxYhdmvB8tHvbYe7tsVq9XCNUGNP+Me7rT5+w4wwCPKSFfefsCVWE2uayG3jGH848z8ZmbiMjy6GbekcJEbQQKb1dXu36zksVLFYF8NthxXiRyTuzFtwLoizMMRU2741W7Nx14xnggzU/rs28x67u/cZx/pbLdUnSsYzVQS64nvmO9NNEdgGj5V+65h/UsOCkC+VfwL3y2P1BWOeiqyI8Q4zbRy8S2kKIb+3IZoF0oX388kA6coWxML3g7s+Kn82/gpLgsceMHrr2O8/4BAdYOWvYqI2HZLUXO4Ub369BX+SKINA2h5Uikr6+wtrZdqa9+1SoMqpEa/k7PcRcUoIiVNb/zEnXLVPtpamf03zHLBA5RrDOOunHOgfMUgLilH0gXf0VzGxY87zv/tcL92qIatJj1ZSvSUBlF2QeZ85KCg2f1LjAslXOz5U2yKNk4g8ShE/dU3zDyeG2zTGSxao2v5OQu29YYIqpc7Khgro26rpxTcFv0ZUgzHujllf4ppo3lj0fgG4YGfUPqO/NFv15JfoOHqBty0sznj+bwS7QEuiDh2cgLYfJIM1wkHvgyKCvepVTjK33t/eyjHrAMi6OImsPdxwTAj2iUaNE13MftfJaySo7VJIEN5JW62S+D6r1ZQsgX5WOJCPpaKg/VM0z3M/WdAk2Dt4Tj6A1orn1X+XvIXmICf08FSVbCW9KK4QY0qZLv9KFMqDclemyDHRVGFgTVXVaGw= x-microsoft-antispam: BCL:0; ARA:14566002|461199028|8060799009|15080799009|41001999006|8062599006|19110799006|7092599006|3412199025|440099028|12091999003|102099032|40105399003; x-microsoft-antispam-message-info: =?us-ascii?Q?uBp3sNur+Bvk3YZVIHvQ2Bgs6VswSXNmHtvdLEm3Ftc4f6tdAqtkqufekiMm?= =?us-ascii?Q?jhCfWZNfZueES5jFvyzO5iJbKgYdzOQl+i40PqjIDOtxnmjzX708pj7QePgg?= =?us-ascii?Q?r7o80pRFov6MkGSI7wuodjkIU76Ljahr80diLEu1aMtelavPkoF13V0JIMwh?= =?us-ascii?Q?T7lNatHJrxq5oL+dvGzYaD7RTVPnY7or3pFU1+n+YX4bry+vUOk4aLMjE2AO?= =?us-ascii?Q?s+uRskSD/s2R87I6JI7mGQdTETNQf8ux582F/PohcfOppWAviwLJ6zpA7Zky?= =?us-ascii?Q?CqEfS4fcr9oRDMSqUgpBNqJuMCzw+XbTGdoZfvesrlSua1+CB4UAfuZHQ0ga?= =?us-ascii?Q?4QWPg+gyhTYuA2IUKmJNPdDKqo0bwtoc2MztxGPO4EwMUU2KEXuy6X8YmUFt?= =?us-ascii?Q?Vacd9pmbJamMcJwAS0cn2oE+GzOjuI8YeDqUeXBtqOXyzucVK0lByLPkArtK?= =?us-ascii?Q?zcq9Zcjglxhcpn2emiWDmlchOzmPBMCLaswN2/0nwLRR1P5kkNFfl8HrrJmE?= =?us-ascii?Q?oJUfmS8EXe8i7dHQjvWl90anHhm3rPPysXKQdU3c6jux2Vmt3UBdBcFVOIWD?= =?us-ascii?Q?tc3h8hLEB/ExPBjgc3TKBdSJ0nXS0SkGcNgEVtB7Z1r0HY2AmalUN6gY3pDr?= =?us-ascii?Q?mJICJstyTXdmxkg4tlZAGArmYNyiJCCrVqBQ5LzLR1FEJGnSaUyJF45tZwQO?= =?us-ascii?Q?clKjWTQb1CQNRscnlIrp+LBkWNR4k/Et81BPsjIpjPCQM2I+owEdwJnigfEJ?= =?us-ascii?Q?mgq+3oYxT1K9TW0R2ZDyyR50CoehgYid1ZQy6zauJ1LPCSNmdMzI2RBjcKWX?= =?us-ascii?Q?axfgmL5XOAksL2PkmNJNJdAu4FHFOTZnn7BWh8JhtkscTxIq2NcfSDYwH6Jm?= =?us-ascii?Q?EzWng05/py9iq9i75qTROZN3zG4S8gWB35wS7kM8xc9qCEzK8l/xSQRd5qJ9?= =?us-ascii?Q?cFkN0tKhCo8B5Q4eAmcA2urzLstDSB2wQ9EnQ4oz1YvYP4QakbCe2R1+bD/H?= =?us-ascii?Q?OVsJXQjVa3X+ICcDH2I/BrsrGzoLEeAmYMT5qTFPO8/YnAMs2lAeFUxK+L5M?= =?us-ascii?Q?asWyGXxwXZSAvD9eXiPAfIlV7F3u1PXkcW3ZIa2xlwKMlFyvrQuDLtJAvP3O?= =?us-ascii?Q?T9cxdPJKf/Fip7qzMgB02tCMlzv0EESAkMz3gfk6Ri5oLatHHPeKgq/RH8hj?= =?us-ascii?Q?lRWQxahKAZSI3Zqgaj2VryUNCbk69z6B4gA6+Q=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mtgtufJOAS29SSOJhSpoHTWpC3SjvRTsEgHhUIKFVg0vPkBq6hC3AJ1zB1Ky?= =?us-ascii?Q?aQyZ1p2lL3LzPcrjDQDZdWNODYYVf4Du92awPSWX8nCuqJngbNwrlrUumGAx?= =?us-ascii?Q?/bTls7SyrMwf05kAjdgWPagXBYDzPiZUTLIOLhAbdI3evvw2S/ahLkhxdBnj?= =?us-ascii?Q?A74QApisGHhH8JZ4IBszd4jt0vINtQrGMw5uiEXaMAOAmeUS4i+AIPyrpYNM?= =?us-ascii?Q?hmJlsD0zess3TS1LMv/8ieoYF3CM9ub6CwJkoRGQxmtJVcseupHIIWNbiiwc?= =?us-ascii?Q?ytTXel125MzA6Ye0IVYXqhXFm1jVOuSlc+piZkrO9cdG+FoBHbdvJGXgQi0m?= =?us-ascii?Q?lWJs+cM1rQpMKxkzodNHBYf81Lb3ZBGdkgO91qasZ3NbVt+Cq1PJlPXjC6MT?= =?us-ascii?Q?SNEhX/qnWnFxG5xCs3hXY+LbuIR5vOSqt8X7iLsYhBSCrF7yHuGp87ivtQsP?= =?us-ascii?Q?d/EEr9E1N1vviUAhSiL14bOsC/G/XYAndZasBUTyJAY3/4/kAFKfwvfhrImf?= =?us-ascii?Q?1Su3UhhF9jZ4UgLiornPq6BhrhJA5JifNB4MHd+y0vAleFPgRwXT6mug1+vN?= =?us-ascii?Q?lOlpNlxKz5tGZwF7ehZ81amGebrKphTpReu1PBPc4XCEbGXpOm+R8hjxmoX3?= =?us-ascii?Q?Opmi72a8JQtV9wqOVfNPyaFQu7++tYJmyTkexpK1K7OT/RKPK4COR1FwFtln?= =?us-ascii?Q?qyuPCJRiGjSaz2nMzWifnA9i4kIxYrY9BzojUFKEiU3Tob0hyogZLHVyxgCj?= =?us-ascii?Q?vTZQ67EJ+9DN0GbP47wxK9mxYDIZulEwoX3qq1HWcbn/qR1dJqIE86hWV0LZ?= =?us-ascii?Q?rPDPd/OFZOXXo7WhAXXNmnLsVx0M9G2VKVst9akw0ja/oEOjTlg5aybGMLAI?= =?us-ascii?Q?FlsRfWDA4w7YMTDlXvYnPlEU5RoRpeusqKBErjovceJZTyhyOfysHECiZUqt?= =?us-ascii?Q?/CYRIIpbB90b9B9e61EVqXNhyv/adONYa/1EeZKToH8Qm62wB3e3/qLILtll?= =?us-ascii?Q?/sDp98NAWqou+hOX0rylOxXcDDCe/NmTlex7eMCGoEUTMdEaeLCezcffvlwt?= =?us-ascii?Q?C5HTILNvYAiZz5BazJraVpWhoUrGsv7wneU1zCBavRsu0hHKV352e3uZ+Nem?= =?us-ascii?Q?8nbJ9yRqDOpVfah2G0R3Ko60d8ckHgseJNQm6faVgEthQupVN3zoFM/QZ4Ak?= =?us-ascii?Q?BIOMYOnDQQjyvDpHVejteNheJndEsTRCJoDCtWfgTxH9PyN0t+73/SzWPzo?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 561bc921-3339-4d53-dd01-08dda9cb9fa7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 16:10:17.7930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1P223MB0410 Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Donnerstag, 12. Juni 2025 13:25 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > variable scopes > > > > On 12 Jun 2025, at 4:26, softworkz . wrote: > > > Hi Marvin, > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf > Of > >> Marvin Scholz > >> Sent: Mittwoch, 11. Juni 2025 22:42 > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > >> variable scopes > >> > >> --- > >> fftools/textformat/avtextformat.c | 15 ++++++--------- > >> 1 file changed, 6 insertions(+), 9 deletions(-) > >> > >> diff --git a/fftools/textformat/avtextformat.c > >> b/fftools/textformat/avtextformat.c > >> index 14779e6f0c..f1811abb1c 100644 > >> --- a/fftools/textformat/avtextformat.c > >> +++ b/fftools/textformat/avtextformat.c > >> @@ -101,7 +101,6 @@ static void bprint_bytes(AVBPrint *bp, const > >> uint8_t *ubuf, size_t ubuf_size) > >> int avtext_context_close(AVTextFormatContext **ptctx) > >> { > >> AVTextFormatContext *tctx = *ptctx; > >> - int i; > >> int ret = 0; > >> > >> if (!tctx) > >> @@ -117,7 +116,7 @@ int avtext_context_close(AVTextFormatContext > >> **ptctx) > >> if (tctx->formatter->priv_class) > >> av_opt_free(tctx->priv); > >> } > >> - for (i = 0; i < SECTION_MAX_NB_LEVELS; i++) > >> + for (int i = 0; i < SECTION_MAX_NB_LEVELS; i++) > >> av_bprint_finalize(&tctx->section_pbuf[i], NULL); > >> av_freep(&tctx->priv); > >> av_opt_free(tctx); > >> @@ -130,7 +129,7 @@ int avtext_context_open(AVTextFormatContext > >> **ptctx, const AVTextFormatter *form > >> const AVTextFormatSection *sections, > int > >> nb_sections, AVTextFormatOptions options, char *show_data_hash) > >> { > >> AVTextFormatContext *tctx; > >> - int i, ret = 0; > >> + int ret = 0; > >> > >> av_assert0(ptctx && formatter); > >> > >> @@ -202,7 +201,7 @@ int avtext_context_open(AVTextFormatContext > >> **ptctx, const AVTextFormatter *form > >> if (ret == AVERROR(EINVAL)) { > >> const char *n; > >> av_log(NULL, AV_LOG_ERROR, "Unknown hash > algorithm > >> '%s'\nKnown algorithms:", show_data_hash); > >> - for (i = 0; (n = av_hash_names(i)); i++) > >> + for (unsigned i = 0; (n = av_hash_names(i)); > i++) > >> av_log(NULL, AV_LOG_ERROR, " %s", n); > >> av_log(NULL, AV_LOG_ERROR, "\n"); > >> } > >> @@ -525,13 +524,13 @@ void avtext_print_data(AVTextFormatContext > >> *tctx, const char *key, > >> { > >> AVBPrint bp; > >> unsigned offset = 0; > >> - int l, i; > >> + int i; > >> > >> av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED); > >> av_bprintf(&bp, "\n"); > >> while (size) { > >> av_bprintf(&bp, "%08x: ", offset); > >> - l = FFMIN(size, 16); > >> + int l = FFMIN(size, 16); > >> for (i = 0; i < l; i++) { > >> av_bprintf(&bp, "%02x", data[i]); > >> if (i & 1) > >> @@ -571,7 +570,6 @@ void > avtext_print_integers(AVTextFormatContext > >> *tctx, const char *key, > >> { > >> AVBPrint bp; > >> unsigned offset = 0; > >> - int l, i; > >> > >> if (!key || !data || !format || columns <= 0 || bytes <= 0) > >> return; > >> @@ -580,8 +578,7 @@ void > avtext_print_integers(AVTextFormatContext > >> *tctx, const char *key, > >> av_bprintf(&bp, "\n"); > >> while (size) { > >> av_bprintf(&bp, "%08x: ", offset); > >> - l = FFMIN(size, columns); > >> - for (i = 0; i < l; i++) { > >> + for (int i = 0, l = FFMIN(size, columns); i < l; i++) { > > > > You are changing behavior here because size is changed inside the > loop. > > The pre-evaluation into l is intentional. > > > > I fail to see how I change anything here though? It is still just > assigned before > the loop runs, just that l is scoped narrower? This is the original code: l = FFMIN(size, columns); for (i = 0; i < l; i++) { if (bytes == 1) av_bprintf(&bp, format, *data); else if (bytes == 2) av_bprintf(&bp, format, AV_RN16(data)); else if (bytes == 4) av_bprintf(&bp, format, AV_RN32(data)); data += bytes; size--; } See the size-- ? Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".