From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DCE2042834 for ; Fri, 7 Jan 2022 22:20:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BBB9168A962; Sat, 8 Jan 2022 00:20:23 +0200 (EET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07olkn2064.outbound.protection.outlook.com [40.92.43.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22A656804D6 for ; Sat, 8 Jan 2022 00:20:17 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eMGOgPNBbU68GMaemcF0pX2F6IFf4lSyAEt+R+HsZ26CfSdejDhHrS8Hcxs8nyWPTuxI5t3JCeiIwY29cYd8DWsOZ1U8QQlDtM9KZhd3NLq/nNhn/dpNg0zSyPYyZhA/Vk0R+HHMRYMiRCaxRcx/e5jIk1dT0Z8yBp8PEpm8QTDvifvlIoLZiz37/+zLRAguomFl3iHGeXHUcriiZGZteIJ/4otxdxEzGENKt45PjhPoiqniWDIdoMQeSzMTGRHu3NB3yIM6d837lnaqkHzbLHV8jm5EUfJsoggtvnXsvdf40fqrxtrYyCMVBZb0eX/EdOtz8RfRsgUyZTfacSH9Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6KfaD9XH8Iv2OaB7A3XG5sqdRGOAZ+RfTP/yfYlmE4U=; b=B0GZ0jTEOqiE+X/S5/Cct2dqXrsc6BUtAcqsiFuU8OZpxP1o+WZh64NXT9JNOGit8DVhRqLotJpw1nOmRPQPuX+FL5a41urF6A9V73xLGGxjlEvIctiBEtt5IayjAlBHWlTspuWNsqjfHnwoteq0Dgbhz/JJ7IZc8SbfZELGvnX+aFVc5vnN0rxyvTxjxs9q56EPJaMw5XTxkv1P6fGm/KksDYeK2ai5arNbGPV1KtlSRY4vSI7Q5/rpdsZTCImbq+qjebkC3WNXRlpl2OrgQOUYbvLvuMBnzk2E6d25X9fWw2BXy+rNz661edK+dzDclMeSRYvIZ5J9EygJ3JBvqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KfaD9XH8Iv2OaB7A3XG5sqdRGOAZ+RfTP/yfYlmE4U=; b=YjIxM8IZGsgjHGK2gKHB3pA5p5Nd24M7lw1nX4hKDIJ/qkmgXX3MXwLcRXSRyA0e+0OTSRe2RMlAb/SejYR1jJFU2Wyf4a3LQoVjM2xwXLjpXzXD/wUt41nXNtgO5VsbYrF2+9QL4qu5kQxEtWmwczrB+J9eKoxNTDEpmUE7Gpyyi9zhtd46QuXce0A153eYOfcDshrDm1x80Tdw0oOZQ0i3rspTiFU0uHV6dWZEqgCdEbpDIkXTn0scJdlHxhtqXcsFsjuvFnpy+zp29Lo4zOJcrmtHfGjLZrvb47Nk26sjk4xfuND9ZOHr4RikSl8/wv+gnsR8D0WS3rBwLT6z6w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0046.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Fri, 7 Jan 2022 22:20:15 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%8]) with mapi id 15.20.4867.011; Fri, 7 Jan 2022 22:20:14 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define Thread-Index: AQHYBADKYpheftzI80ShXywzU5s5VaxX+mxAgAAfeoCAAAOcAA== Date: Fri, 7 Jan 2022 22:20:14 +0000 Message-ID: References: <64b6a71c-ff36-1218-448a-186a729be62@passwd.hu> <6caa272d-584b-715c-e89d-6e47982b5a2a@passwd.hu> In-Reply-To: <6caa272d-584b-715c-e89d-6e47982b5a2a@passwd.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [AW8y5iDW6CFgl84mle7tS9d19G090jpg] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ac3acf4-59f1-4b1a-5d2b-08d9d22be0cb x-ms-traffictypediagnostic: DM8P223MB0046:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jihpe9bjf+R8RTG3l6TDuNXJtUtyVJE3LGMoa9w/pBLKXKmH6DHgruDW8melilXfQcuTYPXxll+1HAs/gxHCJdwzOGqLEUWgjyqSj1uZ8HZj9+Ul+CAJFSeizhTrgNafqyA8m4SIE2x/zRWwJUxh0vF2UfomVBE8Qf8IZJIOlmWks/CIy1UfTg+FYg2h0gA8vGdp/fhQq90CQ3Vp0uSS4jkTwRE/iy4wQATh1yeRocB3vjmOK8b7M7fYpLlDHtP100y2uV+VOiHRI/koN0f4201S77yaiKGorzsmatOTCStxczaFWL3919ZoLEkhJhIrMYR+c+syYdWVLhHTqbNoa1sVSNen6APn6Am1zfda4NbhE217iyE7DFt83tv/gGIZfnv4Ms2Oj5LD7pdY2w/4SVhTm1OgdycsAqToIV9Ebr4cWQfDyZ2NxeSMgGNBUdRryo21ZzL+B7tenAgS9I8xzcLSW5hSwfoSzFuRwcJRd6DNVmcs1FpBppqE8c6CimPRTAqID05atJpLvO5YIHXsPftbK1g1VN/+u+3kGrxOygNi9BKlNT6MgW6i0R3l8RzpNBWDOguNfpBZlE8TJ59LoxYUYJtyGfFcEDUelCZl+DD6a2I6WSaWhshaKMMo9jDMAIb85mBqd1E6QudPxQbzktkkjGp6bX4m6hFMfO0FPgU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z1BLV2xpZjhwcmcveUtLdXBodXBqWmR4Rkdid2xLU2F1eWJaU1paSm5DWTJH?= =?utf-8?B?eEZqNnNMaENWcFFDUUEzdU5qN29takRzdi9TN0VWcDllSjU0OGFOSWJGWkhU?= =?utf-8?B?LzVXVDZqL1VDVE1rSGN5L24xSER3WWNpdW80dTB3YktXOE5MY0NCSlVZSUt0?= =?utf-8?B?TlhUSEJmVVc5YldDT0RGQit2SnV2cmxDeEZoQ0oyWTY5T3lVNUxua3IwZTBo?= =?utf-8?B?S0dhRnB4ZzVlcWUxNTlXOVBCVzZERUh3aFJHL21NUVYva3RPMEpLcTFHajN5?= =?utf-8?B?WWdLc1lMYmRmQzh0S2lpVlNleDdUSzF3anlodlZYLzQ3NkYyM0dTUWpOR3l0?= =?utf-8?B?MGJ6NDFsbng4dVpmcmRzUVlUQ3JzcTlSOGF2SjFYeXVRcExiS1VsdVVzOENl?= =?utf-8?B?TVRPdllIS2ZibHdBOFRrWnFiQ3U5dUFEOURMRFl3OG9vWkx5MTRVUjc2a041?= =?utf-8?B?K0dPNjJXNEowNE5RSHZUK3pmdkxhUzZXdmgwQUt0Mll4KzN3ZXpYamtMdDZB?= =?utf-8?B?RmN6SzV3bEpQWGsvdCsyZjJ5ak9sYi9UUmxpWXRmazZYS2dwYnlSeFRMOGIz?= =?utf-8?B?S2ZxS21CQm0xUzZNN3VYM2ZLSktsbFYyM1A4Nk9YSmNLMHVhVmNPcjRoeTlR?= =?utf-8?B?SnRNVWw2Q2F2YkxPM1BsaE5yK0REVDNNR1RWNmdnRDYvWWxZMVpldWhuUHB5?= =?utf-8?B?Ri9KV2RkVUhVR05NZGxETnFyT21CSUs1QnlCSlViUDZoZDFmNlBTUGZuSkNB?= =?utf-8?B?ZGsvM0krMTZCMDkwTEpYVUZrR3BXczNHK2luc3pqbkE4bjZFSmZMTkV2dzNI?= =?utf-8?B?NmRhZHNIdVJZb1ZKdkpNcENUMjYzRkdTVWNuN3ZpNXFSMVk2QWdUOElCT1Y4?= =?utf-8?B?VXdHZjREdUE0WXVNRGhwV3hGalBrcnVVWkd5bHdxbmxHbDBVT2hHZG1zYlF3?= =?utf-8?B?aldqN2FIVDlMK3RPOC95akNmTERYT1ZLNkRNUzEwM1VMeWl4dVZCUzc2NUFz?= =?utf-8?B?WDVKY2tDRitDUXdFbVNETXRqdjRncmlpVE0rcWFTSTcxTkhMbW5hS21lWWYr?= =?utf-8?B?ZXg3b2tDYnd4Z1d6M01UTE54dEl4c0tCMzl3Sm5FNlFtT1JXU2x0WjYxd09W?= =?utf-8?B?cjBhTWVXV3RxQkR5YjB1VzE4RTRMbktCdnI4WEtNT0ltb1lHK0tJRXRNSkxr?= =?utf-8?B?ZEQ2UW1neHFxNlU1WnBic21yWXJJeXZRbkdyaTRGdXU1UVZWMU90TGoyN2xh?= =?utf-8?B?OEZBaTFTbk9Idm5OVGF1eWx5Skszb1pDalpWd2RBSk80d2p4QT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4ac3acf4-59f1-4b1a-5d2b-08d9d22be0cb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2022 22:20:14.5872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0046 Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Marton > Balint > Sent: Friday, January 7, 2022 10:53 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't > dump images to disk based on DEBUG define > > > > On Fri, 7 Jan 2022, Soft Works wrote: > > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Marton > >> Balint > >> Sent: Friday, January 7, 2022 8:57 PM > >> To: FFmpeg development discussions and patches > >> Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: > don't > >> dump images to disk based on DEBUG define > >> > >> > >> > >> On Fri, 7 Jan 2022, ffmpegagent wrote: > >> > >>> It's annoying and unexpected, but still useful at times (as I've realized > >>> just recently). > >>> > >>> This is a follow-up to the earlier submission here: > >>> https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > >>> > >>> There has been a comment from Anton, questioning whether the dump-feature > >> is > >>> useful. Meanwhile I came to the conclusion that it can be useful in-fact. > >> It > >>> just shouldn't happen automatically when DEBUG is defined. That's what > >> these > >>> patches do. > >> > >> Well, I kind of agree with Anton, this a debug feature and it should not > >> be added as an option, but simply should be removed from the codebase. > > > > It's not added as a regular option. It's an option that is only available > > when you compile with DEBUG defined. > > Ah, OK. > > > > > Isn't this an acceptable compromise? > > Well, I am not a fan of leaving DEBUG chunks in the codebase to be > honest. But if somebody applies it, then fine with me. The code exists in the code base for 6 years.. I was about to agree to the removal, but just few days ago I was glad that I could use it, and it might be useful in the near future in the context of subtitle filtering for troubleshooting. Also there's a bugfix patch where it could be useful: avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles https://github.com/ffstaging/FFmpeg/pull/16 https://master.gitmailbox.com/ffmpegdev/pull.16.ffstaging.FFmpeg.1641262759164.ffmpegagent@gmail.com Eventually, I'll submit a 'dumpgraphicsubs' filter for this purpose, and then that code can be removed anyway, but for the time being, I think this PR still improves the situation (no dump files written to disk unexpectedly), sufficiently enough to merge it even without a full removal. Thanks again, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".