From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2EC9A4C577 for ; Fri, 7 Feb 2025 12:03:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B3B068BDA4; Fri, 7 Feb 2025 14:03:26 +0200 (EET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2109.outbound.protection.outlook.com [40.92.20.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EA3F468B72B for ; Fri, 7 Feb 2025 14:03:19 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qnPV34inPT04cjaepwGnP9FKeFPJ8l6HvnDZb/uMqjTrbuwM1YapSxuayxzoWmqTRxDraqlDhxj1IAXNaeEbnjYeqyQM+irVotTH+ei7YVq+vx5XOCYm/TXVWEzeQsYg/VgVDVPmjxo8dk81LPa9m+cEX651C6meoR3toWwaW1e2n6IRSYF7q/eLptgrf/hTyUXcJbaarxXQe35byHMHNfubAKYPsJApAPIXshMfElQWwP4tIF+hpwdqUKNZWLA3ovrbaOIQR1l4oMkcKC/q5OIstctIkbTAdWrWV/4lCp8uvrD+9T80E5dOsaWPZVcy/zvwxs3LuSbjxrywEHNj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrPqQ1/2gxFDFCa816M9IN5HUp4GZT5LNUCvhB6fXh8=; b=twRPvebT6GhOzpDF9U38sOvCqIzR7No7ihtvond8zsk2Rbp2pCySTHUZO815m4ib5DuK0SnNYqmIJVFkf4Bow/J799uoCn+rUM/OrPzdUV4T3sC+hgXVDWmWx1pm9rCUwn3WcuZlti+e4e+tMi8250+LoKEdG0Z252S46osN+qfMNdjPeUjtL2TFUJElBVi6ooDU1GHOcI4ep4uxX6TZPdgAHvc7SnWiU6ihil7ShyvMyo2hNntye/MOI6rfOeGfMjNThcnqTJIn5ambgXaTTveLov0hSJZB/yRWTT+Nn8Cd0JOMFJmZlWnXiMRzse4NrNcuHjwXaFddMfMKEGNhmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrPqQ1/2gxFDFCa816M9IN5HUp4GZT5LNUCvhB6fXh8=; b=hEPK6Pj1ijqrt2foiKBEZhtuFYfPG7dLL6nB29i9aZzwxzDUFCvEHrl22LtdavnaShh9RIfr/yBAWHBctevK8NzXEXvMHpJd3LKzMrKuBW2nUXWEGGLaH4IKIe+5bSXfT4pUZOB41DL/gZ6Lszzk/YKPSAxKJBDFXYOF67oAaW0iesDb7i7tWtZA17CUi1womwg8KP6AghbhdK8+mIGVtdGHFzURAtZVk0n2FzVrXci7ynZJEVgBdRQyPKN7NKtjftAtO9mwvtl2W90LYfZosrHF/svlE5ca5+849/ylyJQ5e4lil8c8ilvwpxXn2YJ3bSzdXd2JPZiDriOrxLVuNQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DS7P223MB0503.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:99::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Fri, 7 Feb 2025 12:03:16 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8422.011; Fri, 7 Feb 2025 12:03:16 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags Thread-Index: AQHbeTXwerC42Ouy1kiVtWD9N2hrjrM7p4EAgAAHkUCAAA6agA== Date: Fri, 7 Feb 2025 12:03:16 +0000 Message-ID: References: <63ab3a941166604541ce91cc37137edef4cbac93.1738915048.git.ffmpegagent@gmail.com> <2bd0c238-546d-4cb2-8778-e9d6f658fa3a@noa-archive.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DS7P223MB0503:EE_ x-ms-office365-filtering-correlation-id: 87b411e0-6bd4-4efd-4c29-08dd476f67cc x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|461199028|8060799006|19110799003|15080799006|7092599003|3412199025|440099028|12091999003|102099032; x-microsoft-antispam-message-info: =?utf-8?B?K0hNaUhKMmpxNFlUVllhUFpiWXh3Ulc5UUhMbXdKMFN6ektFZlZ0cmhaZmdv?= =?utf-8?B?YUFEODFaVno3a2FXa2VCcXRoTTNZU0hRcG9INFZxZzh2NVd2bGJBTUM2Y3Zx?= =?utf-8?B?RWZBcWNXdTlIVXBGSGJHb3ZXYmlIWHhvNXpHSzNuSG5FdHlxVUJzd1FsK2FD?= =?utf-8?B?T0RsVStVRCt4NVN4TWhkQmR3RDFYYU1SS0NuY3hQVzk0V0oyM3pRTlRPWGtI?= =?utf-8?B?OFdGQUJtL0pCc1lyNXhpK1FjVTR5dlVCc1hxbjkrOXRiWklnTEZTRlZkZU5n?= =?utf-8?B?NExMZE9RcERCQ1cxR0xpRkxKcmY1dk1hc2hrQzlpQ3kyU1NERDBXVUUrWlI4?= =?utf-8?B?ekhCRlFJem43WGRoOXFWOFljRzZlVG9ZaGlzZlFxOTVvSDdlMW96NWE4V0N1?= =?utf-8?B?VW42dXE5aHI4NlljRFpPd0Y0cjVwL1I4WmxrZnVDSS9OWDNERjVYSDF5UnJH?= =?utf-8?B?NTE5cy8yTUE5RkZpeEdSc0k2Y3BGQ2RsVlhSRWtjV0c5Zy9Lc1I1N3R1NUlL?= =?utf-8?B?c1NqQmoyZUdqNlJxSDA1Y2Z4YlBiMXJkekV5cnVNRlhwNkdYRDhjcm4zSXBG?= =?utf-8?B?bG05OEtiVFVjQmFrM1M3MkxWRVozeWtnTmQzaURtZ2l2c3VWdnNLTUVNVG1y?= =?utf-8?B?MVZGOE9oQWxSa1ZaL1dkcVlWWDVYNzJTZTRpR3YraWV6SU5HdlhicE5nT1Vj?= =?utf-8?B?eGpUSjNnZTg5V3J3Q0s0b2ZrQnE1a0lwdTBiMlFVWGlhQ0UvL1Nld3B3alFh?= =?utf-8?B?VWsvTW9jNmFQS2FVdmhQN292V2NVUFJYbmtDS1VUYUVmdVRoOVJXcGlSVHpk?= =?utf-8?B?WmlzanFVQkY3cnJnV3I1bExsVTh0RVFvKzA5eEhnTUxtM0xFMlRUQVNtM2w0?= =?utf-8?B?V1RYUzNPVVQwRlRIeWgvaWVLNndKaUhuSkVKRGMwaTcvREpYazJETm1ITGRa?= =?utf-8?B?M2hNZVdaSHJxOGllNS9nWjBkV0NESUR4WXNJemtmUUo1OXExUE1nUFl3L1B4?= =?utf-8?B?VmI1V25pRUpRdU92b0FTUk1rdSttM09haFZ0cDhKYyt3WXdDOG1GeWQzdXNs?= =?utf-8?B?QzFtODhqY0NJblFCVzR2ZzRhZko4eW5JdWhTdUs0TGpwWnViQS9kU3A1bUdM?= =?utf-8?B?NGsveVNNbWh3MElMNFpVZHZJZHo1V1E0NmVXREloSUNTUTFGVVpKaGFMdHI3?= =?utf-8?B?QjQ5V2xONVU4UFhvWFYyNUtZbzZwMkFwdlJ1Yk0xZlh2cE1kVXpyQTFpQjhx?= =?utf-8?B?VS90dGFVb3UzNElDQWZhS0RiTDZmWXpFTjA5QkJNeGZudE5Bdy95aDYrOWla?= =?utf-8?B?UmlZMmR2TGV6cEZXZ2ZBcTk2dVBSQUY4NEROOHMrajh4UkUwc3NpeHozMUs2?= =?utf-8?B?QUpROStZdmtHNlVSOFk5SVo3RFh0L1NOelN4dmZrTWljeGZzdUdURGE1TnB4?= =?utf-8?B?Ni9yeHpndHJtaG8vcHlLUzlxRVZiSDdhWU5TZ0hSOVI1WGlOeSs5MGErTFRs?= =?utf-8?Q?XzT0Ec=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TEVjQnQxR0kvZ3p2VXZXcWhkV01yL1JqS2w3T2NCQzBEOU4vYlpQMTlHNEk3?= =?utf-8?B?VVlERkZsb09TUFdDaURVcU9SR1NUZE1HUXhCZnN2a0F2TXYxY0tQVEpMY1V6?= =?utf-8?B?VWdQTjlpdHdsU2FSQjdORGtlNXJUSFhHbEh4L21FaEdnQ2pkNUxVMTVGTEFq?= =?utf-8?B?YnM3dkY2OEFxVWpvS2IzRUQvYjFWZnc3ODB5MEpHSUlkWkxQWTRJMU96NjZJ?= =?utf-8?B?M2liMVlOOEx4QnZSTmxJK2hsUS9GVWRyamRvWXp1emxSbUtHdXdCd0VjVkdY?= =?utf-8?B?MGw4Z1hmdlBNL2hCLzM5bGRwQWFMZUtobnlHQThKOHRKQWxnZkNSRGRmY3Mr?= =?utf-8?B?SU9jdEkvejQwaWVkOGcyd3draFN5cko2b2M1S1FyRWowNERHaVBnR09UdHN5?= =?utf-8?B?UjFVaXI5ZzZiak1WV2xmOEJScG01T1YwZUJxV2hFamdXM0IvMzdOS2FtT2RV?= =?utf-8?B?UDNueXdyRGRTcnFhOEdQci8wb01uaVNkRmc1RGhHbGxxMXYxZ1FPOVpleFB3?= =?utf-8?B?SVI3OTVqTlVSdTVIV3ZHOE5xYXBKUUxoMWlGK29SbVF2MTNSaHFNWWRxaHpU?= =?utf-8?B?VjkyQ1NIcEE0L2laVmc5VlNIa1VTRTNxK0k1b1VkanpGOENpbGcyellBRkJa?= =?utf-8?B?MzFRNFRvZ0d3enVoRXA3cWJXTUVSTjh1WExnSUhNdWlaWUNCUno3Yy9xZFVj?= =?utf-8?B?MmE4aWsyU0J1MDRLZzVWWmhwdnhjOUhVWmdoME4zeFJuelB1aGJHbExVbUNE?= =?utf-8?B?Z1lRT2hwOWFKdE5COVZtV1dzbTh0WFE4c1gxbldraEhnODM2Qlo4ZzlkKzRN?= =?utf-8?B?MitUS3hEeG1wUkY3a0Z3ekkrVC9QOU9ja0FaNCtxTkpqWWFSaFdwRjY0Z2VI?= =?utf-8?B?blFJM3FiZmYyemlGMEhIQlI4TVlNWU1RS1BCcm9WWjlFT01mWHNzdnNEeTE3?= =?utf-8?B?aU9jMlJjaCsrY0IxeW9FWDB2QXBQYmNsZDB1cDB2RWVyVmJvRnZUREFidkts?= =?utf-8?B?V2NJWGdvWFVxTVVRR29XSUIySUt2S2E0MVVSTlJvTjVSdTE0TURicFArb1Iy?= =?utf-8?B?MU43TmNFNHBCTFBBNDVUaDFRczZLQy81N2x6dzR1QzR5bGFKcHAvajI2VW5M?= =?utf-8?B?WCtMTVVYOWRTNE5aQlNzcExLS1pQR1dTbDBjVnNOUlpDQTltVjVPU0FZa0Jk?= =?utf-8?B?QThka1FqdGgraU5oaldDMTFldXlWZjhuNU8rV1hYTmpibVNuTHpZUWxuYzgy?= =?utf-8?B?SGlSalVDQitDUzdnVlE5NFAyQjF5U1EzZ1JHUGw3ZU9CUjdTTFpwMWw0MFpu?= =?utf-8?B?VVFoajVScDdpejlKTk9sSXV5SUVVazRmeERVQnptYXkyVEhWeG5ZczJnYUVr?= =?utf-8?B?eEFDSk00Q1dmRVZBenlFR1hsU2VkUTBoYTVzU2YrWWxjUnFJekNiTkFBenZh?= =?utf-8?B?RnJLRyszZEVoWWFXN0RCS3hDVW44b1IzQnJpOWRmSm94bW5WN0k4WVRiQ1pI?= =?utf-8?B?NTU1dS9VY2x6QnM5YXZxbmlDWUszUmhMb0w4TVM5OGZtaHo4VFN6cXNlbmRH?= =?utf-8?B?MmwxWnU1alpJUTVkdWR2RFdZMEJIQlVLYUhXbEM0RWRRM3dBcnAvcUs1MUJk?= =?utf-8?Q?+IHWUsxSkd1yg2ONQkuDBbIlCZGO1dc8EA5bRsTtsF3g=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 87b411e0-6bd4-4efd-4c29-08dd476f67cc X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2025 12:03:16.4599 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7P223MB0503 Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Friday, February 7, 2025 12:27 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Tobias Rapp > > Sent: Friday, February 7, 2025 11:42 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > > time and datetime log flags > > > > On 07/02/2025 08:57, softworkz wrote: > > > > > From: softworkz > > > > > > This commit adds two logging flags: 'time' and 'datetime'. > > > > > > Usage: > > > > > > ffmpeg -loglevel +time > > > > > > or > > > > > > ffmpeg -loglevel +datetime > > > > > > Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents > > > timing to be printed when exiting. > > > > > > Signed-off-by: softworkz > > > --- > > > fftools/ffmpeg.c | 1 + > > > fftools/opt_common.c | 12 ++++++++++++ > > > 2 files changed, 13 insertions(+) > > > > > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > > > index dc321fb4a2..f4c717afaa 100644 > > > --- a/fftools/ffmpeg.c > > > +++ b/fftools/ffmpeg.c > > > @@ -130,6 +130,7 @@ static void term_exit_sigsafe(void) > > > > > > void term_exit(void) > > > { > > > + av_log_set_flags(0); > > > av_log(NULL, AV_LOG_QUIET, "%s", ""); > > > term_exit_sigsafe(); > > > } > > > > If I understand the purpose of AV_LOG_QUIET correctly the correct > way > > would be to skip writing time/datetime information in the log > writer > > itself (part of patch #1 in this patch-set) if level is <= > > AV_LOG_QUIET, > > rather than clearing the flags here. > > > > Regards, > > Tobias > > > Hi Tobias, > > my understanding of AV_LOG_QUIET would be that when program code logs > a message with that level, it will be printed even when the user has > "-loglevel quiet". > I would wonder why such log messages shouldn't be prefixed with the > time (normally). > To me it appears that the special case is rather the log invocation > on exit which prints - well: nothing. > > I'd rather question why it is not printing the log level for quiet. > Is it really intended or was it only done to make it possible to > print this empty message on exit? > > Do I see it wrong? Then I'll change it of course. > > Thanks a lot for reviewing! > > sw > Hi Tobias, what do you think about this? if (*print_prefix && (flags & (AV_LOG_PRINT_TIME | AV_LOG_PRINT_DATETIME))) format_date_now(&part[4], flags & AV_LOG_PRINT_DATETIME); if (*print_prefix && (flags & AV_LOG_PRINT_LEVEL)) av_bprintf(part+2, "[%s] ", get_level_str(level)); av_vbprintf(part+3, fmt, vl); if ((level == AV_LOG_QUIET) && part[3].len == 0) { *print_prefix = 0; } else if(*part[0].str || *part[1].str || *part[2].str || *part[3].str) { char lastc = part[3].len && part[3].len <= part[3].size ? part[3].str[part[3].len - 1] : 0; *print_prefix = lastc == '\n' || lastc == '\r'; } (plus removal of the flags clearance ofc) sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".