From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A27444332D for ; Fri, 1 Jul 2022 21:20:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D77F368B7FF; Sat, 2 Jul 2022 00:20:05 +0300 (EEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2039.outbound.protection.outlook.com [40.92.45.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F3C5A68B7EA for ; Sat, 2 Jul 2022 00:19:58 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhbvD15dMecncdZbP4PpLHRV+Evfa2Yxiox8EJ1shu2+PZTLCjQGbVdYC+VU1fYaOfAOQmQSab81xXj5Vuo9sqvyIIAiC41XhstgE59jge4GW3GOKnlFfh34OglNGHShhkHkqbL2cciWQ43nJUJ8qSkgeGbYIwGPGovTNkTWJBuCoopWH2yUkpbLV8Kev5kYtQoAkJiz1WMiA/AHQIXKAt7ZvUAsUX0L7238uV9tigW6qyUhfTMAKgJ8qxUF84qJS+m04i/YS3PpF3RjPDRkUqBXYp+8w0d4FNwDLcxiFFvDlx0xuU/M1M4YgW825aSFrD+2SVdc1zLcveW7KVOz5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s1gW0u23TkTIE0ejYCwGQFFEnxiQd9CHlO8OXdSKkYA=; b=k4hsx0eM9SWwBUSe/4X0kC+CrfYeF6Um+2rUv0eeag/ZhX+9C9crprjvG9vg4dnYeKhxQnACMrwld8HIaabPFEHF2sVsNDqHDvzPceaeU4RIdnXmMlhvsGqpjjKBwc6HL1buwFgO/lH3pkh45sBlZZS0Sil6XRvXlChi1FuLxu3nGSvneb/Sv8+OEmG36f/54i//Y2x20IL+Fki0WKtAQ6E3BfXJBnrXgo6eUpwyeP1wksVcYX7NsBgpptcCicvnn30ZmeOqBrdPeKxPmS//H/rHv0uqaxjIcDsIqViJMyjDscO0hKZva/EuveYmKgpRdqygr0mUIFt/bK6I6mdPbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1gW0u23TkTIE0ejYCwGQFFEnxiQd9CHlO8OXdSKkYA=; b=RlJmPVB8XnEmUmyiCb0AmyypQHlFFR1zMXKV6xHJ4LHaQmfesSS6G8JrtPQWSBALrTip06c88tQlI/tj6eFwzD16p8ByvFnGhEfb+H3DV7jtbe28U3LnI7OUGbFWa4FK1ocun/NzZTqzoC7G3uhxDtZqlO13dzrXUA4En5YOL91VSjGiHWBeNVyKMSohHRnwI5zBz5kkx62tQgzyfNPW5lLxIxOLMZTkcr9dKnUXK3QaK0VqGLvyV+b4owMECAiSyBCUY6xT3zzpsNcGNT8a9/fPmQxwCdKvT1VJrfoTG+V3AN+01HAnSJLUShfrD3Mm4E9WP1xm/ih6uiQv9J6sCA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM4P223MB0520.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:a9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 21:19:55 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231%2]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 21:19:54 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb() Thread-Index: AQHYjQzoPVd3oe7NoEycv9A+6rgNQq1qBRxw Date: Fri, 1 Jul 2022 21:19:54 +0000 Message-ID: References: <20220701053434.2137992-1-wenbin.chen@intel.com> In-Reply-To: <20220701053434.2137992-1-wenbin.chen@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [fX9VsKr9XzaOIPX8vzDALerWiWZGGh2v] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13209e76-f239-4824-8c5e-08da5ba7714f x-ms-traffictypediagnostic: DM4P223MB0520:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZJYV087/ApNjHQ9JyszUCLokecQ1Wvs06wNn+8ROcXaYqFia4Q7OYzDsCoNlXQF2t/Rx9N8ZteyX8kDPmxRTaC6LvTj/WiW2jMirRFu9u/JdoIa+Ebxg6mzCgxMdFLNNMC6mtk1J8zXm/UlXYPVl93CjBNhAUA5CQvpO8+IhI18XvesFmu4mWmC+WaaaLnW1SdVcDg2Whfn+ju8s5fAj+ONDXTJ151hXSM8/B25uN5ViCRxLPi/X9fgaS0gfTUVgLExI7e43AS6hs4y1tqN6/3bLNAfjhs99eRvISySVFVVKzla12P/g3qpVY+wQsmbC8Scb8xIB/qoJ7MSuyT983g3RULzfK2Vc2AUiLUJqpkRU2SORadkD7cdsadmpgoXcqvyG5zSuz6AkI3CHwUVuIqTAZuxk77/8DOHR8FfB2C43diqicQbVjORW58nXCFk+vtHh1kiBnLrxSemqxl1VJNSOY3hRDfuw+hUaNB8IBkiNpbH8UVlrLl30U+UUI0OhPuOW03lGMiZR+CrJvqHgGcIXTPTtn6XRX3zfcAXjwEulkg3nQ8XqHpuJlx+aODw7D7Bk1Mxie4k7c27fJjWSFoFTOyNV65TpUntVxAza5ns3EjME1wx8JjXwHnwcQA2hIqIeS5m9CgPB3DBrsgy/GA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bncxYjhURVBRS2JOQndFN01neUdYdW9YaUl4ZHNJc2dLd2JwTXZSMXp6cWlO?= =?utf-8?B?dU9RYmR4NlFGNjE2VnVwU1dLc1B3WUJQTFhLOUFWY21Vc3hac0xMbmxHRG9R?= =?utf-8?B?NjAvMStKbi9VWlE3ck9ja3hjUFdoZDhpcGJoOXZkMXkwMkQ3bzcxeE9MSVZG?= =?utf-8?B?b3YwU295UGIvYzBCdVcrZFFuYmdJdzJnWkRQenBaaVJ3bU5mbFRoMUVUWUFH?= =?utf-8?B?UTI0QkpYUCtRNEhnNU9lb0dweGtINjdhUm12WWRnZGRvRWNjRWJsd0NtRVRU?= =?utf-8?B?YTRxWURvTU4rQXpOd3BoYmUvLzJueUhHVlJqQXc1Ykt1ZXNReXBhV3FQS0NG?= =?utf-8?B?UDNTRzhLSzBEU0dIdjJzNExmcnFJSlk5c0VEQ0tsbXBadUhFdnpiTERIUU5G?= =?utf-8?B?YUxGRDV5OEVoM2xIMU5XMGdDMWptZTdHWWZIQkF2NjM3VUJrWmN2NHgxcUdB?= =?utf-8?B?TWpmNENISXU5WHdzR3haYXR0bms1QmcvL05OU3hQVWhpSmhRbHRDOVloY0Ri?= =?utf-8?B?cFhQMlNkYVFQeU80b2xuYXV6aVFVbGllNkhxMWgvaU1vdk1DRWRhMENCUTR0?= =?utf-8?B?a3g2VXluRi9HVjNESU8xSEMvaE02RGFybmxTMGVabEFmVjV6K3M3LzBFVUtv?= =?utf-8?B?bVI2eHVUVW1OamtmOWlXSFI2K2FYMndnL2dxQW5TWXV6akV6c2x6QnZSVUxV?= =?utf-8?B?Rm16L1NUWkhDVkY5c0ZNcW9VVHQ5WExVcGJFZWM1bi82TStrSU8zY0F2WW0w?= =?utf-8?B?TGpIanVDS2VhYUhROWdWWFlTRmd1cFJmV3NTRXhva0xRdkJGOE53Tm15Zyty?= =?utf-8?B?ZzNYa1V2SHhiNlpPN0dkMGJSczFSOHo1ZVlVUDIyZlc0VlpoRDNKYmFjZlFh?= =?utf-8?B?Qi9IdVF0NG1GckVWeWFOeGZ2YUd6R1lkTDcrdDBDSzNrcUI1UzlKTkVHNlVv?= =?utf-8?B?LzAwbG1DbWJUZlhaWTZyY3FTVHhJK29VdXpra2tUN2szU2NVVXB6VUhHTnhO?= =?utf-8?B?eXBTNi9nc2E2Q01mMzl5Y21rWWcySDZvdHNVRXV6WmZxNFdMNlhIWGdSdU5L?= =?utf-8?B?NW92bktSQWNrOVZBVHRzaEtHUUxxdGNsN2g1Nm5GSk1XVGZVNTVoaWd1ZUJY?= =?utf-8?B?ZGNJVHVzemltTEtBelY3c1BjN044S1ZsdHBXWHNLU1NiRG11Vk0yQS9tdHc3?= =?utf-8?B?RTVRS1R5ZitDcXVMa0prZjRSQy9BTHk3OHFScHlIYTIybldhSDU3VFRaRkpN?= =?utf-8?B?OXl3N05rZUp5a2dheEpSSGFZanY3a0xxQWhCWnpYWWFqazU4OW5QR2szRklz?= =?utf-8?B?U3ppZ25lMDk3Z21RNElPUVpIWU5vVXF4RzdWd0doY2hKMEdha1B6MTloZUJk?= =?utf-8?B?SnRwNnVXM3dzSUUzdVJxVjdsVkh4U3AzN1M1WW9oV3hORjlMMGtkdHNycEJB?= =?utf-8?B?Q3dhckJzSG8rV3hNS25JUEpBN2owOHN5N1lMZUxremVkSFEwWjFFd05MbWpj?= =?utf-8?B?Ymp0WVprWTZqdGFxU095N2lUVE1uZUZxRDJhcEhUNUNWWU1VOTViSE5xKzhD?= =?utf-8?B?L2RUYnJpRGkzOURHdStDZWFUYlVKSTJ1Nm9CeEFVRVA0NGk2TUh2a0w3amhi?= =?utf-8?B?ZitEc285TlEzQ0FsclI3aXFPQjJMQ1c4N21DUnVtQVpVL1ZmYkVtUUNGd1pY?= =?utf-8?B?T3NIVE0rUCtKcmlVZlh3ZUkwQlJBUThLOVMrOXlSTEowVGp4c2xQazFnPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 13209e76-f239-4824-8c5e-08da5ba7714f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2022 21:19:54.4738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0520 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Wenbin Chen > Sent: Friday, July 1, 2022 7:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a > chroma mb size error in sse_mb() > > For 422 frames we should not use hard coded 8 to calculate mb size > for > uv plane. Chroma shift should be taken into consideration to be > compatiple with different sampling format. > > The error is reported by fate test when av_cpu_max_align() return 64 > on the platform supporting AVX512. This is a hidden error and it is > exposed after commit 17a59a634c39b00a680c6ebbaea58db95594d13d. > > mpeg2enc has a mechanism to reuse frames. When it computes SSE (sum > of > squared error) on current mb, reconstructed mb will be wrote to the > previous mb space, so that the memory can be saved. However if the > align > is 64, the frame is shared in somewhere else, so the frame cannot be > reused and a new frame to store reconstrued data is created. Because > the > height of mb is wrong when compute sse on 422 frame, starting from > the > second line of macro block, changed data is read when frame is reused > (we need to read row 16 rather than row 8 if frame is 422), and > unchanged > data is read when frame is not reused (a new frame is created so the > original frame will not be changed). > > That is why commit 17a59a634c39b00a680c6ebbaea58db95594d13d exposes > this > issue, because it add av_cpu_max_align() and this function return 64 > on > platform supporting AVX512 which lead to creating a frame in > mpeg2enc, > and this lead to the different outputs. > > Signed-off-by: Wenbin Chen > --- > libavcodec/mpegvideo_enc.c | 29 +++++++++++++------ > tests/ref/seek/vsynth_lena-mpeg2-422 | 40 +++++++++++++----------- > -- > tests/ref/vsynth/vsynth1-mpeg2-422 | 8 +++--- > tests/ref/vsynth/vsynth2-mpeg2-422 | 8 +++--- > tests/ref/vsynth/vsynth3-mpeg2-422 | 8 +++--- > tests/ref/vsynth/vsynth_lena-mpeg2-422 | 8 +++--- > 6 files changed, 56 insertions(+), 45 deletions(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index d6a85a037a..c9d9e2a764 100644 > --- a/libavcodec/mpegvideo_enc.c > +++ b/libavcodec/mpegvideo_enc.c > @@ -2558,24 +2558,35 @@ static int sse(MpegEncContext *s, uint8_t > *src1, uint8_t *src2, int w, int h, in > static int sse_mb(MpegEncContext *s){ > int w= 16; > int h= 16; > + int chroma_mb_w = w >> s->chroma_x_shift; > + int chroma_mb_h = h >> s->chroma_y_shift; > > if(s->mb_x*16 + 16 > s->width ) w= s->width - s->mb_x*16; > if(s->mb_y*16 + 16 > s->height) h= s->height- s->mb_y*16; > > if(w==16 && h==16) > if(s->avctx->mb_cmp == FF_CMP_NSSE){ > - return s->mecc.nsse[0](s, s->new_picture->data[0] + s->mb_x > * 16 + s->mb_y * s->linesize * 16, s->dest[0], s->linesize, 16) + > - s->mecc.nsse[1](s, s->new_picture->data[1] + s->mb_x > * 8 + s->mb_y * s->uvlinesize * 8, s->dest[1], s->uvlinesize, 8) + > - s->mecc.nsse[1](s, s->new_picture->data[2] + s->mb_x > * 8 + s->mb_y * s->uvlinesize * 8, s->dest[2], s->uvlinesize, 8); > + return s->mecc.nsse[0](s, s->new_picture->data[0] + s->mb_x > * 16 + s->mb_y * s->linesize * 16, > + s->dest[0], s->linesize, 16) + > + s->mecc.nsse[1](s, s->new_picture->data[1] + s->mb_x > * chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[1], s->uvlinesize, > chroma_mb_h) + > + s->mecc.nsse[1](s, s->new_picture->data[2] + s->mb_x > * chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[2], s->uvlinesize, > chroma_mb_h); > }else{ > - return s->mecc.sse[0](NULL, s->new_picture->data[0] + s- > >mb_x * 16 + s->mb_y * s->linesize * 16, s->dest[0], s->linesize, > 16) + > - s->mecc.sse[1](NULL, s->new_picture->data[1] + s- > >mb_x * 8 + s->mb_y * s->uvlinesize * 8, s->dest[1], s->uvlinesize, > 8) + > - s->mecc.sse[1](NULL, s->new_picture->data[2] + s- > >mb_x * 8 + s->mb_y * s->uvlinesize * 8, s->dest[2], s->uvlinesize, > 8); > + return s->mecc.sse[0](NULL, s->new_picture->data[0] + s- > >mb_x * 16 + s->mb_y * s->linesize * 16, > + s->dest[0], s->linesize, 16) + > + s->mecc.sse[1](NULL, s->new_picture->data[1] + s- > >mb_x * chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[1], s->uvlinesize, > chroma_mb_h) + > + s->mecc.sse[1](NULL, s->new_picture->data[2] + s- > >mb_x * chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[2], s->uvlinesize, > chroma_mb_h); > } > else > - return sse(s, s->new_picture->data[0] + s->mb_x*16 + s- > >mb_y*s->linesize*16, s->dest[0], w, h, s->linesize) > - +sse(s, s->new_picture->data[1] + s->mb_x*8 + s- > >mb_y*s->uvlinesize*8,s->dest[1], w>>1, h>>1, s->uvlinesize) > - +sse(s, s->new_picture->data[2] + s->mb_x*8 + s- > >mb_y*s->uvlinesize*8,s->dest[2], w>>1, h>>1, s->uvlinesize); > + return sse(s, s->new_picture->data[0] + s->mb_x * 16 + s- > >mb_y * s->linesize * 16, > + s->dest[0], w, h, s->linesize) + > + sse(s, s->new_picture->data[1] + s->mb_x * > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[1], w >> s->chroma_x_shift, h >> s- > >chroma_y_shift, s->uvlinesize) + > + sse(s, s->new_picture->data[2] + s->mb_x * > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > + s->dest[2], w >> s->chroma_x_shift, h >> s- > >chroma_y_shift, s->uvlinesize); > } > > static int pre_estimate_motion_thread(AVCodecContext *c, void *arg){ > diff --git a/tests/ref/seek/vsynth_lena-mpeg2-422 > b/tests/ref/seek/vsynth_lena-mpeg2-422 > index 06d8f7ac3a..1fc2bf93a0 100644 > --- a/tests/ref/seek/vsynth_lena-mpeg2-422 > +++ b/tests/ref/seek/vsynth_lena-mpeg2-422 > @@ -1,46 +1,46 @@ > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st:-1 flags:0 ts:-1.000000 > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st:-1 flags:1 ts: 1.894167 > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > size: 19967 > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > size: 21479 > ret: 0 st: 0 flags:0 ts: 0.788334 > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > size: 22575 > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > size: 24774 > ret:-1 st: 0 flags:1 ts:-0.317499 > ret:-1 st:-1 flags:0 ts: 2.576668 > ret: 0 st:-1 flags:1 ts: 1.470835 > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > size: 21329 > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > size: 22845 > ret: 0 st: 0 flags:0 ts: 0.365002 > -ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 104454 > size: 28984 > +ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 108763 > size: 32204 > ret:-1 st: 0 flags:1 ts:-0.740831 > ret:-1 st:-1 flags:0 ts: 2.153336 > ret: 0 st:-1 flags:1 ts: 1.047503 > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > size: 22575 > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > size: 24774 > ret: 0 st: 0 flags:0 ts:-0.058330 > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st: 0 flags:1 ts: 2.835837 > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > size: 19967 > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > size: 21479 > ret: 0 st:-1 flags:0 ts: 1.730004 > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > size: 19967 > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > size: 21479 > ret: 0 st:-1 flags:1 ts: 0.624171 > -ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 104454 > size: 28984 > +ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 108763 > size: 32204 > ret: 0 st: 0 flags:0 ts:-0.481662 > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st: 0 flags:1 ts: 2.412505 > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > size: 19967 > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > size: 21479 > ret: 0 st:-1 flags:0 ts: 1.306672 > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > size: 21329 > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > size: 22845 > ret: 0 st:-1 flags:1 ts: 0.200839 > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st: 0 flags:0 ts:-0.904994 > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 17497 > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > size: 18339 > ret: 0 st: 0 flags:1 ts: 1.989173 > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > size: 19967 > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > size: 21479 > ret: 0 st:-1 flags:0 ts: 0.883340 > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > size: 21329 > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > size: 22845 > ret:-1 st:-1 flags:1 ts:-0.222493 > ret:-1 st: 0 flags:0 ts: 2.671674 > ret: 0 st: 0 flags:1 ts: 1.565841 > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > size: 21329 > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > size: 22845 > ret: 0 st:-1 flags:0 ts: 0.460008 > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > size: 22575 > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > size: 24774 > ret:-1 st:-1 flags:1 ts:-0.645825 > diff --git a/tests/ref/vsynth/vsynth1-mpeg2-422 > b/tests/ref/vsynth/vsynth1-mpeg2-422 > index e936ba463e..a39b2b4dce 100644 > --- a/tests/ref/vsynth/vsynth1-mpeg2-422 > +++ b/tests/ref/vsynth/vsynth1-mpeg2-422 > @@ -1,4 +1,4 @@ > -6e135a1a27235a320311a932147846b4 *tests/data/fate/vsynth1-mpeg2- > 422.mpeg2video > -730780 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > -0273cd8463d1fc115378748239951560 *tests/data/fate/vsynth1-mpeg2- > 422.out.rawvideo > -stddev: 10.27 PSNR: 27.90 MAXDIFF: 162 bytes: 7603200/ 7603200 > +651f054730be04257498eeae08b3bdc5 *tests/data/fate/vsynth1-mpeg2- > 422.mpeg2video > +855859 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > +10fd55dbd10b08f9271eb89617766be8 *tests/data/fate/vsynth1-mpeg2- > 422.out.rawvideo > +stddev: 9.38 PSNR: 28.68 MAXDIFF: 178 bytes: 7603200/ 7603200 > diff --git a/tests/ref/vsynth/vsynth2-mpeg2-422 > b/tests/ref/vsynth/vsynth2-mpeg2-422 > index ec7244f9f9..5da29b4eac 100644 > --- a/tests/ref/vsynth/vsynth2-mpeg2-422 > +++ b/tests/ref/vsynth/vsynth2-mpeg2-422 > @@ -1,4 +1,4 @@ > -b2fa9b73c3547191ecc01b8163abd4e5 *tests/data/fate/vsynth2-mpeg2- > 422.mpeg2video > -379164 tests/data/fate/vsynth2-mpeg2-422.mpeg2video > -704f6a96f93c2409219bd48b74169041 *tests/data/fate/vsynth2-mpeg2- > 422.out.rawvideo > -stddev: 4.17 PSNR: 35.73 MAXDIFF: 70 bytes: 7603200/ 7603200 > +fcaf6242ca4b706d392e40d9631e3465 *tests/data/fate/vsynth2-mpeg2- > 422.mpeg2video > +383946 tests/data/fate/vsynth2-mpeg2-422.mpeg2video > +474bb259f041bfb971691551f678fd09 *tests/data/fate/vsynth2-mpeg2- > 422.out.rawvideo > +stddev: 3.93 PSNR: 36.23 MAXDIFF: 69 bytes: 7603200/ 7603200 > diff --git a/tests/ref/vsynth/vsynth3-mpeg2-422 > b/tests/ref/vsynth/vsynth3-mpeg2-422 > index 2247f286e6..e83c23635c 100644 > --- a/tests/ref/vsynth/vsynth3-mpeg2-422 > +++ b/tests/ref/vsynth/vsynth3-mpeg2-422 > @@ -1,4 +1,4 @@ > -4d108b861715f1fa010fd70baea91793 *tests/data/fate/vsynth3-mpeg2- > 422.mpeg2video > -68612 tests/data/fate/vsynth3-mpeg2-422.mpeg2video > -73b16e906d07b6bbccf4b00d4a25302c *tests/data/fate/vsynth3-mpeg2- > 422.out.rawvideo > -stddev: 4.02 PSNR: 36.05 MAXDIFF: 46 bytes: 86700/ 86700 > +96dc854fc40a6410d4edc387b63ded1a *tests/data/fate/vsynth3-mpeg2- > 422.mpeg2video > +75445 tests/data/fate/vsynth3-mpeg2-422.mpeg2video > +5337fc0bfb789919cb3325a02d48eb82 *tests/data/fate/vsynth3-mpeg2- > 422.out.rawvideo > +stddev: 3.24 PSNR: 37.90 MAXDIFF: 27 bytes: 86700/ 86700 > diff --git a/tests/ref/vsynth/vsynth_lena-mpeg2-422 > b/tests/ref/vsynth/vsynth_lena-mpeg2-422 > index 5f11d4e7cd..85d598782c 100644 > --- a/tests/ref/vsynth/vsynth_lena-mpeg2-422 > +++ b/tests/ref/vsynth/vsynth_lena-mpeg2-422 > @@ -1,4 +1,4 @@ > -521ec92c0b8672011a43dd13db98c400 *tests/data/fate/vsynth_lena-mpeg2- > 422.mpeg2video > -356431 tests/data/fate/vsynth_lena-mpeg2-422.mpeg2video > -51ca353620f85db8b5b1c56f1a275add *tests/data/fate/vsynth_lena-mpeg2- > 422.out.rawvideo > -stddev: 3.15 PSNR: 38.14 MAXDIFF: 49 bytes: 7603200/ 7603200 > +87e5c69775b363db649c253050536045 *tests/data/fate/vsynth_lena-mpeg2- > 422.mpeg2video > +361341 tests/data/fate/vsynth_lena-mpeg2-422.mpeg2video > +93cefcf101e6d0814acfaa626a02be90 *tests/data/fate/vsynth_lena-mpeg2- > 422.out.rawvideo > +stddev: 2.97 PSNR: 38.67 MAXDIFF: 57 bytes: 7603200/ 7603200 > -- LGTM. It fixes the broken FATE tests on new CPUs and it's no longer needed to run configure with --disable-avx512 Thanks for figuring out the cause of this! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".