From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 129F742D11 for ; Sun, 5 Jun 2022 14:06:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BFCFC68B655; Sun, 5 Jun 2022 17:06:39 +0300 (EEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2089.outbound.protection.outlook.com [40.92.47.89]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A67D368B623 for ; Sun, 5 Jun 2022 17:06:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XiToXIZYZ4XKkWRF8uNtkCfWvmy0772RS1jqHyraUdM8lU9eGLH0TB4kfL3sDnG1tI8bozEpE1V+AXH7RWZXtuc4psjCm8cfRpLEQaP55bXWS900chfxO75tRGv9Swtg1peWXtYWfsFee0Dnkyw3H3gYDpGNQqtWiXlwwPVlpv/2FcjIBYAyLXhizho4u2UY+B2jPIcdvAdGGgAfKZN3gsgK1ixBayGTfCvmiRh0/G7VFSn7a7WWl/vuWNUyuu1A1WMQoK+UEkKBDE+RWYClf9ailkSes/HRFOYa4A2pNGiBDA/W9b38bj5FWzlTNA4kCP/Muu2NYd3mWwNij8aAWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YGC3dy831v5AyJAMWEPCKqR2BK15HllODsL34wL6KXQ=; b=oHukqXjjMJtEXKHsnEy3WKj0xJIwA/57ox5TPmt8Z31fmCSS9K23uROyzQexMAybHieHEdsWCN9eT0WGqMJ8P4SNNGYm68mqsIGS/ZS6Dtb9nksPluYazFAiLaVAgihPXp0Yp8SUkylEH6NvL2QK3PPH9R/itXyQSuaZ0U39vRbwY4AXtkeGZa7Ky9PUcI4J1g2s1MMYbMYq6Abha8+6QVo4YLkDD4Ktoi+TInT4vpc3Y9rp+PAQTPOZG3jzXEQ+kzITVssLxDtRTrvLT3ser4yA0uK/aYyVaz4wfXguVkl3DTbtE7eWADF6REK589I8LRuilMAqYST0zD2cyCc/Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGC3dy831v5AyJAMWEPCKqR2BK15HllODsL34wL6KXQ=; b=pr4bKbEGPuxsPUOl9fvkmCNQAqhLbe81GN9rJcVF5+7DI/IiQsYn+jNIDCYhq/zUFB2ftarls5/u9VlH8QJRatDPMqoO+22XAomZoVkGvRuNHsHHvfhGqWv/mx4J1vZJNHBA9LHbVtXX2mLyg+SF5p/N53pp0lqRHqfAobpgSuU6wBPz3Hxk06qfm2kIIrq0mRrpZNt+jEf8aghNlCKqPYRNpW5mXlLLmLCPeqnnsvwGMf2Z5eNpBfqOT7QNtEv6urG9fns0OoaH0j6JW2GO29GGgHb4p9VV2fDM0vot975Yyr3whQ7HTx0EotW5trlsN4A+Ryf8uqVLny7WEYvKxg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM4P223MB0472.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:ac::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.18; Sun, 5 Jun 2022 14:06:29 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.019; Sun, 5 Jun 2022 14:06:29 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking Thread-Index: AQHYPs69Q/NxwRSzxUypnCXsEU54I61A1pQ8gAAV+nWAACe394AALEGugAAKPiA= Date: Sun, 5 Jun 2022 14:06:29 +0000 Message-ID: References: <20220323155720.20017-1-anton@khirnov.net> =?utf-8?q?=3CDM8P223M?= =?utf-8?q?B0365783CC5AF48817C137226BAA39=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E?= <165441247425.5088.1095760194724448724@lain.red.khirnov.net> =?utf-8?q?=3CD?= =?utf-8?q?M8P223MB036512ED3D29D532CECAF58DBAA39=40DM8P223MB0365=2ENAMP223?= =?utf-8?q?=2EPROD=2EOUTLOOK=2ECOM=3E?= <165441720181.5088.3725748658698613904@lain.red.khirnov.net> =?utf-8?q?=3CD?= =?utf-8?q?M8P223MB0365143E20505C262ACE1D89BAA39=40DM8P223MB0365=2ENAMP223?= =?utf-8?q?=2EPROD=2EOUTLOOK=2ECOM=3E?= <165442573064.5088.16462974575447102257@lain.red.khirnov.net> =?utf-8?q?=3C?= =?utf-8?q?DM8P223MB03655A93A4EC40F315580519BAA39=40DM8P223MB0365=2ENAMP223?= =?utf-8?q?=2EPROD=2EOUTLOOK=2ECOM=3E?= <165443523477.5088.13247718055308484660@lain.red.khirnov.net> In-Reply-To: <165443523477.5088.13247718055308484660@lain.red.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Tj6r6c/xhC17yCHmta24c05kuCmGvNDO] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ec9747f-8a13-4de3-a707-08da46fc9632 x-ms-traffictypediagnostic: DM4P223MB0472:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U7sBhxI9Lf/SK+6YWKPshQWCfNhVShoxYY66mLDCjw7Dr/8+u4IzxwBW6RNxAd0FtJODjf/i3NV8w1VHF/nUfT8yCjeT8NkMFG8sXYMR39Y+LG+oApn5u6qJlCEyeWlRyDD6WgfqYzlrU6bPQoq1g4hTSj1zSgF3oG5sxxqpf23YxINMh7WVUv21cfZ/pmunfaa3ZTpviRiCYFYzxTCP7nxEQuuq9Riao+dCuvS++UaqEOZbgiLE+3Ycqw5VvqL07aqNGcJTu/T8OebtN06xjxW67gyVro/wEeQFe0gT676V6wVfUlwhBw0S7ge00JCoSNbGvhQPoaU/6JYCxtzvLzJhtIQKSmNyU30CJ6OmPx0Sq3OLEIel3pzLwhIAbN1CeuPQWQLrlmdiG8hb648jz1P3Pft+sMGR374BlJaqdRCtHppZ6EHIlQaDKJi25jB7mxRPM5VmU5YbjJqb1Vu+R82UVv/BaigMQpndIR5Ro+f/QpfnBPE+yNxwpfD+aC+E+KPzyCbnZZ+aWAwNcOimTyGbiMTGevX+K9ZGh0xRTptYbfTrndTL2SZjkTkA3cOxdzlzDXyY2X6rN1pymH37Dg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXZWVDdGUmxwRWkvT1VrR1pvV1EzZnJhY0N4MGJxd0FMSXgyVkdxYXZZVG5G?= =?utf-8?B?VElhdDlQWUJ6aUMzQmc5M0tyU2ZJczM3UUQxSFRaZDJxeDU1NTVzY1drS1pG?= =?utf-8?B?MzNJMitMRE9WVmF5VEhWeStFalpkR1JrVkM0QU9zZ1JEVENvaGRuQllPa1BE?= =?utf-8?B?eUZnZGxmSGtZdjR6RnBRRVlja2RBMDFFcE1aVXZBVStrVXFTMHFsMUdOSitv?= =?utf-8?B?OVlIdnFUZTVHSGFEWVRTNUhxK3dVZEdDSE1YcEt4eisyaTZ5bzR0NU9VOWxV?= =?utf-8?B?ZjhnTElycHhrVUpJQjVNeU00MlI5WnZUakFNQlo2ekRNN0JjS0M2Z0xHazRC?= =?utf-8?B?WkM5TmNTd0tsOFBCTnYxZWNtM281UU9uMmVMM01vbEF6bllqM0dRS252VndZ?= =?utf-8?B?cE1kVUJndXBMb3V5bzRZb2Rwc295MkJzREpPUFpGbDNuSWRUby9YaDRsaktt?= =?utf-8?B?NFdObnIzcTRuQUZ6dll4UXdJc2Fuam5nWUlSSFlQK2JmWk5yV1A2NE9HcHFO?= =?utf-8?B?RDRUVlpQZ0NrVWlrZ002VldLNWtHNUpNR29MT3dWU09wVW42bzQ4bW5SWXg1?= =?utf-8?B?QzZnU0ZlNGFzNGVkQjBUdjdTNUpGdTZQYVZYaXhOVTZPSk1tOWU5VnMwRW4v?= =?utf-8?B?RmI0TUh3TDZZSk1PT2dPYlhpYWprSmdQditHeW83enVLWGh3Kzl2ck8vR24y?= =?utf-8?B?VUZuMWdHbng3aHk2R2FzV1NjQTR4MEJEcXFJT2dGd0xacFg1VENSL0EzRXVK?= =?utf-8?B?dlJzbzZabEdxYW5GTGZXN0xWV0JoN1FwczQ0RzA5L25wQmxyenRNbS9LdWVC?= =?utf-8?B?YU1ob0xTLzVFbnlGbHVVYmhVL2dDZnk0VDlMMEJMeUxlUk50ekRNeGZsM0t0?= =?utf-8?B?cHlsblBTd24xeWFoUC9Sb0s0ZTkwcjhteHd5MUZ5eDRiSEpOelozQStudk1M?= =?utf-8?B?SUlUWHNPUjMyUDFRbWhvdmhsekJwUGozNkVyTFVweDRFMS9lL1ozcVZoVUFU?= =?utf-8?B?SmkvZVN3WS8yTTlMWkZpL2JtTTNBUEhJU3RPRVRrckJPZmZHZkt3bnhpcnJv?= =?utf-8?B?R3hjbUZ6QUx3SnMrQjFKTC9lNm92SXRLT2xBeHlZdVdiU2FCcWltbG1LZEs0?= =?utf-8?B?TGV0ejdRWUQ0WVVKS3I3WXhidzFhOFVFZzZtMXJoUWlqSmttVXpFdUg5RTlM?= =?utf-8?B?am8yOTZGYlc2T1JFTnVIU2ZLd09jeit1MmFTV3NTYWlhNnVDVE5DckQ2ZGJl?= =?utf-8?B?SWZjUUx3VGZURVVaTVBlbnQ1VUhibGdEWjZhVVBvRFNQMW9QKy8vT3JseU5l?= =?utf-8?B?TDZVb2lGNnUxWnA4TDRzTFNvTk5pMVMxcDljcWYrUDd3RjFDWHVmam1SMjZi?= =?utf-8?B?OXBZQUY1SUI4TmdaOWdxZ3pDQ282citQQkVuS3lONUdUY2dzOE1rOTRPdnVO?= =?utf-8?B?a3kyWlBrcG9sRkQ4VTFnV3RGRjV5dHp6Zk1JU1Q3eUFjMTRpTGxNK3hPUkd1?= =?utf-8?B?SkIwcTFqYVgzT01TcnFTbXFZSVZXT25UM0pjSll0Q05HUlBEYVZ2UUtOUktD?= =?utf-8?B?cXVVZk5IZmlYMTgyeS9XaldUTHQ2VG1uNVlpR2RQVnBvZDhHajJZTFZMQVh3?= =?utf-8?B?VTJEZzVMWFZQSDFLYmtXbk16TTVGUzNrZmhkeVJlS0MwM0ZUcVIxYVdwOHBZ?= =?utf-8?B?NFFlZ09GKzMvbUZ4WEx6d0prV0FhdC9hQnZHUmtVRVV3U040UUN5NytiUmV0?= =?utf-8?B?aEs4aXJnNDlUMElxOG0ySkh3OEEyeEJiSkZoM2RJV1ZzU0pZM3pZK2xJTmJH?= =?utf-8?B?YU15QTYxSzJ2bnpNbG52MUNLRXFKU3RCNlNUbk9GL011QWhlNHlNMVBZdjhT?= =?utf-8?B?T3Fpd09LR3ZvdktUb3U1TDlBdm9qaHFRdm5NWTJlQUxQQUI4dlRUU3piUEYz?= =?utf-8?Q?AytYzw6rGsU=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec9747f-8a13-4de3-a707-08da46fc9632 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2022 14:06:29.1795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0472 Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 3:21 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022-06-05 13:10:49) > > > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of Anton > > > Khirnov > > > Sent: Sunday, June 5, 2022 12:42 PM > > > To: FFmpeg development discussions and patches > > > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec > id/type > > > validity checking > > > > > > So much text, but no actual answer. Again: > > > > I fail to see how calling avcodec_open2() with AVMEDIA_TYPE_ATTACHMENT > > > > is valid API usage. What do you expect it to do? There are no > > > > AVMEDIA_TYPE_ATTACHMENT decoders. > > > > As you didn't mention anything about how you want to address it, does it > > mean that your intention is to leave it as is and declare all other code > > being wrong? > > Frankly, your attitude of breathlessly repeating "ffprobe is BROKEN, and > this is HORRIBLE" is unhelpful. > I am open to various kinds of solutions, which include (temporarily?) > reintroducing previous behavior, but first we must determine what the > actual issue is. I.e. whether it is libavcodec or ffprobe that is > broken. You seem uninterested in this question, which makes me not very > interested in spending time on this. I need to fight about every single character of submitted code, and you are trying to justify your commit that clearly breaks behavior instead of either reverting or offering a solution. Instead I need to go through stupid discussions with you. I don't understand that behavior. For most others it would be totally clear that such commit would need to be reverted until a new solution is found. I have reported the issue nicely and well explained. But you start to find some justifications instead of suggesting any solution. I don't like that. I wish I wouldn't have been required to write that much text, and you would have just responded something like, OK, I'll see how I can resolve the regression that my commit has caused. That would be a normal reaction IMO. Regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".