From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97D2D44E52 for ; Sat, 26 Nov 2022 02:54:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DCC168B3E9; Sat, 26 Nov 2022 04:54:51 +0200 (EET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2049.outbound.protection.outlook.com [40.92.47.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DF5ED68A87F for ; Sat, 26 Nov 2022 04:54:44 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=axvv9dmzco8GEnlWIakCoYjveYvui9K18WD7jrp7UyL9qtdChDnQKDYQ5FdXVd74M/Zd08Zm4vbAls5kX8NJZNm9DUz0Pb3wVD4iEYANAwjZ6B1R8lYasqXvTKzEpSR3ZTYRphlhE6RxKt63/iULteqp1/LqVQYa9UncygNM9IpTQbCKKNnXHVyscHxpcUE7I2YzCd+Cg6mZQPTGnN1ygO49hfRMwX05Q8FNKWw/3JVLJbmb6g9vNGpfypGqkrQzWTRdHEOJuaMtxAdlXT05mfZTUmNorcqwgIELDkUL+gaHnR155+j1CvA5OuzuEGatmtJ9a0tHTkBsHGa8d9kUpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QPlvcgpyXwXmgLm7Bs6cJcNBWwtJz3/OrF0d8FKO21w=; b=E5k9eUlz1j+rTrGSFIOJyXzGIySXZtWJfEkrNvSkHWOCiGLzjPQkmSjr30USyA8aC67FCA9lOMHoPjuHZEqCr3V4ytXQWsVV7De8JKtEhNCHatMzkxfFIqPvdThA6CWnr2Ipl97mXozQ0oifxQni/Xb6ZW53KRtSX5kXfSa8XQ6pxzG1SggoySlVvDLt4ELs+uWq/33B6WzTIdnCDBM6qEzYUS21kD7HeDIE/Fiq4oadntsW7iG9+fRbt40xvWBT5SEB413H/JjwI//mbLMUCTs8UybTQD1ThS0DpmC8EYogtewyZ04S2CfdUFnghcR4qvxgzKRyPYRIifd68IWgFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QPlvcgpyXwXmgLm7Bs6cJcNBWwtJz3/OrF0d8FKO21w=; b=EmiSRO27JemTzThvvghStsv4MQ8ahLCLokpO1zPQIM04iK58/kAIMkbYHP8cUFAh9yy/mUQHUpaN+aSWLTDQp1Sryr5MPS/mwj9gkDcxme1WVgA+J3HQvH375TuzuAgff1kxqcx9yzo+weImAQJbiJZCgO6uEluZRMjEg20mXDQg+JpRziWK1WlVbCBAAa1/2t2amdhT9Kh3na6CZK78i98dczOi6kRPC+BsI+4fvV7w1AzOMDgungxw4VCbksQraBrM2DTgbpJ5iZZVfctCMoJ9F/VHAsPt+tXwP+hyJ0322gYX6x8d+Qf/M6o7N5CTxNSOk8+Tce31twJGzYsiog== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ1P223MB0433.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:488::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.18; Sat, 26 Nov 2022 02:54:41 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0%9]) with mapi id 15.20.5857.020; Sat, 26 Nov 2022 02:54:41 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format Thread-Index: AQHY/8THCFVwiEkFUEugDzP43oUjCq5PqNyAgABCHnCAACMZgIAAGzVQgAAhdoCAAABtgIAAAjyAgAAD5KCAAAKbAIAADnxAgAADFwCAABh5oIAAAgYAgAABT7A= Date: Sat, 26 Nov 2022 02:54:41 +0000 Message-ID: References: <20221124052209.520239-1-haihao.xiang@intel.com> <166938393779.4503.7930861168279237996@lain.khirnov.net> <12d8e532-f236-83b8-61cf-6c9ee72b10ee@gmail.com> <4bcec8d4-8593-9a23-3130-8aa52b1f3c11@gmail.com> <494bbc9b-ab82-0c62-f471-3ac9be03e80a@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [ZmXMX5sTCzNX9k/EbQeSQnRt4uuaVVif] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ1P223MB0433:EE_ x-ms-office365-filtering-correlation-id: 207525c9-1ef4-4bfa-a1c1-08dacf5990c9 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FPsDd5XYoEvVRwic6xlp43fNO680s5kjvMT1Fj/XpV9h9+7p2m2deftTNN4q9f8+Iv//0IyJHAul93jFiteoQxi3dLRsGXMMZwBxYZegYZxTc9BH9vH6WtEyw5aW467O7a0DBFP+xSyOAs+4NHwFIfzq9grMknm62DclB+qb0OKT7iBhJVjABNqz6FThxH4A/B7v8uO7cXfQjHznD1HRh02CRlg/1LtMiKMxdujlv24Q9D7Xpuys6rErVscPCK1GSMPTQBXWvX8gXseVv7OSEhx+psQLxeIN8xftmQApJyUWt1+QGVxcEndX532HdixjM8oByDQhaHSM//S9nObStsc1uBViMECL+chdgg1DOZmI7SS0tp/f5h61ikghwzYsw8KufOzuzN+fdWGuERxKLZGtuo9mTiRkXZ8kOzDcQF63+BcwYeojLYIUX9f/0nSXj/4K+vC1eA5NnR8TmIgkj2/In+bp13rgt+9QGPvi2jztctNt5QGDbZOmkow5CZg2a4oZvCLQb3jJwa8rwDHRkJKQ30jxW0GUZb3PVLmT+mkK8Oi3tETuajcrmOJq8nIFjqwsUV9Ffj0TWb8GigVa/7S/0ENBmcgYizOKGcWivrgLd/eROksUjl76bvKahaR/T6mIO6ALSokSIIWv3b2GSg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cE1mMG9jbFJodkpiSW9qNGxaS2pWTkRTWnNBeEFjYldTOUVsVzhSNDFkK3JS?= =?utf-8?B?My9lU2FLcUdTZS91MzZRb3IzMEZPUmhtSlJaTWNENitSMTl4M0tSckZ6UjFq?= =?utf-8?B?UDJyNTVUT2diaWNVUkdERWplVEQyeWJEQ1o5SmlMS3dza3hFWmd2VE5Kc0xs?= =?utf-8?B?dmhBZ3gzSnJxUmF2c2luQ1kwU2VsbjUreW1GeG1TRVg5LzlIRjFud1dYMm95?= =?utf-8?B?MVJQQ29DeG01aUhRWHdWUi9DbStPbkFkNko0ZjNXeG54bkozamowWGEzY2Qx?= =?utf-8?B?VktsRUlvR05jU0taNHN2SWhnTWh4Q3NCVk0vK3lpRHNoMTM4QW10bU1WeVR5?= =?utf-8?B?ZXFRYTFxSWxBRlRTUW02T2FuWWJOQUsrSUxWMU9FSWJvOHo4bHppTmhmVnZ2?= =?utf-8?B?c1F5ZUswcktsNk9zZ2twT1V4TFNqVGZnVzVOVGVSd3NSM1RFSjEzMWpMN2RI?= =?utf-8?B?d2Y5SElwVEhpWUtOUmhSbTZnQ1hPU0JiamJYSmhvcS8xWHBUOCtlUS8vZ3Q3?= =?utf-8?B?V1lhM3ZpU1E2aHBKYXZUQ0dPclRpbHUrSklZVkVqdk8xUFpXUVN0bWRzdGhW?= =?utf-8?B?Yk5DL1FzVEtXVjJtazQ0dHUyMVppb2pvTGVnTWI2bnRid1p2eUd0R3luWmtK?= =?utf-8?B?elhZdVJCaWNPNWM1SktJRm9zSTdzTzFzU0x5ZXk4c3BXcWtzci9QSzFzcUhG?= =?utf-8?B?eGRtTlhjbnJpbUVlTzJZMDhnMjhhU2lVemR6U2RxSUd0bTJXWTV2enJad1JE?= =?utf-8?B?VWhaQmZNV1FXZCtQQ0xjYVlWd2dLTHhnZ2pEUGZzSTN4S3U4TWJOVy9tK3hN?= =?utf-8?B?NktrQkxTTEVZWkoxRWlWVXdCZTVyZmxrdUFJRjFNUkJCU2hKTHU3Q3BCNkRS?= =?utf-8?B?bEpCRWJpL2lPelVDUUdweU00YTk1VE5KSTcwUnZLOHFHL0owbkZIaFA5aXQr?= =?utf-8?B?aERhSndwUTk2dTNNVVQzc0dDWUZPMGxTVmFPTHdWdG8razVKV1haNlNMSExP?= =?utf-8?B?ZGhzYU9nSjBPRGIwSDRNWnpZVnI1U1NPVmJOQUJDSEpUaXpJcllGSEdQaUtr?= =?utf-8?B?cWVvamd4YWEreVU1bFdmTDJiN2VIS3BzVmNXU2hrMmhQeFNsWUNyaTQvbXgz?= =?utf-8?B?TTUwN29EMThWaFpiUWxQS0wwclZGRy9FSmJiOWs1bXU4RTRuNmNRcy9RQm5R?= =?utf-8?B?VzJnYUUwcldMU0tWWm5PVVZmQk1iUHhiR0lqd1gvMG11enV1S2hmU3hWUC9r?= =?utf-8?B?UGdta25DcHN1dDVOSDBVRVdSdjhvcmpaSmxFTmxCVmRScW52a3hVcWYwUXUz?= =?utf-8?B?WUdrMCs0ekJ5T01lY3NHU2xCY1JqbUQwVmdIZHN2SEQzS2lZWFFlY0RnZm96?= =?utf-8?B?QzNWc0lqQ0JDdUFKMG05Q1EwVjhLd3ZITWVaNE1jcnFOSVFGTmFKN25SYmdY?= =?utf-8?B?Z1cyQlRob1dvWTNSZSt6SloxUUI0SkZWYWhKSWtwWnRDMVVkZTd1TGkrc2JQ?= =?utf-8?B?UGZ1NDZKTkI4dUxrb2hOLzRLYU1wY0g0bjZ1VGVJbUZ1aCtxSmlDWDE4ZGFR?= =?utf-8?B?cnNQVDhySG1qNHQ0RTAxa3lBdGhoTUd3RzlIeE9uWUp3TmtpUVRnU3EwazM2?= =?utf-8?B?SjJDRWdMdmI1aWhqQm0wVEZNQWpiOGpyZit2UmxwZ0J1WmhxT3RzOHBid3Nr?= =?utf-8?B?YndQeHdtYWF3TkI4bklOODJSRlRUWkhhZ0RuQ3o3UUFaRlZiSThVWFNBPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 207525c9-1ef4-4bfa-a1c1-08dacf5990c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2022 02:54:41.4362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1P223MB0433 Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 3:36 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 11:31 PM, Soft Works wrote: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Saturday, November 26, 2022 2:01 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 9:58 PM, Soft Works wrote: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf > Of > >>>> James Almer > >>>> Sent: Saturday, November 26, 2022 12:58 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >> support > >>>> P010 format > >>>> > >>>> On 11/25/2022 8:51 PM, Soft Works wrote: > >>>>> > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: ffmpeg-devel On Behalf > >> Of > >>>>>> James Almer > >>>>>> Sent: Saturday, November 26, 2022 12:35 AM > >>>>>> To: ffmpeg-devel@ffmpeg.org > >>>>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >>>> support > >>>>>> P010 format > >>>>>> > >>>>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > >>>>>>> [AMD Official Use Only - General] > >>>>>>> > >>>>>>> Will it make sense to accept P010 input, however encode to > h264 > >>>>>> 8bit? > >>>>>> > >>>>>> If it works (the encoder accepts the 10 bit input even if it > >>>> encodes > >>>>>> it > >>>>>> as 8bit), then i don't see why not. I assume it would also be > >>>> faster > >>>>>> than using swscale to convert said 10bit input to nv12 before > >>>> passing > >>>>>> that to the encoder. > >>>>>> > >>>>>> Removing support for a pixel format as input in an encoder > needs > >> a > >>>>>> reason other than "It's rarely used", more so when it's a > single > >>>>>> line. > >>>>>> It either needs to not work, or somehow get in the way of > >> further > >>>>>> improvements. > >>>>> > >>>>> Oh sorry, I noticed that there was a misunderstanding. > >>>>> > >>>>> When I said "It's rarely used", I didn't mean that as a > >>>> justification > >>>>> for the removal, it was meant as an explanation why none of the > >>>>> hwaccels has implemented it. > >>>>> > >>>>> softworkz > >>>> > >>>> Alright, then i'll repeat my question: Does it work? > >>> > >>> No. > >> > >> What does this encoder currently do when you feed it p010 input? > What > >> does it output? > > > > An error: > > > > > > 1. 10bit from HW context: > > > > > > [graph 0 video input from stream 0:0 @ 000001dc301aeec0] w:3840 > h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 > > [auto_scale_0 @ 000001dc2362a700] w:iw h:ih flags:'' interl:0 > > [hwupload@f1 @ 000001dc2944ef00] auto-inserting filter > 'auto_scale_0' between the filter 'graph 0 video input from stream > 0:0' and the filter 'hwupload@f1' > > [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le > sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > > [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Init > > [AVHWDeviceContext @ 000001dc444fab80] D3D11 Init > > [vpp_qsv@f2 @ 000001dc22a3d880] VPP: input is video memory surface > > [vpp_qsv@f2 @ 000001dc22a3d880] VPP: output is video memory surface > > [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le > sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > > Last message repeated 2 times > > [h264_qsv @ 000001dc161b6040] Using input frames context (format > qsv) with h264_qsv encoder. > > [h264_qsv @ 000001dc161b6040] Encoder: input is video memory > surface > > [h264_qsv @ 000001dc161b6040] Using the average variable bitrate > (AVBR) ratecontrol method > > [h264_qsv @ 000001dc161b6040] Current pixel format is unsupported > > [h264_qsv @ 000001dc161b6040] some encoding parameters are not > supported by the QSV runtime. Please double check the input > parameters. > > Error initializing output stream 0:0 -- Error while opening encoder > for output stream #0:0 - maybe incorrect parameters such as bit_rate, > rate, width or height > > [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Uninit > > [AVIOContext @ 000001dc16197c80] Statistics: 0 bytes written, 0 > seeks, 0 writeouts > > [AVHWDeviceContext @ 000001dc444fab80] D3D11 Uninit > > [AVIOContext @ 000001dc161839c0] Statistics: 131146 bytes read, 2 > seeks > > Conversion failed! > > > > > > 2. 10bit from SW context: > > > > > > [graph 0 video input from stream 0:0 @ 0000019e915dee00] w:3840 > h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 > > [auto_scale_0 @ 0000019ee99936c0] w:iw h:ih flags:'' interl:0 > > [format @ 0000019ee9993240] auto-inserting filter 'auto_scale_0' > between the filter 'Parsed_null_0' and the filter 'format' > > [auto_scale_0 @ 0000019ee99936c0] w:3840 h:2160 fmt:yuv420p10le > sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > > Last message repeated 3 times > > [h264_qsv @ 0000019ee9995dc0] Using device qd1 (type qsv) with > h264_qsv encoder. > > [h264_qsv @ 0000019ee9995dc0] Encoder: input is system memory > surface > > [h264_qsv @ 0000019ee9995dc0] Using the average variable bitrate > (AVBR) ratecontrol method > > [h264_qsv @ 0000019ee9995dc0] Current pixel format is unsupported > > [h264_qsv @ 0000019ee9995dc0] some encoding parameters are not > supported by the QSV runtime. Please double check the input > parameters. > > Error initializing output stream 0:0 -- Error while opening encoder > for output stream #0:0 - maybe incorrect parameters such as bit_rate, > rate, width or height > > [AVIOContext @ 0000019ef62b4000] Statistics: 0 bytes written, 0 > seeks, 0 writeouts > > [AVIOContext @ 0000019ee995abc0] Statistics: 131146 bytes read, 2 > seeks > > Conversion failed! > > > > softworkz > > Alright, thanks for testing it. The commit message should mention the > pixel format is being removed as it's unsupported, then. The QuickSync architecture does not have any scaling/color conversion capabilities at the encoder stage. There's the VPP filtering and they also have a decoder-size fixed-function scaling which is separate from VPP scaling (similar to CUVID). It's not yet exposed via ffmpeg, though. Generally - when other video processing is required, it doesn't make much sense to do encoder-side scaling/conversion. You'll rather want to scale down first and then do the other processing on the smaller frames. The only case where I've seen an encoder-side scaling feature is MediaCodec, but well - there's no custom processing anyway. Best, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".