Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

[Soft Works <softworkz@hotmail.com>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Soft Works
> Sent: Monday, May 30, 2022 10:08 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem
> alignment for vsynth..mpeg2-422 tests
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Anton Khirnov
> > Sent: Monday, May 30, 2022 9:35 AM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem
> > alignment for vsynth..mpeg2-422 tests
> >
> > Quoting Soft Works (2022-05-28 15:17:54)
> > > Do you have a better idea?
> > >
> > > The one advantage of this method is that you don’t need to change
> > compilation parameters
> > > nor  any source code. It’s only a runtime flag being set only for
> > this specific family of tests.
> >
> > At the very least, I would expect the commit message to explain
> what
> > exactly the problem is, and why is it fixed in this seemingly ad-
> hoc
> > manner.
> >
> > "limit mem alignment to fix failing tests" explains nothing.
> 
> 
> There was a longer conversation ("FATE Errors") with a number of
> people, I'm not sure whether you followed.
> I submitted this as a possible way to work around the issue. If you
> find that patch acceptable, then I'll gladly adjust the commit
> message
> with a detailed explanation.
> It's just that I learned that it's not very effective to spend a lot
> of time on things that are likely to get rejected or ignored.
> 
> Thanks for not ignoring (at least ;-)
> 
> softworkz


I should have conclude with a question: Would you consider this kind
of workaround as reasonable and possibly acceptable?

Thanks,
sw


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".