From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id BFD964DAF0
for <ffmpegdev@gitmailbox.com>; Tue, 22 Apr 2025 21:10:53 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A66EC687DAB;
Wed, 23 Apr 2025 00:10:48 +0300 (EEST)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam10olkn2020.outbound.protection.outlook.com [40.92.41.20])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16B92687D46
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 00:10:42 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=tMQIskIua892/aWTKJH1VVXbW13CQoutYGefhnGr3Hoq8Ph5VAzu86olt02OyMk349t8HQYE8TbZ1026fa/WDwbGk+cECBvM9zH+1k6efJiamUdEaHkKfvYEkR1Y/1AdzvrqzbrHA+oJmUD0SNLF4Yp2gSxFffmH1X6zukxPgk4jHYbkrId0FkBj5L+gN4hBqNT6QHUO1HxTZKdC/IdEBONJiV9cm1Oyk1wai6VOUnkbHhYYE1eMXx4TMKLGRO/PMNkA51G3y/H/Mbpy7e+HLgnynZ/wepYiV3qwgX3rhmQz7H74yj+Fa88uLvyDXcfjhh6B5ALi7ZZf8QQ6UcHVng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=CwVLmjsZ9JaxsHG+fQ54F71MOU7tKbDtYgNoJDpXuEs=;
b=q2vRUXm0kCq46PHt0N/M82LgpSw+S43ylogATmWZuvxyx1HIPbJQtXusWYdXyAJOKF1N4AohkTow3AtRj0iMFay4nXpKvhhOZv672MVFlVO1EEktRM3x8dOTprD69wIZYEKJmcgILKjrCJXAJltuufuY7cZiQE/6/yTJIjCf5o96/wJKQqYg7tlCBwINiLzXXzA2/XeyW1E25aMQROBVUL0SZz6xGnwiL81YGWpDl4klZEp4qQasUYqEI4DnWfySESM9Sfg+rUdiFs1fdIYE0UEGxlkBEWb0b0rhumP9zLio1QsKy1uPGYHQPByeH44ctmTGl9RswXizOc9GeIG5UA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=CwVLmjsZ9JaxsHG+fQ54F71MOU7tKbDtYgNoJDpXuEs=;
b=FzLJEsfV1qtXRFD9hNk2QP4aDw2fFkpQToU4GmGV6XU0xGYw26UelwqB/+t6mbuFXm6VoCELsDofrFQRu58YqO4TBD7EnhLKWDKLxJ6voMJGpkyu8FS8HsJBjWroK7btUPSiz6Zu2dVs/okJU9SmxrWetwJmdGJExLg/dawvBo14IUJCDG3Jle1u4cMN8RgTbp3SffIUdp85lJg1TvwLuE4XxMQHX56qa3ufGXtiWlFnUCb8KxhKic/AuDmrTxElKDsmBgtVpWDAmRFNbbvRQr0i3175CW25bgsE4gmPbnguR/YPjy4BaEEtb9SUq5hAMl+uL2xxHVlGaSk7L7RsoQ==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
IA4P223MB1548.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:568::17) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8678.22; Tue, 22 Apr 2025 21:10:38 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.033; Tue, 22 Apr 2025
21:10:38 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: Stefano Sabatini <stefasab@gmail.com>, FFmpeg development discussions and
patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
ac_default_item_name
Thread-Index: AQHbskforhOcV3Q0nE+InvTUBbMy8bOuYcaAgAHNytA=
Date: Tue, 22 Apr 2025 21:10:38 +0000
Message-ID: <DM8P223MB0365A9306A56C7799CDA211EBABB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.v3.ffstaging.FFmpeg.1744945024.ffmpegagent@gmail.com>
<pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com>
<4f1218b594ac2b4de96870dbd2903abde3f94d95.1745189955.git.ffmpegagent@gmail.com>
<aAaA3V6kJyfHPtAT@mariano>
In-Reply-To: <aAaA3V6kJyfHPtAT@mariano>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA4P223MB1548:EE_
x-ms-office365-filtering-correlation-id: 3d4ab6d2-8ed2-4d4f-ecb6-08dd81e221ba
x-microsoft-antispam: BCL:0;
ARA:14566002|8062599003|8060799006|19110799003|461199028|15080799006|7092599003|3412199025|440099028|41001999003|102099032;
x-microsoft-antispam-message-info: =?us-ascii?Q?sGweegJRBom5wXDIbtOBfLbmNraWr5aZTdutupokW53MyeToKwxcC8/l1P83?=
=?us-ascii?Q?o0OhR7rF5etKhFo37RT/2ryw6WfTZ897iBEaK1LItPcvPzBmuhTpXNuy3RzW?=
=?us-ascii?Q?4iX2pGDzAwZDPvxqBdsEfAQPR4CzRRHM3jFpxrWpX3Euwt2zck3QfTkq52Nw?=
=?us-ascii?Q?c1hpCSGKnPQsrM3XolcrQ/QACeJGYFvJkh5reS0HoAaSf6LkTB0/IJYXRKoR?=
=?us-ascii?Q?Ew6UkBKdCWavHlj9Rdknx0qSH19l0SQDP48oBzhNKmzj4ywTJMKc1feLv4V/?=
=?us-ascii?Q?apENsJRIStl9H336UY9u3lbc4VvsgsrJXt0fGb3NOcR1U6tAGHEsf3qHMCl+?=
=?us-ascii?Q?UIxR6nBvQv2FLewEgJ4JD9iLaMZZFm1Irz3M16VGKxO59d1yiNUQe7a2p7KQ?=
=?us-ascii?Q?ybUF5Zjyb5apCMFV3mwXviUQxCEog78rqGdBeQCvAnlbmtLDW3HXt5PTSlza?=
=?us-ascii?Q?E2kj5zaVbn9oq1SCjPE/mwC4ncglhwfNv3vuZHIlM7Xys3wosdcvVmTnn8tu?=
=?us-ascii?Q?lbhf+f9NjVjqJ6WEcFVTRZ72WPJTHLbDcS7o403GIkrPYzQejgrNMMxJ0K7t?=
=?us-ascii?Q?vh/rRsnrKvi+K0ziuMwBbpw21KVrugarBWZO5Zt6OC3Z5DonaTcsBjyvd9U0?=
=?us-ascii?Q?yB9J/9pVFjBW/yKYLdKLXhq5r0+L+ibH3pPfTR3pH0U/fot0sxG4z9I9yWG4?=
=?us-ascii?Q?DJIchnlNjVVN3sfoVD0rhvdqDrXWrBJAq+NA7c9o99FkkRsNdjuo+r6Zmmrw?=
=?us-ascii?Q?Y7zwa8OOXF37rEGjR9l2YruucwA1Aj8SP2ydf0D7qhHqB7vAjnl/XmT/gTYb?=
=?us-ascii?Q?Ib8CDzdKEPLmIDCRAUGMCWMhgmdZysO64Wd/ebWoYnBGR043jHlOEGtY0jdM?=
=?us-ascii?Q?W+l0kWilPhcQAGz8mj2uWdEp0tqWEr9Uzh7SN8LYIBHCspRjSOK21YbqtLSL?=
=?us-ascii?Q?E76/9GQqHHv27aITCsY3J0de+QKfG6Wv5UYo7prJI9nSgZ6jlSoic6qpkPfq?=
=?us-ascii?Q?UIQ2sDJnYkROx+2LxvZ09YQ8oOtpp24zj46aJzmeln0bXfORV9+eFF+69uRQ?=
=?us-ascii?Q?yfZTcbkHdvQUFy5Z3dtmO8W0BY6FgdZw9v2r/JktC0mCYIJJp++G3n9Px8AJ?=
=?us-ascii?Q?EeegXm8NIbL4Ls5N47VrRrb/XHZ9GUrlSA=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y1oB0iXrL3RLsXgDvm1H58x1nie5PpYYi0/1nDMHRls71IkxuJBs8epfXCgp?=
=?us-ascii?Q?mdE4OgvpyXGNKAVSFnK66ocojp/zQUFsB5tzkxAuF/o96+VUgfcO1q8qnfK1?=
=?us-ascii?Q?TLQz94vEaMC+MKegR7aTydg9B6IsrOkYJC2xgP2GzpFaGGJqI16ZbrjREMUI?=
=?us-ascii?Q?dEiqW2P7uXjcNAls5lh0GK7X95ohi9bqtAozOBJMKpvqqIRymVtBzQ3qr6Qu?=
=?us-ascii?Q?OIRCNVWWYDvMAMfIOMm8SJrUPxmAeVhGbCl/zupG/cLeo6ct1NuRvlTwqvjz?=
=?us-ascii?Q?u2t0i/GVrDlkvlL4PommUMcc/u0kIFpll5ljHaxXcauiHXe8lo58fpdvXfGD?=
=?us-ascii?Q?9HcjEaIqAUj6pr9IemqPT6DRhhR+5wo+5SUP6aXAGjxZE1TcFc0ka3n7nsg7?=
=?us-ascii?Q?DPrFGJ3ddt9pSb2NwoxE2YBKpJPyPgZR2G7U7vqwRXr2iWi4chyex0lp3Ymq?=
=?us-ascii?Q?swT0tShi7tKx6xnvOfHUq7QSzsIHoII4cxzAip0nGg7rNg9kAevxyRqYkmhM?=
=?us-ascii?Q?CpS2JEzDVKIfLb+L5+UDDPx3xhU8eYufsYTztQef43aNi20ECQrs64tBSlzh?=
=?us-ascii?Q?3d8YVMmfg7xaK0HqnGhW3w8SgkiEkWAM7zDUCQjrSwH42Xd3/5OcKOXPY1Ag?=
=?us-ascii?Q?mV7KZnplHMSx12/j7x11VTp38SiBanwN25X99c3QNgz1Ocl2JDF1eFhTiqxw?=
=?us-ascii?Q?29fL6CyeLBWcTYUFmTyVxef+UhSzVtcRit5CZ0ZSRiWqh8K/Wb4M2B3HMG+4?=
=?us-ascii?Q?trWUgmP1Jzmz8/k/ZYnL0KZhlrr04Ik8B/wcbITX4XtNehQbRMU8VayBbulQ?=
=?us-ascii?Q?YReyUMkqln4iExM3rUHHCnbBe0LHwWnF6dDEelv9CAse5+CVmzFRrYuVq7By?=
=?us-ascii?Q?f6jZ2GhyUq944whUbd+eHbUmHRt8/Q1MiCzc9VkX6NiBYVaVGIk8xLFTnDOt?=
=?us-ascii?Q?PHT/4uGdpFHdA/aqTYESbN3Md8tH7JrcT14AnBUx/jK2Kk/gU7hqHQ2OGXb1?=
=?us-ascii?Q?+jJElLsJMc+7NNCHJxODkfZRqYOk6+CnM6oZ2GvDtpGCcoAWkXsNTm8xHQHn?=
=?us-ascii?Q?8qa3Yt7tdEndnPwvGgpa0Ym3ShseJWuXEO/yUbC9SqcsmnToasEgAp6mpEUB?=
=?us-ascii?Q?Pl+SR4xPt/BfGSu+zPOilt+V4OTIOAV8nxPLv5zwD2Hhd/xOckp3Q/Ihr6Ne?=
=?us-ascii?Q?v2f+34/b6Aw6glErdOaaq5XVSEVNsWQmqkRQqJcHtkK0pxYncSPsWJmYahs?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d4ab6d2-8ed2-4d4f-ecb6-08dd81e221ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2025 21:10:38.4411 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4P223MB1548
Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
ac_default_item_name
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365A9306A56C7799CDA211EBABB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: Stefano Sabatini <stefasab@gmail.com>
> Sent: Montag, 21. April 2025 19:31
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Cc: softworkz <softworkz@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
> ac_default_item_name
>
> On date Sunday 2025-04-20 22:59:07 +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > fftools/textformat/tf_internal.h | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Typo in commit headling: ac_default... -> av_default...
>
> >
> > diff --git a/fftools/textformat/tf_internal.h
> b/fftools/textformat/tf_internal.h
> > index 7b326328cb..e145bc83bb 100644
> > --- a/fftools/textformat/tf_internal.h
> > +++ b/fftools/textformat/tf_internal.h
> > @@ -29,13 +29,9 @@
> > #include "avtextformat.h"
> >
> > #define DEFINE_FORMATTER_CLASS(name) \
> > -static const char *name##_get_name(void *ctx) \
> > -{ \
> > - return #name ; \
> > -} \
> > static const AVClass name##_class = { \
> > .class_name = #name, \
> > - .item_name = name##_get_name, \
> > + .item_name = av_default_item_name, \
> > .option = name##_options \
> > }
>
> Looks good to me.
Hi Stefano,
thanks a lot for the review.
I have applied all the suggested changes (including those where I didn't
explicitly say I would).
For the avtext_context_open() function, I have introduced a new structure
AVTextFormatOptions to achieve a stable function signature that doesn't
need to be changed when adding new options.
This is done in a separate commit. The other two changes where you mentioned
have been moved into their own commits as well.
(V5 patchset coming)
Thanks again,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".