From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E65C54D006 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 00:32:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A4C8B687DC6; Wed, 16 Apr 2025 03:32:07 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2100.outbound.protection.outlook.com [40.92.23.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C8F7F687D14 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 03:32:00 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TUEBPOqZPfazu1f/maLnyPNQxgrKfsfryS/f3LK/eP0+GlZXsf3OZLjFB5xrJAU3bKwO3CnfNWj0y1v3fDGcUOatQ2bIv9QIFcHvBXMpqkju1ESkMZEhThhsyG71V6Fm8ILKt0hHDnYKJOU944pKojKcn5GcGnM6+uMa2pwU7K2Hk3WSDWiPEOgm1pFUuMDHsH+ekNcJi6SKU3APMTj+aS1BZKY31CzdKf7TmOyJ4vL/t7/CcioewXmxfpYAjKi8/+skXSu7stISLNV5ywHQ21RnAUBnOIyroQhT1dvqNMbKXflnkK428Eo+0b/8DaoxOrcygAbbJZXrKdxhkf/mnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OPNbw01dsouXSCggN6LJD70rzk+oGA6a3gSO3XWot0U=; b=LEz2+eYc/rTjDCT7goco/8ighx0lxaic120Telh06o7dEcrTuc56k6ZYr5oSxBMnXJKP+JuyZUvrG6TKTjhCLgyKZgTkVRm1/v2krHHGRta6Z2TxNf5LOt4JYb1Gt7T9VOC2Mf3PMGiX3ri8M0MmGoxvOLyT/M14Tu50FXLccqxAm7lmiCof6NB5w9gqj+nrURH2EqkfTBdXKDMBd0LPNwlHFpxHwTaB5p2CvmDRVcxrkSVg/BOfWYaA/EfiBayaclo9YwwrM5wWrtAJTRSsha2vkb9gQGxmxIrN2V0Z0VgGsmWPYKJZLdu8JL1bRhi5fJ+/1VZpweeI9bHV3f7HSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OPNbw01dsouXSCggN6LJD70rzk+oGA6a3gSO3XWot0U=; b=Zb7qPkYRwDrbYT/3fhIEyQ1gLvEBMYLGLsTcV+fictihHC+OCyIz3xFNHoo9pEuD1P79n7AgrWiRhirn8kdjznZFten+HTC1XE5MujgxfWSJ9+8DdE6azmxJziQ/TK23koHPXea9q8THbJ1Rka3kKeXHoa/ONQ6FQ/wAXKrrYVEH7N73rCy1RuAFlr4zK5/b1VsFa4nlvThrZGMV90CZK9Kk9zH9v7I5DI6rl1wuSvZSt2hKDZiSdt4itiQM4CAex8k6WK4MVAk0Ay2X2TF7isENxsJjxB0XWtkMxLtryy4XPGbnZfC/16DfobDVhLizpnm3lNJK4gvT6q5ifhlHiA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH8P223MB0575.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1be::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Wed, 16 Apr 2025 00:31:57 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Wed, 16 Apr 2025 00:31:57 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() Thread-Index: AQHbraHTu3l+JvRExU60UdWjAjGt3LOj7GeQgAB7K4CAAQCBIA== Date: Wed, 16 Apr 2025 00:31:56 +0000 Message-ID: <DM8P223MB0365A746840DC346FCBA543CBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <GV1P250MB0737FC8C3B89F1100A6324E38FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <DM8P223MB0365FA00332594FD619AA750BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <GV1P250MB07376B6342E54BFF4FC853378FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> In-Reply-To: <GV1P250MB07376B6342E54BFF4FC853378FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH8P223MB0575:EE_ x-ms-office365-filtering-correlation-id: 7d58e2e5-f04a-4eab-0954-08dd7c7e182b x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|19110799003|15080799006|8062599003|7092599003|461199028|102099032|3412199025|440099028; x-microsoft-antispam-message-info: =?us-ascii?Q?6x9TxNqxt2OQ3zwvpsWerSpZvgHzlyNzT9e2wtP5KWjEN63BaW6JPtJNXTme?= =?us-ascii?Q?N5wxV6YCIXt3alMhQpb+gCM375koV8b9058bAzxQi9Gu60rIGuogMcpRoAwG?= =?us-ascii?Q?laZG/Lquj+kW7PH1M7ECjPNgKW3ZfvM0Nkrw/qq5KlTgT19jm9sdQizYV82U?= =?us-ascii?Q?qX20NZaPoowa3p7rHc/4/AkUFbkztTo4X20ueQJ4v/JqRRsinulb1kh7ThIA?= =?us-ascii?Q?WxjiwonOb0aSWQUS6j9tAiZW0iO8sNHbBvBaOizWPIgr2eH6pWro/oAk+vAA?= =?us-ascii?Q?XjTU14aM/hL/5/Dha9gkTCDIuNgJB5g1rebxemY0d5NCY7IHCVX5Iw85Qh7F?= =?us-ascii?Q?xb/7HRmsXmqr2gp1SDNbQWP4qRqyhtxLEL7Stru173eGCj6Ep53zXSW9jawl?= =?us-ascii?Q?9lYnOXIHI+l2Hg7NgR8ChEUtCbIJNdTxW8iIouzNiCxHSkKZd+BApXgNYdjz?= =?us-ascii?Q?zP/qDiTvW+1kC2B1DDsqKF08UGMzslCnzxjW6sa3KbZEd8cn9SGkF27Wrs+S?= =?us-ascii?Q?Q7DOBbB3gw4BA2nBcp8UchM2MoE7tarh9HriqpbgJxfAeZcGFX9ubozGW+AP?= =?us-ascii?Q?wQIpXQ3SbByPGk7nnpnIFKMvLjXBEsaTqKhbC9ZDQd3TKt6zok3O83EB+dqV?= =?us-ascii?Q?mDhdI/cU3lDTd3NtDzstWyNjdtzYsbg9cb7HjOFH4hw1bOGPP0z8NIfzeKpd?= =?us-ascii?Q?HYBjatbgiYlwTVhww8gmpkUmoJv2BdXji74CbK3X1nAuumeUkghY5xTyE8a+?= =?us-ascii?Q?jZ9qyn9oWHUCYmnQlg09F58DqeVw9AuAQZoaZAwtSXvpoLsvGgNYN8rQnQ9d?= =?us-ascii?Q?RPNTYJuwp3U35OPkVOXJ4x8Mu3u8RcN4+9dmPK6+oU+M0obCLwxP41cXEFHO?= =?us-ascii?Q?PJmSGafmV4WnDuWTaYkJ59MV8F0jHt95eAZPMi1G4sQ0XpvkCOBekgjmLnre?= =?us-ascii?Q?Xuf5tCzh9g6rw8ny6n/pB3eAC5oBfCWp4IUjTDyBO3aYddsD9+lbRE8XUs1K?= =?us-ascii?Q?nhqyEbMvnr1offuLDbsLzP0luXYpgOu1XA2iiVYlVr27gdxER1BujtJB2BGc?= =?us-ascii?Q?7qrLOSsTLmKrDvWgfN4zH3E6z5UdpihBaZtzjvEQ6lN4W6XhPyI=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g5GKYN+9dqPmfUlHRmu9sFOt+kUksLdv/o4xSX+iWBBElS6v0N0SN3n7VRWf?= =?us-ascii?Q?keZxWNMq9fjoZj8x17YU4HeOg+Lqba1MxyXtcI7rwTfOqxE3R/yd0ldqshFl?= =?us-ascii?Q?qP6vMnY98gEIbeu/1e9wJXoAeo+2bSMuUC4k5jOCJqQiOwEjmeGTxqTIsEVA?= =?us-ascii?Q?zgHgx1tmdKeuerZItSAfFcBDtB5R2/AXRPTtU8xaiINpnrBu/erWC1ITqVhC?= =?us-ascii?Q?0tLxEcQwiWOCMu177VhvXTo2iYpUsQoHQBenpEcmRA3lSomgCEyPyoECL0ya?= =?us-ascii?Q?TB2mRfqUSRvKzfC0Vcvz9Y5vkARklybGy7pf73DNj4wcVNCMx9uWSIfVwmCg?= =?us-ascii?Q?+Ps1vFpCTzBifnbU8eC8PDO0JVG1ocVudr/cGm1Dn+niQrbYbegoBRVDTB2c?= =?us-ascii?Q?lx+fNYXkwoQbV9sUaGhfx/dnKk7mv7GsVHc/PAx2gyQf7a4U5TOrJ4nCMIrq?= =?us-ascii?Q?6XsOsFCSRiOGdpxaArUZOIDqOPUBcwhWKZDzc6BLvy42r3dmK5Wnvkgk7K1K?= =?us-ascii?Q?+dYfly4tStbt5/QI1gyUBuZJTjfP4JqHmQFGAwjW47D26nnCPIWIrhPGteHr?= =?us-ascii?Q?gRFelaLcTjJO71WFrUsg/6HepeUjoSsty0hfdtuhcyrPwuNjEiNxatt2stDX?= =?us-ascii?Q?/jlTBpFTbt8NBxBasiB9wQ288k1KNJ29opGvwdoJYlf68a8KJA5fOTgeP50g?= =?us-ascii?Q?mqPXlMlQh0qFmQzzplvEidVf6Mjj5DugcjAGdlUUWczbDu7cZhUJsQ9ty0uh?= =?us-ascii?Q?UAcdIrz916PNkflfEvn0Cb1lA1ok+3u2+0mx+o68j+tLf/YdM2CRhgolrcsE?= =?us-ascii?Q?Kpnr2ZwkUTQIGp/gGv0ZSCpbPSDzIMw1zoBazRJp/o2qMmhyQtXWP0Xvgeb7?= =?us-ascii?Q?NAk82UkZB7sGXjRgH7xR5FRMJ/TZphlvJlKgCeHj3qbKesVRpnF4uytBV7Pe?= =?us-ascii?Q?u/1+o+QuDSv+IUOzIoYkblBhroNzyyD7vG1hK8ywiJBKk2B0KB8ccYAZAqga?= =?us-ascii?Q?F6YN+TezG2qqAVQKq8W7/nsxuT2ukjJI9X1ZOfnUQYnknzpZs+qDZMwYhxyz?= =?us-ascii?Q?kkrl3ZMOOM06Gmv3T8eQ1zYZy1MF7Pqfgz4M6YQeQeJM5cuL7RUOPRbVxBxw?= =?us-ascii?Q?3odUMpSGjkWuVSPgaZdBB2MsxcoGRr5poGubNuaxr/s8tSL2p3rScdw/XVXY?= =?us-ascii?Q?+HHhtHPY66dFsLiJsh4Sqk0hyn1bnj1+Hd329gvSOKRhYzhO2uiwQE38bAQ?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7d58e2e5-f04a-4eab-0954-08dd7c7e182b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 00:31:56.9329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8P223MB0575 Subject: Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365A746840DC346FCBA543CBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Dienstag, 15. April 2025 10:36 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > >> Andreas Rheinhardt > >> Sent: Dienstag, 15. April 2025 03:00 > >> To: FFmpeg development discussions and patches <ffmpeg- > >> devel@ffmpeg.org> > >> Subject: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: > >> Simplify avtext_print_rational() > >> > >> Patches attached. > >> > >> - Andreas > > > > > > Hi Andreas, > > > > thanks a lot for working through this. I'll go over it tomorrow. > > > > As to not waste your time, it's probably best when we get those > > changes applied in a timely manner so that I can rebase the new > > patchset on top of it. > > > > Since you're sending the patches as attachments: > > How do you want me to reply with code context? Whole files or > > just snippets? And quoted? > > > > Snippets is better. So is quoted. > > - Andreas > Hi Andreas, thanks again for the well-spotted improvements. Just two notes: 0007-fftools-textformat-Use-av_default_item_name.patch In the new patchset, those macros are removed from the individual files. There's now a single macro in tf_internal.h and I've applied this change there. 0008-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch 0009-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch Can this happen? (yet I'm good with it) Everything else LGTM: 0001-fftools-textformat-avtextformat-Simplify-avtext_prin.patch 0002-fftools-textformat-Use-not-for-lavu-headers.patch 0003-fftools-textformat-tw_avio-Remove-unused-private-cla.patch 0004-fftools-textformat-tw_avio-Don-t-flush-unnecessarily.patch 0005-fftools-textformat-tw_avio-Use-avio_closep.patch 0006-textformat-tw_avio-Remove-close_on_uninit-param-from.patch 0010-fftools-textformat-avtextformat-Initialize-stuff-ear.patch 0011-fftools-textformat-avtextformat-Add-missing-AVERROR.patch 0012-fftools-textformat-avtextformat-Make-close-functions.patch >From my side, it would be great when we can get this merged asap, then I'll post a rebased version of the patchset, also accounting for your other review comment. Thanks again, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".