From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9385244846 for ; Fri, 28 Oct 2022 20:40:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E3A3F68BD20; Fri, 28 Oct 2022 23:39:59 +0300 (EEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2057.outbound.protection.outlook.com [40.92.41.57]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A785268B613 for ; Fri, 28 Oct 2022 23:39:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EamidCDpqb3Hrhmml8xqTRye4B/4HPhCT7/o7ouMxu9cA/6FLuKsHWlrdOZHWV6wf3ZUUk4L8DiDA8Is9U3VE/CcwRtt/bdBoM+54b9O0KYtYBk5l8lt9+rtL2m6gH8ePFys/+uyrHiEOmSotyHMvn+d3w53nHEs8ijD9dQp0no6+0ptla+ICLgWXJzLHkf9skxBiKrvgsmEXNGsuvgj3s2FwVGPLUq7/0gA/bY56nAYMGi4d5E6Py19rP9sKoj6MHSo2eJ6sY4jMtU6lZBEBw78nuVh3e8yAOBzYgfRGzg+lRt5Xae71u+5HfXsIN8yGrZ/eg/vaD/xnnGP6dTQxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjUJDa2oRMO/TWRygypLzm3BiJYhpNAQPt057oDAVw8=; b=iVi/ngSN+AZAYsogAWBMykTn4v9/1eOOtS8Gty+878HJPGC7IEHZk+6XgJy3vqWKbfj9LawQf5580INWUX/1mSfkyDfHcR0dPXBjNTrAkrmbjP/9itCg/TMNfST0vCn28E2txEIYih8WkrqWCPtF/gVxPbiPY3wceQycEvWV44SVVJomiLY15X/KqHI3JXBN96AVT92Li1UYW2n9pMwyO2eyIkdIMtoqonhP/0/N4SvgdOKFFmHNrNejh+8is9wsj7tyf9A5VD5B27y8NDmGceSG30D02MnfXH6pIuvNHbnl0jatodz1nGc79JYi8r4l0w1gtn5uYrJF5mSx5eA8KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjUJDa2oRMO/TWRygypLzm3BiJYhpNAQPt057oDAVw8=; b=joHo0+nEPPZ7ERc531tvDnPkO9FI1reXqoncPnDY+faO+6LxwNaN+V2NflsbMq5hTbrqbVWo+xL8aFHZIOCUgpkVKigpbJmP+hCH1hxm682ONVPcRbDwIiATVlBrRyc77X7bd/n/iZznlCuFKmp59VwfvLdOi7/OC8rlj+rVPP8/W9NpVW0p6Cb4CYSOkipSTR9zALM95mpLzwhESx8B2HEFGK+tHefGWr10bxYTlGgMgq1OnX9WGyV1bfXNpLTY64QXQri+TrNsUMk281f4ke67Q8KG9S0xX3D4QT+1VzMiVI9DSoxeE73Vg4hXCXRlHb/KVHHNUVUTAlnbsIjiHg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0028.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 20:39:50 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::4b66:8c2b:d786:9906]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::4b66:8c2b:d786:9906%5]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022 20:39:50 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare AVFrame for subtitle handling Thread-Index: AQHY6FIZ6iaATX3dY0mmlAmUcbv3h64e2jwAgAADECCABWtdkA== Date: Fri, 28 Oct 2022 20:39:50 +0000 Message-ID: References: <95e9b5f39f921151f1da2aeba099088ddb1ed0ce.1666689226.git.ffmpegagent@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Ex7ZPfXI2PMz85bfM79VKyC1L7WMkzH1] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CH0P223MB0028:EE_ x-ms-office365-filtering-correlation-id: ac52b169-aba6-48e6-9719-08dab9248fcf x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9OxgmiWCb7NSsWAud/KO8Fqg+z0RU19dMkNvnAenh5besAfbxCE5ecS83K96d5Wl1ux4VHHowmdEpbi3VBCxxWhBB52j5YFxAzQhld/+VBCkSfAvZ6SS4JbGhKeMmRux98h59yF3LBbGsrlLARF8EJNESwi4G2pGmnM5YMRslj9rP3opJSgqOtiXG7cIsBXyCyh1Kv6hqHf8I2+TaOnQCiqMAs9VsAmikfaQ8OoYFyG1XcnyJCKsl0BgCCybraupOHmray6QfoBN1qDACc8CsdsZiZW2X0aFaXJ3Xmy6u5VYqHHhVFNT66Yi+bFwfUR8omCW5jPpbc4aPrnnPGofQjqRJeY9ndwBwW5c3zDbUXjObJFLZ9IsZNWumhbNNdtcTQhV87VISNsWbAGoDboApMsJhtZFSNGUgPLXFDBe6o2lcB2e509v5fWSFp04yR4S9oVpex8UIiSIr4heSdcf2PVKNLMf84Bfx64+WGkmBpsJeQ99zNGrOy1RsHsY1xn9ZV4I1iYMajIwSaVDO5egC8sWhxNkYgZdEQJXmxALY14ULT2RitFvrQBd6zIEqrpdPkbZAruug0MfiF6eUiPRj78Sv2f7tR3iY0VSWwCb+/i5egMxmnIYqgqwHPvTEmo22bnBX7CZ6f/XObpvtfyqm0ClI8ptEwYT6J8SaYNiyCJ4iYmnxCuyxsIvNBxWAPdj x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U09WTEFqSldjMDlsOEJuK0phTDExR1ovMmllUWllb0hKNDdHNGU1VCtDZm84?= =?utf-8?B?Tm5NbzdDRkkvWmU5Wk5qZ3pIWU45R05XSHNEblBiRTZhcUhKOXU2UHIwU0hY?= =?utf-8?B?WnJ6R2lCTzNoZUlUbE0wUktudDRSZUxRMnlzR1NnZGxoT0lJcGhDSWp0UkJx?= =?utf-8?B?VWpKSnZCOTJnb0lKVVRDWnlqVDVPN28vR01BcTJoV2QrVlZlNHE4VTU1aGly?= =?utf-8?B?MFA2d0hkQlcxdmhLYzJEVUhDWG5nYmxBdFVjRFZ2ZVB4LzFVZFloYTFGRzVW?= =?utf-8?B?Ry9Xc0R6bGlGS0s1UlVHRE1iVUFqUnYrVVFTSWp4bXIvSGhEN0NzZzZDaXFV?= =?utf-8?B?M2dIWHlyMkVjSTJlTkJXVnh2Mmt6dWlDSG9FalBzSDFXQjRVZG56aHYweExF?= =?utf-8?B?NThFeE4vTWk5aU5hYXoydFdiVys4c0g1SUpsVmlZTUxNWWgzQjBPSVA3ckFD?= =?utf-8?B?Y0ZoNEpZcFVlMW4xQ3V6ZWZZUkNJVFNURnd4d09BTjlXN1VadDhjZzgzM2VV?= =?utf-8?B?SHVNYW1pK1JEbXpUTUt2YUZyT3RFSStCc1IrdGNDY0ppVUVRSkpmL1k0VGpD?= =?utf-8?B?TDhtdFo0cWswV2w2TEV2RkhXV1R2VHJCdUs2ZEhSMnZrNTZCOUlDTlh4T25Z?= =?utf-8?B?VmowQUZkaWFrYmNDTGVUeHkvbUh4VlIyd3pveExwQzkva0s1UkcrdFpYdTBU?= =?utf-8?B?U0diVW9sNnAzSGdta21ZaDVVdGI5M1dYdjRLMEJQd0tIZ1JsSGJ3WVhERkJ5?= =?utf-8?B?eGlSL0c5VmFXdmVoR3hnUEVGbFJ6NXNvT2FpVFNjNk5TTnJMSzJWcnVGUWpC?= =?utf-8?B?blZkSFZEZWVxbUpiZjBXbVo1d0kyQ3B1WldHZ2xuTnNJWWdselZNNjUwdUtO?= =?utf-8?B?WU9odlpqSU1pUkY0RUpXWkEwZllhMnk0RlB4Ty9mVjFmeExERHFzbkVNYXBp?= =?utf-8?B?RkNSbnJGeUVUZmF6ZENVbmZ4QnhQNnYvdjBqMmJOWDAxRzBsMkY0ci9XR2ZR?= =?utf-8?B?cjBQOFRTSW5ubkErV2N3aStTajltc0JoQkJEYkFxazBTaFpjQ1ZUWW8yaTNn?= =?utf-8?B?dVJObG5SVjQwYUNqR0FLY2VZOWUyejRsQW1hbVVocGl5SDJ3ak1aQ0pSN0h1?= =?utf-8?B?MGZnczV1cEZuUkRxRzV0TUZ0amhrNFdJRVdJcWlRT05BYitWRFJNTkpsVUZE?= =?utf-8?B?UWxZL2ZQT2tDS0lqKzZxQWF4YUlsR3ZiL0g4OHBMMVNqMUMwYTV0bG9VSE1V?= =?utf-8?B?OTR1OHZVU1JSajVNK2Y2SGtTTlYvcVl2bkpQVW1iZkhRbVZFM1ZBT3hTMVho?= =?utf-8?B?SllGOG9GU3cxb0w5UkR3d2RRa0tEOWE5SUZZdk03cXh2aDVKdXZ3R2l4cFdy?= =?utf-8?B?MEUxc2U0SUhxaWtZM1Z3OUJJSE9kOVNDRzl6WkNIMTVQL2h6K1VtQ1Y4anRT?= =?utf-8?B?VGZBRGgwQStyYW5zVHA5SWlIQ3o0U2xiQ2lFU1NYTGxGdi9wU3pCVEJ6dUU3?= =?utf-8?B?anZmVzA2QnNWWU8wN3htRm9mdlFKc2plMzNCcjd3K1M5NTBXUWppSkZRMjBx?= =?utf-8?B?TG5PemVUSG9uRWVTMWpMa0t1ZWhsVXlsUnB1Ni9oOG1IU0RWNTBLUTd1bzFo?= =?utf-8?B?Z1crdlk3YVd1NWQ1OFNhRzFrSmljdlBYRWpyNzlpWFRZdXFKc3pycDB4YlFW?= =?utf-8?B?WWxDSWVPWmNOd2RQN2k2dG80QTVhd25aUUlCZ2RYc0V4bEU1d216YkRRPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: ac52b169-aba6-48e6-9719-08dab9248fcf X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 20:39:50.8741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0028 Subject: Re: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare AVFrame for subtitle handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Tuesday, October 25, 2022 11:59 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare > AVFrame for subtitle handling > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Hendrik Leppkes > > Sent: Tuesday, October 25, 2022 11:38 AM > > To: FFmpeg development discussions and patches > devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare > > AVFrame for subtitle handling > > > > On Tue, Oct 25, 2022 at 11:14 AM softworkz > > wrote: > > > > > > @@ -712,6 +712,53 @@ typedef struct AVFrame { > > > * Duration of the frame, in the same units as pts. 0 if > > unknown. > > > */ > > > int64_t duration; > > > + > > > + /** > > > + * Media type of the frame (audio, video, subtitles..) > > > + * > > > + * See AVMEDIA_TYPE_xxx > > > + */ > > > + enum AVMediaType type; > > > + > > > + /** > > > + * Number of items in the @ref subtitle_areas array. > > > + */ > > > + unsigned num_subtitle_areas; > > > + > > > + /** > > > + * Array of subtitle areas, may be empty. > > > + */ > > > + AVSubtitleArea **subtitle_areas; > > > + > > > + /** > > > + * Header containing style information for text subtitles. > > > + */ > > > + AVBufferRef *subtitle_header; > > > + > > > + /** > > > + * Indicates that a subtitle frame is a repeated frame for > > arbitrating flow > > > + * in a filter graph. > > > + * The field subtitle_timing.start_pts always indicates the > > original presentation > > > + * time, while the frame's pts field may be different. > > > + */ > > > + int repeat_sub; > > > + > > > + struct SubtitleTiming > > > + { > > > + /** > > > + * The display start time, in AV_TIME_BASE. > > > + * > > > + * For subtitle frames, AVFrame.pts is populated from > the > > packet pts value, > > > + * which is not always the same as this value. > > > + */ > > > + int64_t start_pts; > > > > There is still no explanation here why they are not the same, why > > they > > could not just be the same, and which field a user should look at. > > The cover letter talks about clarity why this is needed is > important, > > but then provides none of that. > > > > "Its required" is not an argument. So please enlighten us once > again > > why we absolutely need two timestamps for subtitles, instead of > just > > one. As far as I can see, subtitle frames only have one relevant > time > > - when its supposed to be shown on the screen. What would the other > > time ever be good for to a user? > > Similarly for the duration, of course. I can even see the > > AVFrame.duration field in this patch snippet just above the > additions > > that would seem to fully replace this one. > > > > - Hendrik > > Hi Hendrik, > > thanks a lot for your reply. > > Probably I should have better advertised the article I had written > specifically to explain the background of this: > > https://github.com/softworkz/SubtitleFilteringDemos/issues/1 @Hendrik - did that answer your question? You are also welcome to contact me directly for discussing details or going through specific examples; or just to ping me for logging on to IRC for chat. softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".