From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 75A344073F for ; Sat, 30 Apr 2022 14:00:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6D2E68B251; Sat, 30 Apr 2022 17:00:07 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2055.outbound.protection.outlook.com [40.92.22.55]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 56E8868B18A for ; Sat, 30 Apr 2022 17:00:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=erK84sv1pAhin74KyJoebn/zJbL6vQmYhOnwU+3DbvwrW/9HzcA0VIPAwy/QFmKZSMERQwOLgAGIP7Pozjui2KO25whJadh/RQuESEyechJcS3fPxSZKazQUPsuOGVMy9sYk7uLnAp08ApkmoPcRhoAtxVCtwwDaRibMTLz/pqnd+9cJ3osW0r97HGJfVhnqlMnpmj233VB+V5faeQncAyto/s2F+x1PHnVlLmQUS0rF45ppDEaB/tZi9sG8a8Y29nlDFzBY2TC23faRDlNUw/0SorHOABYHhJKCn8khe8wg+tRUFhltuFSRPJdypHn+q+dmCGAGFzpA/RPWqTabOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TnlUE87wl433xBMxIQxCiFOZlU1xuBAebrvMHw5bQGE=; b=dDh+iL0FeSUuhBt/MBJMBcOXYsXYwmySR819MQ6tY8ajOWOhk8XV2DxO4X809iddfzKJDC+WaKAbPXDfdPw90XkLXKAVesclAy2GkRWtU5/2jkZ0uFLvyumvprZzobLX7Kn4hbc65k78HWpqIDg/WiPUOA9H6E60LwHDl0swOiGF8QdvmaYU8sSwBzP3plFzXikP44985YXDbcoSiRiH6dHfoxqnbHcs70INs4k0uWEu8GCG/jgBzBaP/yxTBooPUoJObQykcu2RdcOdUyws2VA/tAxoWnCQ/gi90bFGBuNBk80/PKnlLBxk5lwjyorem9+5Vy4gzrpfzv470vUJ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TnlUE87wl433xBMxIQxCiFOZlU1xuBAebrvMHw5bQGE=; b=B3LFTK1ImwH/JTv5Y/iGTdMMC8cNjcB7XYxweOItrOEj4OqPwmJcaz1BBQLiCrNY1b3+utikCzCNECW5gHYacX3k3KAqnocA2rGNvQgszfGA85daLbHWAdVszYmrNntWUti5MDSy9r+vp2BWVTvaA42/KQeM5nx22O9YxKszu1M9jDrJaxlniHriTdirNkhJ1rceHM0uXWmrnR4R82/Q/j0vMpZahHL7/m40oEi3CzY2m/d5fuEGS3Hk6XtXWPa+hpYBRNK7kLGfFBzI6ee49t+UtmC7GNmxMjgo91E9WlW09H3UZSb56Zsu8q6M/Z4zYpdgY58ftnuJt7TPrfFzbQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0023.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:15e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sat, 30 Apr 2022 13:59:58 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5206.013; Sat, 30 Apr 2022 13:59:57 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag Thread-Index: AQHYW7ZG7PhAR+3Ey0KAzg+WBYVY360HcgaAgAEHemA= Date: Sat, 30 Apr 2022 13:59:57 +0000 Message-ID: References: <20220429104505.1747-1-tong1.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [pJMvhbKAxC5f8JShK0+1Su9iboisM1ie] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 730ff2d9-716f-4e46-d848-08da2ab1b606 x-ms-traffictypediagnostic: BN0P223MB0023:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A3ZabkaxlbhFOurdR/hx5vzvzME2xqLR3kT1QNeqj6jS4MWQGB1c7smG7L+T7o8r7MTm+SpGqX0atQ8ZhpoLz0x3VxjsF++z+sVk538YePOapZrOO6j3ji3XBR1sQoaKyHzKhi6oSNrvK6x5S3KwXRtXZ4Olf5W/gEmwkW9jZMtm4r2Ert3+46V29YBb3Rtnv1O0BqETnJwiYxNBF8iUyrwZ6IFlI6i1nhDyj77GDdNCh+vL6IIVS4JA7k7Ugv92jNnW8dM7YI/5oVj/5snYKs40FFsJjdekfz2aPtnbxuWR1ecn+YdtCTFBIZMg0/NzwSSolcjPLasw8fjBkjJ1iYeMbl2FLLYKcuR7OUiI+hBxavsuKtzRCCoc5GKv3AK78m2PXODognlANNqOJQeaqhQLV/AI0a+D9i5p2V2o+RC16eFeJ50KOnQl5ns0EncvAA+MD9S1Cb0GNM3TH/Q64+8EgfRHGB+PLZBw11Tf14SHin7c6WMFn7veAaxeZgno3Ws7Hbhj6nDa9847xosKcHeshLyh01kLRZM+BTsZUD3CYB6J9EhcOK/dnUbZ0sg9SLOBN64DdX3lvf5zWJL+XA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eVNLUkpoK08vSXpqeTVKenFDQlFSR1RFdytuUVIrS0pGZVFzMmFVc0pLVnlK?= =?utf-8?B?eTBiaW53U29yQWRoWUE0bEhCdWhLL1hCZXNtZ3pWS2Ntd2tpME5SZjdtdFl3?= =?utf-8?B?eEZxTnpFSHZCU0xjS2dTSXVWYk42YWxOMDFzdU1GNmlXMHh0aHNSd3FQTnI5?= =?utf-8?B?WmI3SWF2V1B4YVVqaUZKOTBFTCtjaDNreDlJMVJISklJek5BZEZRR244QTdN?= =?utf-8?B?ZFppenIySjh0RzRwL0NiYWVHRWZFU3ZUWDZvMHNXaWtZZlBESlRRdFRINzFx?= =?utf-8?B?NEZoSFlSOWhlcDNQeFRiRitibVozMkVOODc5bFFmZVg4NkowTFh4eWowZnNl?= =?utf-8?B?UGExZGREM29TWE8rUmt1RTdxRTZoeXhRR0dkbnYxVkwraXdaNmNQT2gvUSs4?= =?utf-8?B?algrYzZXcjg2S05sajVBMVE0K2htcEZWV0NUbStTeDdWOEZWcUdwVHAzNTVW?= =?utf-8?B?d2VqWkdtWmE3N0h1NERFdmxyZVp1Z2prQjA0REx5NVZjNUJwc1lyQnViYTNP?= =?utf-8?B?Rzg0SDBOSHkwYWpGZzNqUlQrVkFjR2xHM0ZWd2RsSk5SMy85cWlTcWF2RzlS?= =?utf-8?B?V0ZRdlQ1ei8vYkQ5Nmh3MGdUcHNnSEhrbGpYL3dkSllraXZEODA3S0I3NWpI?= =?utf-8?B?MzYrQ2pEQTJRVVM1SHJXTnoxOWRhMjdsL05DZVc3SFhzZWhQdUdST1VCNkVr?= =?utf-8?B?amRmN2Y3V0xlV0xCbzRRU2JNZGZXU0t2SkE1ZHFrakRXOXYrak1QSmdnd1hw?= =?utf-8?B?N2tNSVVTL0Rsd3dNRkxsNk9JTHkxYUxTMTBnUXVmVSt1dVlHSG9RT1V0N2M0?= =?utf-8?B?N2ZHOWR6ZnZNZmJQSVZUMEtnb1Q3VDRLc1grc2wzNXBNYjk3L1RpR1dOcWJD?= =?utf-8?B?T0dMYkdGWjJQZkx1WTI4S1lpRVZUbDJHYk0wSG41VDdvUUROQjF6bGNDK1M0?= =?utf-8?B?SFBLMzRQcFNlT2JjcjhvaWV1SXhIMEdUZmRGTzYyVC9GR1BGQk52b0RQaWE0?= =?utf-8?B?aU0yVXpQdXZPUkc5ZGFXTDFzM2MvbHd0WjhNZlZLaGp5TzYvUnJKMDFiOUJu?= =?utf-8?B?ZXJIbEJOUzFYK3BjRkZkaFJrQ2luS2l4UTNvN3dqb1YxMzV1YTkrNGJmZ0t2?= =?utf-8?B?a3N6N2RiRHR6K0JqMUhmK3lPa2hxU0RzNnNoWUtVMXFuZndQL3RZVTdsWDYy?= =?utf-8?B?bXN5bFJHS2E3WlRPTTRlbkNIOWtiTnpGVHA1Q1dkdjNvWHBjOENkdUQzQmkx?= =?utf-8?B?Z1Fidk9LaGkvZ1AyeE5OS1VFNGc1TUNmWnRFN1QreXVRREh5dHp3MjRIeTJZ?= =?utf-8?B?VVMxUjZIbndGRjBDWExEYThzV3FHZVY3enJtMVRKMzRYclBETWc4U2tkalFU?= =?utf-8?B?MzZMWmtzdVlUSHBLZ21rNUNKWVpZV3RWa1dNbnhEMFZyUjBGRzRhaW1IbkIz?= =?utf-8?B?Q2ZvMnhwOTd3azYrdWNDOENWRzAzWFFmcUk3RVBXUXZNSW1mOHZQcWZJWmor?= =?utf-8?B?bktEclhJOXdNSVRvNjhVNENUQmNQOFpjQ2I4M0F6aWh5dUVmcWQvc3J6VU1J?= =?utf-8?B?UHlNSVJKWWs1WkFxZ2V0cVM3QkozajRWcGRzdXA1SXVHbnk0aytmZlNGdUtn?= =?utf-8?B?NnJmRUJsNERyRjBoVW9OM2l0aGl1ZEU0OCtoMWdLWXdvK2pudjVDRXF2R0ZX?= =?utf-8?B?eHZlSmhqUStzNTVNdTdNcDVuL0VkVnF4bUhCYllKNHo0b1hTYXpSUVp1bXho?= =?utf-8?B?SUo2bDliT1U3N293SXJ1VnNHbTVpZVdQbnF6MmFvTTRaeEhPU20vRFpqS2RV?= =?utf-8?B?UFRibnVXV3p0cU5Edm9uRk5MOVJoWWR6UWhyNHNZbWphdE1qZzZqbGJqbjVa?= =?utf-8?B?eWtld3pyVW10QktVVUZxZS9tL1VyemNMQ2U2elYxMVE1SFpjUkpsTU5OMUNG?= =?utf-8?Q?LvhDR17S+Ik=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 730ff2d9-716f-4e46-d848-08da2ab1b606 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2022 13:59:57.7201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0023 Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Saturday, April 30, 2022 12:02 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: > fix the uninitialized texture bindflag > > On Fri, Apr 29, 2022 at 12:45 PM Tong Wu > wrote: > > > > When uploading rawvideos using d3d11va hardware framecontext, the > bindflag > > is not initialized and will cause creating texture failure. Now fix > it, > > assign it the value of D3D11_BIND_RENDER_TARGET. > > > > As with similar fixes of this nature, this implicit behavior to fix > one particular bug does not seem fitting inside the hwcontext itself. > There can be a large list of usages of the hwcontext that all require > different BindFlags, but we can only define one default - why this one > specifically? I agree that this change is not ideal. On one side, it is "safe" in a way that a texture is practically unusable for video processing without having at least one of the flags (decoder, encoder or render_target), so this wouldn't "hurt" anybody. > So rather: > > Where is the context created? Looking at the command line in the commit message, this is about standalone D3D11 context creation. > Why is a required flag not set there? That would be better, because > that knows what flags it needs. There doesn't really exist an appropriate "there". I see two options 1. Add a generic internal device creation parameter to the dictionary in ffmpeg_hw.c like "standalone=1" (for all devices created via init_hw_device) Some time ago, I had another case where I thought this could be useful. Then, this could be used in d3d11va_device_create() to set an internal field 'default_bindflags' which would be used as condition in d3d11va_frames_init. The situation would remain similar though, as that when the device is used by a decoder (which sets the decoder flag) this needs to override the default. 2. Use a device parameter specific to the D3D11 hwcontext This would need to be specified in the command line. Everything else like in #1 What do you think? Best regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".