From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EAB1940B79 for ; Fri, 4 Feb 2022 23:25:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B09368B2A6; Sat, 5 Feb 2022 01:25:07 +0200 (EET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08olkn2010.outbound.protection.outlook.com [40.92.45.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFDAB68B183 for ; Sat, 5 Feb 2022 01:25:00 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mnDVXQCzW55AsfClzRpwrYlcjNwiR+E/10sqqV49oGBHozy6IWaRbeHwJ22wsWnUWAETxjcfGl3X1EjE1rIrbxvuV9l8E4Sjiwl+li7vEJA8U2mvc7SxoVGAJO2A9+n0Os1kp5aO2RN6w/14gNs24yVzlnhtYQvZ4eOupZPip1pBVyrbeRyXdUOU+UARWdZQrRQ6X+7gyaAeLElZqqawebjHqqnrXFEn7XED0pahrVVijsLqzAZMor7DGIIGop4c4F4AjhhrgVrfZcu07/iXue9vXlRv7fPAIkqSmFQz1xYekedw+28ZU3k/4F9TmV5rdM9ri05DVSgEB6EdLjNGZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VgJ0s95J5pX5iD5q8KR6tOzh27WCScjj3Yt3XT7Mq/I=; b=oS8+YtG2CuudYjFuoieWUiYKqOTyrr+7gBU2zcGuRKNb2sj4ieqQC4DDtnMrkBfdQa9wCLHUcPRzdKG0LwP5AJsL2reIjRDSDz5/reo7nZrK6uO6BfMpJhanq4cTenCGJNJpXahwVLUL9S7tPHxdbOY+LiC00xRVWJJqHRxm5IR44a2Am6iPcYK45k5785cF8ib+O1p1ljX8J1mIzjFoSySpNAsvJff9+B7TtrF8JMd8+Ro8o7B3aGwmpI4/wFJ3quIkxVmQxbCM3VTcrC83Xq/yV68WjYkqJzk2cRfXAsiIT2YEA6B5ODmV9hCU48zVg5/b4PMLQyOzGF4jToGVsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VgJ0s95J5pX5iD5q8KR6tOzh27WCScjj3Yt3XT7Mq/I=; b=LXY5IJ0nNWr5Bj7db6Vf0EE8FUvp2tDM0035yEnoJqMpF3B0bcYVyNOZAWdFruRfbXn56gI4A8ww33lRUhg+4WgVw4uKDe3PuBAgpvLx5fz+uN7slaVFFtw6ue+FNqgvH0OvyAsuNHdq+/POk8X8DuljYtVcLvR+ruV5EgkJUQEwZQS1h0IaDcSAbGAUgYaOkk3sf8LmkI9VEJxAkIN08FWY26ifMGfVWf4W/+ebXb0Ob4Y1nZIJjDzqjSBamnvwTy0tYoyfpwRz74hDLpiXE31Te9qBQtKM8VS93SNz7A9QszKs/bbaN0cHvf5urpOXc4HTpDMmV7fBzuUsj9S7LQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0005.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 23:24:58 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022 23:24:58 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes Thread-Index: AQHYGhF8jFRG05hxM02I4Vf/9Ft7TayEBNHw Date: Fri, 4 Feb 2022 23:24:58 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Ia5J9P3gEvCdYttpEsCfhSh5QcJEXfts] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9fc284b2-8876-42a6-2656-08d9e8358f73 x-ms-traffictypediagnostic: DM8P223MB0005:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b4GAAtJCiSufs+ZBK9CFQUIZ8x3S5Ks47/ccNR3ZGIOpkyjaOG7+rP2VRzMg+i6X1Wn7QntpYAGUrEVRH9EuvwOigUkHydUsEN1FYQeONJ0KBz81eNZy24wivqdRzrPJhznRfKXcB56k/0EsozB9Sf7rzO1WvIyHmSaI1+K7BLyueNcEqJeBcmuVXDw8psxeYLffGFUFk6YinUx+0rd/a8l6y/mdbdm2MJ9G2xBrQRpmmAwdPUtHJFQAdRYcM8OAMg19joyMqLvrKqtx08vaINdAtVT1x5YR8Nu/flheBkomy+KGyH2eAUUMacWf9gKdeMytz/RIllI7e00+6syD1KJ8rHsp9MaiByHp11fTQKnLZY6LhAOCccuhdBHnbKz1Vn3SE+e94zTG/LoAxpZalRqKxweYK5joGVp7tSLnFQFwoC44dmoVohou+ZmtBW+RJLhOdgNdZe+3GlnMH4pmCvCofDGu6QdLCvNeZ/v2kjW5K9CjSGD4OuBrIZCgBAdIiUBxdkErA7fku2rnvl92mxOqPcw3LclqVpzGPi47PcbiFd6OhNTrNJg7XhTw+sV8591wACqG3nhR3RdHD3JnqTJh3XvuCtrk9OM4zaVWhyK178baSQU3MIfnFffdIzdX x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eDV5cXVQQ3JkT1I3RlI4YmtyTEtRUk4rQVIvVnZJV3VkcG1jRmhPWUdzUkFR?= =?utf-8?B?K1g4SjlnQzMxYjhNQndENHhBa29senpBVU1vVzdBcG9URXhPZy9hT2o0SkIr?= =?utf-8?B?RE00dFUwTlc4dVo1aXZTVS9TZzFHWnBxcEwydVR6T3U0S0pYbEpkTVIvQXRL?= =?utf-8?B?UTRsRzJuVUpQcHFiZU9MZkhyT21sZUxMSlp6Nm1oMkRKNEpPZjJWQUVKclpB?= =?utf-8?B?K0VLalZMZTVhV1lyMXdiUWhNU256cGRsQXk0amVFRit6VnE2aDMybWhTZ2NU?= =?utf-8?B?N3ZNV0s2dEhidGU4aGVxSEIwQ0FoTnZqZmlYRGFYTFJKUXlkb1BjdzhmZjEv?= =?utf-8?B?dHc5dGVKcEwybTM0cmJDT1dETWxIbjRCL0RkWjY4UmQza08rRFZJR1N6T25T?= =?utf-8?B?cDJhS09rZHRHNFJYYXJteVpzNURCY29YU09ZbWI1dzFpbmJZbXFFQ21YYzd6?= =?utf-8?B?UW9DM1BTYzJaaEF4dWt5WWdNVEZiTFZyZ0E5MUczQU1ZWFlFSUszMEFRV0xC?= =?utf-8?B?UUdPa2x2alBLUVcxYldUTktDN3NuRUp4UkZVTFRLaFByYlRWZVdJeUk4cU9R?= =?utf-8?B?NENNK2hZNytDdTZHK0tjaUtyUTBSeGhZQ09QTFVsRWk1dFUzdU1rempiSXk2?= =?utf-8?B?YTJhY00ya2VzQk9TRThkeUhQbHYzcmRNdzBZZmNFcHl6QkVhTVc2YjMxREhT?= =?utf-8?B?Mllsc3o1MW9kVm5CNGZnejZCMUJWY01WUTB0ekxQUDN6SHptWi9FT2RYTlI1?= =?utf-8?B?T1h6OXAzZCtFd1g2M2xwdTVPRmlVKzFTZ2d5MFA3Kzd0NG9uRStNV2pPUlZC?= =?utf-8?B?QUV2U2QvT2g0R3RGcjFmdi9YSURVSmRhZ1F0d3FRak82SjF4d2pTTWZFUFZo?= =?utf-8?B?T1cxRXJuY1BpRkp4a1ZabE9GbFFRRWhiRjh0aFNsd1dzMDNQL2xuY0czakl1?= =?utf-8?B?YTg2aXNUbjFDaXZwbEl3RW9SOUtwUTk5b0xyeFFBbitqeWNNWEZJRCtPeStr?= =?utf-8?B?eDRKRWJZdkZmelRxZEIxeGlOd3lCT3cyOGVDUlBLRmt4WDkxaDlJYyt1VmtI?= =?utf-8?B?UGRIMStPSGdmQmlLVFRFNlQ1VW0zbktXRk4yaTNMZ1loZkU2R0ppSEJBVWVw?= =?utf-8?B?SUJ3djBkNUxkZlVsaklrTGoxUlJoVjl1TVdXLzdDc0lEWXVZLzdJOHo1Y01Q?= =?utf-8?B?ZmJkdHBkbGxWZ1ZwZEZEdWRpWGZFKzRvNTZmTTlRT0FhdEJEZnlWR2VDcVkx?= =?utf-8?B?WTdERGlkOG1JeVlkaTFiTUhFSEZJQVJBOGZvZXVQbVlGVlRYUT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc284b2-8876-42a6-2656-08d9e8358f73 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 23:24:58.6453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0005 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Oneric > Sent: Friday, February 4, 2022 10:52 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix > handling of backslashes > > On Fri, Feb 04, 2022 at 02:30:37 +0100, Andreas Rheinhardt wrote: > > All text-based subtitles are supposed to be UTF-8 when they reach > the > > decoder; if it isn't, the user has to set the appropriate - > sub_charenc > > and -sub_charenc_mode. > > > > - Andreas > > Thanks for the info! Then at least the UTF-8 assumption > is no problem after all. > > [..] > > > > I'm not sure whether all ffmpeg text-sub encoders can handle > > those chars - which could be verified of course. > > Since it's in the BMP and ffmpeg already seems happy to assume some > UTF-8 > support by converting everything to it, I'm not worried about this > until > proven wrong. Proven wrong: https://github.com/libass/libass/issues/507 > > Finally, those chars are a pest. I'm using them myself for a > > specific use case, but when you don't know they are there, it can > > drive you totally mad, eventually even thinking your system or > > software is faulty. > > > > Example: > > > > Open your patch file [2/2] and search for the string > > "123456\NAscending". You can see the string in two lines, but search > > will only find one of them. > > > > Or just look at the two lines directly. They are preceded by + and - > > even though both appear identical. > > Actually, I see this with helpful colouring lost here: > > -Dialogue: 0,0:00:55.00,0:01:00.00,Default,,0,0,0,,Descending: > 123456\NAscending: 123456^M > +Dialogue: 0,0:00:55.00,0:01:00.00,Default,,0,0,0,,Descending: > <200f>123456<200e>\NAscending: 123456^M I didn't say you won't be a able to find a viewer that can display them. :-) > More plain-text oriented editors likely won't show them though, yes. Yes => pest > > That might be true, but I think it's valid to say that such > characters > > are very unusual "original" subtitle sources and that's why I don't > > think it's a good idea for ffmpeg to start injecting them. > > Don't underestimate what subtitle authors can come up with :) Sure. But a subtitle author is responsible for their authored subtitles while ffmpeg is responsible for encoding of large part of the world's subtitles. And from that same perspective I find the relation of this proposal somewhat insane: You want to "pollute" gazillions of subtitle streams in the world from multiple subtitle formats with invisible characters in order to solve an escaping problem in ffmpeg? softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".