From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 083C74117D for ; Thu, 16 Jun 2022 00:00:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B8F5E68B6C0; Thu, 16 Jun 2022 03:00:50 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2053.outbound.protection.outlook.com [40.92.21.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B50BB68B574 for ; Thu, 16 Jun 2022 03:00:43 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k68moPl7b/0PG8MLjgAAJYvojjVa8YsMyHLdtOWdFffofvSb8BO+dNmcBAp++oS98J7ZEdyIJNt+f4ormvz0wb84bk/LIkBIdAL1tKS/rCvDLkC9Dl2X60ihnCySoDYZljksaN96zyk6fF4nZiSxyHundLuFfet8uEj4XtbonJlJJWWH3vvDR/gOS9uSaPUcNMIE/xiVaTIjS6RyNCXRidWd3CNLESlRGvqiIvFZZfV6+k5ZmQF0cenayiErO6+5dUGtgkc2BIwvyG4PLBgFom+CQ+0Mvz98KcKOKkhIp8hMLaVfBsdfyfznOU5agUL38ji1hbMZ+UVbF0HsuO9r2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GpF7ydWf5YmiJZ7gs5pgQpHW/1l94KaVA3xVL0Oyyc=; b=cjqMQ+1jm6oKIoLUAWPPX5u71zs5OnZynZrz08o4v6c3aWgLhF0uxJpTa4Piy/TPrepFoxI6eBfpWwEPkY7JuqNrDr/Dbsa1XPmCWqoYMkfNXeqlLwGkU/+Cx3JGWczwPimqXByfZYR7LNBbNThH87reRagWpV+R2ksETcM14rq7hmRpqx0JPatoiL5Yc2LhBtPcKNvj82b+DnF96myekOVGHvIYcav1z4beixO0YZK8sw59+KE8ueVPNUlWG4hc1Mq6iLJEWvpJjweJeDDD663anSkJwwkac7XhVxRmIsDUleAGINyHh4sdXHVGcniWwkwNtBrJjOq5TVpra3trRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GpF7ydWf5YmiJZ7gs5pgQpHW/1l94KaVA3xVL0Oyyc=; b=VedHKpe3y/v+PiFIgGlj2G2kiSDsm2h5zMoKOGXsbzcu6usdNQ5ed88lpU/lHe1IDwHeTDx91aH5Raj3grPmbBDUwfUnlfPK1/nG4IUjPB8blLRy3PLY8d1HZ6doDMb7leCMbmLBB8gPU2EjoSTGCv0SK0txH7TrUjg3IuDvtGzfvn6tFHwVM3tu+AKI8gbYQ4YBjFPVUhAd0DjlpAbXKwwCLfQowp+EuE7lNFFLv7VGn20mOnsP626f09sviTDcBlJG1KuQ/LYtrX10U0dpJ3o77ZF+S17x8f7BM7y5cLSOrphX4phF/VQzjkLgIrdKvtD3sIxNdpCKaNzURiWtYg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0157.NAMP223.PROD.OUTLOOK.COM (2603:10b6:5:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Thu, 16 Jun 2022 00:00:40 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d08c:b865:df15:6a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d08c:b865:df15:6a%6]) with mapi id 15.20.5353.014; Thu, 16 Jun 2022 00:00:39 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Thread-Index: AQHYf0Jr6qpkXsE9T0+yfFq1DsaMA61Nu4HAgAMrAwCAACN4IA== Date: Thu, 16 Jun 2022 00:00:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Cs+t5qFoO4y9UVOmFxe6G/IZA5F/p7iO] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8c92331-42f5-4c4f-16bf-08da4f2b3fc9 x-ms-traffictypediagnostic: DM8P223MB0157:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CyrHq50/rHO7E+EIRwep/6nUGSCXRMWIo6KwvvfYRkmgSIasV7ghYTp8ahJCFRds1aLfxM2eNwztgPjZCon0b0rl8Qn4Zl8eFDR8GdXM9LmrYGT/eRe9TvSUXM1SvU4aAC8yZv6QVl+qAXPqDJmI9WzWcCjDn+0bhDZp6xQN8MoBdbDOIf33Qs22kf82a95y/G4bi/c8BXQ3f7oSsuiEzAJf301WWOYyFHrbfGxEg/B/2YnUVYhCIYG5zcV3W/w02659wUA795ObhrzzctF4K2wH7eH6i+VJkwqLMK9KZNj/ZfSy3yEFgYdNR/s8VFDoLyD9lupkvOITawh9djLwTWB6dtHno2d3DUr+t6qhxeilRnOjzBxIvL3ypbP1au7mWhBp7SV8fxAlVPw2PtSbJAsXb/rFy6nEsp7B4zakf9b7vZym5+a1CMUz+UwPtJ4ZtQd1Wdr9IDjZrtk4FyceTHXDb2Sy5utHvyeMBj1E4odhqYYuOXBusLcd8ObxrnoY7XGtX/+Vslew3059MTk6i8dEwQy8EExUfmU+0fZBrjYCm4BdLvEnFQQ7zM4STvA+R7CuTZBBmiXbZ6g4QRIvnj4KeQH+5hh7X0eSCBzlx0NGuA8CW38dVNV7GwLLWNnY x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UkxpTjRDZzdaZ2F5Y05yY0RnZk1xUXhEK3NiSkhQOW53VndrNmc4OU9SZklJ?= =?utf-8?B?YjR2Y21xNWYrMFFYSDdWZXpkOFk2aExuV1Z1RzdIVnhseWZSKzY0eEo0R21z?= =?utf-8?B?S3h4NjFuWG9DS1ZDdXhPRTFYdHE0SUkvYk10bTF2WWM2bGFGU09sYmxvcXNG?= =?utf-8?B?bjZrdFlHdnVjMWJ4R25QVVU3cTg5dGc5MmN1cVpjcEU2eStFKzRSbC9aSlY1?= =?utf-8?B?MXNkMm5tUUxrSVUvUTNBSEl6elFES291aFZZQmdiZDVKUzhRek9FUktmeEhq?= =?utf-8?B?SGR0Ti9wbzg0ZVpIcmhXN2JWVi8wcU5zYXhqT0xwb1lTWXBNbkVFeEtUOHFM?= =?utf-8?B?b2JEQkl4WW0yUVU0dHZVSXVuWS9OOXROenVHUzhwQ0dyaWo1aG1GZ2ZWSU14?= =?utf-8?B?SzlZSnlrR2xlL2RpcjRPcXM0dDNZRmVFOGZzVncrUDZlV2dKUE1WWEM1b3hi?= =?utf-8?B?VzZaMjhRQzNZK2F5V2VMK0MySmhZU1FCeDFIa09QWG9oNE5ZbXQ5eDZWTkJP?= =?utf-8?B?VzRvSFZoWUVGV3AvRXNTZlV2b3ZZYWJNKzVZcjhvY25TS3dwSHZXUXJOUklk?= =?utf-8?B?TVdaYlNDdEJhZEYzV1BnS0pERXpwSklEL0NXVDdnbGJoRUc4dGRlOGZDclpv?= =?utf-8?B?amtLQWZibVNxTVNzNUlQR3lTTm5QbmEvajNxZDhScnl2SGpTSjBiM2U2SHlV?= =?utf-8?B?MzE4YzF5TExNWkZhVVo1OXBQNzNvNFMyOEVNOTIyR3dwbHJwRDRHellDaVM1?= =?utf-8?B?eFhhdEZrY3ZCbmdLRXF3VzlXeUpFOENMaXl6QXEvbm56Y21jSGI5OFYrOGZu?= =?utf-8?B?TUY5d0g5SHZLNkhJeDQ3cVQyWGVjQU5VUkdMcy96WXR0SGRwTUtpbU1CMUpP?= =?utf-8?B?ZlJUUXlVVEh3OFBYZWlaeVkwVVBpSHlObEYxL1BiOThEeWp5R3RVL0VtYmlm?= =?utf-8?B?RmtkV1prU0NrNnZTSzR3Y0cyMlgxMU5RS0JlOHYzeVVmUEQxUncrVytFM1Jw?= =?utf-8?B?WlZjdzlBSFN1RlRhT25EOHppWCtBM3cxL2x0NzNqcC9CWEJIUXlKNVFPY3hl?= =?utf-8?B?SVNpaXdYVHFkM1Q4OHlrZzVFWnRMSHdqZnl0a1h6Z0JKSDVEc1E2eEpOZWtT?= =?utf-8?B?Wi96NzJEdkdEZ3ZFVWNBNXdwbDlaODROeHRFdlBHRG5BK0o2RndWN05xK3lY?= =?utf-8?B?bUJranJ5aGY2WXRNU1lzQk9iWVBMUXdtSzJUMTB1cDZoSDVjZllmOU5VSWdV?= =?utf-8?B?emRlY2txeGJDMmF4QlVRWEFDaDUzYXBLdE1ROUhyTytLd3J5Q2VtbFFVNmNL?= =?utf-8?B?OW12WmUxWjR4cHY4V3dQYXlxQ1F4S2M0UXJhUzlGelMveWVPV2pHaCtzSTVN?= =?utf-8?B?UTNpMDRqd25RUnJUZk1TTXdWQ0srNnZCNHIzVTRSNTJoVTFuR3I2QnV0SHdL?= =?utf-8?B?RGVSNW83aU9DQ1haVlRKVEJWVnVKL0RMQkhVeW04RitOQllzOXFzVE82ZE5q?= =?utf-8?B?a0R4R2JYYm5zcGlRYzhQWGZwdkxRNHB2VWMvRlAyTElOWGJucFVhMlU2ak9r?= =?utf-8?B?NkVIbU8vbjVFOHN5eml6Y0J3VjBPTjFEZXFaRUROeXdlV1AvWlBKOGhtS2RZ?= =?utf-8?B?cnd2MElOT1hIYXprS3BGcWd4aU1SdUdMTys3Qlc2bDVrelNLMmpMY0M3eHhN?= =?utf-8?B?QWFsMlhNczRvMDM4Q29jeHFCSUJXU0RyOUdMTDNNWFlLR3NDM0hTWEdxL1hz?= =?utf-8?B?WkpPaUs4NTRvWkY5QUNXbGRrQzhzZTBOR1RRNDBhWVd2NktZcmtVVEcwWE9t?= =?utf-8?B?cEpjN1h1dk96cFJHZXpQTEZUR2M5TjQ5L2xHTVRwRERORU1tQytwS0M4bUx3?= =?utf-8?B?RWFVR09kek4wQWUrSlhZUUo4RXJJZkhxYlhZWVNPQUFyano5bmlkaHNFZkts?= =?utf-8?Q?gPbih77IRk0=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c8c92331-42f5-4c4f-16bf-08da4f2b3fc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2022 00:00:39.8521 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0157 Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > nil-admirari@mailo.com > Sent: Wednesday, June 15, 2022 10:00 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove > MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW > > > path_size <= INT16_MAX > > > > (the edge case is already covered by the equals) > > Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022- > June/297590.html. > Don't quite understand what edge case you've meant: > INT16_MAX is 32767, which is the maximal path length allowed, > + 1 is needed for the terminating null. With the +1 your while condition term is effectively path_size <= 32768 But when the path_size is 32768, you do not need to go for another loop with an increased buffer because this is already as large as it can get. There won't be any 32769 or 32770 (...) cases, I think. > > I know this line existed before your path, but it would be nice > > to clarify check and condition, like: > > > > // On Win7 an earlier we check if KB2533623 is available > > Changed the comment. Cool. Thanks. softworkz > > > name_w leaks here > > Fixed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".