From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4C4274E88F for ; Thu, 12 Jun 2025 02:26:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8E73A68BE32; Thu, 12 Jun 2025 05:26:46 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2072.outbound.protection.outlook.com [40.92.40.72]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ADBAC687DA0 for ; Thu, 12 Jun 2025 05:26:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ASdJBxwRz66FlNYiI07nLTgGpJMb1523IHw8gQt0zaGRNxI9I8BcCKZbvIjanOEoZbXA0tXNby6ZjkbHAz5BZcM/1qvt+Y1kS8iyQVIvg72OfHxtfInDGajOdjSRqaqm3o7PtnSF1aIjZ63tGCGXVX43qXaIdWmNOKL0u8JurPt1GZ2rIfRsgig7Sf7Z6j9HRbweQbe1ypkp+suWxpG3G3ONd6stoZX4zLp4XyZERdzoazvmA6Tat9k9ZqWXKkZxMiPM7b1ajU7ggXNqZlq1YWUokfThT+rkW7bDqM80h3reMyORAdZVZe6Kp4n5JoT87D6foWYRI1UGJqC66/sglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXU95WYxvAFXlFbcnUSy4ULFM9uyUwzeQD/npB1HGhM=; b=NQdS3mQz7zI1SrPDJqMwCKv7woNsaUqcD4FfeSvKhXEUpHbBsEA5PMQ4FoIa3TlHc+GAJ5r5bekBOLDB9NkIlewXgmVAzZExhiyBMksSbALZx/yn9RV4r4BjxBsoJmGBHbMzTv3bQehCOphrf6xhQ+qsHjXS3BRDOmEAAvQb5WkcSPZP8UI0tRaFnHG+C/StMHyCMb6IvdA73uJZ4/vKK3FrwWOdqp2qvKBeahkHt5vOW19tDpyD+XgBTvNopwOLNSJfGiregbVwIt7HKbq+7iOEtoOc5bDk3HkQb5EPt15I/+Oh7URf0bmCMxVmgmsiqGzM6tNCXhnHCA4QHVTKCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXU95WYxvAFXlFbcnUSy4ULFM9uyUwzeQD/npB1HGhM=; b=OsiDRf0+VY7knhf661inkK9FMW6aiVDjsKUsRqQAMGZHm/qNiaCkTVMgvB447ZjwnK4Jw/eCl4nV7YEQFBtasf1Wcvy5VgNgbv3J/vrXfXLSd622OYnXk/qZxovhGnBqI2KprJisBSGGtt5XFeLdfJE5pq5NTRAqLpUbjAhvkCe/Bhxb7u7MqOhcgf7n9ygHPeSFNUesR4xu1rwMdM6bzWYxWHXGlSsSMaQpvVGFg/kRBdRB+bf46YgpRLxjSvLBnEXltvvK1uQITMnHZJ5GAPRy0NQXH+sS+TnwChyDDLcAMigi/VoCTm9bVn9C9UDxFqPEXj0JmN5AwzreETTFiQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0667.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Thu, 12 Jun 2025 02:26:36 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:26:35 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes Thread-Index: AQHb2xFtsobu0ETyC0KHJhY1nBY0ULP+zBuA Date: Thu, 12 Jun 2025 02:26:35 +0000 Message-ID: References: <20250611204213.97295-1-epirat07@gmail.com> In-Reply-To: <20250611204213.97295-1-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0667:EE_ x-ms-office365-filtering-correlation-id: 89884405-1a58-45e4-d249-08dda9588ddb x-microsoft-antispam: BCL:0; ARA:14566002|15080799009|8062599006|8060799009|7092599006|461199028|19110799006|41001999006|440099028|3412199025|12091999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?UR4+z1oSjWV5LfMStB0uVtGd5IA40aiAXLH6ia91zZmGQNV6qzKyUVjcBRJt?= =?us-ascii?Q?ZyTqjz6KCWqqE2OTFoJxf1nqyHI+FHzy42hNg4llYopkK8u2odbB/zCtlYcl?= =?us-ascii?Q?PvfCiCHUqiHWu1ig+4XMvnBVxBulj0/xdFgInDfBVUeX1M/SZjnCoQ501kas?= =?us-ascii?Q?b51RkNir0+k8Bq7+gnPDqukq9+OG7EBC4cNBb2wRf3gXip957citRssV6LQR?= =?us-ascii?Q?ldMsVCdxH6dqm7JLwj/dJ6aRWqYJZL2nl/c23DWmEAyYiMriLZqomk1epYw7?= =?us-ascii?Q?/gvEEgTLM36mXVgw6fapJp4xcDnz2OMKBZzk9cce1XKn7pT5lbuUezZMv1Ks?= =?us-ascii?Q?Tv/gkIdWjbfjaDV7sklLRqb/U1aBdrFmZm1AFbyFxzqRmmjRN3Ugjth/k/rD?= =?us-ascii?Q?3tdfTxG2BQjQehLhpPCXP1ds7cYGPhppfM7KO/UUU/Nlx01r/yGuC2jfHDBz?= =?us-ascii?Q?jTv4Khxb8X62n0A8V+8nFXv4R5mBEWbFxUalSlQ8i0ebnESM3tp1G/o5lsDN?= =?us-ascii?Q?5teIdPKA+Ftdx2CDAMOehrIPiyOEHTef8hn+A0aF0RCAz9Pl82tDMJjWDJ/I?= =?us-ascii?Q?eL0HsbzsLis10Rct+gJmZqJLnwQvm7QqYaQPGi8UruqUlvw/02clUbK40UFl?= =?us-ascii?Q?9nM3Kcx+RsYJ8v1is81QBIF5qQJrt1bkemJgqa/4zCeWLDFYqiyEKI0yHe72?= =?us-ascii?Q?UoHtJRw2Q3l9t0A8ft38CCqPvhCPKNUeLgkwVnaA3BaOf2kTp9P5nZh+zh3a?= =?us-ascii?Q?o1rnAwwk6puSyVr8hWjPA7/tDmRjOb9JJjmlJpJvw2BoYKPik9cel4043JwN?= =?us-ascii?Q?Tnsgxm3jpDJSPLlAv91xA7MiN2vXPHTB9EKaHblIvKfYOT5sWnwfa2hOV3uM?= =?us-ascii?Q?x+QZpM6ZIaQLQoDkTQG0LriQHEQuFRgEQGg7z4u2cUA0JAeo0lKnYheC9EiT?= =?us-ascii?Q?RxR42/4IRRphWjIOFHsuzZAGXjAIwyjS+wtfAkrj/uZmU+kDlsyWA6kTJSKC?= =?us-ascii?Q?bhGpOqDdJVZcQQsqqSDt51/ep2MYh0HB9dAp9GkCqp6BuqRFbP0RvAKgRIxS?= =?us-ascii?Q?rvMnEYoLI/kAt2aYb2NVMGueutYHKeNDbjGRXyH61yANVZ+jZbKnv1DJGict?= =?us-ascii?Q?IKxZeVAbwvht6x+bO3q3z2L/w0cEW8W+5LOqoS8C0rqBQg9gYJ8831U=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CuHqh5lLoJ0vf8cJwVBw1Vs+Z/l8liVLKzB5YeVfv4qf/8QoeK5ZjmN3fUjc?= =?us-ascii?Q?KvIQf0jt1j6tB9QMvtVnUExjaS4+8egHyhO8a2FhINZJ4ur0Iepx9SPv9gGa?= =?us-ascii?Q?rfBsmBWynu3GmsYn45NGBy9L81oclaqARAIG/3bubg3kJk2kTyR0ytT2qlWr?= =?us-ascii?Q?WCuY52CvxwfEYa9S5wfDUEYmkILqC+0+KDsVyeORQBNPuxog3PIjJkRS/OMX?= =?us-ascii?Q?29cTsTLk1zIsNICKkUyqXxnJZYVnbjVMOp7trP2satBJ8Suf2F92Kgj+r5OS?= =?us-ascii?Q?5w6eIuAO9I1uBfmPWWlTp5h2D+xQDjOf6nU/04hYo31MXJB8afS614xXC4Sr?= =?us-ascii?Q?F9bLus/hR1QFo3DTsDxZMCDoLsYCbhiRVtCdmO1EbVBlOvXLH3H2E9J0cA5b?= =?us-ascii?Q?JtGDmm0+suDUHCHxp/fPszzwYrWqu6BGPJzUb7rhsA+Ou8fS8AjM3/fQ1XhE?= =?us-ascii?Q?GeE2vcv5/NzIOwMBaIU3PBH7e5lyix2BZcTQH2WnJOnEzR9ZyZ5ImXbuWWZ1?= =?us-ascii?Q?OXZAHIC57acsPQ+SntmBUlLWVq1r6fVpb9t9YVclDRgb1CV4ohEnxMyeFSY5?= =?us-ascii?Q?fD40tS+lxK9XqW3By3RuZCVyAAn/J5d9NeS7aDhPQe/JhigL+EcmXKWKQZ6z?= =?us-ascii?Q?+ZjWTomvGgoGHw8CxjVns23FrW88UKVRLjw9TtF4KO/zvK4DCc2qYjEYePqI?= =?us-ascii?Q?HDRc53XGcXRgAo29zrNDhbzwTeyNzH0GX7qo7fYIEkZdE7l2mFf3Qeoogf7Y?= =?us-ascii?Q?wSMoraewLxOvI9p3gJ69AzVNZeI3ZIFKpCI15nYBUKBde6s2hq5ZwSV1kN4P?= =?us-ascii?Q?Ntnrvw02XzJLuvg4dIAUeokN6+ay5E6IG/rbJnRmQAAlkGisAkbOZ6pOZDdy?= =?us-ascii?Q?aL97ZLICc8t/9DVsVWqk7/W1R6eeVDyl7NOOroqu2DjZnGIrNM7XO2G1WnwI?= =?us-ascii?Q?RkEViarSql4bBXqTREiCQlyI0EgD18VWGV/AI/aoyfmVqGL2P9IQORsU0g72?= =?us-ascii?Q?R/TJcu7Da00ziqfHyLuNBqJUhELvStNsnJtyg5h3ERVZbdUV1LUrvPaUAssl?= =?us-ascii?Q?0TsNjvSvLR9ll/su0crJ2Nmwq9oI/g0Rb5RiWnNUEPhv6z42ss2tnacr+xhC?= =?us-ascii?Q?wBIT0FXcLtY9UriqNfJtRVM2N1NXzF00qXEeArixT1agj9MMV21RVdb43XZK?= =?us-ascii?Q?gsTtjEDcdrVt3K9DItHtm1HkATxaVpTNO6kF4Vd0Tw3fR0+jWsWrZsj8z4M?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 89884405-1a58-45e4-d249-08dda9588ddb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:26:35.8084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0667 Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Marvin, > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > variable scopes > > --- > fftools/textformat/avtextformat.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/fftools/textformat/avtextformat.c > b/fftools/textformat/avtextformat.c > index 14779e6f0c..f1811abb1c 100644 > --- a/fftools/textformat/avtextformat.c > +++ b/fftools/textformat/avtextformat.c > @@ -101,7 +101,6 @@ static void bprint_bytes(AVBPrint *bp, const > uint8_t *ubuf, size_t ubuf_size) > int avtext_context_close(AVTextFormatContext **ptctx) > { > AVTextFormatContext *tctx = *ptctx; > - int i; > int ret = 0; > > if (!tctx) > @@ -117,7 +116,7 @@ int avtext_context_close(AVTextFormatContext > **ptctx) > if (tctx->formatter->priv_class) > av_opt_free(tctx->priv); > } > - for (i = 0; i < SECTION_MAX_NB_LEVELS; i++) > + for (int i = 0; i < SECTION_MAX_NB_LEVELS; i++) > av_bprint_finalize(&tctx->section_pbuf[i], NULL); > av_freep(&tctx->priv); > av_opt_free(tctx); > @@ -130,7 +129,7 @@ int avtext_context_open(AVTextFormatContext > **ptctx, const AVTextFormatter *form > const AVTextFormatSection *sections, int > nb_sections, AVTextFormatOptions options, char *show_data_hash) > { > AVTextFormatContext *tctx; > - int i, ret = 0; > + int ret = 0; > > av_assert0(ptctx && formatter); > > @@ -202,7 +201,7 @@ int avtext_context_open(AVTextFormatContext > **ptctx, const AVTextFormatter *form > if (ret == AVERROR(EINVAL)) { > const char *n; > av_log(NULL, AV_LOG_ERROR, "Unknown hash algorithm > '%s'\nKnown algorithms:", show_data_hash); > - for (i = 0; (n = av_hash_names(i)); i++) > + for (unsigned i = 0; (n = av_hash_names(i)); i++) > av_log(NULL, AV_LOG_ERROR, " %s", n); > av_log(NULL, AV_LOG_ERROR, "\n"); > } > @@ -525,13 +524,13 @@ void avtext_print_data(AVTextFormatContext > *tctx, const char *key, > { > AVBPrint bp; > unsigned offset = 0; > - int l, i; > + int i; > > av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED); > av_bprintf(&bp, "\n"); > while (size) { > av_bprintf(&bp, "%08x: ", offset); > - l = FFMIN(size, 16); > + int l = FFMIN(size, 16); > for (i = 0; i < l; i++) { > av_bprintf(&bp, "%02x", data[i]); > if (i & 1) > @@ -571,7 +570,6 @@ void avtext_print_integers(AVTextFormatContext > *tctx, const char *key, > { > AVBPrint bp; > unsigned offset = 0; > - int l, i; > > if (!key || !data || !format || columns <= 0 || bytes <= 0) > return; > @@ -580,8 +578,7 @@ void avtext_print_integers(AVTextFormatContext > *tctx, const char *key, > av_bprintf(&bp, "\n"); > while (size) { > av_bprintf(&bp, "%08x: ", offset); > - l = FFMIN(size, columns); > - for (i = 0; i < l; i++) { > + for (int i = 0, l = FFMIN(size, columns); i < l; i++) { You are changing behavior here because size is changed inside the loop. The pre-evaluation into l is intentional. The remaining change should be ok. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".