From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B18AB4C539 for ; Fri, 7 Feb 2025 11:27:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A97568BCCC; Fri, 7 Feb 2025 13:27:11 +0200 (EET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2022.outbound.protection.outlook.com [40.92.45.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DCF4168B7ED for ; Fri, 7 Feb 2025 13:27:04 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kho2jvSYhOY1FrfzZ3TkQFqnsuROWSI2YPD9+gYJDDrozx6cyBemBQvoqpwEBBk0NtSzSN5lx88gL8gVUvKmId5lZl3Jfv/EPUzIojbXYukWsSSp02/n+TeLD85nzJ+7G0vnONHfNRFrKHjBARtXfpSIEkLBmz4vwtf+Wy5paTLHPi5sapeut29Bv/r8wRXNVATh+xbSuxArytINsUUaMswBCEQD0DAsDxkxPYEW/NVHuB6jar/uAhQpDg/HDBkTnmxugn7IcB+QxXHgeuCgMOQwuu0JyYaPCF46f/uYYbMNqMOJWtqKKQ8M6WncRYLHKH4t3jdkYjGxp9koiGhGEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLaTwsaoWLH9QuKh021zcppz/36hiO4MZmSX8VXp9tQ=; b=N7ar7pCLzZ1/IEKhN+biEyw/ESCm8X+sywGNhZyOLezBdUvyVjP4bhnMc0jAf3vxf5lAWxi8/7SAP0I9JWgO5BblLMiyFYTzr0v85qMkHKvxRGFaAujdsdqwj0xccSlIuvEe+/zCJvkknLaIoGsG2+RyvosfkcYdMKqKW/2aZxVn4roxEbhGAOoLj73s9VZqPUDz/CBEGG3cdeMd3mushGNLS2RQx8rbzviGIRNICbeJu/XzcFuYKT6k/Od7MTE4rwIcpae0kRMsfNFcI6VGjvpBPR1DM4w7NqJBXTGgTRg7GmXAPEPBJa2sydfU/z+N8pAmEqAsBs4pbIB0F1/cQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RLaTwsaoWLH9QuKh021zcppz/36hiO4MZmSX8VXp9tQ=; b=NIEar4UoassYwVjGj9L4uwXl9MkLVjTY3AUegE/uLk9nFYkgLAClG4FtPz3wS1To4lrBH05k6vlINP1G4Pwo/2NY+7m2B5GNEn4Nlr6i+E5pcZTV+nUjgIPyVlAlFBpzSU9F2OesGopVwNJKS7KUjYUiS2WqA5Za+q0e/Ae0uTDg/ew1phxObs0/kR//DK6Ly6IL+DJILJZXTX2HcTqhquHfuIXscXHhD/CdOa2Bxc/aETQvi9cAI9wXOVkb/sXan6IZA+NhxXLOyQG+aQkHkoWtYG2w0h7k0PIJ8abWM0aG9MmaYIwOxWVTfRwnr/42JmAiE7Vx13hqpFzVbCje9Q== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by MW4P223MB0588.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Fri, 7 Feb 2025 11:27:00 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8422.011; Fri, 7 Feb 2025 11:27:00 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags Thread-Index: AQHbeTXwerC42Ouy1kiVtWD9N2hrjrM7p4EAgAAHkUA= Date: Fri, 7 Feb 2025 11:27:00 +0000 Message-ID: References: <63ab3a941166604541ce91cc37137edef4cbac93.1738915048.git.ffmpegagent@gmail.com> <2bd0c238-546d-4cb2-8778-e9d6f658fa3a@noa-archive.com> In-Reply-To: <2bd0c238-546d-4cb2-8778-e9d6f658fa3a@noa-archive.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|MW4P223MB0588:EE_ x-ms-office365-filtering-correlation-id: fd7865ad-f7c4-411e-20a5-08dd476a56e2 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|8062599003|19110799003|461199028|7092599003|15080799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?B?NkxTUFoybUcwa0x2VkhheG1JTU5sNUdmV2xSSHA3NWMyV2k5MWk2TWJsb1Bj?= =?utf-8?B?ZnFrQnBiWmVueGJmYXFNTVRzSVgrUE5JenJLVi9mRjRtVENlL0ZpMXgzNGl3?= =?utf-8?B?N2ZITVdZMVFSUlhLbWNRVFZwS2NBU25OUlVvQlNhbE9ZZEd0YnZiNllkYmsv?= =?utf-8?B?dWthbS9CcEVyekpDZGFKaG14RzVaRmpHR3RqZFdGZ2MzQlNBL0VEVWtjV2k3?= =?utf-8?B?ZkN3aUhJci9LNFVmd0dXSk0rL1ZYUXduY2tKd3JSZjljaXF4ZndyUHRzbDNa?= =?utf-8?B?Z0s2K2VKVDB4TlNiVE5ZalRvRGRlcW96OXlJZm0rb2hGUUdWazVvQVEzL0xQ?= =?utf-8?B?U0xIRUVNSDFrcksyMHRuZTZUMko2OHhyRlcxSXN1bk45bS9heHQyRTFCTXc1?= =?utf-8?B?eTNKNUcwcU80Wk9QT1owVEkydFBlcUtSTWxkUy9OTkhwUHprKzZJVGlGbjVZ?= =?utf-8?B?ay9qNit4UnIwN1pYNlVTRFQ2dlIvN2dPNUV5emtuUm85UnM2Y1Y5UVBBVkpB?= =?utf-8?B?L2hQZDhDalB1c1o4UnlIQ2dRTkt6eTM2YmlJWCtOK1pxSm9aTTdTVHN1Z3JJ?= =?utf-8?B?dVA3dC9LZVZwVUpwTUNGVFdYdUxja1Ywb05PUFlOSkhPYmZIai9PM3dTZ1FS?= =?utf-8?B?TmlXVnpNOEhoTTNsNTVVS3VwbWY0V2JEOFM0ekUwZHUwU3U0eTRNamJKLzd0?= =?utf-8?B?SGhsMHpJTzFScFN0SzJ3NzQvZUVQNlN1N0lMbGhSRGZqaHJFMnlQZGJDZjNh?= =?utf-8?B?ZnlCV285c0IxSXdzTVQ4OXFJUnVnU2JOVFVWUTI3UzM2TlJ4UXEvUlJJV3Nv?= =?utf-8?B?bS9FREpvSWFCN2x5aGloVTU1c3ZNQkRwMlRweEQyV0FJUFpqUFAvVHFZckwr?= =?utf-8?B?dExGZUFvUWJkL0JoTmJ4WVFTK1dpUXdDMmI4Nm9EUTdSZzVoSnU5RHlKUExp?= =?utf-8?B?aHNrVFZVK3RtbmIzdngwTjV5bU84QnJFT1FzTFp0OVdtdHlkS3NYUGFVSHpD?= =?utf-8?B?SDlBd0FPMmpHUEFBZ2ZsN2VlSmxGV1luREtFWnVpMitCbDA4OW1GUU9QUWM4?= =?utf-8?B?QmZIbUdleEJIVzIrWVNsU0ptOFo3YVFCdjRla3dRaXhMR1NBUmx6OEpxNTFN?= =?utf-8?B?ckt6c3RyQ3NucEhYLzBRT0d2anBxYnZmMXRrc1Q5ZUhrRWNSeUkwd2pNenBK?= =?utf-8?B?dWJsSlIwTS9XMk5mN2p3dzlkV3lJR0EyYnluMzViVm1lTG9RaGVFR3REb0lG?= =?utf-8?B?ZVFUSmhPdUtZbk51WXRKcXo5clY0bHJYMmV2d3ZYQk5WY2xNbDFuWkNmcnd2?= =?utf-8?B?MnFyUTNZMkNRS21nN1dUYXNWWGQxbHpiYk1RMzc0cnpvcVM1ajNubHY0RG5i?= =?utf-8?B?UU95cTk2N2I3ZUlEaDFvYUxyL09JMFJIRkZLdnNiL1JuYnBDbk4xOFo4VGhO?= =?utf-8?B?dkNmcjdiaXNmZWt1THY4UmNyME5Ed3NycEY4WXJnPT0=?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NFUwaGRsMVRTN1RROEYzVzBhUWhSTGtQWGY5WjFGYW9GYkJxWnU3eGF2bEZE?= =?utf-8?B?RU96bnhJU0lJY3RpSWttUVZnUUcwV1VaVFZhNlcyMGVWY2RSRlZWa1hwMFhJ?= =?utf-8?B?Z0xGbFpKdnNuUkxoVHlGblFRSkFlNzEyTzMzb1BvSkZTSk1ka0RXN0tuZHBH?= =?utf-8?B?Yit2VDE2bm5lTkNNSEk0aTF4SFM1aHpxZDU3MWxSZEtDMDQ5QnZhUU1SVW9m?= =?utf-8?B?clhUZVlyZ0ZoS0R4USsrbU1RNU1qWmREWjFiS3lzQjZzdWJ2Q2xtM1BKcXRS?= =?utf-8?B?QU1IVDdld3JQT2Y0eFdnNzB1Vy9VQWxlYTE3V2RhVzc0LzI0RHFkRU1RY0ov?= =?utf-8?B?S0ljUHArcUtnTUNKQk9YMGRDSjZjMWszRkoxMXByVEU0OEFkMFh1WjRIMms2?= =?utf-8?B?REx4TzFvRjNtTjFwNHRhSmtDczBLRjJVMVpnSjlBMkg3RTJoeTkybkFvNEwz?= =?utf-8?B?clIxeWNMRU9UdFVvSk9PNlI0SWxEVDM4YzFqdnpTNmJIZ1k5U3VMd3UyRVF0?= =?utf-8?B?UEpWMXEydnBzckk1UlBGdEpqeWZ6d01lc09mTi9RWWRkWE1TUzNlbE5pZEYy?= =?utf-8?B?bXJEY3UvM2dROXJ6QytvRWI0b2RMUTJLdkpBMDBoKzdCa0J6TEYzSkdobldJ?= =?utf-8?B?RFdPMW9Dalp1QkxkRmZBdkNraVdIVHlzYmxkTnExSUJmSnU1VzZsYW1YSGpz?= =?utf-8?B?L2x0OFFGMGt4NHhjV3dUVFhVcHpSZm9ldDhTM0RFeDVvOVlXcXdYMWtDWk5K?= =?utf-8?B?cTlzQVdOZkhGMU1qQjdqMGtLRXo4dkFDb2pLZEZTcmNMQ0xJWkVLS0RnczlJ?= =?utf-8?B?cGIrK0w3UE5udzAwajR2R0FIUFZJc1h3dklJUTlDMFNKZHhxN1NlUDBSbEwv?= =?utf-8?B?cmIwbzNaYWpNTi9CdjAxUTUyOTVWaGZmSi9oQ3VRbzg3N2FSNXNtL2drL2xN?= =?utf-8?B?K1RpUTlmTTlHalVWMmN4cnphWkkzMXlJRkpVZkd0WFc3RkZlaHRZanFHeHJ3?= =?utf-8?B?eER3Zklhby9vVCsvMzJvbHhxMkcwWGVaLzA4b0Jtb3BKM0tINllWY3pIMzQx?= =?utf-8?B?eDZFa2FXQlAyRWVucUVPejJMcmxPRmM5NUJpVU1WY0ZwMjNtdXQ1MUpjUlBo?= =?utf-8?B?cmlOangvbHJWbmVSNU1WTFg2UGZ2MUhkakIxSjlUSkJqRDJuRW1QQ082K3pO?= =?utf-8?B?RHl2Rlo3S2p3MW51bWZSOGhjZ2VUYm1LNFVsYjlEM0FVWGdZTGIxVmkwZUg1?= =?utf-8?B?WjBjU3g3ZkdvNnlaczJ3Z01GOE5JNHVwYXoxNVJBS3EwcHFDcEF2NnkyN3hp?= =?utf-8?B?bHZSdVl3YWw5RFZNcGwyRWt2RWxLZitWT1VSWnBLQ2Y4dHYzVEl4dWpBYUtq?= =?utf-8?B?TkxNQndHaDlpOFU2NjZYY3lWNHcxczRFeDZRSnozaVRzSnM2dFgzMGZ6dWZN?= =?utf-8?B?ajdJVWR0dTlvK2w5S2M4ZFBmcyt2SXg2a3V6VGQzWVNjNURYS2o5bi9TVmdS?= =?utf-8?B?UmFESHBYa3QxcHBUeXE4SkxjUEQrSnFZVEVxakdHdXRSdEhPY2Zoc1ppSkht?= =?utf-8?B?ay9ZSWo1WmR4OXBQREpUV21ISERCODNKRENOdEJFc05PbFBKWWRtVnI5anlC?= =?utf-8?Q?gG95uERl7Z8m+yq/kVvPQCQmrAO9CA0upvJoimWVykw8=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fd7865ad-f7c4-411e-20a5-08dd476a56e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2025 11:27:00.6025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4P223MB0588 Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Friday, February 7, 2025 11:42 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > On 07/02/2025 08:57, softworkz wrote: > > > From: softworkz > > > > This commit adds two logging flags: 'time' and 'datetime'. > > > > Usage: > > > > ffmpeg -loglevel +time > > > > or > > > > ffmpeg -loglevel +datetime > > > > Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents > > timing to be printed when exiting. > > > > Signed-off-by: softworkz > > --- > > fftools/ffmpeg.c | 1 + > > fftools/opt_common.c | 12 ++++++++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > > index dc321fb4a2..f4c717afaa 100644 > > --- a/fftools/ffmpeg.c > > +++ b/fftools/ffmpeg.c > > @@ -130,6 +130,7 @@ static void term_exit_sigsafe(void) > > > > void term_exit(void) > > { > > + av_log_set_flags(0); > > av_log(NULL, AV_LOG_QUIET, "%s", ""); > > term_exit_sigsafe(); > > } > > If I understand the purpose of AV_LOG_QUIET correctly the correct way > would be to skip writing time/datetime information in the log writer > itself (part of patch #1 in this patch-set) if level is <= > AV_LOG_QUIET, > rather than clearing the flags here. > > Regards, > Tobias Hi Tobias, my understanding of AV_LOG_QUIET would be that when program code logs a message with that level, it will be printed even when the user has "-loglevel quiet". I would wonder why such log messages shouldn't be prefixed with the time (normally). To me it appears that the special case is rather the log invocation on exit which prints - well: nothing. I'd rather question why it is not printing the log level for quiet. Is it really intended or was it only done to make it possible to print this empty message on exit? Do I see it wrong? Then I'll change it of course. Thanks a lot for reviewing! sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".