From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46DE4436A9 for ; Thu, 21 Jul 2022 20:31:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13C0168B556; Thu, 21 Jul 2022 23:31:16 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2085.outbound.protection.outlook.com [40.92.23.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6F31168B4BB for ; Thu, 21 Jul 2022 23:31:09 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVxl1XHB7Z5FY4fXhCqzFCCQ5ZeyuSVaxvmBUOvc6yHtkZGElzy4M4SmJQ9lNN/o4qs73d8UGu2C9MxOOIeTcyzqTWSqQt59LmVvlNYY7kwV8jt1F7xKFH5lcAuu7GxnnIa5OvPe12wnldvhCFnAMr2kvKGV28ts3zAyQMqjfaTU2kE7mTsvwSAUF8pmNKDH4HblXsdX2jCWr4H6ES90R/oiiSxEuJbumCp8oHw4/7MIdRrGLbFOq2MFumWDaqhQ8Oh9vCGEB8EefMfIPbj+wDhYkRQWnncwyxIIh3x8kAcPrbRTmKrptZ88SPH7iWNwGDJjBVfuM/734boGQANvqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kXUrnlON4dPw8idIGWoiVvo4+zH9ta28//S7JxAF8Eg=; b=D2s7GpPoDn0BYI9H2qnGzyI3a7xwhAsAkn1YWJq09GX3d242PMGLso+Teo7tVFRgDlSq0a0x9bFWk8zF8S6Owq1KC0i9WczW8sSeC39o3B+/wPY0J8UrjYIJNJ1xrg2u4mYKGRG+UVPTrN7xoHQxx+6TzV5NBhYjql/EMWTAFL1qZnZj/EJEIPtASuvuwvSXcbG6A2a5uwLUCM67YDQz9B91vTPGaMeNI8ftJRYBFlr/RcmUoMU9v5ET00RrqX7wYB0/D+DIr3tU0eGh2I93OwqcFgMrgeWbZdkUabi8XamDsSiTgHL3DrHxx/kSHd+LqE9psJiLYE03rpVhI8InoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kXUrnlON4dPw8idIGWoiVvo4+zH9ta28//S7JxAF8Eg=; b=t88IauSM+Yu510ol8WQc+o3Nisri8CRgXsI657Vabu0lURy70/9bM6pp79DBv5yTWDcjkESbfk1kuatqOmek+cB2iYHK3Wf/f0I16C2CGq0Uy3o0g3p0yjwv8tdo0ksIp8hiPP2d+VYcUzrZYXaLtgjbADHrt/e3JGvPyjBve6Db4giTuyiYOYr1mj1/BKbPj6vvTWuWFznkb0ujTgA31KW/Ndm7b31PK8TVmNJg5NQzhgCd68b0A+04l3gTk0dYIX3re+wDatm4Jvon5Gtg0PtvUC8fXYupTiTPpJUdLRUbyLnRyX695MuO+WR11O5aThWGB5G1eab8p9Od/J+ssw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by MW4P223MB0562.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:1ec::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 20:30:58 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231%2]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 20:30:58 +0000 From: Soft Works To: FFmpeg development discussions and patches , "anton@khirnov.net" Thread-Topic: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL Thread-Index: AQHYlbjOx8uO6q87m0uMeFOgNMPp/a2EIewAgAEyPQCAA/2PoA== Date: Thu, 21 Jul 2022 20:30:58 +0000 Message-ID: References: <20220712062735.20339-1-haihao.xiang@intel.com> <20220712062735.20339-11-haihao.xiang@intel.com> <165814937028.25016.15272296385260114959@lain.khirnov.net> <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> In-Reply-To: <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [AMZ+nXa84A7Va5AIGC5aiy8cnXIAEuiF] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e22ba93-ca92-4f2c-7890-08da6b57ebb7 x-ms-traffictypediagnostic: MW4P223MB0562:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FJiZoDGD1sDrh0tRwVASNSpmsNK0UBF9PhWJGDQL2ZroKkYqaFR58zbtXxhFE886/9ehUM/4PJpOWA0wzgloomowRk0AaJefFsMBMQ4WZncE32i/9eFQOqIGAN+E9PBNB7hmkf9OUE6Y2DzP6NJcE+XWgK9ccAxoGARrFx+zcpBITA/ad0kcl1pVGysCpyOCJBVFccOouD8JkwMIHTwFUnlkOaFKxSebzbxpLL4E4GFOmCdrJAFj4ICia0UCyuoBjU1xSIcYX2s/lRRAlD/zGPsV2oeW0a/kbonPIwmfLpeZq0hrXBCKy7sXtJgi7navmn6wNbHJYM/2jpvlpoewhAVgpGQw0NCsyP73JaCC/ErSocvT10nvtSyyivdDpKNth/j+bdYCbGO4HB2yD0+U2Mv2Dhp3Arcnhx8zNTfPZOD8oxFQjZxPLJy+m1ZDP6nQvcsTV2NZRfB5yV9oAKExGN1NLT+bnAXakhQiKtRKqi3qgfAv9TPDoAcYbQYqoJSoMVbvbXTe0GIyk/WWarXTbqUYa0G1GGXOF9X20j1yal47DH9YZkwTQHZLFxjnXjm76cUfA56KDuSTcKeWH1hQsPawOWF0HEtSM7F4+2YFSiH9//PW2vnI0HV3VLExvo/mlSwJUj+1gyxucdThtbXN+9BNF3gfDZBkqMZ02hsDoC17wFtCWX0Pp252POH0Isuv x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bSs5QXRaZmpkdUJaLzdvV1FhRmp0TFhaakpVZVpuZjdPOGlkK2VFTkgzZ0FQ?= =?utf-8?B?amY4NzZvb3Z4SzVvZGk3anU1WUxVYjJzN0dYLzdKWFgrZzlzejNhV1ZSSSsz?= =?utf-8?B?djE0VTM5U0ZISENYOVpiZVlINllENmhZM2F1Q0dHZWkvb0tzYkxXdC8xQjNx?= =?utf-8?B?TW43S3dRcHNnVHdsQUxEd3ZqNUdWNEFma0xnSVNiaWxpRzBZZUJ3ZlcrVk4x?= =?utf-8?B?aTlhby9DVHk5b1Z6anpmby9YZmI4ME90aStseUhOL0pwTVdWdjZVejByRXVn?= =?utf-8?B?ZTFRaXI3UmF3cEF4T0ZzSklWbzBoYUxxN0IyUE9KTGQyc3ZxZ1ZSeVJGbVI4?= =?utf-8?B?cW9CWDFadFVXUVhtNE1IT0FWN1kxYUZkZitCR1VsNUNTZG9BRzRRV3E3Wkh1?= =?utf-8?B?ZG5CZEFUOENNQ05FV3R3ODAxTlRCQ0tBWXVSUEI5bHBRay9uTThaSzFRcGVa?= =?utf-8?B?Y1liWnFmZ2kveHAvUkFpbXA1QUc4a2lqZHNVWGNKK1BJN0FjVGQ4eVdtUHhS?= =?utf-8?B?US95clVSUWhmWnlNV1U4THFMSVpZTWUwb1F5WWU0UkFJUURQcFEzd2sraWJx?= =?utf-8?B?end1SHVUTHRPRnREYkgyMFJYdHVxUmRZelErMWlBUlFEbmFXclhNY25MSUVp?= =?utf-8?B?L09KYlNJU3RZNnJ5NHdwTWRrRWN4UTFlelZxcWlVUm1rZ09ORG9wZWZsWGV5?= =?utf-8?B?bVVoM2U2S1dyMVNiU1NGUzFDcVVUKzBBZDFCZllYZWlZNytYbEUrVFEzT3Fq?= =?utf-8?B?Y2RmYlJLeXoxZFZJTkZheGg1N0ZPUkhlakM3OFFMQVl6VWthV0tUU1Bxb0ps?= =?utf-8?B?RWJmSGJsMGhPMnUzUEEwUHdmMXQwVzhxRTI5Y3Mxa0FMY2VMcmZaVUNZUXBu?= =?utf-8?B?YTdXUUY0UW8rK3MwODBxRDFCZFk5QkFMd0VqeUI1QW9Xa1UwS0VkdEQ2d0g3?= =?utf-8?B?SVk2N1VlT0NreFAvMkc3SlhBR1lJUDdnUXpmd3pMSTN0eDdHRXR6SlByeWRK?= =?utf-8?B?L0Rucm9oWkdrZ25NSlRxVlhrZ2VmaHNtK2pEL21UcGkzV2R2Vlp3Tnh2R1BG?= =?utf-8?B?WlZKVUZhMlcwc2wweW9EL1FyMUhXeVgwY2d5SjVoNEkzT3JFYXIybGhyd1RM?= =?utf-8?B?TDgyaGxrTXZ6UjVWM1oxS1ZaMlFleE85ejhNdm1NS24vR3N2SmxSM3dSRys2?= =?utf-8?B?d05hbXNjRm8yNVJDSjhGdTJad0VIanFpeHl1RGVLM2tpMEtOcld3bTcvTjk3?= =?utf-8?B?MTlma2RMTGE0ZDE2ck03alE5RlZxQ3ZzODJneExiQWRFNi9JNnY2WXdNQ1o5?= =?utf-8?B?alRDcEUvUzdEZ0NrQmJCYWw4MUI1UmtLbDZ0bjNRTXluT2taTzE4SXA5MnUr?= =?utf-8?B?NEdyR1BNYnNodzgxVEhRRlB2T0NBU0lKV05uUURxTXlRQUNXbzdOZDJtRE9M?= =?utf-8?B?OWZLeW50cmFYVnZkK251WDJpZlNmWnhNeGpTY1pSdGpDUmpEZllGWGVZN3BB?= =?utf-8?B?MWNBUnBZeDN6cGkxMkJNRW9WUHVvK2t2aEl0ZHJsYm1DUkUwV0tEZWR1S1Ns?= =?utf-8?B?R3A1aXRDRytqNnNON0VpT3ZJV2NwbXdUN29XU3NlSjJ6RzlVNENXSmU3T0xi?= =?utf-8?B?Mmd2U2pZMFJYOFhxbXhQUmliWFppUTAwTEJIVFgwcndleHFZVlZJNkpPS3Yz?= =?utf-8?Q?vfI1rPXoYfHlKCctyTEF?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4e22ba93-ca92-4f2c-7890-08da6b57ebb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 20:30:58.6718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4P223MB0562 Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Galin, Artem" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Tuesday, July 19, 2022 9:19 AM > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > Cc: Galin, Artem > Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: > make qsv hwdevice works with oneVPL > > On Mon, 2022-07-18 at 15:02 +0200, Anton Khirnov wrote: > > Quoting Xiang, Haihao (2022-07-12 08:27:32) > > > +static int qsv_va_update_config(void *ctx, mfxHDL handle, > mfxConfig cfg) > > > +{ > > > +#if CONFIG_VAAPI > > > +#if VA_CHECK_VERSION(1, 5, 0) > > > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > > > +#else > > > +#define LOCAL_VADISPLAYPCIID 21 > > > +#endif > > > + mfxStatus sts; > > > + VADisplay dpy = handle; > > > + VAStatus vas; > > > + VADisplayAttribute attr = { > > > + .type = LOCAL_VADISPLAYPCIID > > > + }; > > > + mfxVariant impl_value; > > > + > > > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > > > + if (vas == VA_STATUS_SUCCESS && attr.flags != > > > VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > > > + impl_value.Type = MFX_VARIANT_TYPE_U16; > > > + impl_value.Data.U16 = (attr.value & 0xFFFF); > > > + sts = MFXSetConfigFilterProperty(cfg, > > > + (const mfxU8 > > > *)"mfxExtendedDeviceId.DeviceID", impl_value); > > > + if (sts != MFX_ERR_NONE) { > > > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX > configuration" > > > + "DeviceID property: %d.\n", sts); > > > + goto fail; > > > + } > > > + } else > > > + av_log(ctx, AV_LOG_WARNING, "Cannot get device id from > the driver, > > > the default " > > > + "MFX implementation will be loaded for this > device. Please > > > consider to " > > > + "upgrade the driver to support VAAPI 1.5.0. \n"); > > > > I would still prefer to fail here. The user requested a specific > device, > > disregarding that request is evil. > > Thanks for the comment. There is only one available device for most > users, so > the default one and the given one from user should be the same, > otherwise it > won't work. I don't want to make them in trouble if they don't have a > driver to > support the new interface. However I agree with you it is a little > evil to > ignore the request. I'll update the patch to return error here. I'm not a fan of that kind of automagic behavior. Quick success experiences are surely desirable in general, but we also need to consider the effects of such behavior - in this case, that would mean: It doesn't really matter what a user specifies for the parameter, because it will always work anyway. In turn, users may start to think that their wrong command with the wrong ID would be right, and then, in a subsequent command use that wrong ID again in different context, where it might fail, while in turn maximizing confusion. When it is possible to internally retrieve potentially valid values, why not output something useful like: "XXID failed, you might want to try A, B or C" (or similar)? Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".