From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7CC6640AEE for ; Thu, 3 Feb 2022 22:10:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD4DA68B027; Fri, 4 Feb 2022 00:10:24 +0200 (EET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2037.outbound.protection.outlook.com [40.92.20.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4AB7368B167 for ; Fri, 4 Feb 2022 00:10:18 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=POE4TEgWcqLQeIQsXdZZJOuyYkQSmOqgb88PBuQNbcsn8DTYIs9xJtOMqw/QmdHv9zP39PX7mA1s47quOCZjondz9ORb0SooRbHL07w2fWwLyWzhI+sQ3xRUCS/vT9e4JPHKq9l6LElhcbFpRhk433ouW7Ldaze1b32uiE7rbbQAQB1Q+I4naF04M3dPKj3AGRbEIRXNTzilWFmFUYgcfHZ5Jf77Nkn6+G4fwlsrSxfj0kIk+nZZcCwO2A51pJz3MrB8zNt+2crEH1Hp7gY1tIIAsTHbPYfpkpxwZWTpXASEMXI1eR2pp0VQOygz3ieu2tyoDK2lOvsNaigoBvQkgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hfIV4VlSIN8COqfClG/Aj5rT76Q4SExzmLTDv/4v3RI=; b=GrPVg/biouzdQnGMGDUQikSLKXlL/617D6DXGSGchoB8j0kZjBPVc7ebLhvrTp4YbKeH9d/eAdqwujTDNgZ+tPdhKDB5CX7bO96PGlEonMEvrxVFhumRDp2usBbGvZOzSev1HVO7LJJ2iMg86wrQW/0pGoo5rmR+aXcLV3YNIZ9Y15jjNyW9I2hw2YIbcv2KSYeN5C9mezeBC2WCRTj9RRj1LGI0MtDf5we9jcktCiitfkrpYu59Gat2jmw33fxJ8OxHKG0ggVNGbcBGOh3AQDh1lGAHmLz0L6MufK4dY0k7TKGWCapkwZcQJ7oTYI3cCzzeEpo39xnj0whETjY9xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfIV4VlSIN8COqfClG/Aj5rT76Q4SExzmLTDv/4v3RI=; b=M+5+vE4HB8HB/DS20dokkccn0wiUEDA2gP9BHXIQ1JtvqFAAPuNgW5HhfJMjUG9en5y9ZpexjXy4iwAOM/I20UwtjVA2nx0Cwqaqv5ccvJ90A0Lq2gPos67CiYfY+dwljkxj7cjZXFyQLx3M8H0H1/QJXKo2enM78VQbJt/OO9WzcnXgQlNaJKo5iLsk5TgWCiLGCN/0JNT6nPtyEmUcNTZQzam3Y/jgCCYZwQFeL1hdT2pGVa3Zlr1l89oK8QyzTBIV2vRdnuRMUHvE7gSj7GbQjK+Wkpv5UyZl8jydPdjAAOikycuevM3n0r1wC5B7fkbmDK0pe1KLO9TAnxLclQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0334.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb 2022 22:10:16 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b%5]) with mapi id 15.20.4951.014; Thu, 3 Feb 2022 22:10:16 +0000 From: Soft Works To: ffmpegagent , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles Thread-Index: AQHYARF8bvNXtjI3QUi6T5JS+CpW3ayCk1BQ Date: Thu, 3 Feb 2022 22:10:16 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [HkfhpYqK+3NjyLNst6sVlr3kVzJlsN+W] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6aa08add-33bc-49df-4f62-08d9e761f537 x-ms-traffictypediagnostic: DM8P223MB0334:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /7Lq8ilb0nA4G31zh1SL9z4f7DGfXC7MwWYSBIX3xRtbvD+92kYTj79RUQJ+hDfOW27QbMadWGoxpubxeUpE1T7v1dFz+ErydQpj+dlbPeAcwVUEf6Exo6SKVkMm1EQcGUDEjMwwaeutqGCVdDl+FEzC1kopwuDMYRuLpVL1GPwQc1vIIWlZIt3pcusyzhXl7llcedSiZykBDTGgqLpoVJDZSkG8IKNY6pBUualYK1aaEaD+nMVZgPXIjFxkYZlbDjpJcpPyLcSdkaV/oF+lfba59UJxaNjl0WFfbrZ3kgI0KBrb8ENswanyCt+bfS6n+g8NR0tl8wth2HAc9ag0sYZArTDvirVrXXKOzbOb/ay4Lo+Wu9iEOiDKcmXnH9dRhwwcBbffu8jY43e2Eypp+pi/4yEDI2mGKeimDq6yH5eEgoSYqIpCzW9fwXKqAn5q8V/cRRs00VQPUc5dOgfccJDEuaEYELWOKpGw9czppE+meAYqf6fVwzeAQBSvXpALr712BUvsld9keMHobeQTaGCOa/0Lox4YoIO1VIKW1bNX0Tt31BiXmjry3WGaNNbmZ8vUR06AjTLM29ANBZ8id8WPgUnm1cABPXHDustKKee4TH+KMOe36zIaXcytKyypCQ7DnY7bgyk86bBv8hr77h0p344rPMYjXvTSFIzi/bk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlpKNmZ4TzRUSFh5NU1Hb0c2SnFoa0oybVMwbUUvWlpQY3VoUVFxMU11K0NM?= =?utf-8?B?YUZ0YU9LdmZtTnJlT1JOQk03U1FTUjViSEpaOHR3M25mM2FFeVNxWkxIOTBJ?= =?utf-8?B?L3NhWkt6MFhtYU5ENE9JVkdwWnNlcFJIZCtjSFFvOTloTlpURmdxUmUrQUEr?= =?utf-8?B?U0t5OUYzMXQyek9HU3N2OEkwdHVFRjhpYTNtaGxzcGxtbW9Ha1packZOcTBy?= =?utf-8?B?SVFWZEEwNGtPdUNidnZ4MnBuS2xLYVU2aEV4dU1yRDdTRFkxVWNCemxJRVQw?= =?utf-8?B?aGp1UWNhbnBIRnA2R3c1QndzUnArZTVOdStBbFN0ckhaOHpRcGtvUUQzaEFs?= =?utf-8?B?UkVZWkV5NUNrVUJHY29oRlF2Y09VdUFxby81bWEyeDdiekR4K1owMS8yVzRq?= =?utf-8?B?RkVUNFlEaFFzUmpiLytkQXRTc3hPVDhPc1V5L1doNmNQL3BDQ1RhNHZqVGVo?= =?utf-8?B?TXBhR2xDSnV3MmVZU25TNm8xclJ6bUNTMWMrWEFId1lZUHNzWmgzZVJQZGpP?= =?utf-8?B?ZWxvVzZvZ2pjaVNkL2NBYS9SdFZ1WmhQWlUrRStyRHFXZlJ3SWczRUxIZVNF?= =?utf-8?B?anREY2oyZnorUUVEZk1sWEVPQTZFcHoxV2U3VW9iK0IvNEdYTTZNTW82b2xQ?= =?utf-8?B?MGVxQXVqd3FpOEZYb3QxY3J2VEdTdlJqa290bVB0ZGdzN2x0UkllRUtEYkdE?= =?utf-8?B?UHFIVXA3MWFhWXNOVEFpTDlhSTE0bkV6bW9ZSTJncnpYWHNuYXpvNDdIeEhr?= =?utf-8?B?M2Y1NlpKeEpJRkpqdHhGNytRSjE0Ylg4UG5iczNZRml3b1ZrMCswaGJjRG1h?= =?utf-8?B?YnlUSzgvc3lsajNKZ21zU05Fc3dqWnZ3TXoxWFdXS3JlVUtiZTFjNVVVYTZM?= =?utf-8?B?SkxvSm5lc01oRFZQWGpIYWNTcDRQSzZqaEozenFVa0xUV3JEeVZDSEpzWVpV?= =?utf-8?B?UmZrVUwvNGN0cEpudEM0RVpkYk5uR2tDYWlUelZCWFpib2dlMnNmay9ZMU5M?= =?utf-8?B?a3R3b2U4YWorYTlIL1lxbzZqT21TV3JNanZFTDFZOHRhTXRFcFRXR21RcjZ2?= =?utf-8?B?M29XMElMTEJGazVWbHNWMG9BcmtFUUhJTC9lL0dVU2VXd0cyVzZYb1FGeENG?= =?utf-8?B?cWN3Tm9HbmJXMUJQY3ZwdUk2S1JwVmxJM1diUXdHM0hHMGZHNFJLR0xmaExz?= =?utf-8?B?YTcreEZQMTJTbnhiazFPNzlXM3ZnUjROL0tuNUdXQlpmSlh3VHFuOWkzL2xy?= =?utf-8?B?SThram9tRTVqaWlBR3NpSmlWazdONGZiMENFMzVWU0R0anBUZz09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 6aa08add-33bc-49df-4f62-08d9e761f537 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 22:10:16.0741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0334 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpegagent > Sent: Tuesday, January 4, 2022 3:19 AM > To: ffmpeg-devel@ffmpeg.org > Cc: softworkz ; softworkz > > Subject: [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of > dvd subtitles > > From: softworkz > > The guess_palette() implementation is questionable in itself > as its results don't match those from other DVD subtitle decoders. > > This commit starts cleanup by fixing an obvious bug which has made > certain DVD subs appear yellow instead of white or grey for more than > 10 years.. > > Signed-off-by: softworkz > --- > avcodec/dvdsubdec: fix incorrect yellow appearance of dvd > subtitles > > Fixes an age-old bug in decoding DVD subtitles. > > Ever wondered why certain DVD subtitles are shown in yellow color > when > ffmpeg is involved... > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr- > ffstaging-16%2Fsoftworkz%2Fpatch_dvdsubdec_fix-v1 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr- > ffstaging-16/softworkz/patch_dvdsubdec_fix-v1 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/16 > > libavcodec/dvdsubdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c > index 52259f0730..a3fdb535a5 100644 > --- a/libavcodec/dvdsubdec.c > +++ b/libavcodec/dvdsubdec.c > @@ -400,7 +400,7 @@ static int decode_dvd_subtitles(DVDSubContext > *ctx, AVSubtitle *sub_header, > } else { > sub_header->rects[0]->nb_colors = 4; > guess_palette(ctx, (uint32_t*)sub_header- > >rects[0]->data[1], > - 0xffff00); > + 0xffffff); > } > sub_header->rects[0]->x = x1; > sub_header->rects[0]->y = y1; > > base-commit: 573b6b8a607398c5f34108efda9c29d41c5727ff > -- > ffmpeg-codebot Ping. (no maintainer seems to be registered for this) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".