From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 921B8420DD for ; Sat, 15 Jan 2022 08:36:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1609268B423; Sat, 15 Jan 2022 10:36:25 +0200 (EET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2099.outbound.protection.outlook.com [40.92.42.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D63F68B2FA for ; Sat, 15 Jan 2022 10:36:18 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lP0KFeK/xs3TgfFIjQjItA5v36XJiY8zYe0PjdvdKvcc/ambVR9BlrddZPOjhrDl8nvFr70oqCpvNuBr0IfUB52/Qk/PiJLs+OgGYfvUv35D3bL/FQcL4qMrKcWat4aYoKPx9hF3emB8sscrsVP1z3zyHexVVOD/sFv1UaXlU/+roGcjlOBv7XMr/rVFYqN2OVhCIFhLXlVfnI05Egtp/QGr/XfSTT4+n439mmBFhmWvwhK/RDMMFhWuFxanD7OPgakg1Et3dtJEZLrLH79idnJx6iOdYJxZbnqvW2mTcnrQD4R6SitWbfLzKsR0B+IhPrZaQu12+R+DKxp7YkpSIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v0YqKakG03Y66g4mVvUCrxBV1sFRt9oM2d89FELh8pk=; b=AcjGilkJquYxeL1FDkjGlBp9FXbJGO3J2uIjlGBi66kBGIjdB/8DuesWHuDNV9+x8qhTojaWMeA3qdwzfE2W42+PFPwpmZj7CM4tyZPi0ne+86uYBpm8SMytvsph68tkW2nR6oKk2FgJL2elOxKdtRRT3kotbnjV1p/YvjrVi5wdeKbOIvOgngbjSlrWaQNRAFo0oPcJDoNT0KRfaVXOP8lv8Vye5utqZ5hGvtjrIvD4EXIaek462YDNUe8ZEMi5Lq1Q5xAtc+B4H/czQHX5j47+mQhNOIlAAafgweROYV/tA5oOzAvZS0rvGcvNFjugWZb7fFhI1mzkfvtqtZX4oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0YqKakG03Y66g4mVvUCrxBV1sFRt9oM2d89FELh8pk=; b=EUrdwoVHfG6iYdCXNW4wpriEtJmE6tFvO/l+/tAjmbAfycorWg2dd6BNcUKp2zfU34RAp0jaBsLisSy0v/mUmgcaDnUmc4G6etlgDh7usxNMZ0eG64RT7PE8MB83WFxLTHiWCP9zpa3r7D2PdRJIRkvsVp6bkF0jYiRlGBL0Yz27GaH5zBUb5HMxPbpWwGSG/ihz7aR4tyJGtJBn2qr8LJkGYspm0X9o52Dt+/U23Y0U8ZfYNvkulQbs7A5W9ABQ2roqCXXZbRHVSloDhqDR0eKKiqqsX8Xfb+VeZLKhRVmUhnaWa8p4QXipB/9D6EuUo3wUNKSWTncO7c00UFuBmQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0158.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Sat, 15 Jan 2022 08:36:14 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%7]) with mapi id 15.20.4888.012; Sat, 15 Jan 2022 08:36:15 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 21/24] fftools/ffmpeg: Introduce subtitle filtering new frame-based subtitle encoding Thread-Index: AQHYCOQMH+yxbTN7kEKeK+PUnJnS0qxivI4AgAD9i2A= Date: Sat, 15 Jan 2022 08:36:15 +0000 Message-ID: References: <00643582cfc13d22e7967fef50e9b0078ee99657.1642122814.git.ffmpegagent@gmail.com> <20220114165252.GO2829255@pb2> In-Reply-To: <20220114165252.GO2829255@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [ei135TGqCxCBbAhUcUTUdr3coR3ZvY7V] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02a44149-9af9-4e64-3949-08d9d80217d2 x-ms-traffictypediagnostic: DM8P223MB0158:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bdEqr+nWJijgpxKY60gWa0X3IN+vD7ckbPLrTpSHvLWAbOciFs79wB4YxNuRGSkznP0Gyp0VxRjcaToOb7/Obc5rwbtFj0fGLfXwWmIF8eTg3OmrUqfQ6DE3550wCRyUkZFmO8hn9RX7k+VgvqtSOeMTFEuinE+5wDTipC06dFRzge+YcofMtdTER78ZwZ+05zBWNj3xXQeDHW8kMbL+nkY6Vdy2baQxxAHxvduLQZR92QIWGQ92lBLMd8JVZdAtxL1BkeBtxxSDYra9pjvbN9nNWnpXS5Q7kw4avPZWTIfIKvXmOtjnzEVC7uV2yWkrNOnxAykTYZ0bQbRWQeXr0ETPCo+1gJMmgGqlZKcnYNf2weCyayjKJdFF6BJBGF5m5hbrHKEMlvyIelx+3ps09uwjlfB17dqq8h+h7pElaq23CBwYS0xm3PSTMX1qzG9CI589uRcTxjVwUuVh0FLAUa4l+8+KzfexMTnK/uwtdX6364CMaUPRNluOGQFb+CaDVtg+MYYCgEzBQTRToWY4YfCDV6ieu3fsbghZc/ka65cWdbKLlf0IHa5jpA41BTYBfvyc4bbJ+aa3E2VLn3aFHA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dzZXSFhTbUtweFg0WnFzU1BWUGZpbml5TEVBaWVDK0Y3UlpOb1cxcEI5WENa?= =?utf-8?B?RkcxSzFlUDg5SlNzeGlPNGlwd2dxQm9qSldBUS9YR09zOGdaV0ZjTTg1cW9D?= =?utf-8?B?UlJWamt4dy9pbjNIckxnRk1MMUhOUlNCclFHdXFMRVAyekN3dG84ZkE1eEd4?= =?utf-8?B?T1dCVlYyeUxqY1N4M1NTbStOTnppbFZTZWRxL0tCb3ZZb1ZwZGxZQkJ3aEQw?= =?utf-8?B?clhhcWkyS2YraGluQkkyNUpLUDk1Y3BXMCtQcHB2ZUdQRXhNZGw4OXljU2JX?= =?utf-8?B?SElnS1dWMWR0TTdMMEJRTnN1T05INkozVm5xSURXTVdrS2Q2WGNWRjJhL0Z6?= =?utf-8?B?bnllYTJZTVlmZS9qTGhwNVM0TGN0aERiSTlNZ1QwYjAwSzlJRjkwa2phSE9C?= =?utf-8?B?SEMxS1AvV3J3eTUrM0o0M2NPUWZlZnRVQmQ2d204NkRFbFQ0WjRWTFVsUkJZ?= =?utf-8?B?RHhvUFV5TEFEUlRRdG9MUk5ZQ1ZuMUpheDdDYWcrWjJDYXdyTUtMdjJtVEdx?= =?utf-8?B?dGRPcTJjL1NxdjZ4MHN4SThUTzI3VVRMNys1S0x0N0huRUZlVjJjc3RGUFNT?= =?utf-8?B?TFlPekpPK0lpZUhZZG5VK3hFTmFvQkQ4ai9sdmVTUVlKaXV4MWhrVXhsMkR5?= =?utf-8?B?aHlVVXN3M0pHZE55eTZhYml2bis0NnpsZDJZZ2RPV1F5WFkxOGRhYWtIK1k2?= =?utf-8?B?L25Wa1dEVGNMVkdtSE5tVHV3YXhTTnNtYnh6MklKTktmU2ROWTBCTVhZSWxP?= =?utf-8?B?WGhoWFZOcFFRWDRXUTAxMGRSZUx5dU5iRk9SY3YwMlhRRTZ0anFxSjRSdjZk?= =?utf-8?B?Z1BmY1N6UWV2VllBNDdldVZldUNXTHo5OEpTVjZFT3V6VXBGWnUxa25xejdi?= =?utf-8?B?WkhEQWJwbXd6TTBpNG5PQkExNXdkSWJQdFpHelVxRTAvclhGandzb2RxTGxr?= =?utf-8?B?a2IxZU1lL3RBcGVITi9pWTdoWUdlNnpLbkR1eXltVmhsWjhiVEJ3T2pVeUJ1?= =?utf-8?B?R0pYL3h6akhBTVRsTEZ2NGNFSUgyMXVEV1NUS1IvZEZGZFFIMURObXdrNTdX?= =?utf-8?B?WW5iZjhlbXJzeUhpRjBQMVZBeDR1aWNxd1FxYm0xdm9LMUxqblBSZ0IxRG5l?= =?utf-8?B?QjBsYW1Hb0t3d2V6U3BFclpLaWljc3pVd21iQXdHU05mWnZ1SUErV2NuNEtU?= =?utf-8?B?bGlPTlYzVEZ2ckNydHFtZC9aRVFvMVVBT3hPemFpV3h5TS9oYnJTbXJHY3M1?= =?utf-8?B?M3JYUTBkWmJzYm5nY3c2eGNNcHovTUNXaSt0ZkduS1JRb0djUT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 02a44149-9af9-4e64-3949-08d9d80217d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2022 08:36:15.0042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0158 Subject: Re: [FFmpeg-devel] [PATCH 21/24] fftools/ffmpeg: Introduce subtitle filtering new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Friday, January 14, 2022 5:53 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 21/24] fftools/ffmpeg: Introduce subtitle > filtering new frame-based subtitle encoding > > On Fri, Jan 14, 2022 at 01:13:30AM +0000, ffmpegagent wrote: > > From: softworkz > > > > This commit actually enables subtitle filtering in ffmpeg by > > sending and receiving subtitle frames to and from a filtergraph. > > > > The heartbeat functionality from the previous sub2video implementation > > is removed and now provided by the 'subfeed' filter. > > The other part of sub2video functionality is retained by > > auto-insertion of the new graphicsub2video filter. > > > > Justification for changed test refs: > > > > - sub2video > > The new results are identical excepting the last frame which > > is due to the implementation changes > > > > - sub2video_basic > > The previous results had some incorrect output because multiple > > frames had the same dts > > The non-empty content frames are visually identical, the different > > CRC is due to the different blending algorithm that is being used. > > > > - sub2video_time_limited > > The third frame in the previous ref was a repetition, which doesn't > > happen anymore with the new subtitle filtering. > > > > - sub-dvb > > Running ffprobe -show_frames on the source file shows that there > > are 7 subtitle frames with 0 rects in the source at the start > > and 2 at the end. This translates to the 14 and 4 additional > > entries in the new test results. > > > > - filter-overlay-dvdsub-2397 > > Overlay results have slightly different CRCs due to different > > blending implementation > > > > Signed-off-by: softworkz > > --- > > fftools/ffmpeg.c | 493 ++++---- > > fftools/ffmpeg.h | 13 +- > > fftools/ffmpeg_filter.c | 235 ++-- > > fftools/ffmpeg_hw.c | 2 +- > > fftools/ffmpeg_opt.c | 3 +- > > tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- > > tests/ref/fate/sub-dvb | 162 +-- > > tests/ref/fate/sub2video | 1091 +++++++++++++++++- > > tests/ref/fate/sub2video_basic | 1239 +++++++++++++++++++-- > > tests/ref/fate/sub2video_time_limited | 78 +- > > 10 files changed, 2829 insertions(+), 669 deletions(-) > > ./ffmpeg -i ~/tickets/153/bbc_small.ts -filter_complex '[0:v][0:s]overlay' - > qscale 2 -t 3 f.avi > > Press [q] to stop, [?] for help > Auto-inserting subfeed filter > Auto-inserting graphicsub2video filter > Assertion c > 0 failed at libavutil/mathematics.c:60 > Aborted (core dumped) Thanks for testing. With the new update also incorporating the final step (complete removal of heartbeat code), it is unfortunately invalidating the previous test results. The new version is providing the subfeed filter as a replacement for the heartbeat functionality, which is working somewhat differently, and even more tests (of those you are running) won't have bitexact results. In those cases a visual comparison will be required. Anyway, the previous results were erroneous in several ways, so it cannot be seen as a straight reference. The individual results need to be evaluated individually in case there are significant differences. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".