From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58D2D40B10 for ; Fri, 4 Feb 2022 01:58:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AEFD68B235; Fri, 4 Feb 2022 03:57:59 +0200 (EET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2068.outbound.protection.outlook.com [40.92.18.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2584468094F for ; Fri, 4 Feb 2022 03:57:52 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODb5t/O3pfO2hCp4dqGbbhEqDn6lMaW7lx+orc1SpXJRTCBh/Rq5A5Jov/YUDRjXf/XRI/XABR6xIcQkpj2vtqlaWWZFkFzQGebWsV7mr27lLLbhtP7p/N8g0CvV3i5Fvo2CUFCXh+X63APXEYwobO/SuJQfsC6roxCWPaoDIFuX/Xto08PLVQgLD4qPUz0DGM3g7/rjUdkGCMlQR8ypnozvhgRheMZmXFUKygjJCohAQ26y42UJQktBDvPbp9U9oKbJ7ilRSchs/8AlcE5lybEp351/WwDR9bjpqmvhwQpR+4Yeg9PlePXvQWsh6jP66DfvnWS0MqLUqQEb+E0f2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VT+EQaYRVbAH4T3VILks79aB9NLNDSG2B1I8aXEUbUM=; b=gLcDY8NUmoCINKDeobLQG2N71GTq5ww/wNa7UgYCM3F5BLhITQ8MZlxsBBhYh8uGNFSZFfqTxWeqyHTQY0xUyHJ4o2mpqGwozu0x/lEeNkQSdkaV4mnyOqB2DO7H3ZlM0IYLS3XrjyndvD7u0kzsTlmubnjN1RAxXZwvJ1B011ytEaVToqOuHjrYtUxIOiPU031FAfjnQcOFl0utYZ+PhFrRCNCf1uITjOwUfEIT2A28X9nHMxQ8zE/87ns8+UdlgLscRFN4DT1VUGQjr7msmMqBqg5ly45wWo4pcDcyiS/vV6Tr5QDNnUtEho4RADaeP6F5a35QTg/2K0RB7rcWSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VT+EQaYRVbAH4T3VILks79aB9NLNDSG2B1I8aXEUbUM=; b=RUrvqJiXF/IBMrWEE6yUUSJV8cHe9vm2M4IUBMqLRkdEa+WBt1lQO+J5DuvqAZCECFe4ZvpkSvA1yeq0hwnfWwZo+6PLiIPH+uXWWzxXq+qOazMkw+8/fT02Jb+AlGRoK75CMwOlufRUybnCALMJMCGRdkgK+Vjx5V9N6AhS+dsJ4MCDCVfuZmc28awMeILWqutfTGQaF9peHq0Nsah9pVWwjdYTFmSub1G7heJXEISXQHcp81LyBEoP/gIZ+Z7WZGoNEj4jkHq7dcwmBd+MM9hzgMdEESXDthQWSrqCo2bFDdMo1zPht32Qx67f9zzhhpogKn2e8vObraWR+5lPfA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0184.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:146::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 01:57:48 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::496c:9ebb:f23e:8e6b%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022 01:57:48 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes Thread-Index: AQHYCwVRgXvA06Jx3E6UTvILqno24ax/DxUAgAAiirCAAAbTAIAAAGXwgAA3OwCAAEDQIIAA5q2AgAAExGCAAFZm8IAAPeOAgAE2mMCAAEgxgIAABc+A Date: Fri, 4 Feb 2022 01:57:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [a7acD/C0OsqJSLE540V1kIKOOR1sPkVZ] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf63f6bf-eb08-4d47-f565-08d9e781bec1 x-ms-traffictypediagnostic: BN0P223MB0184:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C1liHyemldeUKy0NqTChpf09KJM1HvEEZPzLvRamR7+x+eM/JSJmerEpXv94iAI6bXgADSpWgwh3QqRVX7YtJV9Q3ohN7Q3rFckwpcfU0pXnoJ2a/AyMYm7wXpL5NzHbUgocBQqKqGJdS9+ll/dd95MCPSbqbmZ0RnmUTpr76/3lRi8Tc4dB5TO9mPdILMaUgPL7YhKgKmL1LFMN8TMS5c1kAE/wX+58nJ4QYtGQoJmb9an7bJSARRc0cT5/SE5JGnjO3AkidptPPh2eBtryGBR3zTRVjxxX2SlVYNg3fv0b1o+uJQqabbx9spdQ/vwFXX0RTZZP0r3meycmE0vw9coPkNMMFhbRQzCgfcZDmS82oWUdlEiLoFQRukm/bvI3se9BqV17WpzG7FqbxNLk8IF4VF71gnntzq/Q9BH7d4VHw3FDHdRqOG05rY9DqtrneFTTL4pRC1V3tGi9/la/xOWIOdxQy7FhaPCEO6hrGEQXaTZ48HKW7bqrBZtBPtTsWKCVLlbSxqBG2gCAYiokwp3Inv0aELowrCL1PmxHbCt/SAIyBdxW/qoQcOP9L4Q7Db1N1Gy/yW7b/9pmsG2Zhw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Wk14WjNwcEY3TmpxSWI1ejVvYlA4MkFYUUlmb1d6bkRjMFpQTHZXaWQzRm9p?= =?utf-8?B?NlpwRG5PeHYySGVCYXF4ejhVKy9nd1IzdVBUQ3NQNTAvek1zUWRwdXYzQURK?= =?utf-8?B?Y3g4Z04zbmdrMHE3T1lkQm40UnErbjZUNTY4SVFwMzQrZ2xRODRKZ3hheXpP?= =?utf-8?B?Y0QxR1phM1lSL1VJcmlGSUhkNStYS2YyOUZRbHJrdzRuRHRPTlk2YkxvM1Vt?= =?utf-8?B?UmMyVVZIR3g1TlJZditCU0x0Qk1nc2I3N0Ntbm1hMUo4WU5vVEwxd3p1WXVh?= =?utf-8?B?WUVJQmdMUXM3ZU5ZUjBkVEtXbG9aSXlRc2lRS2JlTnp2UEFXeGlISGxuZ1lJ?= =?utf-8?B?TDJ0cW1NTExESCtsZStLc005QnNnRlNBT0Fkb0YyeFdacUZpVWxMOEZ0QTFO?= =?utf-8?B?QlhnTnM5Slk2eFBidU0rUWRYNC9ZZUFWOXhmYVU1YUlKeU0wdXdlUkRzUFJh?= =?utf-8?B?ZHk0OFF6YStkRjh2cFpHdHhDSVlkRENHSncxYmNPMWdSbWtTZHpWOHN3YzRZ?= =?utf-8?B?K1J1QmkrMmNyc0c1NzhRY0c4cy9ZbkpXSEl5MXp5VURzV0EzU0ZaYnZDWVMv?= =?utf-8?B?WWFxeTBPZHY3Q3QxdWRtNFFsQVJjdFpRY2tvcWVwZ3N6WWJoL1VySHdOU09Q?= =?utf-8?B?dFdTZjRObERFOTlpcVU0MnQ4aDE2YUNsWW05Q3ZOeHZsNStPWFJya1hHZUFE?= =?utf-8?B?aDhDSG5CdE4wREsxTW5oUXR1akhzdDlpdTdsdk4vbW9ETU1MRklKanU1WlBr?= =?utf-8?B?WTZkQmU3SnR6VjlISjNtRXBVZTZiM2NiTzk1YUZvVFB1ZVpFMGl5THVjemIy?= =?utf-8?B?d3VqWExjcmV0K05lRU1uT2kzYjZzZWJyRXhxYUdOMGpXMWZXZURzeUtZdzRy?= =?utf-8?B?R1k5RDFnaU4yR1E0NDlxcEFrR21vRGZTaEM0dDVPa1ZyajE0U0o1N0xDU3lU?= =?utf-8?B?dlkzMUJOdnJ3UWJtN1BmUWZNcjhBZHdoT1hSc2tTMnpIS20ydkdwMGFURnhT?= =?utf-8?B?RXVzVkdZelgxUVFjYldpWXhEOWFna1FLcTBOUitXcFJtWTlRazQ4blhTNllt?= =?utf-8?B?LzZMNjFaQ1E5cEVqOWNENDZDd08ybkoxNUYzMUZoaThWWVkwZDVpK25ybzQv?= =?utf-8?B?VXg2ZS9aVnJYUGJycmVMODR0ZjdXZUYramV1U1hCOUVNYUUzQkdZRDlVUHc5?= =?utf-8?B?R0VvWnF4MjJ4dkhwSXhJQjNpdXU1Rk5YQ2RzckFuUXNVVDErWFkxN09IUW5X?= =?utf-8?B?dHhnQ2JSWUovcXJsdU9PVkdoeVNFb3I2cGhzSDRhaHIydWZRUT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: bf63f6bf-eb08-4d47-f565-08d9e781bec1 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 01:57:48.5890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0184 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Oneric > Sent: Friday, February 4, 2022 2:01 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix > handling of backslashes > > On Thu, Feb 03, 2022 at 20:51:16 +0000, Soft Works wrote: > > I think when you inject that word-joiner as a workaround for ass > > parsing, you'll also need to make sure that it gets removed > > when encoding to other formats. > > There's no way of knowing whether the word-joiner comes from > a conversion performed by ffmpeg in the past or already existed > in the original source. That might be true, but I think it's valid to say that such characters are very unusual "original" subtitle sources and that's why I don't think it's a good idea for ffmpeg to start injecting them. Subtitle implementations are often rather minimal, especially in hardware devices and might not always cover the full range of UTF-8 specifics. > However, the wordjoiner does not alter the visually appearance and > is unlikely to change line-breaking properties; that's why I chose > a word-joiner. Therefore I don't think removing (only) the inserted > word-joiners is possible, Why not? As it seems to be required for ASS encoding only, all other output formats should remain unaffected. > but also not necessary. I'm not sure whether all ffmpeg text-sub encoders can handle those chars - which could be verified of course. But what remains is the question about the effect on end devices which are consuming that output. Finally, those chars are a pest. I'm using them myself for a specific use case, but when you don't know they are there, it can drive you totally mad, eventually even thinking your system or software is faulty. Example: Open your patch file [2/2] and search for the string "123456\NAscending". You can see the string in two lines, but search will only find one of them. Or just look at the two lines directly. They are preceded by + and - even though both appear identical. So, this also needs consideration of the consequences, like how many developers (inside and outside of ffmpeg) this would be driving nuts over the years and make them start hating ffmpeg for doing so once they've found out. softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".