From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1538F4103D for ; Mon, 14 Mar 2022 19:35:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 213A8687EBB; Mon, 14 Mar 2022 21:35:46 +0200 (EET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2075.outbound.protection.outlook.com [40.92.20.75]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A08468A4CD for ; Mon, 14 Mar 2022 21:35:39 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i6XKkfmwM4QyHK2zbWdWvM0SGE5wThWdDplV4ooeLZbn8tMzO2cDcfho78EvVJmABQWzSYjnpeGtVszrH2uKCKrJtxjF2Mk8DiMh4V0CwHNh6RXsdIEw6wZT0mraoL0TkG/+VIX8zC6cVAcUUMgi6Q3j/AMTB8er3zUbf1n9DKNXVfqkVioMcpi//ezq81+804qUh4snVSq4pdabm7WsLdwCX3ivGLhJ5IJ5GERHieVNg1ooVGSrzPdVAVukXbT+vYA7xg3KryvXTrvyCz5rMupAfN1CJIw+qxued9Xpgqokvy4fQhvjyK4vJUL64EAtrpz1/OR4c4EjjIi+14QchA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8BCo+TG7s2a+7VF8cXs4YeX/BGEC0mBk2agyrDRNdQc=; b=mg+JV1dzAvVo096N3L7H3vacmbqW/WmMyck7AbU2RbE6fVKaldKWVtt3+jbe7acWs2EkaHSrWtJP+xX+4zT4qCwoqopKxZHER/qPs0l2v/MJUcF5ZsQkG2OjuXCCS8FvE27c2NsY3gLIYwSaKETndyLshmJ/wngyzMX/d9p9y37lVIrjfoqsT36gMo/yQMvmTZRp1Do0LR0IbGtwHNy7pxR6DQ7TZpKYYQnMFcaI6y6FbyCg7azAhrEav6UQ+LLPSpOidVaQpXIi4fnF+Y5k5zPydBPSNzzt7eiG9wMA5z5yBBIvs08V94CqjrKkWXsJ/2fMhQ0I8Ht8xbDFMzedNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BCo+TG7s2a+7VF8cXs4YeX/BGEC0mBk2agyrDRNdQc=; b=Fe+OtD6OOTFkm7r+RHJ+KeV4O+mj7iDcY4arcZLxqWely8Pza80OAkkv5NMQLs4yOLUjBkvtBjQL9QJD76Crgpko3rKV4qz/sqFl1Kr5OW9+bzBBV6f5u+x8YZC+Ttfi7Aa+dRxSGuNS8V5BdHUnVLnJiE9vxlYp5MwQM8bnAbVB3LdnAihwdfPDXP3ffxHZwBMh4V1v3/0V/EQGy2E33cpuKlIxnNslgh2IyGuaYAwkkirgPqEkU48bwFYAaXADGVxYM5p8+mSeMGY9nD/lejaL/pSFdz7mxGDtaRHguXm7coymEH+fHQcfGHKmA5m5vtoP0449MpIPCIsN1w/rkA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0097.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.21; Mon, 14 Mar 2022 19:35:36 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::3e:16b5:48d3:6834]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::3e:16b5:48d3:6834%7]) with mapi id 15.20.5061.028; Mon, 14 Mar 2022 19:35:36 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: pass storage size to libass Thread-Index: AQHYN9bDK279Nb3A3ky6Ri2Ye+KA5qy/Q9Uw Date: Mon, 14 Mar 2022 19:35:36 +0000 Message-ID: References: <20220314190638.24816-1-oneric@oneric.de> In-Reply-To: <20220314190638.24816-1-oneric@oneric.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [xJCO40Mg3QZCi7IF/LrXY9y112h9Litw] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6666ff5a-26d4-4aac-8d29-08da05f1d02f x-ms-traffictypediagnostic: BL3P223MB0097:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7GjWDRhzdEw4XtRyS/kyxmmw6ZET8kd76Sg2GNv8p0lNV86QkLQIhDhrgbnx3JXrpFrgpjsuwMviPMnhs/hYvvicTqd5/Aik2ZxUWb8eEFAW9hPN6F8jcN23p6GQVAMTkqXmAfWB3TKCEZhc47iOexneeZ33aNKJtEjsQ6lqCWvWVu2F0nwOKH19TPeVUCyMqOclSexmYsOC6/1yL0ctfjjruMb8c/BRBM2kYks3L4EyBG1cANNH3yC1IERGv3ilNPXt6QzQA6XttyKXTfqQrc6s2guvTGL0PkozMcGlyRQpTOsy7f0c4/FuqeEYEkuSiN2SaBEC0CKqXwbUG1ud8c7xHMncjfyeq9yK6yRpncC3LR6i2BmVxIAcZ3mQhxbnEE8NzQsxS8zye45owqfkDFOTn01v7iMnq6d3zJvNKUW+oKDaV5gCQgJQTZzM2CQ7P4OVd4mVfeWD69+C8DzP3edPF1N7l5rV2QjXbUTqnvneh2BwCQHwG2kbMOpq5Xj+s7/zKduu69wsurAtGKvZNE6ube+NNrMIvfcl06CSnml2DZqSEdd8fsryeNKDJfqruyF1qnufVIeyexxZeUZcYeo1bVlx9JpAt1YhK1eH/xaD6MjMIZb097bsi7ORfG2E x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bnBYUkF2L3lnREFya0lIb0VDWUM1cTh3WFM1eWJLZEJjZmhSbHlsL3dzTGdP?= =?utf-8?B?aFJvd1p6VXl3VDlpaXlOZHFXaS9zVlVyNmdXVUFTTTZXdGZlcjVIdFNYa0ZK?= =?utf-8?B?RWhGa1hPVStsU3ZNdnRvdGlWV2ZqV1NaOTQvbGtkZDFIREJoWUNaSmszRzF6?= =?utf-8?B?SzRTcjd6amZzRVpSUU5ZV1lWRkFMMzJDdXYvanBQcnp6VklhRm5iTUw2dVFW?= =?utf-8?B?ckFTR3ZZbVhKR09CNS9kcjVnWVMzMXdwMTgwS2VRNWlDS3RsajNOdTlsQVYv?= =?utf-8?B?MmdabmhiRHpraUZ3ZUZJVU03cjlqbWFMZnJ0SG9qbWtGa1VsbythL1cvblNG?= =?utf-8?B?STRqOXVXa2g3TkdnRVMzZ2sxeEZuSTRtS2VHUGJ4aVJEYmN0U3RJdVdzeDYz?= =?utf-8?B?R2UyamFicFNyWVY1VE9MUDJsNGtlOVY3UVNtbmN6Y0FubmdDN0pWU05ENjd5?= =?utf-8?B?MlZsNFVsM1lyQjMweHdQTjRZQ2R2YWN5ejY0MlZzVmh0VW5vMVMxSWg0ODhF?= =?utf-8?B?SmRUUmhiWm14dkIvMUEwTFUzemNlY1hXeVFCb2pGT1UxVjFVNkNTajNvN0dF?= =?utf-8?B?a0RORG8reFRySk1yd3plU2c4WmQ2a0ZDTjdqTTA4b0xlR3ZIUXZOQTZGUEhm?= =?utf-8?B?RlArbEtIN3haWU11emZxNXE4OWNZb3FDblhVVVkrRzRPd2EyQUMzUUZzRURM?= =?utf-8?B?Y3RDNzZFQ1NBN1ZwaWFPd1h6V2RZWm5XMS9ZN1NJN2h2S3F6UVNaMlo1K0Zp?= =?utf-8?B?N3kvQXdSTHExRnNKdm94d0d5RkwyLys1SHVCNEYvWmN6MkJpY1NaQTE4Q0Mz?= =?utf-8?B?ZjFMdGpaY0JrcVJGbzRTTHlXZlZNem9KRWFFZEdWQmxFTnZjaU9zblIzWDdE?= =?utf-8?B?aWpOUktxQlBkbnJCUzRWQ3JuWmdoYSs0OU5HQkdwVHl1djR1aXB4dEx0VHA3?= =?utf-8?B?YTlkM0Rhei9nTHJ5SjFxSkNXSmZVTEtwTG03SHhTODIwb1VsR1lYT2hxR21l?= =?utf-8?B?dnEzcU81WHdIM3Fkd3cwaGo3eHVNdEtyQUpldi9GOHB6VjFUYzRDSmNIbzFo?= =?utf-8?B?YUQzU28wMUZJWGFoQ0NDTENIMDlta00wbnJ2R2FkNDllc2xsaC9KMVBQY0Rm?= =?utf-8?B?aWtBL1Z5cEJUTVRtUjVVYnN4WkdkTmdNVmM5RG0yaUxaRnVCcXVFMkViTEFE?= =?utf-8?B?NDJuaHJxZmVvY3FIeE1UNXpTOVgyMkZ5OGZZaXhiTm82bHJHZks2WHBRNjNN?= =?utf-8?B?UjhRS1FrbUlqaVBmSEluR29Senc1OTVrY3Azc1ptRmcvRkgvWnZJdUdEeXFK?= =?utf-8?B?MStoSFZHWExKU0JmbjFGNHRuN3ZZZnVKbHFIWDI5Z2ROUlVxMHRic25uTzFq?= =?utf-8?B?WExsTXphVTdGbk91dWVUS0tkWGtmVGxpckVXbnBVeEtGQ20weWpYbXZVWTRE?= =?utf-8?B?SW4raXZ6YVhkUTNXYUtyYWNZRytJTE5GOE1taWt2emlPcGxudlZQaXM5TGNH?= =?utf-8?B?UjhQVDdXR0UranJWcFFKUUhObnI2WDNYQi9UZlkrZlFMbERZaWR1SlhSTS8y?= =?utf-8?B?dlhuQT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 6666ff5a-26d4-4aac-8d29-08da05f1d02f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2022 19:35:36.4068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0097 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: pass storage size to libass X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Oneric Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Oneric > Sent: Monday, March 14, 2022 8:07 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Oneric > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: pass storage size > to libass > > Due to a quirk of the ASS format some tags depend on the exact storage > resolution of the video, so tell libass via ass_set_storage_size. > > --- > ass_set_storage_size exists since libass 0.10.2; > ffmpeg since 5.0 already requires 0.11.0. > > This resolution dependences of ASS was already recognised when the > original_size parameter was added, but it actually goes farther than > just the aspect ratio. Conveniently this parameter still has all the > required information to retain rendering after resizing :) > > Sample files to show the difference can be found eg here > https://code.videolan.org/videolan/vlc/uploads/b54e0761d0d3f4f79b2947ffb83 > a3b59/vlc-issue_libass-storage-size.tar.xz > > ./ffmpeg -i test_1080p.mkv -filter:v ass=./test_1080p.ass tmp_1080.mkv > ./ffmpeg -i anamorphic_s720x576_d1024x576.mkv -filter:v > ass=./anamorphic_s720x576_d1024x576.ass tmp_anam.mkv > > --- > libavfilter/vf_subtitles.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c > index 3fc4eeb63d..af6352b315 100644 > --- a/libavfilter/vf_subtitles.c > +++ b/libavfilter/vf_subtitles.c > @@ -146,9 +146,14 @@ static int config_input(AVFilterLink *inlink) > ff_draw_init(&ass->draw, inlink->format, ass->alpha ? > FF_DRAW_PROCESS_ALPHA : 0); > > ass_set_frame_size (ass->renderer, inlink->w, inlink->h); > - if (ass->original_w && ass->original_h) > + if (ass->original_w && ass->original_h) { > ass_set_pixel_aspect(ass->renderer, (double)inlink->w / inlink->h > / > ((double)ass->original_w / ass- > >original_h)); > + ass_set_storage_size(ass->renderer, ass->original_w, ass- > >original_h); > + } else { > + ass_set_storage_size(ass->renderer, inlink->w, inlink->h); > + } > + > if (ass->shaping != -1) > ass_set_shaper(ass->renderer, ass->shaping); > Hi, thanks for the patch! I've been at the same point some time ago where I wondered why ffmpeg is not setting this, but then I had found that it is overridden by the call to ass_set_pixel_aspect(). ass_set_pixel_aspect() is setting settings.par and if I'm not mistaken, an existing par setting leads to the storage size setting to be ignored: https://github.com/libass/libass/blob/5f0e8450f834894b2745238e3d32ff4878710ec8/libass/ass_render.c#L2891-L2903 But perhaps I'm missing something.. softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".