From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 87ED3433B6 for ; Thu, 9 Jun 2022 20:16:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DA76468B48C; Thu, 9 Jun 2022 23:15:59 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2075.outbound.protection.outlook.com [40.92.21.75]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5308168B48C for ; Thu, 9 Jun 2022 23:15:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Br2ihbbzq8sIND04HIp+DbgGk9t5L7sdajec2dlnZqPzwDHgAKaij/HE9ZUfRgQCkM1kbhr6+z+25ZRaFVG5tlB+QI91ekZWoI80HZNpuAAQZIIM4FokQk9/xSvPkJsZtrM1X7rVNDB6K864l9DN8ZhDCIxBmQt7rbj9RlompzifcjmdptzdGOn1uu2zsKHSxrZdyQoE+6B4ztpFtiHXdrsNI+O78UA54Na7/NBI86KOyEKu2ZoLlSMFn3q++JdAs9rShshEbM3VQj9DAwzq8W6SHuDfuaMmPT3UJNW50hwgRY7Xyh8rsvX7gPQuX4XMeqA/H4mZFVg+t8265Mz4Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmxJHqFs8VljWzruXL5GXCfOapwNfL3kX3f0XXRylEY=; b=JMIfPmDtgRz6xVu+JYWyPUrjg8sc/Pf0vFzS8es/xWOrUa8sKEGAXocoGzsppz09nWDEnpG/gYTnWqDr5E4TNXLRZfr/WQfWTEFJ/r5MVGa+J24Q1M5t88omm23vdFbYyZcU/rrkKFet+B0O9zw2eOYkraddIV9FCxm3aJ0DSXbKtdIxnQzleiQYBSrRABL2NEIHd4xk+/AveXwPN9D8VpCX8J1Le7/ulZZ4kL9BlbEGMyUQmNfouJz93Xw8FYSufx1bnhYYFRw/8HfzRoihyrSV8JVsZsQzn7Q8ofKai/ckUooJT+1Ko7dgAxZc1l/R2b2rAuTKqz8eYSOjVo/zcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YmxJHqFs8VljWzruXL5GXCfOapwNfL3kX3f0XXRylEY=; b=nOUeBXMcrUuMs3wHR1XRCC3veiYDqrJ9z5HDcJzrhrKlw8Yyt+bl6U/lFGe39oUTjNyHoKTdwncr5cOGNgZL62aFfNtm0f87790B744nKjL3xIHYrh9Lm0aL/GRojYCd6D1xYKiiUIiSRqazxGLGWgvKR/K9JE+LQIiDWMTRDga3W4iCKfJ/9zn5aLrG4gXE5qG2pMbjZEs4WUVy+3DkXPy2JnMv3kfGVlogOnCA4XSADwh0alxPhuBqVYCEZah44yDlpA8TRKCfC2A4BxGFkIVlD34f2btiZMv9RMgXvv4QfGKy8a79P5/9Fz0RbMHo3aA9NqCRYcs+1EEFmpIr5w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0279.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:146::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Thu, 9 Jun 2022 20:15:50 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.019; Thu, 9 Jun 2022 20:15:50 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows Thread-Index: AQHYcOMEF+s1C8V6TUmBB4T137zuaa1G7n+AgACgcICAAAgFUA== Date: Thu, 9 Jun 2022 20:15:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [ydhKkpIHjNlG+Iv+W2UYOOpe+G6V2/o+] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9031ac2-bdd1-4d2c-4965-08da4a54d90d x-ms-traffictypediagnostic: BN0P223MB0279:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bX+SYpAzbpIJEsgkWmnOsF+c72R4BdIc4dVaHl73f/e81g8xt+mJ3RmHB/Od7EoOUEdwXNeEScMJhaqOjmoGFmIPFtNKuThH+O5RXopA+EyhL37ih5Fr1TBcLUWMWqDybYggWBdpQGx8nSlRqQxU5/oemRoX9LjLFUEAQH6Ip9Os1caSdTng1tJ5sobGyiUeu9zIeuEAivMwL3QAogvHdAKw1zoNnfF/Dt8qa5FiDj2R1Ol1zfQkcJIhmAKglvcHyDnbprfFGmuzB0MaiTC3o/yOSIY4XkI/GJYaM9TCjdTvd3x13WjMM9tzx4kz0JzRVeX3ZQ0eL7y01IyH0VMxcybNQbZjxJu9OSC42IcHNvgsP4JW43sE3iuFcALZZTr2mVJLVxvm3+wgeuQrFMYnFvSK88BRPRNX+KTQp3/RIeTiMWM8NGtQckbvWAE7DLJTk9supGno4PSoMXnsIejI+OhaM97OyVA8VRzee1fk1++5Sfj50WBKhJQdBwmgbAf3nsGXRm+Il9KcttVU/3eB8vdV5vx0UH9HPqZifUEi8knnn1WW3fTBsA1VbeCNDWc7Yn7bEqxjrr4BTrkKf2unOIamxZAO+jhezHZ5vZo1+Q9L/UNmPs/SD3h/u0Qvi+Ax x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S2l1bjhxUEpaWkNPa0I2bHI0SGc3c29OVkNiV0U0TFZwM1FmaWtXYXk5U1Fu?= =?utf-8?B?VTlUUDFXTmtKV1RhVkdUdjZoQ0RJQjZZRXB4azMwTFJuaXBLZU9mQndRaXdC?= =?utf-8?B?MkgyNGJ1MjNKRFBzUlkxRjVmVzFEN0NqdUpXR1FXY2R4clRXSmJjUkJJR3Rv?= =?utf-8?B?ZWxPeHk1SEtTZ3lvYnVYK1E3MlRxSnJKdmwwQ09vU0VWbmxQQUdERXZOK0p5?= =?utf-8?B?SjJtYXorSGg0ZDd1dUxHek5Sa2dsbnFUMzBIaVN5Y3R6Wjc4S1RUalQ0NEp4?= =?utf-8?B?UXBxK1NqdjdsY2NrVjR4N0cxMXFSVUZ5RGFjMW5ZRlk2WnRKTHVkdU90Vjcy?= =?utf-8?B?Z3ZtZFdnY0FyZ0UzVkd2T09kNzAyU0RYRk9YMFl1SnNMRWhrbStONHBaNnNl?= =?utf-8?B?ZXoyVnZVZWF2biszeUpUVWtBeGxxcHBDdDlvNElVQWI4cEw2dWFJcmhvR2NM?= =?utf-8?B?dGtLN3lrVW5Vd0MyQ0pSYjRuQlhDOG4ySWcwQVBaNUlXUDIyOFpPQUV3S2VE?= =?utf-8?B?VFFkY1V5WU1YT0YyOEdyOUg2UFVkaThkcUtVM3c3VzYvd0VCRnJMVnlkMWdq?= =?utf-8?B?VVBkYTBRcXIzL2c2d0FoMmJDVWx5R0M2RHEwa2ZmVHZ5VEduWnlBTzJBZ093?= =?utf-8?B?eUtaNTVFQ2hDbGJqNDBuQk1oamdXZC9KVHZiMEI0cHc2bUI2bHRqbVp3cE1R?= =?utf-8?B?TCsyNnpKTTYvZnZpS1kramVueE1GQkJnRUI3STlIbFFPVzBCSGp3eVVqd0x3?= =?utf-8?B?L3Z3bXBjVTl6M2E3MGxLMk5rZ0w3eVlXTUljT3AyWUk1L3ZXZW1wWWJycGV3?= =?utf-8?B?WDZzMm12bktLUzNKVHJjWEhRTkJKdFI1MHJEbmVsOGZML0g3YjZhaXJGa2o4?= =?utf-8?B?UEhXYUVkZHhkVnJjM2tmOGk0NXhjZWRlRUFwc3NhL0g2b3FvVXViTDdLMjU5?= =?utf-8?B?OHNXWEFxSVFkaVlxR3hkQWZNZTYwc0MzV0pweFhOTHRCY0J5UHFpK1kxSWRx?= =?utf-8?B?OFpvZWljcndNZDlBVnlLRVltU0c3VkNuTEc5Tk1vemR0WS9SMis3bnJVOFBn?= =?utf-8?B?ejBIN1F4N0V6cjVNT01mTlZUMi9idXZISVh1WnpRTU90aGlscUFXSnNkamtp?= =?utf-8?B?Wjl1ZFFYSUtHQ296WmZ0Z3BKMm52ckFGTGROTmRpKy9wSFVqMjdYMHBuVVFy?= =?utf-8?B?NXdHZ0ZFaHBlLzFsaWZ3cGlXY2FRZ1FHekVBM2NheW4yNy9SRFlBejkrTWg3?= =?utf-8?B?cWwrZWJGYmRLT1o3UWl6d0VuVklJQVdIbTZzVWhja0ttblY5bXdwanhXSDgw?= =?utf-8?B?TklZZUJ6TGFkY1ZYbVhJR3VPMzZ4ZW8vUTRSeVFrdmpMSDMvRUdMbDBnMXZs?= =?utf-8?B?LzRGY2xKYUFUNlYzWHZnQTJWeVU3TjRpNWVCNEtiZHZXcGdCN09WaERtVW5S?= =?utf-8?B?cmprcjhGNyt3djIrWnBZaTRtRy96SUFjWWZXdnVpRWJmWFFRRlFRZWFCMWZO?= =?utf-8?B?UE5VOUJhYlB0VE5qNEhCd29kZzNWdUNhcGlJbzJVQkVyYjJwWDdtNFhKeDBP?= =?utf-8?B?ekhVUzMwZzExRFZRT3drREx1YU8wMmkwNmMveUJrM2pNZk0yK0pKcjdqUzZi?= =?utf-8?B?azVoZFNjakx0ZU9BMWMvdjI0L0JiMHZKcmJ2TE0vWGtzWlcxTW0waUpjbzE5?= =?utf-8?B?WWprQzZscU11b1BFVm56N25FeGVMZWNOSWhWNEt3bVR5bStPR1hkVmhZS21q?= =?utf-8?B?NEFsTVRnMFlBUmRWSVZBRTFTOWx5Tm5QOThOT1oxaUttUTBYdGROZmRNZE83?= =?utf-8?B?OWZ1ZHhzejMwK2dGd0ZINFpPRHFnc3c5WFFBeFNIbE4yc3RrczU1alFjbjd6?= =?utf-8?B?WVFKMGVWUWxvU3pIM2VLRDhudTc2SUwvRjdGMmRxRmlaSXZXSXlRdW1BMHZU?= =?utf-8?Q?z76fq/+Xt4g=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c9031ac2-bdd1-4d2c-4965-08da4a54d90d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2022 20:15:50.5425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0279 Subject: Re: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of nil- > admirari@mailo.com > Sent: Thursday, June 9, 2022 9:37 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows > > > This looks fine to me, and the discussion seems to have converged, so I'll > > go ahead and push this. > > Build is now failing: https://github.com/yt-dlp/FFmpeg- > Builds/runs/6819319105?check_suite_focus=true. > > In file included from /opt/ct-ng/i686-w64- > mingw32/sysroot/mingw/include/dshow.h:33, > from libavcodec/mf_utils.h:32, > from libavcodec/mfenc.c:26: > ./libavutil/wchar_filename.h: In function 'add_extended_prefix': > ./libavutil/wchar_filename.h:211:9: error: > 'wcscpy_instead_use_StringCbCopyW_or_StringCchCopyW' undeclared (first use in > this function) > 211 | wcscpy(temp_w, unc_prefix); > | ^~~~~~ > ./libavutil/wchar_filename.h:211:9: note: each undeclared identifier is > reported only once for each function it appears in > > wchar.h is indeed not included in wchar_filename.h. wcscpy is defined in corecrt_wstring.h, included in string.h, included in winnt.h included in windef.h, included in windows.h > Incompatible pointer types warning is still there as well: > > In file included from ./libavformat/internal.h:30, > from libavdevice/alldevices.c:21: > ./libavformat/os_support.h: In function 'win32_stat': > ./libavformat/os_support.h:241:36: warning: passing argument 2 of '_wstat64' > from incompatible pointer type [-Wincompatible-pointer-types] > 241 | ret = _wstat64(filename_w, &crtstat); > | ^~~~~~~~ > | | > | struct _stati64 * > In file included from ./libavformat/os_support.h:32, > from ./libavformat/internal.h:30, > from libavdevice/alldevices.c:21: > /opt/ct-ng/i686-w64-mingw32/sysroot/mingw/include/sys/stat.h:129:69: note: > expected 'struct _stat64 *' but argument is of type 'struct _stati64 *' > 129 | _CRTIMP int __cdecl _wstat64(const wchar_t *_Name,struct _stat64 > *_Stat); > | > ~~~~~~~~~~~~~~~~^~~~~ Yea, right. We need to get rid of the 'i' in the struct types for getting fully independent of USE_32BIT_TIME_T. Will send an update in a minute. Thanks for reporting. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".