From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 687304D40A for ; Fri, 21 Feb 2025 11:56:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1D9F68C7BD; Fri, 21 Feb 2025 13:56:51 +0200 (EET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2104.outbound.protection.outlook.com [40.92.40.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6409268C1C0 for ; Fri, 21 Feb 2025 13:56:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WMNr3E2SlpcphWY+qCmCx3Fu7nsS2GNZ7qR1+HICLBvyiJrikNp82hX7KaK8jqzuMcPLf5blMpa+57T/7cQ8FxUaxs0mkKsUcNp3Gkvu6rd5yyJ2QdKQwDY1AIno9rBf36Cp2uIDXQdA5O2M2hTFUXtt8tJHVTcrg43FLpaE8DULEWHgaLPCrf0u9skhUBDFdUDjZwPk+URo+sMqN+Ww0ZtjvQ9Ik4LnaLuQZ3nIA533P7k3+PKcv8gnNkfHT17zUXZ8eYiJbLIWY+O/DBDmvIA4Dkgk3PHQq+V+oOkDUBc/NmpsQWW3iqdn+zBCP4SX38tTTBYj7cP2Bj2KVwVIuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/wP1xvZsMtqnWXzas4SDDl4yJRNQb5LSu+airQftNTY=; b=B9x+IJ92CCpEThtdGHT1DUvPSTTDLwaonVsQ0k2CgRO1RpOt41aGa94/67LFWhrpTT9MDkmcPwvO2k6lt2EtsGDQTIhAtsidJAeQYI8GGA9WETra7IZ4HLhCABjvSZ7BT8232wAzReJBkbKAxVJnmPQldJ1YKjqbQFCH++FlV6N16rafuEx6jNLjTRMumKrqsTCTjonMr89o1Kr0ZqRlFD06VdB7ixHQtzx/PD44ti60uuxMkFHqZUlL6N+isvlj3oVZgVuTZS1M7ouxl7P4rENXmhinRPzHwDwnvTHipvlcsdtoIs0Ixnqy5mO8ZsUzfbMMnJ454hwnvI/9a9ovew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/wP1xvZsMtqnWXzas4SDDl4yJRNQb5LSu+airQftNTY=; b=YrDXd0MRHK1HH6WxXlN/qrw7/VI1YDoMRbOcNqnzQ7eM1HDB7dIkCM+kC9ZsWqr+6r/CHL8gQZIyCbrZAFGxOmxx6X4uem52wAoLatLa3KzsJz2AKTlRU2NhymsGIuYJKk3u8MCFhHCCHJMoCmAcYO1XXkX76sWs/uX8aKLJTSCOAiAU47SSWBdZ/PByHzupbulddm8PDPPnOpIu7YbNKC2gNaAUTOwvWiXBPZnFdr/tHAU8ltnqCfacl7UWUUV1GWvSXuHz2fQlmLhGBD72Fdn9uzdPFiU6x0001fDMIRrTNjYvEB3EPmGj1co1SD7TQhw1O3yxBWCwUVGM8V+v6w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0843.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:310::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb 2025 11:56:42 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8466.016; Fri, 21 Feb 2025 11:56:42 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] avformat/hls demuxer: Add WebVTT subtitle support Thread-Index: AQHbgtgKMM1o2+xJsU6wq/42GmZJJ7NRfVMAgAAnmHA= Date: Fri, 21 Feb 2025 11:56:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0843:EE_ x-ms-office365-filtering-correlation-id: 6b167bb2-2a88-40e3-f692-08dd526ece64 x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|8060799006|19110799003|461199028|15080799006|7092599003|440099028|3412199025|12091999003|41001999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?NZS4HSX0+hpUjOCpwCyWbR99SIRFJ2CqCFOYxvsUEL3B00UtV3CbgCXte5V+?= =?us-ascii?Q?9Dy1OqlmUmMwSV4D9ER+k8I1P205Ms7nIbbR77p/K1vhpjF7JqVilO9WCKCm?= =?us-ascii?Q?VJmgvx2ssrN8AmUEvRpJFEVd4olfB3TQteAt+vCKwk7vmVdyz3rqMCB3Skye?= =?us-ascii?Q?1QJVwapnrXMkU+A4plXjc8plr0tgvBDxrkuReoqisWoshWAUrG6prGZe9LHv?= =?us-ascii?Q?14QJQ7zfFFy4YkfJyoOPYEwJFFIaTPcQinpCUtwq7bJEv+QY1kDGohkPKXp3?= =?us-ascii?Q?bgJjNC6d9BuG2b3aewDgDkBsFKMjWW50YlAdlt8QCnhbrEmUO06z5fPeNj8C?= =?us-ascii?Q?WhSJty3caNh2p3nhlZdmuNA46Srd3fTUqFxmm8fWnwHnDlxZfD8LvWnj5h3u?= =?us-ascii?Q?MvbF80vIqX/vV9cbtxP3yXN0udzqLVKJlVpWJYU22E7dw7ELDPikaohJygVA?= =?us-ascii?Q?c6CslivOHCFk74fjPtu6f1DQsScdESDkbFNvHb0OAdguOfVS0lIIm8h9HdLA?= =?us-ascii?Q?gjnXAVLUzLGXFHIQ1DhrEaV+y+N0JwBrt2lL1wRvOh/rYj7nj+N1n9A94EIc?= =?us-ascii?Q?4sydYdvmv/IssayLpe1YCGlJDYozcZ03TJCeB+xOW421vQjEEqsi2SxGnCcv?= =?us-ascii?Q?ZxSsopNyIbAmwIOW8+XwR7o7AKj+yyJLjYEwVmDxwYtQgJy7p+clu9Pd28zA?= =?us-ascii?Q?bWxkwkRLaf5TV7JyVzsnaM6sbxQR/C3Ue5vNk6pMp8Ankj04L3xJf/E6TvOa?= =?us-ascii?Q?tula6lWRBSuo+5hRYYXYBBkRtRvmwuRVkOowt1yrsQ+qyRkUMh9sW5pFnVYJ?= =?us-ascii?Q?NLXCNe87Tc8cCFkVad8SQRiuMrqkYMNi7AQ2bsXp0qsCYLmkbJCWDEUXw7fU?= =?us-ascii?Q?plqxrv06BVl3NxKvkRD7/zltmPfXSUgOW2fdu7Mrht3ZlMXksuZUEby+40DX?= =?us-ascii?Q?OtZYRMGvL5D+3sGLQ+dG9At5nvELyUh5JZTFXaGnNK1Q7DVl0GAGFSY79ueA?= =?us-ascii?Q?6qsC/uAcVHN2h+H2bfMG+Jk9zXJIa+6WxB3M9uz8I2R/nkPmHR7bZdzWCA4X?= =?us-ascii?Q?cp1dV9AKfZA0Kfy2ZFd7VukhWMH8OzIj1AVD8YosrgKRdWhUCwPuffPJhutV?= =?us-ascii?Q?+jMtMi7qXsK9Ofs2s/XVg8JeuZblZDVfqg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+AX5N00DYFWbrdwnNhE5EezqGqplRWzcuyHOaTTWR91hYFAGQxEXE53EjKIM?= =?us-ascii?Q?p4s2sKbC5W1MGuJQDd4GcynVi6RFsen5IBES3s2qdskE4ZGpOjD2ukjXsCll?= =?us-ascii?Q?WzW9ESv9tMONfII0hrtJg+0GqFTPByFu3MaoPcWI6BI7Di6DkFgvHzxD/NiM?= =?us-ascii?Q?VffHeW0tJ/T4djh3Kg+Pzw8NPTVmE3Va2i3+Nzwjkf6eZ8vMDMGfBC3M7AKY?= =?us-ascii?Q?8WiviNZIjPJRXDcm6fJazF8/v5oEF6YbeanpsNCSxmkGGl72MxpnK6hDD0Gg?= =?us-ascii?Q?9x03Y77zhNEJr1jmuooL+v8m1CTqWsX4qBkuu5EwAvDYpYhfNO+cNtA19ZAN?= =?us-ascii?Q?3nQf0Vwko0IKaYPaoIRPj0KQA7aNnfUBiAGiJ/Jy8qCODnHxxDq0xdP3k5jS?= =?us-ascii?Q?1X2rG07rmVkKe3UIcMZhqjYbHZ0nyAEAcInBcOl3UY2m8uTjMHk/IU+GBlx5?= =?us-ascii?Q?YmemE7n1RKZ2rP29uj+8RavwCGlVmt4sknhJPHpGQCaFgo5ss41whPMXo8On?= =?us-ascii?Q?7wAsfaNToTKrqRJUGqQcU/nrXLkhH6gwoISVxU//Ws3nG90UqB1ddvcVfnvk?= =?us-ascii?Q?+bQtx17SqIkDRxWk13xh0MLxl2HjLGQGx+GjxyZB+RqxbidN/68zTcRAHt5K?= =?us-ascii?Q?QxZIAi3uANYc58mPAwQsWXBCNCSPONGrEYOS5c1cTQ/DHvxvsEntgq4n6zDw?= =?us-ascii?Q?zUO+xj9f6206d28O96+kYsTnv+/mq+jOn6fpQysc3GV4LnWU7X7ATuAH3B+D?= =?us-ascii?Q?8qToOwB1X0ehwLwyVIIJ8R5mfdimOHRCzpar34g9Fpo2CjwhV2+7HRT1Iiyc?= =?us-ascii?Q?Cc+vqKEkBnv4Fa8RJBp9+EcJYmnoC/ek2OyfNdnMV0wyhEDGtD9TIN1g78Xu?= =?us-ascii?Q?r3n03CLT5YN5GLBukf/jFvTpd0o9CLnt2jeF/vUSxhwbxWRzXsEBYi3T2P8U?= =?us-ascii?Q?8ubfLyxu+rgA6n9OpXrHR8t0mWRjTgWnDe8o5Hxygcsp1ssnalu9RLOby1hR?= =?us-ascii?Q?l/qXowcVTljdY8TSAKvnCnNeLdqsnX9EOmffPV3xl+jvJgPUsDadEvSdFjXp?= =?us-ascii?Q?BPGMMFLKq7ESj5ovfUvZlIwORZVUJKsApk2Pc/GdIwB6ETUm81W2JDSSxM3p?= =?us-ascii?Q?e5t3jyFRb7ZCOzyrbB08rg3Niqxh3QiCl5vjwIqvLGwm2lQire0g8SQn09bO?= =?us-ascii?Q?j1siYRPtXDIgk50cVmRJM15w5Zi+kP23i7NVzETBq2xDP/wvjjpNRO9JULw?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 6b167bb2-2a88-40e3-f692-08dd526ece64 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2025 11:56:41.8611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0843 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls demuxer: Add WebVTT subtitle support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Freitag, 21. Februar 2025 10:18 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls demuxer: Add WebVTT > subtitle support > > softworkz: > > From: softworkz > > [...] > > /* Open the demuxer for each playlist */ > > for (i = 0; i < c->n_playlists; i++) { > > struct playlist *pls = c->playlists[i]; > > @@ -2107,8 +2230,12 @@ static int hls_read_header(AVFormatContext > *s) > > return AVERROR(ENOMEM); > > } > > > > - ffio_init_context(&pls->pb, pls->read_buffer, INITIAL_BUFFER_SIZE, 0, > pls, > > - read_data, NULL, NULL); > > + if (pls->is_subtitle) > > + ffio_init_context(&pls->pb, (unsigned char*)av_strdup(vtt_sample), > (int)strlen(vtt_sample), 0, pls, > > + NULL, NULL, NULL); > > + else > > + ffio_init_context(&pls->pb, pls->read_buffer, INITIAL_BUFFER_SIZE, > 0, pls, > > + read_data_continuous, NULL, NULL); > > 1. Unchecked av_strdup(). Yup, thanks. > 2. Is duplicating the string even needed? Can't we simply set the > AVIOContext to NULL before closing the AVFormatContext? The lifetime of these two is not aligned. Also, I wouldn't want to make assumptions as to what is being done with that buffer at other places of the code (where the constant might be subject of an attempt to get freed. [...] > > + if (pls->is_subtitle) { > > + avformat_free_context(pls->ctx); > > Doesn't the copy of vtt_sample leak here? Unless I'm overseeing something, the FFIOContext owns the buffer with the copied vtt_sample string, and that FFIOContext, is owned by the playlist (pls->pb). It is freed in free_playlist_list(): av_freep(&pls->pb.pub.buffer); In that function it would be ugly to make a distinction depending on which type of memory the buffer would be carrying, no? Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".