Re: [FFmpeg-devel] [PATCH v3 1/2] fftools/resources: clean up and improve resource manager build system

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ramiro Polla
> Sent: Montag, 2. Juni 2025 00:08
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] fftools/resources: clean up and
> improve resource manager build system
> 
> On Sat, May 31, 2025 at 12:56 AM softworkz .
> <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ramiro
> Polla
> > > Sent: Freitag, 30. Mai 2025 12:52
> > > To: ffmpeg-devel@ffmpeg.org
> > > Subject: [FFmpeg-devel] [PATCH v3 1/2] fftools/resources: clean up and
> improve
> > > resource manager build system
> > >
> > > - move .gitignore entries to main .gitignore;
> > > - move vpath directives to main Makefile;
> > > - remove superfluous comments;
> > > - turn css minification sed command into a one-liner;
> > > - deduplicate targets depending on CONFIG_RESOURCE_COMPRESSION;
> > > - introduce common .res pattern for resource files;
> > > - remove RESOURCEOBJS noop from common.mak (it was never populated);
> > > - add fftools/graph/Makefile;
> > > - rename OBJS-resman to RESMAN-OBJS for consistency;
> > > - move graph.{css,html} to fftools/graph/graphprint.{css,html};
> > > - disable dependency checking for resource files, to prevent spurious
> > >   rebuilds;
> > > - generate resources list at build-time based on all resource files;
> > > - the resource manager now uses the resource filename instead of an ID.
> > >
> > > Adding resource files now works from any subdir. Suppose you want to
> > > add a resource file named "foo.html", then all you have to do is:
> > >
> > > OBJS-$(CONDITION) += foo.html.res.o
> > >
> > > To access the resource, you retrieve it by its name:
> > >
> > > data = ff_resman_get_string("foo.html");
> > > ---
> >
> > Hi Ramiro,
> >
> > here's my review:
> >
> > 1. General
> >

Hello Ramiro,

> > First of all, I think there are a bit too many different changes at once
> > in this patch. It would be better to have each kind of change
> > separate and then apply it uniformly to both, .ptx and .res compression
> 
> It would be better if this cleanup work wasn't needed in the first
> place. 

I'm afraid, I don't understand. I don't even understand why you are 
working on this. I have sent patches already which are even predating
yours. 

There's no need for you to do "this cleanup work". It is my work and it is
naturally on me to do this kind of polishing.

I really don't want to see anybody saying they "had to cleanup.." something
I did, because nobody "has to..". You can review the patches I posted, torture
me as much as you like, but you don’t have to put any own effort in this.

Thank you,
sw


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".