From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 880D04206B for ; Sat, 15 Jan 2022 07:30:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D768A68B3FA; Sat, 15 Jan 2022 09:30:37 +0200 (EET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2081.outbound.protection.outlook.com [40.92.42.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC78C68B3AA for ; Sat, 15 Jan 2022 09:30:31 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7k4RElQOhNqM5eNwtKyjGZfhYdx2TbILMx5a9/zDixRov6cJ8bsjVstrvsOHV65vei6uWsyawiZ40s4IrNpRK8+3afoqzhKtNXCcqkXZSlLTiGU+hvLDIaAcnn2jMcjmgs+ofG4osPt4SczttESs042kkWbEnbKcAM1M6eIYBb/bckEnOX4KpXo3K6iHCd10buLqhDUeAMR85KQY8NTOPK/VxtpUjnbF6iMLp5dL3GcL5dLvUysFsv2gzFbFweCYy7Xr+7xQ8NIJ610H+Let10VHBZPOSHWTHPPs/uzMxGlKQg3u4hp6ytK58vrHMtaEDeRtolamFUkP3OtzKFh9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PcZfwjodE5jDnweaF2oX5MoQehe9ZJzeQBU3cynsVRw=; b=lct3f42h1kYCrf6JnBQOY+8eGiuV8yoodgkWda7Wo1PlUBx7UK01Nj+g+6e9C8cg0v8Dz1PPtF6FhisODRdjHe3f7vaj9dQ8Jxc+f6f82W7Pi9P2nmakogN8Gq8zeOeqt62dlsHabPfX95Z+isclbMjAIUtFSv4i+qQZUnkUEnlHoT+M4iCFI0ktrTVC3epmSmp6vj19pjGUG022Ph6D9gN8G1jYIr2EVODdInSVXGabrRHJ5/WI8lVPJ5EAMcWVeM0lqqypZnUHBzBB9dO7z9v/3SuiG4RgOixeWyyyxMR37PuHfrrvK8BnJyORwrAWGkCeREtbVKMQnsFdkR6JDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PcZfwjodE5jDnweaF2oX5MoQehe9ZJzeQBU3cynsVRw=; b=P+j1iGWavyk6GVDISb25a2UxLU3o8cXF8CtEeyZLmpaiAT137pcw+WBAa1T9JT6qrd+wVrXghOepHiq38dU/kisVMGGIOeMqVKvY4XpAFoIas7anF1QV8SK8w0kEcFA6e2GltzuZ4zFbZmzIHBZIPJIANOVk50ZMeI42yyuPNTRb2dfEG0lvAPf+Sn+cI88MgWpDQtv29NXcbSsZIdKKf8wj6Nrj3b390pho5aq1OQRIMFOUozLgm9g8VNYIueb3554G1t5HlMaM4vDRnNbFDmViiddwEearHb5bnqoFd8slm8VWrw3BHOBUc7C1C6ECinCxwnIE3Dto+a/HSGU2nA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0113.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Sat, 15 Jan 2022 07:30:28 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%7]) with mapi id 15.20.4888.012; Sat, 15 Jan 2022 07:30:28 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows Thread-Index: AQHYCbb0X5En51serUyBtJh6PLfb5KxjohcAgAAHj7A= Date: Sat, 15 Jan 2022 07:30:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [nDlTpRlbdG2yhO7mDurgDUU+NRFchOS0] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2fe08379-b6e1-446d-b79f-08d9d7f8e755 x-ms-traffictypediagnostic: BL3P223MB0113:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SBodt1TTsQI2aqc2Pp9W4dnWRNUhkPgWq2qxto/OmEe/6Jns6EMJTZkB/eeMFcwRDpLxd5qxJ4ym5O8UPA8pd3w33orzzmsEUShYMWs+Ue0aO0Q8ITpnrPZ8JVbOlUdSMv5ZiHJOQCqOQc9olXmJqccmoU1XdkHbwulL11loc3zz4YZRL1qWcJuTmxtrZHUAYU5bfoOgNMwQUGgdOERj1V/T/jqCiioiSNmAN6ZgbeBOk8r/0GVASXNuJVz8ynsyLoyYq0s2C6e/8BA+ivggGONSMlDQyYvBWCxWHXuLMTBAosN74FiKJipOVmAQgbRrPBtIBk6FYjPYX6/Xz1hiie0Y6Cf3bGakcMW/4duew+b85LxdOdO6qV+wLSISiqPAowu4CskfsXn9ewF1UziDzKCZ6V4Qb1zVxhSN7efrwQ4sy7iKZWlsOvE3+f9CI/1aP5Zp6eZ6v73T8lTaG8HjAgMt6w6uXLBYAXQE6OVNaNIo6sRXhzj1WwXI03fislueL4ukLD/BinvuI3hiM9evpvoAKHTVAZq434m/RYiULSyFu7+k2zj9wG472UWGz5nFqQp69DBBP+UunzmA0au7y+HeE/HJKq+kocYmBmbryyenr4dmqOJzrBcAstrY80EMHp/gmame62VlHJVnHF5cMSevc7QRwaSFC6xbC73Bt9w= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y2xFa09sa2FYd3NUd0RnZFlCOE9VSUVtQVhLWmJDSGR2eWp1Tyt0U1RsU080?= =?utf-8?B?R3lpdWhVbGFWdXNOOEFwT0Q4RG1ESDBZUVUvTmNQRXlqWVl2Q0RwU1NFQVZp?= =?utf-8?B?ejZmbXhzQ1hYcTBqb1dKT0o2YnFhbFRQdWZJTmJSNGtYSERMbXNVK1I5TjI0?= =?utf-8?B?LzczbDRrY2JCR3U2b09ycFlZTTJnaHdkVE1uN0pmUEY1cVdGRnlNUkk0eDhV?= =?utf-8?B?MUR3NGNGbkl4enVtRnZ1dnlyTG14ZE9HYlMxRHBJeldudC9zSElNR21iditN?= =?utf-8?B?RnZRYzlCZk1zKzRCZmZvdWFJbTlyZHlvdUlWS3dkcGVsZWQ3bWkyTWs3NGw3?= =?utf-8?B?SFp3OG00akhyVHQwRTZvRXc5UzRtRk04V2YwcS9ndFozQ0QweC9RVEk5QUNu?= =?utf-8?B?ZU9SOUR6QktqMGlTRUpmVjBsYkJUMHYrcW1XYXdPWERkOXRJZlhCM0ZhQ3Ix?= =?utf-8?B?TkpMN3pIRitSUkxKT3BNbVZ1VXJvd2I2S3FaRVNZbkNyeTBNUmM2ckRtdFRK?= =?utf-8?B?c0JlalZ1L1h6ZG5qVHQxRG54WHhQMWVFZlpnemFUdjA0WjN3Q2xVM3hBVmhY?= =?utf-8?B?b25VRGpTOG96V2ZhSmp6OWJqanRFUzRMRERXbTYrZi9SZDVDMGljbGFiT0Ni?= =?utf-8?B?VzBWSXNJQ2ZxMkRCOVhoc29Za3VUZWllZGdsUFRwN1pYbVljY2hSQWJhUHB4?= =?utf-8?B?QitWaVhYS09XQzJCdWdwQkRBWFN2TitTcjc1SHU0YVdCbXF2aXhzM3JxaWI4?= =?utf-8?B?YVErTVRjN3h4cC9XN3ZvK1R5Nm5RUm43MXRidlUxb1VLcXMwajhidHhyK2FW?= =?utf-8?B?QzRiUVdTbEdQM05mR0VoNkF2S3MzZXJQRTF4Vndyc2hscytQQlovdUNFU2xz?= =?utf-8?B?VFVNNTZmOFNzbnNQT25ZN29hZTA4Tzhtb3FISHFaU0V0YlA5K1l1SjA4akho?= =?utf-8?B?T2VocktqWHF6bk4vcCtDQjdDakF3RXhhZVoyaVlJY3dwaWZpUCswWjFRamdv?= =?utf-8?B?dVJuVHNHeXR4R002WUNieWxwd3ZldERIM2dDLzFSckUzbkxtT3JxWjAzS1BS?= =?utf-8?B?K211SnR0NmhNcDExcHVWY1VsOFVGaTNXaHNObndRRGhzRkdLbFR0S0ZhNU5h?= =?utf-8?B?VUIzVERIQWtMcnBWNXFRWTdOYXJvdm41SEdhVEhNN2NaUDhYTDREM21kU1d1?= =?utf-8?B?R0VZL2xzZHVxUjRzNmpYSC9CSndKaHROWWxBUzlrc29oSnk4dklSbEZGNFhi?= =?utf-8?B?YWc4dXh0aHNnY3pXbUs4RjRGZ29IRDFCMUdFSldsaTUreWxxUT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe08379-b6e1-446d-b79f-08d9d7f8e755 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2022 07:30:28.2026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0113 Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Saturday, January 15, 2022 7:40 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on > Windows > > ffmpegagent: > > From: softworkz > > > > Signed-off-by: softworkz > > --- > > avformat/hlsenc: Fix path handling on Windows > > > > Handling for DOS path separators was missing > > > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr- > ffstaging-19%2Fsoftworkz%2Fsubmit_hlspath-v1 > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging- > 19/softworkz/submit_hlspath-v1 > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/19 > > > > libavformat/hlsenc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > > index ef8973cea1..eff7f4212e 100644 > > --- a/libavformat/hlsenc.c > > +++ b/libavformat/hlsenc.c > > @@ -3028,6 +3028,10 @@ static int hls_init(AVFormatContext *s) > > } > > > > p = strrchr(vs->m3u8_name, '/'); > > +#if HAVE_DOS_PATHS > > + p = FFMAX(p, strrchr(vs->m3u8_name, '\\')); > > +#endif > > + > > if (p) { > > char tmp = *(++p); > > *p = '\0'; > > > > base-commit: c936c319bd54f097cc1d75b1ee1c407d53215d71 > > > Thanks for reviewing. > 1. You seem to be under the impression that NULL <= all other pointers. > This is wrong. Relational operators acting on pointers are only defined > when both point to the same object (the case of "one past the last > element of an array" is also allowed) and are undefined behaviour otherwise. The case about NULL is interesting - I wasn't aware of that. Is it practically relevant, i.e. is there any platform where casting (void *)0 does not evaluate to 0 ? > 2. Apart from that: Your code would potentially evaluate strrchr() > multiple times which is bad style (given that this function is likely > marked as pure the compiler could probably optimize the second call > away, but this is not a given). It's not my code. It's code copied from avstring.c - so please blame whoever that wrote. Regarding performance, I'm not sure whether this is relevant in any way, given the low frequency of execution and putting it into relation to all the other things that ffmpeg is doing usually. > 3. The code in av_basename() is also wrong. ... > 4. Is there actually a reason why you don't use av_basename() directly here? Yes, multiple: 1. Different behavior - those functions are returning a "." when not found 2. The docs tell it's required to copy a string before supplying it to those functions (as they may changing the string). 3. The hlsenc code changes the string temporarily and restores it after wards. The same couldn't be done when using the avstring functions. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".