From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B9AAE4BD5B for ; Thu, 22 May 2025 12:13:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3EBB168D8B7; Thu, 22 May 2025 15:13:54 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2090.outbound.protection.outlook.com [40.92.40.90]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7556E68C05F for ; Thu, 22 May 2025 15:13:47 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iZKlLFX9XQtNE4+jSSJ/b0KXSMZ4EMvwN3Zqaort0CRVGLLmjIhJZD/JegGtiX3ivI48mTtuLA2HYG2DPD/4/njT0qPD6Py/ISNwI2PzKD7KIfebX3ATVUakys7+CTrgHcFrta/JLfEf4qMVCB5lAOvOhIWRUU2UzSLGiZ+vFXjJtoMeuE7/Eus/YgtPpZ3inYvl3HewAVKRSVNrA4qR1q41FQzssTwvFrs4EpHS0nAde3dtBBlFgi9o9ElH7JT+DfPJRN72+S6B3B2pKNIeIzFClOfa+4lImYJBK8qJ0NujZUWtnyYu+XzBzC2NbsITrPfJMR8gC3pxHfs3ViVpOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+kYrzAf/Ddgl6oCOKeCQxTWs18/5Ze3MQVFI3mgxEM=; b=Qi9dGIkCQX6HVWgfuvBNSEmXO5JK1SDDZqIeIbkZSll/qasBxbZDH3IIhwPm6RpN9DZJtx+yx5kUOqEEcPvBHzJQmongpnywSiD6b2ztakfbofDEfwTg7R2Wf93J/AqfT0AqltQkZhptIhs9+petOaCEFVg2M8rnVkbz+44/OgmzPhulN0hxq8TbsoEBZK1XRNNRkzbaG64pIVlmS/K2sNnFU8uvX9zeTCXqtFNPMw1tcZ5aC75hlPCKZ0Oy6cjaytLZrIj45fzacfuoQZRYucuS51gDj6AiFAuOq+dIjwYpENe7bSvC6HiUlM1RjForcjfmYXvV6D9ywq8hCGE/bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+kYrzAf/Ddgl6oCOKeCQxTWs18/5Ze3MQVFI3mgxEM=; b=YlsugYj1CXB/ojNVfw+rwJBqlroVDFtziuSzNSBRx7LBVYFXDia5jlg8UmxSrO+Rp9t9NPKDeJ9hDJ/P5jmmhzGwoRM5Y4FsLE9Ubz8M3CJ3NJ4ModNH0Yl5AJSt6aTFAzZ8dETF87QmvKJySMi482p5FTlpu/s2B5lU/+XHKXV3HZbExsUfmz/pm07sgiinBYbXSi2px99BGUek3EVBSlCNXhSlxqXvv7rfYi+2Mc4q8hqy79NJj00EO8EaLGpo/g/qWUoWj0BvRzD0wqYi73wWiLVdMzCdRZkbZVXHnCQuCImbodQtynQVTEqC+cr25//BItZwDZjzGbF9vZrl4w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0348.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 12:13:44 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8769.019; Thu, 22 May 2025 12:13:44 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Graphprint Patches Overview Thread-Index: AdvJ5+bnifF8gBLfTUqEJSqZYoRXbwAV5GKAABNAjwAAAC/O4AAAs2uAABaJmgAACHPyAAAAh/vQ Date: Thu, 22 May 2025 12:13:44 +0000 Message-ID: References: <20250522112350.GP29660@pb2> In-Reply-To: <20250522112350.GP29660@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CH0P223MB0348:EE_ x-ms-office365-filtering-correlation-id: 31f2718a-f1c4-4e73-6490-08dd992a1922 x-microsoft-antispam: BCL:0; ARA:14566002|8060799009|8062599006|7092599006|19110799006|15080799009|461199028|12121999007|440099028|3412199025|10035399007|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?l1z8hIyiuxY2uFSP9IMvkVkhvtoidwzJ3a+qPY0P7/ZGGzjtTrVbraZDoOGV?= =?us-ascii?Q?ie6rY8i/1TfIDXJkshQ9FzvxGwyLFIte/Kj4rwRdbtlHHgh1r8Ej0/5JcoHt?= =?us-ascii?Q?NwWRyw9cDReeFrc802pp47iHJYn8o9NVNGcVwqFa55gXL/av25oR2cyalRJV?= =?us-ascii?Q?hLU88LkJhB7bqVIAEqKtdpKBlTMgfdmqxd1Ok1lj0D1WCZVZMPnLN2HkXsvS?= =?us-ascii?Q?QBWN2FDu18riDUGM0++HaDdQOsjp3CPhsSiLeEtz45z0KR5r/k1nAhDu23g6?= =?us-ascii?Q?p0K+PVHq+rp3ECMaz/LwixjkNMtT4ybFbEMzGvMGkDWgYcc/R6EpKOAbb+eo?= =?us-ascii?Q?eIVfBMm/fxWeXcCiQN+i375H5U0JBeY1643igMYuHl/PEyROEgRj4hucFcWM?= =?us-ascii?Q?/BzT+hTukSKbZtWIWFLjYQejiJfLDy+Tg6RdwbRXfVDylf85XKCSyL56WVSy?= =?us-ascii?Q?mk6QvE0L6U5bn+qzdeNomaWqjLiz5STVxe7yKlFz9m1MTrrJIRkqzfQ1pSSo?= =?us-ascii?Q?6FvylR0Qlxj4HSZ/DFuEcRTpdn9POZjapygfKdIrUmmUAc/iMsaR11LTdcLw?= =?us-ascii?Q?TwkMobPtEBSHhwER5QpV9ISFCwx6GMdAc+7f+NWe/tmK++pnpPQDWgLEwDLK?= =?us-ascii?Q?hRalbzkqzBe/Ut9X9BJGfe2U2OE9WSEnXEfqeDn38bSr/D5Ov2V0MSDA3kZj?= =?us-ascii?Q?UtT99mSKiaHr/tl7rtn7vJMx/RhHlH9ECS12xH3sTbdFDjh8VFy962CL/mXA?= =?us-ascii?Q?4l9Fc4HNm0Y19fxmnzAN2qwh8kThzqsr6ZXIdTJQaR0qgwNFoyQ7HXIQdW3B?= =?us-ascii?Q?CqjZeft1PocD6+rSM2f2IOg9fDnAQcsj9VwmZqQoVes0CX3Fvhhzyh1sK3Ir?= =?us-ascii?Q?TNHdZYEFeTfyf1KOsHa0YA2VuBxdiEisfhGyYsBJ9plbtYCIyVEeozr0YAsX?= =?us-ascii?Q?VGZ0uwx8SH2fU5+x32ZEY9n4LY+JeYxNAUvac+XXNCgVAcE/GQfiVTFUOfVN?= =?us-ascii?Q?2URjxOhxmc721qRA3gsFI/3DXPODuB9NIh0pSpISsSFgcdso0St5lYCwP6CE?= =?us-ascii?Q?bTP+V1XX+bNqf4Jjaa9uQdWU6QNa0Vsw5ifKg0nxyZ5XZ0OB3Qa0DAitMMnX?= =?us-ascii?Q?NtvsXNeto+B5q++8dG5/5wTMaFneNJeXglau8zu1bO7mSQAxQUZ/vwzmV3O2?= =?us-ascii?Q?p+8lU2Ly2dP1EY3xRNN2nPU22fYyethdGgq4ivjHgx03ji2janM/Oa6WFqzR?= =?us-ascii?Q?SpdGFjlMquDIcp7p3vbU?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FgIgXsIXVSCKiwt3cNpOqHGAOL5ZnmKRdbfJ/CsARrDtwifcrerCESreiKHD?= =?us-ascii?Q?eLSWpbMc5NyvgShd4ROTnzW0GGRRbna6XpyOnF+mVTzclnEgnWM1ofDEa1Ur?= =?us-ascii?Q?7f3RBrBiqWV9FiKqN6M+7bDKjLPCk3spFluRd6JlkWn/dvfiyTy3vo9fn4yB?= =?us-ascii?Q?Y0D6Dp/+ezfst3rJcEZdChzhgoqeZFBkOzK2D0qaDAG2XVC1B4q4tNgXrZPD?= =?us-ascii?Q?Z50GoSMz/d6X2rhWfkUycd3I1lo1AS6ENDJuuTAOGCEa/fRRFo+630KLXhaP?= =?us-ascii?Q?Pz7ozdVxSWOsc8kqJxfVGAd3zvN3lMLJOHuP57S+HT5EsDpUmI1O/8cNaruM?= =?us-ascii?Q?afJP5+fufDtr1muaneNz6siLZiqJ7A9D/SuEuYuksU2jcKK3Vd2ItK3BK6ut?= =?us-ascii?Q?iyx1Wph1+g3e2sUEJx0D5EDqhJ6FsgwJSHcGVXxolUtJ9X9WVrTiTvMT+n9E?= =?us-ascii?Q?ARxmKaBUfSkl98V9EHA3JvD1CyQoh34wDf76RYlqljldzzi9o/rpaE3NVd+r?= =?us-ascii?Q?ZSA/Hy+lGyOfjCh9teqp4m3Hv2iD//LQTgHnsSvipjAVaSPNXaTgRVb7yvwB?= =?us-ascii?Q?wFZO5IcApH6mMohbRXiv6iTZKyJhReh/wSjJ0Go6O2r8/OyVAN+fw9Je2REJ?= =?us-ascii?Q?NFP5Lkqo6O2hg6yQO6DNAroK1y5XZW9XkEcM55eAMrxTzHZ7U2MU2MKAIaSw?= =?us-ascii?Q?v+r22JOAx/m1qC7r4JxPhb+g/l8mCkhVCQ2SvK5K6C98Ybg7hnwDNoTID0K8?= =?us-ascii?Q?59Xgw6BJ0A9UbFeXD1Tj0xlvwX3IUuxsXlJ24HEkcWW/UjazQ6j7ili81uH6?= =?us-ascii?Q?LUV1Ge0LIIxVHT+2Z5nVCRUQd6FzrjvL9eJhJTK6qPdR44MUNE7ny5lOc/LZ?= =?us-ascii?Q?2qdyVHJ2h+BIOZyWpPD5SYqK/Y/+u6UiRSkHH/SJRAN9wYIVt2Or3XlAERfG?= =?us-ascii?Q?p+9NTSAFtkHOLMeNsIxeNGPKmFo8dWlf155Ou5HXXQ7WzVk1pP4wm+AhZe9M?= =?us-ascii?Q?eE+O2Nnz3URZDHSNr5AcuPV+C2AP8rvoyUM/m1grseTvAGIlgSkXl6gHA9qN?= =?us-ascii?Q?0vVZrcc8IaWFSlSBrcc3SvyU8Rk4ctd7ZbtIk335KTExOiFb8wt3L1mRISc9?= =?us-ascii?Q?QIgyvIt27EpQbiq/JwLtTPbQ9vCACLywA8tYGV97pDHY1s+R3CBgpQZemX3B?= =?us-ascii?Q?0bO79dnqdiRXTSY6kH3rMRnYG7cXNSrO40c1GoJjnasJ8yAbBPL3DEfY+tw?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 31f2718a-f1c4-4e73-6490-08dd992a1922 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2025 12:13:44.5267 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0348 Subject: Re: [FFmpeg-devel] Graphprint Patches Overview X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Donnerstag, 22. Mai 2025 13:24 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Graphprint Patches Overview > > Hi Kieran > > On Thu, May 22, 2025 at 08:21:48AM +0100, Kieran Kunhya via ffmpeg-devel > wrote: > > It's obvious basic testing was not done on this patchset seeing the scale > > of memory leaks. > > > > I would like the TC to decide on reverting and proper resubmission later. > > Iam not speaking for the TC here > > 1. The graphprint code was on the ML for a month and resumbitted for review > 12 times, basically noone reviewed it (going back to that will not help > it) > 2. The graphprint code is very actively worked on (thats normal and good > and what git master is for and thats how it improves quickly) > 3. The statement that the graphprint code wasnt tested is obviously false > softworkz tested it. I tested at least build on multiply platforms > 4. "seeing the scale of memory leaks." try to compare this to > IAMF "git log --grep IAMF --oneline", IAMF is after a year still receiving > frequent security fixes. This is just as a comparission > > What you are doing is trying to gain from somewhat popular oppinions > at the expense of the project and team. > > many disliked the "opening of a browser" and thats now resolved > and reverted, but instead of letting the wounds heal you throw salt in them. > And while people are working and improving the code you push another > round of animosity > > I dont really care if the code is all reverted or not. (it seems though > wiser to let people work on it as they already do) > What i do not agree with is this seeding of animosity you do. > > This very much reminds me of > Simple Sabotage Field Manual > https://www.cia.gov/static/5c875f3ec660e092cf893f60b4a288df/SimpleSabotage.pdf > > Also there is IMO nothing for the TC at this point. Its actively worked on > code, > there is NO disagreement that any bugs or leaks need to be fixed. > And reverting this is not going to accelerate any fixes (if any bugs even > remain). Just one more note on the status: This is not a work in progress, it's done and complete, otherwise I wouldn't have submitted. I did not check for memory leaks - yes, I should have done that! Albeit it's not library code, no large amounts, not constantly growing and most of it allocated only a few milliseconds before the FFmpeg process exits. Given the attention that some are paying to those few Kilobytes, I have to wonder why nobody seems to be aware of the existing memory leaks with QSV hardware acceleration. These _do_ appear to be growing over time. > many disliked the "opening of a browser" and thats now resolved > and reverted, but instead of letting the wounds heal you throw salt in them. At that time, I haven't had a chance to say anything. I will follow-up to it shortly, but I wanted everybody incl. myself to cool down before. What I can tell though in advance: That narrative of "inexperienced developer accidentally used a 'bad' API" doesn't fly. It was a deliberate decision under awareness of the potential risks when not done right. I really wonder how Kieran can't be embarrassed trying such maneuvers which are so obvious to everybody. Best sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".