From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2D4144D0B8 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 01:29:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C448687D40; Wed, 16 Apr 2025 04:29:13 +0300 (EEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2047.outbound.protection.outlook.com [40.92.41.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAEC8687AAA for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 04:29:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yASm6gp/nMhY9Vvc0E2AGBAWuoVxvTj2YnqdTIqv7Esa7lGxKLFyU5Gvcm3pJ4ozntPL3Jno35YUfFbpbiCB3L9itHxeb3NAO08FNXpF5ZNO/vtsxW98Hst9tiar0D1Dy2yVaegEyCvCYV92mngsxHFgRueP2iflmPecsv6DMwTobkEJME6IkQ6FlNRR640bZrarHUg/Hq3gZUTPIfiXXRdiKCqAVZrYlRpr4CQpWqs/Zq9wttANaS7/fYk5VowdzhEjgvH6mrvM7DNWqO1ia4jAiPnc7ELagROc8P2i6BmqaAoVAmEN10XWlCVpIlSsdmv1P8toAOCGa95MUm28kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4tZaZsrRJhK6nztcDQRijVYOV9JpnwKcrkNFsklnbbU=; b=YKtPFRpNlPwcVaqCgK//PYjicNguTY5Od16lO59/m4KXuejDrtvw6EWXHLWfyNOSH9wCSiW5w3MBguaFNj4p/FuJGVPx2qAYzkUFqpROVGS2QUKfs+FVSuVh9o5QNVFi41dP/xK92wa3wVsA0nma7oxWMHAZn2wTT6z0mTaynqpeJBfGd4DKpyANmAAll7U9vB9tGVtFtqH+nB0qnQfPyayuCjy00us0ZTgl8zcMLIw31KYV2t7EqoiDtfPf2UHrfm5yDToC4JAxwffqScQYU7z/UfDnIKo+8O9w4fx8tGe0LK+ucTwPuBlxil9yucAMmyRax0ZOObNnl0/RXQ0kfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4tZaZsrRJhK6nztcDQRijVYOV9JpnwKcrkNFsklnbbU=; b=sqN1lG1i7Qvh7cRBlz0BKjCTj+/++qDvOLhQoXWObOjHWRJmOYe3KpqLkGWwnSeydUZiu2iSDusf//YfwRzLqw3TMVwfNxGgtQXTBq89W94hv/H2xv8uYjWr4PBuOsdRns3UwMltCT6e+G7bI2XYDvCXPz4e+n4hjoRHZr/BmleXmTr7TRX3iyj/PibcK5xOY7sAjvN5KLYX4RoEmhjjF+UIpKw7J1YChj6hbDl+9f5fJHue6hUZsoBfutwheZ/sQ4uiBfyTjtKjD2eMI4FLbl59JriPdkS6KUPYz0gO8bpkAtwdGz28HShnCho0fidCmFMqwo3sdf3pb+ihRkif6Q== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ0P223MB0566.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:478::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.33; Wed, 16 Apr 2025 01:29:03 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Wed, 16 Apr 2025 01:29:02 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAAAZwAIABQhQAgAAFo+CAADvZgIAAAb7QgAAop4CAAACN0A== Date: Wed, 16 Apr 2025 01:29:02 +0000 Message-ID: <DM8P223MB0365836071D915E428907879BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB0365928500AB53069869DC99BAB32@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415185538.GR4991@pb2> <DM8P223MB0365E10D38EF9174A32557DFBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415225001.GW4991@pb2> <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250416012145.GE4991@pb2> In-Reply-To: <20250416012145.GE4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0566:EE_ x-ms-office365-filtering-correlation-id: 8622e598-5cc9-422c-84c4-08dd7c861232 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|7092599003|15080799006|8062599003|461199028|8060799006|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?I0TsT3JMawoVU3jFrtDVfggyKpbA7hCaKePAdnIE7cf0Sww6GVJKKkg0wzx0?= =?us-ascii?Q?G0KAtmP4eHo7TKrctKKrTeYXbU9zMvMf5VVP90LxfsCIoeagjzn9OfzqMogj?= =?us-ascii?Q?iPHOxyH7fxM29Jv5VM/eqcRwsOqcS7wTDDz8GDFfDV58lG4afBeeL4iifzz9?= =?us-ascii?Q?F0oFFxS52HW6yFkD4yRIGdYdA8olOGoo3giRnstP82EkH33NNn6beveR0bqD?= =?us-ascii?Q?iep5EwqH37u8uTIabtF7QPA5USaMaMHXSh9zZTBaJHGUhce9k3pKQzpXmupf?= =?us-ascii?Q?bnkYEkrhJL5iX+cfmW+8CA/qkWZHJ8YCR4pJ58xOWCMnCrTukgs0qVvm2bUO?= =?us-ascii?Q?BrbS7pJmjnpW0g5UD7Iz3rydBm+oia4i18LH+PtXdMha2DsvOMbyMmNgg8hJ?= =?us-ascii?Q?AeuO+58nsFHj6+ZNdHZNLWWLQcefGaB0ljCcM4l5QnV61+qlQqVUam9AgakA?= =?us-ascii?Q?I5hyisIKCq12YfhjcI0D/6gIzkqrxKtd1pIaElxrUOvJ51YfxhCt58vcT/Rj?= =?us-ascii?Q?cYXmVtgkqc524glpIyxqzQU4HyGfln+rID+9UvpAmb8gS4BZsA7E1BE7WPfs?= =?us-ascii?Q?QFrK8ETHvWH4kxyDM9WuIFwN9R38gy94Lanr62mDdxy3yhOefWpsF7/Ob0tn?= =?us-ascii?Q?vKwwZA2+2eU3b3MgaHEh2sV1CoTD2fxGV1sL+ri2YxtjwDHtQGf1y/s4/dRJ?= =?us-ascii?Q?X1YV9zN7+Dapks8OZ6vL6tYderePwVGZHOUF70ZdUyFMKI1lT2LquVRq4d61?= =?us-ascii?Q?pPBcL/ai+QPancEWvbeioOGEszW3hv4LmlpqiObCmTGs5BPDJjs5Qe2eRR8x?= =?us-ascii?Q?M0M9/s/Oh6EPgKp4tVmN62W/jCe0OBjGcuoERXfyVwyzI7zhB2xcqwulGdRz?= =?us-ascii?Q?q3/dcYbj8+NFk8wk1B26fJaZ9OQz0eY+7PeddmeoWIe6J5y0JtyNJrlmkebf?= =?us-ascii?Q?ELBeUQoJBBd2bBJt42giMyveVU7Q4A+w+kGIHct1MWtpJ/E2I3YLazOzUuPi?= =?us-ascii?Q?212tajTp1tro+6FN9emJB+HwQuFDaab+sQeg3AtFaK/jL9wUwDoO4OqQDd+p?= =?us-ascii?Q?jd1U/92FTmOpvcS2SUMnmJIu2nCHeI6Y/vmTUBN+wT5j+3YWjWc=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yE0XJ3TRceri2Yl7nhj1zpxHbLRnL5r9NhSM22DWU84KfzFFJ0gGYM8ama5Z?= =?us-ascii?Q?fkgkcJQmOg3ZpOmjm4VGt8t5gVQNCWwxnkH7xAZIYN71KwDwvIyoqBoY7xp4?= =?us-ascii?Q?3y2RFPbH941hnNkhTZzyXzneWQjvH70BvfX0zOp34smzrV3556rt25AAVDsh?= =?us-ascii?Q?tiLlQAADquN6f1swguIA9qQAYGCXUJJupesywdk2ZcwCYJH03H6g7AqcvWsU?= =?us-ascii?Q?REoKmdl1HiGlekUSzl7cpGd3D8x2tftX1DP6SU4PU6XL3vAWT6z1jAqUGMvZ?= =?us-ascii?Q?7a7blkyOBzCuke7AGbrVb1sIGpsO1WOJPlhMgh0UnNa9DxEACe8C4az9Bx5B?= =?us-ascii?Q?A52qaNXtoRHhhh8mtcdzNIZtE6J9D1gtCLc7lcuZ9YOVRpWTRZBx5Dn9ATTe?= =?us-ascii?Q?EDt27Ti697/tpOUKa9mFgqkX9qXt7Y+3/waLuc+PRvoiSMGl0kEZnkLANtf4?= =?us-ascii?Q?rWu2/J/c7nI2GgX3kHwt5ZOQ5rtxjLXq9AugC+5Ne/5xIHKAqShZcvz2Ue8Z?= =?us-ascii?Q?iD4/2DgcGa4hbrdX4OXHYej4KqEw31QwCpH1gpLgned4wLHErfXws4YIk931?= =?us-ascii?Q?mNdBtQNwFifazCGI8W7rs10YT1L8gOuKdPdHF9Nq5R5sF4IiuK5cvmHERQNO?= =?us-ascii?Q?7/nKdJVdhZmjcyTRgc2J5/CbqFqkuHmXDZ7GrpKD9KOAfr6W7s4sjhuaL4xN?= =?us-ascii?Q?nYfIXuTKyM9uV4If9L5kmHlAvl0+SVZM4SQH5mE3mKCjwK8VNf05nSsjVFIh?= =?us-ascii?Q?s6wGdLfj7xhb0DI6ybPqlyCScHaCP4toAXi6yVg5pYAlLc4+UvXKgkDljzPv?= =?us-ascii?Q?cc+phIaeob0J9oyliiTNItWymbLsiQ8TR7oGG9rERrTLxrutGjbkbMXAEQWk?= =?us-ascii?Q?HdFTy8aUCtCNNrNB/GqW6JXEQix9J5onKvo5O/GuHFEvuyOZGiUDMehOOLZn?= =?us-ascii?Q?iiXfcQuHnuvd91I1DrpYZB8FUvKW5WrVAcLwx95ljgIMLGMhQlcgtqGGoxLH?= =?us-ascii?Q?kVCGFtptuakOdHo5fuIpsgSxOzkCnnXs24qkZ0f9tkfvOhQvR3xPDOe+j3dK?= =?us-ascii?Q?/iZQeUihTQIOZDP6drgATBIOPgaXILaRWQJIVqyWKBn3QU3Ax47XkWjt0j2L?= =?us-ascii?Q?c4oJJyP7/JMZxQBThUrq8H6cSOUps1YWay77jSnJtau7/5XWCGCcChZgSeCe?= =?us-ascii?Q?WjwcCWeu2mgKYMAt94MVmGT7JoYzqUK62nuZr07eMh16QGP4jeBHIrqzHxU?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8622e598-5cc9-422c-84c4-08dd7c861232 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 01:29:02.8768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0566 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365836071D915E428907879BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 03:22 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On Tue, Apr 15, 2025 at 10:59:07PM +0000, softworkz . wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > > > Michael Niedermayer > > > Sent: Mittwoch, 16. April 2025 00:50 > > > To: FFmpeg development discussions and patches <ffmpeg- > > > devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > > > decode_str() did advance > > > > > > On Tue, Apr 15, 2025 at 07:59:00PM +0000, softworkz . wrote: > > > [...] > > > > > > > - The representation of multi-values - both, internally and when > > > > outputting as probe data - is a de-facto standard > > > > > > The external handling in formats is specified in the corresponing > > > specifications. ";" is certainly not correct for formats which > > > natively support multiple values per key. > > > > > > Internally, if you have a data structure that represents multiple > > > authors, you certainly do not set it to one author and a string > > > with a bunch of semicolons seperating multiple authors > > > > > > Title: "Smile ;)" > > > Author "Smily Face ;)" > > > > > > is not 2 Titles and not 2 Authors and software that cannot handle > that > > > should not be used as reference IMHO > > > > > > That said, anything that works is fine with me, > > > > > > But internally it will be better to use a representation that is > > > universal, generic and simple, ";" may seem to be that but only > > > as long as you do nothing with it and dont care about corner cases > > > > > > Ill leave this ";" question to everyone else, i have a backlog > > > of quite a few things i need to work on > > > > This is not a great outcome, because "leaving everyone else" means > > nothing will happen. > > I have a release to do, I have contracts that i should be working on, > as iam a few month behind some deadline, I have a backlog of fuzzer > issues i wanted to look at. I have a backlog of other things > > And this ";" thing is close to the last thing i want to spend my time > on ;) It's fine. You don't have to. I'm also not insisting on my patch. > > At least revert the rcombs patch until there's a conclusion, because > > it really makes things worse than better with regards to FFprobe > > output. > > I guess thats reasonable. Perfect, thanks. > > This will cause deserialization errors for many people in the world > > who are processing FFprobe data. > > As said, ffprobe should not produce troublesome output As I said, it cannot be remedied on the FFprobe side without making a breaking change to its output format, that's what turns this small thing into a big one. Thank you sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".