From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AC20F4CB8A for ; Tue, 27 May 2025 19:58:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 39F7E68D942; Tue, 27 May 2025 22:58:24 +0300 (EEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2050.outbound.protection.outlook.com [40.92.20.50]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 57A0A68D801 for ; Tue, 27 May 2025 22:58:18 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X7np9an62a7/I5arLiElvkOpqK9V+rvVeNJraBJxO76iLzvXG5zUOZmKOZIm/ipwUBhNJ3jvYkPMltbZzTiEnOgpji2pEPuWS4OOA2/EFY47MKTb5F0hcOPnPOj8aK+5j0XLQ5gBPZxwAUsBhaF5Td/0X4FNGTnr3wFu4FtHyLDjiCK8dOhK+UtFm6bPMNtauhfvUUI2RsC5GfUhdd0lLgVwnTK2WazAU/Uqy3m/LuT8kAHEWmHE/G5EB3Hym2wzSt3/iXf2WKdZ6YPHyg3mayofqrBhqrAWPXvA4U8j68xb5ZYUcHLj3q7momwW+fzQCbaa6hReLX+1ZU7ZV7vckg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hJI0sEglvb4ho4+sOXsobH7619Z8f/8q7EZkG2FGH9Q=; b=AKeRbl1hMbYXI12cVgE8G9I0uZE3LSZgnAF3JVE9bCTzzqoZTJ6NEu/5/8xJpuokaoI1NABV051sSyNNQD5cDYEnxsi68Kik181NBhHXbbps+uHt1OT4Lli5K2F2kiYRbayABXMFJg1M8i5Sfv8VLnNaIzh0ULEmHnYNnlvSSbukfeoRXKaWHMn+fYGXPHr/q/VGCnaJ23zj/mMNihoOtZK4OMwhWxPzKbxICs8f0pTVOtB6LBJZlirO4pZNg5yLU3pFo82yoDo4EILW2en9Gg0TbKPrAOHPKnql/iX6qcSFCCyR+5peUT/1PGzGee5mvtTrbyAHpQkoi7sBXbIx3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hJI0sEglvb4ho4+sOXsobH7619Z8f/8q7EZkG2FGH9Q=; b=ZhLGsheSO5hXNHq3jiwHSvPJMKjxEcCuqO2BVEOymU3nEyrgwblgQl76Vc+lGjxRwnIZsaBlei0kLHPImdLcLEY3A8tQ0fI6YltzEV0f7brrtVHR3d12ah2BGXJRSTn9gjxQZEYYL0BHzBtVJkeesw86V50aom4Cs/3WLvoinB6aRfMcJlQgUIl5o9OHau3NJjY0dfJOdSQ9TwiAJPUFW9NkxnJejx9QUU9553FMkLTE+iyH7iodP+q+I+NjBTMYFR49phLXyS2/LeqVPqMjtnqrXsHq1+cgl6aOcagas+Wdi1NTbIl/97mRkuTjhsIr4/37BBQpPq93ANYUR5Xi9w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH8P223MB0576.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1bf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.26; Tue, 27 May 2025 19:58:14 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8769.025; Tue, 27 May 2025 19:58:14 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages Thread-Index: AQHbzum1ccA5OIIs+0a/vK7hVeGcarPm4MgA Date: Tue, 27 May 2025 19:58:14 +0000 Message-ID: References: <4ED9B765-D73A-4B38-8655-CDEA73B5CBAD@gmail.com> In-Reply-To: <4ED9B765-D73A-4B38-8655-CDEA73B5CBAD@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH8P223MB0576:EE_ x-ms-office365-filtering-correlation-id: 35a8394e-9c81-40f5-b2d1-08dd9d58d0bc x-ms-exchange-slblob-mailprops: 9IecXKUgicB0Vgu95vFSoXNdCFmhIzagFla5LCZSP0kvC/zLYVOTuckaYcJs54iUvzgAEbOi6o5uCzg3o9lpEz3FapHijRklaX4l+H+2YJORK02gswexgt7gPcU2KuR4a8w0xia+z1gp0S4yiKEHFz6BzwFh/bMjUCyisTefaIqEdPkcezI8tSUaEP9ta+TaYBDJHanptjjcXMBVOAKuTWSy9g3/x3D6SWm6Z5XcTUI4c501y4gY0vr/5YC72OT1qkJfVOOg8/DsmwVGPQOVZGt8lo4TThQFhA2kUh8Im7ybBKNo5Eq3lPpUUANvVocd5USR35FbZftAtlN4TkJCNAOMflOPKB1ilklh9NNAgL9DXdpacxJq6dQL1XilVb3kIYe8iZYPFkPgm0LYD1PPVrhi/TGgXC4T02knotQxMN0GBmTQZrYKZbRmE6ou89en09ab8Tr7Yk/fGwtzkFBpV3XM9FlkdIMK4KanXH5TIaHPIOYoU9ivvYwzoLWSKtrjDZDrpB6v51QW9PefOIw0rN6Ps7NArH+ArR8ydE0apdDfp3LqeFmIIZJI6XJyxIVqu2trVOVRdiIUpgAt5/tjyZZCO0WDsd9RlIOKzlNhOaBcWxbl2gK6XvbEqrpUiqCHOJrqJVGZcVwKVJaRG1HmBm4JF4ZK+udHFIvnRKzI1ZS5jBtcbFqgjOE9O0IezUNbraJO/WI1RtnOmXTb1NTXggG8s/eO4+qqG41XeUOeKauB8/GwwtYtmg== x-microsoft-antispam: BCL:0; ARA:14566002|8062599006|19110799006|15080799009|461199028|8060799009|7092599006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?B?Y0VIQjFZOG42bGpTNGZvM2lHUmxCWGtzeC8wWTBFUW1TbG9ZRmxJZDg2T2hu?= =?utf-8?B?OWpIUTM1ODFyS0ZBRUFJRFVNZVloZUIrdy9mOVJ5Ukk2djd4QVZ2c0FNZ0Jt?= =?utf-8?B?Wk11ZThZZ2luMjFTOWhib1FOWHZCZzBEeTdSS3YxMTlKY1dOOEJQN21OT0pi?= =?utf-8?B?YnhzTjk2TStwYXdzN2pZck1NVDVzZVBQMXo4a21ZMUFGbmlmUWlhOVpoVVpz?= =?utf-8?B?N3M5ekFidmtpWjdXNEJHbUxDZDBOZnZ0aE9PeG14cmVXeVc3MDBDbEFscVEx?= =?utf-8?B?UUxSZlQ3bHhEUnF5T2FkM0gyYmd6TlV3TnFQME5EVTEybnR0L0ZEYUxQMDk3?= =?utf-8?B?a0JNUXNKYzBZKzYwY2ZyMzR1UlJ3Um9UTDBaMXNBMDhwYStpUGxOZVFzaDU1?= =?utf-8?B?aVN6OEhSc2d2eit6c0hRa0ZrQkFEKzYzSTluNzdSWXZ0MmVNeXF6NklaVGlO?= =?utf-8?B?YzJvUjExUjg0Qk5PMWordTZoTTNVWDc0U3hYUHkrN2lTVnc4R1E3OUJTUzN2?= =?utf-8?B?ejRsWWlaVTdOWm5ZQnZXRUVPcGJML0tISEVSZm1CRzk0Z1BwNnZBN2dZbzJ0?= =?utf-8?B?RU1VNll2Q3RtaFMzS1ZrdlFkTHpLNUNidWhMcWh6VXhpak9WRW1Scy80aUll?= =?utf-8?B?bmRxb0p6c1pIUXJrMTJwczNDcnR5V1JmTVcxVWdEUGtBV1gwYkY1VnVEamRZ?= =?utf-8?B?ZUZkV1gvbG5aYWxSdlkwWlNXaWx4MkVnSEdQc0pSZTV5SmVUNmNmeVlHYVdS?= =?utf-8?B?cWFkVUhzWFFjUnA2R1F2T2s1UHhSZW0vSUtaU3lhaXJ5NkF0eGdOMDRaMndE?= =?utf-8?B?S0pjWG1ZVm1URWd4MTdlMkx0TEpkd0lickdwS1IzRzNWNWFUY0pjcG5Wdnoz?= =?utf-8?B?TCtFU3FvZG95L09xUmhaVG8wVlB1SVk3S3VlVitUN1JUczR2QTVyT0xUNEFt?= =?utf-8?B?OUFSakw4ZjVYR2hMUmhZSkU1d1FHSnB6TFBIeXZjaVR4NVExS29iUUlTUjQ4?= =?utf-8?B?MERiMGtJMTVCUGIwUnh6Q2xSY3FtbXpvWXZKcUJyTXZ4eTdXTmNhV3JCNzc1?= =?utf-8?B?VXNmY1AzWlJKR1hHRUhrQlNuYVUzd2NXb3lEdkNwSWlEZnFlNUtmTkQ5aXpV?= =?utf-8?B?QlJwamtKM21zaU9TSW5iNERHdTVDMzVoR3I0SzYxWDQxV0pSL24rcG9lUms1?= =?utf-8?B?OUJKMXoxU1NadTRTTVN4cHQ0bkNoZjA3VjUzV2FTemdDSk9PeU1Fc24vdzda?= =?utf-8?B?b2dWdDF1bWdyTVlYbmpIaHM2TmJtRE01ck9Ccmx1dzVjWDlWTjhuU2UySXBP?= =?utf-8?B?YjFsd3hXWDQzN1Joait0Y0g1SzdOOS9jWDE1TlBTRUQ1UW5yMVRNL1EvKzJt?= =?utf-8?B?eTNMNmYyOW4wS3FnNDc3aGxBaTd4aXJGcW5KWWRtNHFXdnB3eTZLUnZPL0lw?= =?utf-8?B?VTFIajNpZGQ0QWp2SGdBN0tRQmpvd2c0MUVvRzB3QWFpQnlXczhWWVQyOGhG?= =?utf-8?Q?4Ht29s=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDhpUCtEQmZBOGdjUHV4bHhjR2hCN1Fwdm9RR3NKYW90bytodmtab1luU1FZ?= =?utf-8?B?cU5acWpiNGNJOE1Pb0RzdFJjVXVCMndTSUlseWxRV3hOQUxpVUUxMDl5dEpx?= =?utf-8?B?MWxpVUd3WmJMalE2Y0hnWnRzMXdWVlBRcU5CRE5HZUNrM1hVR1lLVW1UVmxL?= =?utf-8?B?T3pUWEFPZjBkK2x0TWcxUEl1V0NUMDR3azZ1NzFYRkZWOEoxOUlRdThBZG9t?= =?utf-8?B?dGtKT2NJcU1qZlZaUFh4Ylc5aDc5N3BNVFY0RUFtdm5GdHQ1WW1teVdLNlJj?= =?utf-8?B?T2lKTnk5elRuVHI0RHluVVFOZ09uRG85dEI0QXY5bk1KTCtZWDJnVUx5SldS?= =?utf-8?B?UGwzcVF0Zm1jVjZaUkx5SFhyY25mU1daZVRSRllDR0o3QllaNHp5ZkVFN0s3?= =?utf-8?B?ZUY2N2Y2WTF3TjV0ZGpxeFJJVDhZaFAwZk5ITUx3Q0ZPU2ZOaDJZNnFKcEhK?= =?utf-8?B?UmZLbktBdDErbU15Mis4Q3BHOWUyTGpEbXBKNGpMOUlGYjhFTENCdGU5Nnd1?= =?utf-8?B?dDYyRUtKaWFSL3dlNHJrZFNJeG9FMmdqU2hPdHdKYjczT3BSbm1TQjRlc0FD?= =?utf-8?B?em1pb0VFZGFRSUtGaGpFbHZCZENFK01TTlpoQzM5VUt5VG52TFI1Y2xyQS9r?= =?utf-8?B?YnJaTjVzYVArVW9iaGJOOGpkdVllMmZjNWFXQXhXL0pkNGFNbWVrcjdVUEtt?= =?utf-8?B?cEFoU3czL05RN09NUndVaDByRmg2UmlFcEZ5ZnR2dE02WWFmamg1Qkx4WFho?= =?utf-8?B?bjgwOXVjZ2w5Q2kyV09XUDZ2K2hJTGtteWIwRzFaSXR0SzZEcVAreE1JNjVC?= =?utf-8?B?WEU0OGNCYXNFZlRQelk0czlMMUlxdWZLcmcwdVE1UjFSdkZmS0J2S0laTFl2?= =?utf-8?B?aUYwMUFTQjJsbkROb3VDZ1VRaEQvT2VLblFEbHpRN1EvU1ZWdkdheklnb2tT?= =?utf-8?B?Vk9HZ01HTDdkYXVzRjFudUdFRnpON3dtdEJrU3F0UU9tQWF5VGxzMlVaa3pN?= =?utf-8?B?N0xnb0JkVERCOEw4OVlvRDFiWFgzaVhtbjBxRlV0TnRBN0hycGFRT3BmME42?= =?utf-8?B?Z2dKWTJwMzZrSVpjMkkyamxtR1RDR25aK0k4ZzUzcGdORVZnNGYvcG02bTJ5?= =?utf-8?B?K0ZuZEpWZjRpc1cvVFlOQkFQU0pkODhXSTlEaEV0VFkxbkpZb0JFcVdpZ0Q0?= =?utf-8?B?bWgyalNoREFhUmhMWEREa01heDJSc3VVTWFTRnUzU25pMzJRQkFkRnZvRld6?= =?utf-8?B?QkV6bzIvTkFWR2d4V21kTXZib0NEZjh4UFMraTcrZ3VRaHZwRCtvbDlxcU1v?= =?utf-8?B?cVAxVDd5dG10UkJCRXYyVTYzMHdvRjdxdmdzOTl0NnNDRHg4SWVGZnBvWjFz?= =?utf-8?B?bkgzOTZueTZkRVJGOVNwZGZ0L3JldGl3TmgrTmZBQ1lXUHdFc0JKenVvU04v?= =?utf-8?B?VEtRYlR1Zk1QOVorUGl6d0UwN24yUVl0OFhXNlpKQyt1NXNQenpuNDNJbEJU?= =?utf-8?B?VzlidkNmeE1UbjNreDF4amdUS1FhTjJpdVcrSmQ3eFhvalNjRVpwaTZJeVY4?= =?utf-8?B?ZFNHQlp0QTBENzd4YlNLWURQMEpYVjVIUFpPODdMWTU2U29PN2dXOUpIcDhP?= =?utf-8?Q?hHfYi7HOMrKYQENnOL69r33xctX01+OhJe/0euTbwUfM=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 35a8394e-9c81-40f5-b2d1-08dd9d58d0bc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2025 19:58:14.1107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8P223MB0576 Subject: Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Dienstag, 27. Mai 2025 11:28 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit > messages > > > > On 3 May 2025, at 11:32, softworkz . wrote: > > > Hello everybody, > > > > I have an organizational question that I cannot quite figure out how > to do it right: > > > > Whether and when to add 'Reviewed-by: xxx' to a commit message? > > > > Personally I try add this when someone reviewed and gave a LGTM > for the patch as then I can be sure they (hopefully) actually > reviewed the whole patch. > > I sometimes comment on patches, that does not mean I reviewed > those fully, just that I saw something that I felt worth to add > a remark, I would not like to be added as Reviewed-by for that, > as it would not be true. Hi Marvin, thanks a lot for the reply! On Patchwork, there's the "A/L/R/T" column. AFAIK, the A (acked-by), R (reviewed-by) and T (tested-by) columns are detected from lines in the commit message and L (LGTM) is based on detection from response messages on the ML. Side note: LGTM detection only seems to work when it's at the start of a line. Responses with LGTM have become a bit rare these days, that's what is making the situation somewhat more unclear to me (and eventually led me to ask about it). On the other hand, what you are describing is a very clear and straight- forward pattern and I will adhere to it in the future: LGTM => reviewed-by <...> in the next revision (unless others have additional thoughts to share and consider) Thank you very much sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".