Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages
Date: Tue, 27 May 2025 19:58:14 +0000
Message-ID: <DM8P223MB036582C9C5F08D9A0FEE9811BA64A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <4ED9B765-D73A-4B38-8655-CDEA73B5CBAD@gmail.com>



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Dienstag, 27. Mai 2025 11:28
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit
> messages
> 
> 
> 
> On 3 May 2025, at 11:32, softworkz . wrote:
> 
> > Hello everybody,
> >
> > I have an organizational question that I cannot quite figure out how
> to do it right:
> >
> > Whether and when to add 'Reviewed-by:  xxx' to a commit message?
> >
> 
> Personally I try add this when someone reviewed and gave a LGTM
> for the patch as then I can be sure they (hopefully) actually
> reviewed the whole patch.
> 
> I sometimes comment on patches, that does not mean I reviewed
> those fully, just that I saw something that I felt worth to add
> a remark, I would not like to be added as Reviewed-by for that,
> as it would not be true.

Hi Marvin,

thanks a lot for the reply!

On Patchwork, there's the "A/L/R/T" column. AFAIK, the 

A (acked-by), R (reviewed-by) and T (tested-by) columns are detected
from lines in the commit message and L (LGTM) is based on detection
from response messages on the ML.

Side note: LGTM detection only seems to work when it's at the start 
           of a line.

Responses with LGTM have become a bit rare these days, that's what
is making the situation somewhat more unclear to me (and eventually
led me to ask about it).

On the other hand, what you are describing is a very clear and straight-
forward pattern and I will adhere to it in the future:

LGTM => reviewed-by <...> in the next revision

(unless others have additional thoughts to share and consider)

Thank you very much
sw




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-05-27 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03  9:32 softworkz .
2025-05-26 23:07 ` softworkz .
2025-05-27  9:28 ` Marvin Scholz
2025-05-27 19:58   ` softworkz . [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8P223MB036582C9C5F08D9A0FEE9811BA64A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
    --to=softworkz-at-hotmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git