From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v8 2/3] fftools: add memaddress log flag and disable printing addresses by default
Date: Wed, 9 Apr 2025 14:41:34 +0000
Message-ID: <DM8P223MB036580F95C085399FE812571BAB42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <6d9414cc-bee2-45c4-a2a9-56ad9453dbea@gyani.pro>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Gyan
> Doshi
> Sent: Mittwoch, 9. April 2025 16:28
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v8 2/3] fftools: add memaddress log
> flag and disable printing addresses by default
>
>
>
> On 2025-04-09 02:55 pm, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > This commit adds the memaddress log flag.
> > When specifying this flag at the command line, context prefixes will
> > be printed with memory addresses like in earlier ffmpeg versions.
> >
> > Example with memaddresses flag:
> >
> > [hevc @ 0000018e72a89cc0] .....
> >
> > without (new behavior):
> >
> > [hevc] .....
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > fftools/ffmpeg.c | 2 +-
> > fftools/ffplay.c | 2 +-
> > fftools/ffprobe.c | 2 +-
> > fftools/opt_common.c | 6 ++++++
> > 4 files changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> > index dc321fb4a2..72887d6c5e 100644
> > --- a/fftools/ffmpeg.c
> > +++ b/fftools/ffmpeg.c
> > @@ -954,7 +954,7 @@ int main(int argc, char **argv)
> >
> > setvbuf(stderr,NULL,_IONBF,0); /* win32 runtime needs this */
> >
> > - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> > + av_log_set_flags(AV_LOG_SKIP_REPEATED |
> AV_LOG_NO_PRINT_MEMADDRESS);
> > parse_loglevel(argc, argv, options);
> >
> > #if CONFIG_AVDEVICE
> > diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> > index 2a572fc3aa..9bd1fc2f22 100644
> > --- a/fftools/ffplay.c
> > +++ b/fftools/ffplay.c
> > @@ -3761,7 +3761,7 @@ int main(int argc, char **argv)
> >
> > init_dynload();
> >
> > - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> > + av_log_set_flags(AV_LOG_SKIP_REPEATED |
> AV_LOG_NO_PRINT_MEMADDRESS);
> > parse_loglevel(argc, argv, options);
> >
> > /* register all codecs, demux and protocols */
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index abbd1dcf36..106435b827 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -4672,7 +4672,7 @@ int main(int argc, char **argv)
> >
> > init_dynload();
> >
> > - av_log_set_flags(AV_LOG_SKIP_REPEATED);
> > + av_log_set_flags(AV_LOG_SKIP_REPEATED |
> AV_LOG_NO_PRINT_MEMADDRESS);
> >
> > options = real_options;
> > parse_loglevel(argc, argv, options);
> > diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> > index 2ac3fd4fb3..73a591acd8 100644
> > --- a/fftools/opt_common.c
> > +++ b/fftools/opt_common.c
> > @@ -1304,6 +1304,12 @@ int opt_loglevel(void *optctx, const char *opt,
> const char *arg)
> > } else {
> > flags |= AV_LOG_PRINT_DATETIME;
> > }
> > + } else if (av_strstart(token, "memaddress", &arg)) {
>
> Too verbose a label. How about just 'mem'?
>
> Regards,
> Gyan
Hi Gyan,
I'm fine with that, will update!
Thank you
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-09 14:41 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 15:38 [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids softworkz
2025-03-05 15:40 ` Nicolas George
2025-03-05 15:45 ` Soft Works
2025-03-05 15:48 ` Soft Works
2025-03-06 10:08 ` Nicolas George
2025-03-06 17:02 ` Soft Works
2025-03-06 17:38 ` Marvin Scholz
2025-03-06 17:44 ` Soft Works
2025-03-06 17:49 ` Marvin Scholz
2025-03-06 18:16 ` Soft Works
2025-03-06 18:58 ` Marvin Scholz
2025-03-06 19:27 ` Soft Works
2025-03-06 20:01 ` Marvin Scholz
2025-03-06 20:48 ` Soft Works
2025-03-06 20:56 ` Soft Works
2025-03-05 15:42 ` Soft Works
2025-03-05 16:23 ` Gyan Doshi
2025-03-05 16:30 ` Soft Works
2025-03-05 17:14 ` Gyan Doshi
2025-03-05 18:19 ` [FFmpeg-devel] [PATCH v2 0/3] " ffmpegagent
2025-03-05 18:19 ` [FFmpeg-devel] [PATCH v2 1/3] " softworkz
2025-03-05 18:19 ` [FFmpeg-devel] [PATCH v2 2/3] fftools/opt_common: add memaddresses log flag softworkz
2025-03-05 18:19 ` [FFmpeg-devel] [PATCH v2 3/3] doc/fftools-common-opts: document " softworkz
2025-03-06 10:04 ` [FFmpeg-devel] [PATCH v2 0/3] avutil/log: Replace addresses in log output with simple ids Nicolas George
2025-03-06 16:38 ` Soft Works
2025-03-06 16:43 ` Nicolas George
2025-03-06 17:05 ` Soft Works
2025-03-06 17:38 ` Soft Works
2025-03-06 20:59 ` [FFmpeg-devel] [PATCH v3 0/4] " ffmpegagent
2025-03-06 20:59 ` [FFmpeg-devel] [PATCH v3 1/4] avutil/log: Add callback for context prefix formatting softworkz
2025-03-07 9:44 ` Nicolas George
2025-03-07 17:23 ` Soft Works
2025-03-07 17:30 ` Hendrik Leppkes
2025-03-07 18:02 ` Soft Works
2025-03-06 20:59 ` [FFmpeg-devel] [PATCH v3 2/4] fftools/opt_common: add memaddresses log flag softworkz
2025-03-06 20:59 ` [FFmpeg-devel] [PATCH v3 3/4] fftools: Provide a log formatting callback for context prefixes softworkz
2025-03-06 20:59 ` [FFmpeg-devel] [PATCH v3 4/4] doc/fftools-common-opts: document memaddresses log flag softworkz
2025-03-08 23:02 ` [FFmpeg-devel] [PATCH v4 0/4] avutil/log: Replace addresses in log output with simple ids ffmpegagent
2025-03-08 23:02 ` [FFmpeg-devel] [PATCH v4 1/4] avutil/log: Add AV_LOG_PRINT_MEMADDRESSES logging flag softworkz
2025-03-08 23:02 ` [FFmpeg-devel] [PATCH v4 2/4] fftools/opt_common: add memaddresses log flag softworkz
2025-03-08 23:02 ` [FFmpeg-devel] [PATCH v4 3/4] fftools: Provide a an fftools-specific logging callback function softworkz
2025-03-09 17:52 ` Michael Niedermayer
2025-03-09 18:59 ` Soft Works
2025-03-08 23:02 ` [FFmpeg-devel] [PATCH v4 4/4] doc/fftools-common-opts: document memaddresses log flag softworkz
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 0/5] avutil/log: Replace addresses in log output with simple ids ffmpegagent
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 1/5] avutil/log: Add AV_LOG_PRINT_MEMADDRESSES logging flag softworkz
2025-03-09 19:05 ` Nicolas George
2025-03-09 19:11 ` Soft Works
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 2/5] fftools/opt_common: add memaddresses log flag softworkz
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 3/5] fftools: Provide a an fftools-specific logging callback function softworkz
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 4/5] doc/fftools-common-opts: document memaddresses log flag softworkz
2025-03-09 19:01 ` [FFmpeg-devel] [PATCH v5 5/5] Remove commented lines softworkz
2025-03-13 9:30 ` [FFmpeg-devel] [PATCH v6 0/3] avutil/log: Replace addresses in log output with simple ids ffmpegagent
2025-03-13 9:30 ` [FFmpeg-devel] [PATCH v6 1/3] fftools: Add a local logging callback function softworkz
2025-03-13 9:30 ` [FFmpeg-devel] [PATCH v6 2/3] fftools/opt_common: add memaddresses log flag softworkz
2025-03-13 9:30 ` [FFmpeg-devel] [PATCH v6 3/3] doc/fftools-common-opts: document " softworkz
2025-04-09 5:54 ` [FFmpeg-devel] [PATCH v7 0/3] avutil/log: Add log flag to control printing of memory addresses ffmpegagent
2025-04-09 5:55 ` [FFmpeg-devel] [PATCH v7 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES softworkz
2025-04-09 7:27 ` Andreas Rheinhardt
2025-04-09 7:50 ` softworkz .
2025-04-09 8:02 ` softworkz .
2025-04-09 8:11 ` Andreas Rheinhardt
2025-04-09 8:24 ` softworkz .
2025-04-09 8:27 ` Andreas Rheinhardt
2025-04-09 9:56 ` softworkz .
2025-04-09 8:15 ` Andreas Rheinhardt
2025-04-09 5:55 ` [FFmpeg-devel] [PATCH v7 2/3] fftools/opt_common: add memaddresses log flag softworkz
2025-04-09 5:55 ` [FFmpeg-devel] [PATCH v7 3/3] doc/fftools-common-opts: document " softworkz
2025-04-09 9:25 ` [FFmpeg-devel] [PATCH v8 0/3] avutil/log: Add log flag to control printing of memory addresses ffmpegagent
2025-04-09 9:25 ` [FFmpeg-devel] [PATCH v8 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES softworkz
2025-04-09 9:25 ` [FFmpeg-devel] [PATCH v8 2/3] fftools: add memaddress log flag and disable printing addresses by default softworkz
2025-04-09 14:28 ` Gyan Doshi
2025-04-09 14:41 ` softworkz . [this message]
2025-04-09 9:25 ` [FFmpeg-devel] [PATCH v8 3/3] doc/fftools-common-opts: document memaddress log flag softworkz
2025-04-09 18:19 ` [FFmpeg-devel] [PATCH v9 0/3] avutil/log: Add log flag to control printing of memory addresses ffmpegagent
2025-04-09 18:19 ` [FFmpeg-devel] [PATCH v9 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES softworkz
2025-04-09 18:19 ` [FFmpeg-devel] [PATCH v9 2/3] fftools: add mem log flag and disable printing addresses by default softworkz
2025-04-09 18:26 ` Gyan Doshi
2025-04-09 18:40 ` softworkz .
2025-04-09 18:19 ` [FFmpeg-devel] [PATCH v9 3/3] doc/fftools-common-opts: document mem log flag softworkz
2025-04-10 0:38 ` [FFmpeg-devel] [PATCH v10 0/3] avutil/log: Add log flag to control printing of memory addresses ffmpegagent
2025-04-10 0:38 ` [FFmpeg-devel] [PATCH v10 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES softworkz
2025-04-10 7:38 ` Andreas Rheinhardt
2025-04-10 18:06 ` softworkz .
2025-04-10 0:38 ` [FFmpeg-devel] [PATCH v10 2/3] fftools: add mem log flag and disable printing addresses by default softworkz
2025-04-10 6:51 ` Nicolas George
2025-04-10 18:02 ` softworkz .
2025-04-16 13:43 ` Michael Niedermayer
2025-04-16 13:50 ` Nicolas George
2025-04-16 14:25 ` Gyan Doshi
2025-04-16 14:26 ` softworkz .
2025-04-10 0:38 ` [FFmpeg-devel] [PATCH v10 3/3] doc/fftools-common-opts: document mem log flag softworkz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB036580F95C085399FE812571BAB42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git