From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 077AD42427 for ; Sat, 18 Dec 2021 11:34:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA5A368A8F5; Sat, 18 Dec 2021 13:34:40 +0200 (EET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08olkn2083.outbound.protection.outlook.com [40.92.47.83]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA4A06801EB for ; Sat, 18 Dec 2021 13:34:33 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F4SBvT7aqLQidxx9Gw8YOSme0G3ff77bLOjd6CJmSVly4IWMV6PogLFWQ4gRtTwbw7dD6h0nRCd+L49xVHdN2reWUHO0ws2llDF7QmNW/L9mPVsdBKu9Ax3koydu9X845vrgojyJNv74cAqcPPzStKy7i7TFlCMYrTVTpjbhYWxyS1NdZKo/9VGeK4IcNd4dSYkU+QyXxCfSQ8cgSNfavuPyLfuah0VSX8CVcJp4qxb+X5u/pCp0uYor5IKucF0VOwaM6JTV+VV3ll08/TDHvyK8M4uWgjhKhCZCAd2JaRQ77rvUEEcFCpaV1g4QhJw614W6mtpW2SF4rglN4BuPHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mN0BbECx2QDwBUK0GCsZQBYN0RHg70mxRdk09fYiNM8=; b=HzZKjggwsdRmIulbi4VJHiRyFS7gwoCYE+cSEfZBOs6Jjtn1xs8NaZ/Ii3P8D2o2wCibAialMdH0TzJ6sy5mksjFWMfL87DDe1gCxAXHWhAZf3mB5kh2exIXEMI5Hvd+1TB5qlMCZKQee7cCPI7TWBbiHNOV2gPD3/3LConszBcoztbFCVCCKeX68hehtWfz0/j+0GwOlJrrz0caWZpotF6zw/vgsMQMk15Ocsr7nNCcuAYyA0wBULot/JwixM7u9S7Oc/VuHhMBfIqCNua2OzZHF1Lh5FWnOFouN02WKp6cpIJ+C9IWAYG7BMbt5JFy3ioJcjz/FLupL44xVzqlSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mN0BbECx2QDwBUK0GCsZQBYN0RHg70mxRdk09fYiNM8=; b=iQJJrMs2EWmfnc9bbmYUMYNJuh+p+ZQikjjLN3X/idDRfqcmOtRSUkkW4+efXG9FS4Fka5ybjaT9yxHvIeCgVktUVHVbEx7JqOFlD8eb3gA0MhyjQNSV2/w7QV91eFKBGHL/++nuYlEGlb9ImJ3DiURiOCNC/sIGFiCRmbtnnZCHIQxfDuJiHiVr96S+JuTQ/QeW/LtEoMudglA7eX99IM3/VBV7VentDyGpGRLmb87cvyjYvo2kT61ARHph1Pnxolvl1XbwffcCXVvJdAx3+OfxYPTyFsLVF619GKSSHSYFdguxxRseK7pFcx1ohfyIDsb0ycKF+QkNAU1xrE/6Pg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0287.NAMP223.PROD.OUTLOOK.COM (2603:10b6:5:317::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Sat, 18 Dec 2021 11:34:30 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775%7]) with mapi id 15.20.4801.017; Sat, 18 Dec 2021 11:34:30 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Politics Thread-Index: AdfvHU2CBKI4bcoLRhSl52fM3Tar9QBLh/sAAAAs7YAAA5K2AAAAX9TAAA7bNQAAALs1kAA/KcwAAAg1U6AAkH5iAAAAs7+g Date: Sat, 18 Dec 2021 11:34:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [OL+Kn52J97n5FJq3rn7qwqdbiTn3+Vr4+V91qnn6HAdCw1W/VZUbS90z28A5VyUg] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b37e91f5-1624-4c29-31c0-08d9c21a5b32 x-ms-traffictypediagnostic: DM8P223MB0287:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1bzyOizudNXZ7PuoaTdl1NI8gWQXWSQujpoPCfQYFrAfurRt9SZgXASIWBHETTDJ6zt/Ed3o+wF4+agOVwy1rX5byCu5DEc8Qx2tKMTUeSQu4FTjP52KU0/DC4D9Voo6wdu1X6VV52QxRrmiM3LeBtxxR8057LO61YNWHgXBA5SfMUUdAusdHqhCo5rTWSdK8ZFS7iliQ/bHM2UxtuKBUbYC1u0Y2ew62VN4ThrbTd8MFBrIj52TB3FPS9iQWk7944mFUhqGm5s3/PVtl72E3i05gEda7JHpmc/PVaHAA25vXrmw3TotvuNRUiqhpSiu80WRW6+HDhDnum2Ws7hm92KOgNWXIfOWRCGVS2hRS/6KSGTgBhW1fko0H2vAVcc3YL2EOFmqOluvtEREIKYQ6h+MEIAFIAx/UByPCQEgN9osRupfmygSZvkVY7POJGc4BfCgAKhewJIEQLYzkmgwnp6fjTOtoVfA/8G2nUolyZxiwHQC8AUCTiUmLmOK99BVpD7DDeT8vWd4IcxTUBhH6n8GeWlKdIWw1eVyfECXVRl4wicA0Ff7WylodPEOkk+KC0MF+YPDKzhG/sNlUGW7Dw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SHJOMUlrWS8xUjZPRGNITHd6eHg5ZERVT3Q5bzRPd1NKWXRCbTEzOW0wRWNU?= =?utf-8?B?L0tXWWkxbnRJQTlCNnFVNTJVNW81L0FPbGdUS2JSM205N1ArZGh6cTlFaS9t?= =?utf-8?B?UG1iRUw5dFFKci9ldlJnQjdZKy9RZUdRdWI3YzFDdk1SQm1YODRoVFVaVTdr?= =?utf-8?B?ZUpSZDRMbnE3a2pjc0VSNmV6V1FMa0RZMk1aVVplNU45TVQ4cXQ5bFdjUVcy?= =?utf-8?B?bEFUZzNRTEpTaHZxZEowL2RoT0hEOFM1QlQwNDE0bUFucHR6Y2dweG9kOE01?= =?utf-8?B?TU1SWGJXSm14akZDeGlxQm9weVNyQzJGM0RBenczUWFsUWJETXJiV01TeUsw?= =?utf-8?B?UWh2cm9oQzFKMGxuQlFOSFgvbDRkRFQ4RVdWbmVqRG01cWxwRTVpUGZOMy9p?= =?utf-8?B?OFZZWGZCd0ljdjBHSDhVZUt2aDhHVjlsdUI5N3JoS3dOVHFYN0dmL3FyLzAv?= =?utf-8?B?NklPSzVCQXphVGVMaGFGN0tGSE1XMVZjYjRQRTh2OEVGZ2VxMDErM2lNaEU1?= =?utf-8?B?ODdrZHJhb0EwN3Z2VzRmZGxnQVdyQ0dpNThpTnlFdXFMbEk4dVNESXc4c0FS?= =?utf-8?B?WktzbWhCMGhETm9KcmwvWlg1OFRpMGZKSG1LbnUzYUE5N3lHbWc5dk9UK0I2?= =?utf-8?B?c2k3WjI2aWh3eFFLU2FucytudTVRZzNYVmtQUGV4UnZyaThOSmxvdkdTdjd5?= =?utf-8?B?QTZqSlhzdEppNzUxaTZMbm1haWd2UXlldUdhYnJIR052TWVoVFE0Y1BCZEh0?= =?utf-8?B?RnRMTnhKQzdIaXpEY2VxZUtYd3UvWG93QXpoRHIrdnpHcGtuTHFKbFBpUmJ1?= =?utf-8?B?akRrcjJoQWxiM0NEN25rTGdWdWdSOUh1d0dWY0UxWW5XUFFWUWladWwxZVBt?= =?utf-8?B?d0F0TlZzNUxZYlhudnVzQUpialJjbkkwbjJ1di9kUHN4MnplTm9jc1UzY2hH?= =?utf-8?B?YlhydXB5ZWhaMmRRYlpOcnBmV0dqTlNtMWRFWEhnL0wxRHZtbzEzK3VsNnFU?= =?utf-8?B?dXVqdlUyWWVnVUIwOGdlcjNDd2hDYXZuaEdSbUtwQjcvTzdSRXlSR1VJRHRa?= =?utf-8?B?VXNTSzNkazJvaWlXYlVBc2tueVNHZGtwMW90VHFiNFlKeTJ6NGpWN0dtNXJD?= =?utf-8?B?azAwd0RkbTJFZ3hzSTRZUEVqSkNhQjRIa2F3VHFxM0RBYnZCUW9zS2RMRVhB?= =?utf-8?B?dWFzZjkxb3d1YVMyV2dSZ3BFZlNCSE9Qc1RWM1VXRVB6ejhneGxER0FUcmFJ?= =?utf-8?B?eTJvMG1MTmFldkFpek9DT1psUHhDTjh2WEtRR1pNTHJCRVVnSHNHM2txRzZx?= =?utf-8?Q?rm2NlcOqQ2b/dTx+elPFLA+tHe4VDew/4R?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b37e91f5-1624-4c29-31c0-08d9c21a5b32 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2021 11:34:30.4201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0287 Subject: Re: [FFmpeg-devel] Politics X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Paul B > Mahol > Sent: Saturday, December 18, 2021 11:27 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > On Wed, Dec 15, 2021 at 2:34 PM Soft Works wrote: > [..] > > > > Once for the facts: the subtitle_pts field in AVFrame exists since > > > > V5 of my patchset, which I have submitted on 2021-09-12. > > > > This has been 3 months ago. Nobody had objected its existence > > > > until only 2 or 3 weeks ago. > > > > > > > > > This is really irrelevant, please stop insisting on hacks like > > subtitle_pts. > > > > New idea: > > > > I could remove the three fields (subtitle_pts, subtitle_start_time, > > subtitle_end_time) from AVFrame and add it to AVSubtitleArea. > > > > How about that? It would allow the frame to be "clean" at least. > > > > > Yea, much better, But still original issue is not solved. Yes, correct, this changes the location but not the logic. But this is something I could surely do. It's a bit of work, but it would be safe to do without breaking everything into dysfunctional pieces ;-) It wouldn't be my first choice since there can be multiple AVSubtitleAreas while only those values from the first one would be relevant. But when this would help to increase the acceptance, then it will be fine for me. Another possibility I had thought about, might be to leave them at the side of AVFrame, but put them in a struct field of AVFrame named 'subtitle_timing', which itself would have the fields pts, start_time, end_time. I did some research regarding the use of the start_time field. While it is used and cannot be dropped, I found that the following changes would be possible with moderate effort: - change the time base of start_time and end_time to the same like subtitle_pts (AV_TIMEBASE_Q) - rename subtitle_start_time to subtitle_start_offset - rename subtitle_end_time to subtitle_duration and adapt the logic everywhere where it's used In combination with the subtitle_timing struct idea it could then look like: frame->subtitle_timing.pts frame->subtitle_timing.start_offset frame->subtitle_timing.duration or even eliminate the pts naming and do like: frame->subtitle_timing.start frame->subtitle_timing.start_offset frame->subtitle_timing.duration or still move them to AVSubtitleArea, which wouldn't be that nice to access and require to check the subtitle_area_nb value wherever it needs to be accessed: frame->subtitle_areas[0].start frame->subtitle_areas[0].start_offset frame->subtitle_areas[0].duration Please let me (all) know whether one of those suggestions would be an acceptable compromise. PS: I'll respond to the other question shortly Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".