From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 397EA4E897 for ; Thu, 12 Jun 2025 02:31:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 230DF68BFB6; Thu, 12 Jun 2025 05:31:39 +0300 (EEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02olkn2033.outbound.protection.outlook.com [40.92.43.33]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 680EB687DB6 for ; Thu, 12 Jun 2025 05:31:32 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vp/u1BFXHB5r8AoU/gWDAj7s8KqnRtEdIrRBL7yXn4TUtSFBnU5BMjB2VYuOcDlTOyXkUPZwGamq8xLuilVdJEeyqPcsXezosQ56jhlIJqa1FNMJb5O1Uj+Dia0QdrRbuig3S5DTXfMYF/WRSnnDFSIiHyciUcqCaXsxFdEEP5z/e4BUc7R7NFpCwjTLeqa+qjObTMRPi1AqIqgDRcUhRtgTBmktx3xZDLRRyVsWjZEaf8iSK7TwV5JJpArzE+XBstrqrlAmTsM2IQ1DxGq0FaEAmcpynk7moEtM4O4V/rme/jfsV/tgH1LKySbYIfxidhcbCwkpQYUq1JcvcNMiwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ecv4lA32roFANafEmsU8M+gLvhMGmnL55UHNOr6LZo4=; b=oQijVCtJP5u5jMKXuBdlaHWqn/kTXMcXS0xJCJq9Q9X0c7nKj69FZHFx8vv8rCXhneEDgA6Gtnwgta5TVcnhOGldM5VW+s0zbpi1TlGSZcR021vxLgliqKCnEuCJ7qIiJrXFpidOFlNaes/3nDyzIee98GtJ9VJbtJIZ+cWVjWkEvclanl1H2ntBggFcR7tkZHLmkEvhLPpssmAiNv2gjtfDedMH1hN0/NsTkh7Cl3HXU1uQLht9L8ffloAXJWTRrcSrWZDoRgAtgADFBJ1U3Kcix7zPkkXJRByLWL0VAmgiUe9vhk7vk37fKyO4igPcLysLGlCPHjn+JMYkIMWsDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ecv4lA32roFANafEmsU8M+gLvhMGmnL55UHNOr6LZo4=; b=py1D7RsrDYvQAWOcqBaBWT04xY8h0jkMwUU9iJhT8dtA6910XNZO9huFI3hX5coGv8uDVjLaAd9TzKPBzkICj/BVwQhZ8eO21ABXKj2kVj7Kg0EZwjgpx5A5+IIC3i+iJal8+i2rk4h+kWFVVtaMKQ9faYZGb+cwKDmz/+Kz0dxOYcSsO7BL3wOi2gNlB9uuNp3FuMxUvJGyXiBQ1do5OBxP8S0UkVMwT7yofq06RPqNLW51LcX4GpvtThfE9rJWH6KLUjdQL4dHlJbv/tC634E0scZ49UepKq7QZiWHIF6BbDRNE8BWpn31zZZiX8E4rHIkSmdp+pND79ZvZh4crw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0667.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Thu, 12 Jun 2025 02:31:29 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:31:29 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not return early Thread-Index: AQHb2xFyH8jX59RNsEKkfaiz5m0Dn7P+zevA Date: Thu, 12 Jun 2025 02:31:28 +0000 Message-ID: References: <20250611204213.97295-1-epirat07@gmail.com> <20250611204213.97295-3-epirat07@gmail.com> In-Reply-To: <20250611204213.97295-3-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0667:EE_ x-ms-office365-filtering-correlation-id: 7ffb7aea-0893-4376-c0e3-08dda9593c8f x-microsoft-antispam: BCL:0; ARA:14566002|15080799009|8062599006|8060799009|7092599006|461199028|19110799006|41001999006|13041999003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?usPHfH7lTU2nvp6S59I22htDwMVfjh/0SVvdPd1hzjjEFOw95v1nGzGYWTcM?= =?us-ascii?Q?ZtNi8DMJhbUAoLlays7PGVYdZ2pHVleO1E1Aj+Z2AkwO9MNwPZxJag0KO1VC?= =?us-ascii?Q?b+Kzf+W8aX5iAXbOc/ILIfuEVV6nqkarB3pIFn+qt3sHCmsGVLH9sZnrMmMC?= =?us-ascii?Q?kUBmbyRYKEb0O0+4Ig9riWHw7M9w71w83udG7irOfdIASZMPkPfDMmlXy5Rj?= =?us-ascii?Q?dnOad8q1tXMjOIvPWM0bup1/E7LLVeyIvflW9CWRnNVapNguJjMHwcCu6saI?= =?us-ascii?Q?dKuXpVePQTZMvo5B/5yr3Lr/G8Y5ibfpTPU4cfGoPEwQNPm45cSAKTUOJm8R?= =?us-ascii?Q?17sJgRDL4jvZiW9WqspsoD/M+aLi33QUDmTjhRoFXEeeRsn6R3X0dQ88Q/RA?= =?us-ascii?Q?qVys12Z0gKaNbW5OSGiYuYLykljJgTx3EDMzVoeKsa7wwNEEIWuK16QMRakC?= =?us-ascii?Q?i9w9ORhEpuuLgn9+BuDXHYE4ZAunog/zb1U1oNEzEt6nd2RhY+QsdV1dIL46?= =?us-ascii?Q?GVeDyGrxZ2UvtJRPWbwAdblkl57taSYJVpsmTdEosgTLvJkJLpL/kmf5RHjV?= =?us-ascii?Q?mKxAMHFZzEvC2yn09bTd7HZPSGOGQdEvgVZWWd+VMnAtzGNWKA/APKRH7v/W?= =?us-ascii?Q?mi7UMAUlTFVNGe3/4Wf6QGvhinjkCqJah3MoY6VYIqoNTINUu1Ytzdsy4xGJ?= =?us-ascii?Q?Pcui/JwILNoJmlGcU2TDS2rD9sbubSJlFOc167dvP1fqvFsp+48pk+UWh4ip?= =?us-ascii?Q?FWSksWyunm/4+pVMiplc4xmll4iWAdMEl7SQSTkeGQZquucju96zvS5g4Oj9?= =?us-ascii?Q?f5JjxyKGyMvsUWFB/4+95f0U40dg2Aw2/fjoTJSbUG6/ikkgLuml0e+CXcW4?= =?us-ascii?Q?v7TaiVC+xSOGp0yEWoWQETS0QRQBhg1/SGwY6pU7gAUgt1l1UVY/Oykc6keH?= =?us-ascii?Q?Wybg5zas0/vAp37QTTbkMFWDPHbQprG4JXh7XYlUbar8LMT+AjyVWHhzNMan?= =?us-ascii?Q?4OmAUsJhVuQ9En3gw2Jr4VvOsZGuFPT0gcegw1sBtkjM2DvPY7neenHZPKAf?= =?us-ascii?Q?FZ7tSS/1/geYEs4DSyA+Ml0eLyuhi93RAlEZ+dW2buSNElCE8XdCtl0Sh8qN?= =?us-ascii?Q?xgK1GK1vkVjV/qvTE+2mW7jpzTCpR7WB6vCJ2NY/khXn4uXQyr0GE3Q=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6VvWFcT9lNGsl3pwzj8HraL+0pMAS+sGMaNKMs7vLf1SuV+gXQnKnmPYgYSf?= =?us-ascii?Q?+778SLz2C/xzKQEraTH8gXcTuqVGzSZgfQoxwLKUSqWD2pl7Adhh2JkiyCE3?= =?us-ascii?Q?65FLcQoRkqrhhHYtMF/eRv5WZVLT4dPAE7yFqW/ei16mMgeM9n7ohuXpSrtw?= =?us-ascii?Q?H1jcm6wmUjx5ZCQIiGAd+LbeOwNTDrft3QJYqCjSGClmbkbouRQaAx9jisQk?= =?us-ascii?Q?x7Jl8LfWKGNKA4ie+lO69Gtf6Drl8g9DrFUYPgvjGfytMrn0rfUEzkm+9W3D?= =?us-ascii?Q?N9thSc7e+r+BIHHoWW9maGduwuzFBpoz4acq818OLvLekXtisN0cre+WFPIs?= =?us-ascii?Q?C29+5o1xXDWsxViYag1q/apgi1eYsXvESpdUp76i2Sny0k0K9v9d7KmxM7VS?= =?us-ascii?Q?OxnaYfxVIEC1wlUkWC0e7wo3BfZH+k5wK+A5EsUnMpiruT6yfKgQIWmJV91s?= =?us-ascii?Q?PiCnO1cNJ90HmVJ/jbzTYkyTVrhJK9Z3vXDQRVg1rhQ2FLKCTnpE2w56tJD9?= =?us-ascii?Q?VysbfqOSNdJnvwrJW1Oti+BH82LOVKC2DnAc7h2QmuFL7KbIvtFpH7uUdOO8?= =?us-ascii?Q?JSgiECZPPXwjxvLteEr3c0V15EmjDOm+Z4RNIBX5Ew7kP9VOm8s4LvQu97gY?= =?us-ascii?Q?bQ23yZ1BJl6P95IZKd0uG/N4tlDl+TarLLJtPn687Lq5A/fP2RPfV+Uw641Q?= =?us-ascii?Q?fGWWjGnhBn+7iXaFQzDSNs3AK2qx7Zos0FArpCNsh27l78yvXKfruYN1TSi0?= =?us-ascii?Q?ui5ytF4H52yft+t84OVSYVD09jDKIhRLkgHHsuEVbtENCerYuVA/tkCTOKdE?= =?us-ascii?Q?6B5uyCMOD9rUoJv6ID7sgLClteyNmzlFJ/jlD4C1bgI+LCbiCWlzR85UL1FR?= =?us-ascii?Q?y5Ommc82FSwFILAlChkMnZ87hFgwJluQ0Pu40bI/IGUyQrv1wnV0dfVIhC74?= =?us-ascii?Q?P+juy0Qth3ElbTiyq/L/OChRNi+9ZHwz39EMSr2PeH5ZXYrfh2Gbb3JxN2Y6?= =?us-ascii?Q?tpcc42wL2GIpoKZ9LtFnEEL+vUdJ81vnsp6siAYQoShsAKnzqrGnvYGJ1n68?= =?us-ascii?Q?8UZ2v4kU8IbHlUhvwSOXxbXMUVgX5FP26N9IsSqbb8QA2qi69XA7qqgnN5CV?= =?us-ascii?Q?+BHJT44uhIIHS2cfcLZUh0mRwKnRMAwwA4A66+ZnQDqxD1R/xyoeX5Ghmx0D?= =?us-ascii?Q?0nyBHVvLvxYOxlGFLtT5j8ta8JW8uRInNTFqcyCEWDZ0ybLci47vQY2dN2M?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7ffb7aea-0893-4376-c0e3-08dda9593c8f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:31:28.9390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0667 Subject: Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not > return early > > This would make the goto dead code and also would not properly > call avtext_context_close. > > Fix CID 1646939 > --- > fftools/textformat/avtextformat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fftools/textformat/avtextformat.c > b/fftools/textformat/avtextformat.c > index fa5abce261..e1aaa9ba57 100644 > --- a/fftools/textformat/avtextformat.c > +++ b/fftools/textformat/avtextformat.c > @@ -222,7 +222,6 @@ int avtext_context_open(AVTextFormatContext > **ptctx, const AVTextFormatter *form > av_log(tctx, AV_LOG_ERROR, > "Invalid UTF8 sequence %s found in string > validation replace '%s'\n", > bp.str, tctx- > >string_validation_replacement); > - return ret; > goto fail; > } > } > -- > 2.39.5 (Apple Git-154) > > _______________________________________________ LGTM, thank you! Best regards sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".