Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not return early

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Mittwoch, 11. Juni 2025 22:42
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: do not
> return early
> 
> This would make the goto dead code and also would not properly
> call avtext_context_close.
> 
> Fix CID 1646939
> ---
>  fftools/textformat/avtextformat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fftools/textformat/avtextformat.c
> b/fftools/textformat/avtextformat.c
> index fa5abce261..e1aaa9ba57 100644
> --- a/fftools/textformat/avtextformat.c
> +++ b/fftools/textformat/avtextformat.c
> @@ -222,7 +222,6 @@ int avtext_context_open(AVTextFormatContext
> **ptctx, const AVTextFormatter *form
>                  av_log(tctx, AV_LOG_ERROR,
>                         "Invalid UTF8 sequence %s found in string
> validation replace '%s'\n",
>                         bp.str, tctx-
> >string_validation_replacement);
> -                return ret;
>                  goto fail;
>              }
>          }
> --
> 2.39.5 (Apple Git-154)
> 
> _______________________________________________

LGTM, thank you!

Best regards
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".